May 2018 - Pharo-dev - lists.pharo.org

Failing tests

by Guillermo Polito

Hi all, There are a couple of Zn tests that are failing not even in the CI but locally in my machine. This happens because the tests are trying to do a request to encrypted.google.com and expecting a 200, but they are instead receiving: 301 Moved Permanently text/html >From the response, I guess we should do the request to https://www.google.com/search?q=Smalltalk instead. This solves the failures on my side. Sven, is that Ok if we push those patches to the tests to Pharo? -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

May 3, 2018

Re: [Pharo-dev] [Pharo-users] [Ann] Iceberg 0.7.3

by Sven Van Caekenberghe

Hi Guillermo (et al), I finally found the time to test this new setup and I found it much easier and quite straightforward to make a PR. The new approach, with the simpler UI and lots more dialogs/explanations (and the glossary) is really well done. It felt much better, much higher quality. I am sure we are on the right track now. Thanks for all the hard work. Sven > On 25 Apr 2018, at 10:27, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > > Hi all, > > We just introduced Iceberg 0.7.3 into Pharo. This new version solves several issues people had when contributing to Pharo in general and others. I've made a screencast on how to contribute to Pharo, and added some tutorial and glossary in Iceberg's wiki. > > Below the links and the changes log. > > Thanks for making your issue reports ^^. We will schedule a backporting to Pharo6.1 in a couple of weeks, once we have another iteration. > > Cheers, > Guille > > # Contribute to Pharo with Iceberg 0.7.3 > > - wiki page: https://github.com/pharo-vcs/iceberg/wiki/Contribute-to-Pharo-with-Iceberg-… > > - Screencast: https://www.youtube.com/watch?v=PK2yCu2rWCc&feature=youtu.because > > This screencast shows how to use Iceberg 0.7.3 to contribute to latest Pharo 7, by cloning from scratch your own (potentially outdated) clone. > > This video will guide you through: > - solve the "Missing local repository" by cloning > - solve the "Fetch required" that appears because the fork is out of date > - solve the "Detached working copy" by creating a new branch > - use the pharo plugin to create an issue branch > - make some changes, commit them and push them to your fork > - make a pull request > > If you already have a clone, you can just import an existing repository from your disk. The rest of the instructions should be the same. > > If you don't have a fork, create one before doing anything else. > > New videos to come with more explanations. > > # Iceberg Glossary > > https://github.com/pharo-vcs/iceberg/wiki/Iceberg-glossary > > # 0.7.3 ChangesLog > > â¢ #693: fixing problem when the announcement of changes in a package is nil. (bug, important) > â¢ #682: update update script (Pharo6-backport) > â¢ #681: Author name is not correctly decoded (UI, enhancement) > â¢ #680: Repair actions dialog should explain the situation (UI, enhancement, important) > â¢ #679: Create branch repair action should show create branch from issue if available (Pharo plugin, UI) > â¢ #678: Iceberg does not correctly recognize packages (bug, important) > â¢ #677: Unknown commit can only be solved with repair action (Model, bug, important) > â¢ #676: Unknown commit state is not properly shown (UI, bug, important) > â¢ #667: Merging branches with file deletion doesn't seem possible (bug, important, merge) > â¢ #666: Iceberg sometimes add a $ to commit message (Model, bug) > â¢ #662: The Pharo plugin has to do the fetch only if required. (Pharo plugin, enhancement) > â¢ #660: Add a star badge in the push button in case of a new branch () > â¢ #658: Progress Bar during checkout of Repository. (UI, enhancement) > â¢ #657: Confusing UI: Ghost Test maybe should be default? (UI, enhancement) > â¢ #656: Typo in Progress Bar (UI, bug) > â¢ #651: When pushing a new branch the list of commit is empty (UI, bug) > â¢ #650: "Create new branch from issue" is leaving image in detached working copy state () > â¢ #649: The VM is crashing when trying to use Iceberg from a saved image (bug) > â¢ #645: IceLibgitRepository should use "utilities" protocol instead of "utils" (clean up) > â¢ #644: Unnecessary temp in IceTipGitHubRepositoryPanel>>#getGitHubRepository" (clean up) > â¢ #643: LGit_GIT_ERROR: error authenticating: no auth sock variable loading a Tonel based baseline dependency in smalltalkCI (bug, important) > â¢ #639: Create pull request fails if branch has not been pushed (Github plugin, bug) > â¢ #636: The pull button should have a star badge when it has no upstream (UI, enhancement, important) > â¢ #634: Travis is not building Pull Requests (CI, bug, important) > â¢ #624: add "add remote" to remote picking on pull/push browsers (enhancement) > â¢ #610: Fix for issue #608 and #607. (clean up) > â¢ #609: New branch repair action does not refresh dirty packages (UI, bug) > â¢ #583: Creating a tonel project does not commit the properties file (Model, bug) > â¢ #542: Bug during commit of a new package (Model, bug) > > > -- > > Guille Polito > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - http://www.cnrs.fr > > Web: http://guillep.github.io > Phone: +33 06 52 70 66 13

May 3, 2018

[Pharo 7.0-dev] Build #829: 21818-RBPatternBlockNode-fix-problems-introduced-by-ast-Eval-use

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #829 was: SUCCESS. The Pull Request #1285 was integrated: "21818-RBPatternBlockNode-fix-problems-introduced-by-ast-Eval-use" Pull request url: https://github.com/pharo-project/pharo/pull/1285 Issue Url: https://pharo.fogbugz.com/f/cases/21818 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 3, 2018

[Pharo 7.0-dev] Build #828: 21764-Optimize-RBSmallLinkContextselfMessages-and-friends

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #828 was: SUCCESS. The Pull Request #1280 was integrated: "21764-Optimize-RBSmallLinkContextselfMessages-and-friends" Pull request url: https://github.com/pharo-project/pharo/pull/1280 Issue Url: https://pharo.fogbugz.com/f/cases/21764 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 3, 2018

[Pharo 7.0-dev] Build #827: 20878-Alien-tests-should-be-in-a-Alien-Tests-package

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #827 was: SUCCESS. The Pull Request #1202 was integrated: "20878-Alien-tests-should-be-in-a-Alien-Tests-package" Pull request url: https://github.com/pharo-project/pharo/pull/1202 Issue Url: https://pharo.fogbugz.com/f/cases/20878 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 3, 2018

[Pharo 7.0-dev] Build #826: 21737-NullStream-sends-self-positionError-but-does-not-implement-it

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #826 was: SUCCESS. The Pull Request #1279 was integrated: "21737-NullStream-sends-self-positionError-but-does-not-implement-it" Pull request url: https://github.com/pharo-project/pharo/pull/1279 Issue Url: https://pharo.fogbugz.com/f/cases/21737 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 3, 2018

Re: [Pharo-dev] Fix for 21809

by Hilaire

Thanks Marcus Le 02/05/2018 Ã 12:53, Marcus Denker a Ã©critÂ : >> I don't learn yet the current procedure to integrate fixes so I let it for someone with the know how. >> > I merged the Pull Request. > > Marcus > > > -- Dr. Geo http://drgeo.eu

May 3, 2018

Re: [Pharo-dev] Pharo Bootstrap familiarity

by Guillermo Polito

Hi Ben, as Nicolas said, yes, MOP is for Meta Object Protocol (really nice book btw https://www.amazon.com/Art-Metaobject-Protocol-Gregor-Kiczales/dp/0262610744 ). Ben, the process is not carved in stone and we are fully aware that it can be enhanced :). Any enhancement, even the littlest one, is important. If it is important for your workflows to add more logging information, let's add them! Nicolas, Actually the special interpreter is not the simulator. We do not use the bytecode interpreter in the simulator, we use an AST interpreter that has "lazy class creation" semantics plus some other little tricks to initialize the circular dependencies of metaclasses and so on... Behind, we use the simulator only to store the objects and decouple ourselves from the object format (this removed for example a lot of work when migrating from V3 to Spur). On Wed, May 2, 2018 at 10:04 PM, Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com> wrote: > Nice reverse engineering! > > MOP is Meta Object Protocol (serach in reference [9]). > > Maybe you miss a reference to the definition of BaselineOfPharoBootstrap > https://github.com/pharo-project/pharo/blob/development/bootstrap/src/ > Pharo30Bootstrap.package/PBBootstrap.class/instance/ > allPackagesForHermes.st > https://github.com/pharo-project/pharo/blob/development/bootstrap/src/ > Pharo30Bootstrap.package/PBBootstrap.class/instance/ > ensureBaselineOfPharoBootstrap.st > > And the simulator too (the special interpreter). > > 2018-05-02 20:53 GMT+02:00 Ben Coman <btc(a)openinworld.com>: > >> I found it hard to find info on the Pharo Bootstrap, so I went looking to >> understand the it by identifying very first creation on disk of the >> smallest "seed".image file that will later become the final build >> artifact. I'm sharing here to have a record I can refer to later, and >> maybe others find interesting. >> >> Looking at the log from the latest build... >> https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20p >> ull%20request%20and%20branch%20Pipeline/job/development/822/consoleFull >> >> Searching on "BUILD_NUMBER=" indicates the first major CI step is... >> >> + BUILD_NUMBER=822 BOOTSTRAP_ARCH=32 bash ./bootstrap/scripts/2-download.sh >> [1] >> which downloads 24MB " bootstrapImage.zip" [2] >> which I presume is an almost full image to run the bootstrap process. >> >> [1] https://github.com/pharo-project/pharo/blob/development/ >> bootstrap/scripts/2-download.sh >> [2] https://github.com/guillep/PharoBootstrap/releases/download/ >> v1.4.1/bootstrapImage.zip >> >> >> The next major CI step is... >> >> + BUILD_NUMBER=822 BOOTSTRAP_ARCH=32 bash ./bootstrap/scripts/3-prepare.sh >> [3] >> which uses the downloaded "Pharo.image" to (I presume) produce the seed >> "bootstrap.image" file. >> (This is not indicated explicitly in the logs, but step 4 copies that file >> with a shell command, so my presumption. It would be nice for this to be >> explicitly logged" >> >> prepare.sh executes two commands... >> >> ./pharo Pharo.image ..../bootstrap/scripts/prepare_image.st --save >> --quit [4] >> which seems to modify the downloaded "Pharo.image", >> not create bootstrap.image >> >> ./pharo Pharo.image ..../bootstrap/scripts/bootstrap.st --ARCH=32 >> --BUILD_NUMBER=822 --quit [5] >> which does... "PBBootstrap fromCommandLine bootstrap" [6] [7] >> which does... >> PBBootstrap>>#bootstrap >> PBStepStartedSignal log: 'Starting Process.'. >> self prepareBootstrap. >> [self createImage ] on:AssertionFailure do: [ :e | e resume ]. >> self initializeImage. >> PBStepFinishedSignal log: 'Process ended.' >> and digging a bit... >> >> PBBootstrap>>#createImage >> | builder | >> builder := PBImageBuilderSpur50 forArchitecture: architecture. >> builder definitionFetcher: versionFetcher. >> builder buildNumber: buildNumber. >> builder imageFileReference: imageReference. >> builder systemDefinition: ringEnvironment. >> builder espellBackend instanceVariableMapping: >> (PBInstanceVariableMapping onEnvironment: ringEnvironment ). >> builder bootstrap >> >> >> PBImageBuilderSpur50-class>>#forArchitecture: architecture >> | candidates | >> candidates := self subclasses select: [ :sc | sc name endsWith: >> architecture, 'bit' ]. >> candidates >> ifEmpty: [ self error: 'No candidates for architecture: ', >> architecture ]. >> candidates size > 1 >> ifTrue: [ self error: 'More than one candidate for >> architecture: ', architecture ]. >> ^ candidates anyOne new >> >> >> PBImageBuilderSpur50 >>#initialize >> super initialize. >> statistics := PBBootstrapStatistics new. >> logger := PBBootstrapLogger new. >> imageFileReference := 'bootstrap.image' asFileReference. >> >> "the default espell backend for the bootstrap" >> self initializeBackend. >> self instantiateClassLoader. >> >> ahh, there is the reference to "bootstrap.image" >> >> So just to round out a high level overview, the last two messages sent >> are defined as... >> >> PBImageBuilderSpur5032bit>>#initializeBackend >> espellBackend := EPSimulatorBackend for32Bit forBootstrap >> >> which I won't dig further but the class seems available at [8] >> and Espell is described briefly at [9] (but what is a "MOP"? the term is >> not defined there) >> >> >> PBImageBuilderSpur50>>#instantiateClassLoader >> classLoader := PBSpurClassLoader new. >> >> which is defined at [10], and there is an interesting example at [11]. >> >> >> [3] https://github.com/pharo-project/pharo/blob/development/ >> bootstrap/scripts/3-prepare.sh >> [4] https://github.com/pharo-project/pharo/blob/development/ >> bootstrap/scripts/prepare_image.st >> [5] https://github.com/pharo-project/pharo/blob/development/ >> bootstrap/scripts/bootstrap.st >> [6] https://github.com/pharo-project/pharo/blob/development/ >> bootstrap/src/Pharo30Bootstrap.package/PBBootstrap.class/ >> class/fromCommandLine.st >> [7] https://github.com/pharo-project/pharo/blob/development/ >> bootstrap/src/Pharo30Bootstrap.package/PBBootstrap.class/ >> instance/bootstrap.st >> [8] https://github.com/guillep/espell/blob/master/src/ >> EspellSimulator.package/EPSimulatorBackend.class/class/for32Bit.st >> [9] https://rmod.inria.fr/archives/papers/Poli15a-Onward- >> Bootstrapping.pdf >> [10] https://github.com/pharo-project/pharo/tree/development >> /bootstrap/src/Pharo30Bootstrap.package/PBSpurClassLoader.class >> [11] https://github.com/pharo-project/pharo/blob/development >> /bootstrap/src/Pharo30Bootstrap.package/PBImageBuilderSpur50 >> .class/class/example5617.st >> >> >> So now I guess that bootstrap.image has been generated? >> Just curious, what is the size of this file right now, before the next >> step? >> Perhaps an `ls -l` could echo this to the build log. >> >> >> The penultimate major CI step seems to then start adding packages to >> bootstrap.image... >> >> + BUILD_NUMBER=822 BOOTSTRAP_ARCH=32 bash ./bootstrap/scripts/4-build.sh >> >> located at [12] and searching on "${VM}" is enlightening. >> Its help information says... >> Pharo Build Script >> ================== >> This script assumes the existence of a new uninitialized image. Then it >> proceeds to its initialization and \"growing\". >> * Step 1: >> - Initialize the image >> - output: core.image >> * Step 2: >> - Bootstrap Monticello local repositories >> - output: monticello_bootstrap.image and changes file >> * Step 3: >> - Load Monticello remote repositories >> - output: monticello.image and changes file >> * Step 4: >> - Load Metacello >> - output: metacello.image and changes file >> * Step 5: >> - Load the rest of the image using BaselineOfIDE >> - output: Pharo.image and changes file >> >> Unfortunately those steps are labelled in the script, >> but the first action shown in the log is... >> cp bootstrap.image Pharo7.0-compiler-32bit-9912d7c.image >> Initializing Bootstraped Image >> pharo --headless Pharo7.0-compiler-32bit-9912d7c.image >> >> [12] https://github.com/pharo-project/pharo/blob/development >> /bootstrap/scripts/4-build.sh >> >> >> >> The final major CI step was a fair way past what I was interested in >> right now. ... >> >> + BUILD_NUMBER=822 bash ../bootstrap/scripts/prepare_for_upload.sh >> >> >> >> cheers -ben >> >> > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

May 3, 2018

[Pharo 7.0-dev] Build #825: 21783 Better tagging in Collections-Abstract

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #825 was: SUCCESS. The Pull Request #1256 was integrated: "21783 Better tagging in Collections-Abstract" Pull request url: https://github.com/pharo-project/pharo/pull/1256 Issue Url: https://pharo.fogbugz.com/f/cases/21783 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 2, 2018

Re: [Pharo-dev] Pharo Bootstrap familiarity

by Nicolas Cellier

Nice reverse engineering! MOP is Meta Object Protocol (serach in reference [9]). Maybe you miss a reference to the definition of BaselineOfPharoBootstrap https://github.com/pharo-project/pharo/blob/development/bootstrap/src/Pharo… https://github.com/pharo-project/pharo/blob/development/bootstrap/src/Pharo… And the simulator too (the special interpreter). 2018-05-02 20:53 GMT+02:00 Ben Coman <btc(a)openinworld.com>: > I found it hard to find info on the Pharo Bootstrap, so I went looking to > understand the it by identifying very first creation on disk of the > smallest "seed".image file that will later become the final build > artifact. I'm sharing here to have a record I can refer to later, and > maybe others find interesting. > > Looking at the log from the latest build... > https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending% > 20pull%20request%20and%20branch%20Pipeline/job/development/822/consoleFull > > Searching on "BUILD_NUMBER=" indicates the first major CI step is... > > + BUILD_NUMBER=822 BOOTSTRAP_ARCH=32 bash ./bootstrap/scripts/2-download.sh > [1] > which downloads 24MB " bootstrapImage.zip" [2] > which I presume is an almost full image to run the bootstrap process. > > [1] https://github.com/pharo-project/pharo/blob/ > development/bootstrap/scripts/2-download.sh > [2] https://github.com/guillep/PharoBootstrap/releases/download/v1.4.1/ > bootstrapImage.zip > > > The next major CI step is... > > + BUILD_NUMBER=822 BOOTSTRAP_ARCH=32 bash ./bootstrap/scripts/3-prepare.sh > [3] > which uses the downloaded "Pharo.image" to (I presume) produce the seed > "bootstrap.image" file. > (This is not indicated explicitly in the logs, but step 4 copies that file > with a shell command, so my presumption. It would be nice for this to be > explicitly logged" > > prepare.sh executes two commands... > > ./pharo Pharo.image ..../bootstrap/scripts/prepare_image.st --save > --quit [4] > which seems to modify the downloaded "Pharo.image", > not create bootstrap.image > > ./pharo Pharo.image ..../bootstrap/scripts/bootstrap.st --ARCH=32 > --BUILD_NUMBER=822 --quit [5] > which does... "PBBootstrap fromCommandLine bootstrap" [6] [7] > which does... > PBBootstrap>>#bootstrap > PBStepStartedSignal log: 'Starting Process.'. > self prepareBootstrap. > [self createImage ] on:AssertionFailure do: [ :e | e resume ]. > self initializeImage. > PBStepFinishedSignal log: 'Process ended.' > and digging a bit... > > PBBootstrap>>#createImage > | builder | > builder := PBImageBuilderSpur50 forArchitecture: architecture. > builder definitionFetcher: versionFetcher. > builder buildNumber: buildNumber. > builder imageFileReference: imageReference. > builder systemDefinition: ringEnvironment. > builder espellBackend instanceVariableMapping: > (PBInstanceVariableMapping onEnvironment: ringEnvironment ). > builder bootstrap > > > PBImageBuilderSpur50-class>>#forArchitecture: architecture > | candidates | > candidates := self subclasses select: [ :sc | sc name endsWith: > architecture, 'bit' ]. > candidates > ifEmpty: [ self error: 'No candidates for architecture: ', > architecture ]. > candidates size > 1 > ifTrue: [ self error: 'More than one candidate for > architecture: ', architecture ]. > ^ candidates anyOne new > > > PBImageBuilderSpur50 >>#initialize > super initialize. > statistics := PBBootstrapStatistics new. > logger := PBBootstrapLogger new. > imageFileReference := 'bootstrap.image' asFileReference. > > "the default espell backend for the bootstrap" > self initializeBackend. > self instantiateClassLoader. > > ahh, there is the reference to "bootstrap.image" > > So just to round out a high level overview, the last two messages sent are > defined as... > > PBImageBuilderSpur5032bit>>#initializeBackend > espellBackend := EPSimulatorBackend for32Bit forBootstrap > > which I won't dig further but the class seems available at [8] > and Espell is described briefly at [9] (but what is a "MOP"? the term is > not defined there) > > > PBImageBuilderSpur50>>#instantiateClassLoader > classLoader := PBSpurClassLoader new. > > which is defined at [10], and there is an interesting example at [11]. > > > [3] https://github.com/pharo-project/pharo/blob/ > development/bootstrap/scripts/3-prepare.sh > [4] https://github.com/pharo-project/pharo/blob/ > development/bootstrap/scripts/prepare_image.st > [5] https://github.com/pharo-project/pharo/blob/ > development/bootstrap/scripts/bootstrap.st > [6] https://github.com/pharo-project/pharo/blob/development/bootstrap/src/ > Pharo30Bootstrap.package/PBBootstrap.class/class/fromCommandLine.st > [7] https://github.com/pharo-project/pharo/blob/development/bootstrap/src/ > Pharo30Bootstrap.package/PBBootstrap.class/instance/bootstrap.st > [8] https://github.com/guillep/espell/blob/master/ > src/EspellSimulator.package/EPSimulatorBackend.class/class/for32Bit.st > [9] https://rmod.inria.fr/archives/papers/Poli15a-Onward-Bootstrapping.pdf > [10] https://github.com/pharo-project/pharo/tree/ > development/bootstrap/src/Pharo30Bootstrap.package/PBSpurClassLoader.class > [11] https://github.com/pharo-project/pharo/blob/ > development/bootstrap/src/Pharo30Bootstrap.package/ > PBImageBuilderSpur50.class/class/example5617.st > > > So now I guess that bootstrap.image has been generated? > Just curious, what is the size of this file right now, before the next > step? > Perhaps an `ls -l` could echo this to the build log. > > > The penultimate major CI step seems to then start adding packages to > bootstrap.image... > > + BUILD_NUMBER=822 BOOTSTRAP_ARCH=32 bash ./bootstrap/scripts/4-build.sh > located at [12] and searching on "${VM}" is enlightening. > Its help information says... > Pharo Build Script > ================== > This script assumes the existence of a new uninitialized image. Then it > proceeds to its initialization and \"growing\". > * Step 1: > - Initialize the image > - output: core.image > * Step 2: > - Bootstrap Monticello local repositories > - output: monticello_bootstrap.image and changes file > * Step 3: > - Load Monticello remote repositories > - output: monticello.image and changes file > * Step 4: > - Load Metacello > - output: metacello.image and changes file > * Step 5: > - Load the rest of the image using BaselineOfIDE > - output: Pharo.image and changes file > > Unfortunately those steps are labelled in the script, > but the first action shown in the log is... > cp bootstrap.image Pharo7.0-compiler-32bit-9912d7c.image > Initializing Bootstraped Image > pharo --headless Pharo7.0-compiler-32bit-9912d7c.image > > [12] https://github.com/pharo-project/pharo/blob/ > development/bootstrap/scripts/4-build.sh > > > > The final major CI step was a fair way past what I was interested in > right now. ... > > + BUILD_NUMBER=822 bash ../bootstrap/scripts/prepare_for_upload.sh > > > > cheers -ben > >

May 2, 2018