May 2018 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] GT Playground Print It Popup unreadeable

by Hilaire

Indeed. The use of colors seems to be a mess. Le 09/05/2018 Ã 09:41, phil(a)highoctane.be a Ã©critÂ : > ThemePalette would be a great addition. Color entries should be > separated from the semantic meaning (e.g. background, tooltip, ...). > There is some semantic meaning in the Theme but it is not backed by a > ThemePalette which makes us create additional ThemeClasses for what is > basically the same thing, only the palette changing. > -- Dr. Geo http://drgeo.eu

May 9, 2018

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Hilaire

What changed is the UITheme receive a balloonTextColor method (the fix I proposed), BUT some morphs in Pharo use the theme balloonBackgroundColor BUT NOT the assorted balloonTextColor (obviously as this method was just introduced). The right fix will be to makes these morphs using balloonBackgroundColor to use balloonTextColor too. I took a look but get lost again in morph classes. Someone with the appropriate knowledge could fix it in a breeze. Hilaire Le 08/05/2018 Ã 15:30, Esteban Lorenzano a Ã©critÂ : > git says guilty was Torsten :P > anywayâ¦ thatâs an awful color for background on dark. > Why nobody realised it before? Iâm using a variant of the dark theme > myself and I just realised nowâ¦ what changed? > -- Dr. Geo http://drgeo.eu

May 9, 2018

Re: [Pharo-dev] [ Umbrella Issue ] Cleanup remaining DeprecatedFileSystem users

by Sven Van Caekenberghe

You mean you made a subclass of StandardFilestream yourself ? If yes, can you describe briefly why you did so ? > On 9 May 2018, at 13:12, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > > Hi Sven, > > in that process, how does one rewrite StandardFilestream subclasses? > > Regards, > > Thierry > > 2018-05-09 11:51 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >> Hi, >> >> I created the following: >> >> >> https://pharo.manuscript.com/f/cases/21858/Cleanup-remaining-DeprecatedFile… >> >> This is an umbrella issue, please create sub issues for each set of changes. It is better to work step by step. >> >> The package DeprecatedFileSystem contains classes that should no longer be used, the most important being >> >> FileStream, StandardFileStream and MultiByteFileStream >> MultiByteBinaryOrTextStream and RWBinaryOrTextStream >> >> Alternatives exist by using FileSystem's FileReference as well as File and various new (Zn) streams. >> >> >> Let's all work together to make this real. It is important that the image itself makes correct use of ongoing refactoring efforts. We already took great steps, but there is more work to do. Note that in many cases, using code can and should be simplified, removing ugly hacks where possible. >> >> Feel free to discuss any issues on the ML. >> >> Sven >

May 9, 2018

[Pharo 7.0-dev] Build #849: 21848-Set-add-newObject-withOccurrences-anInteger--sams-as-superclass

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #849 was: SUCCESS. The Pull Request #1314 was integrated: "21848-Set-add-newObject-withOccurrences-anInteger--sams-as-superclass" Pull request url: https://github.com/pharo-project/pharo/pull/1314 Issue Url: https://pharo.fogbugz.com/f/cases/21848 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 9, 2018

Re: [Pharo-dev] [ Umbrella Issue ] Cleanup remaining DeprecatedFileSystem users

by Thierry Goubier

Hi Sven, in that process, how does one rewrite StandardFilestream subclasses? Regards, Thierry 2018-05-09 11:51 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > Hi, > > I created the following: > > > https://pharo.manuscript.com/f/cases/21858/Cleanup-remaining-DeprecatedFile… > > This is an umbrella issue, please create sub issues for each set of changes. It is better to work step by step. > > The package DeprecatedFileSystem contains classes that should no longer be used, the most important being > > FileStream, StandardFileStream and MultiByteFileStream > MultiByteBinaryOrTextStream and RWBinaryOrTextStream > > Alternatives exist by using FileSystem's FileReference as well as File and various new (Zn) streams. > > > Let's all work together to make this real. It is important that the image itself makes correct use of ongoing refactoring efforts. We already took great steps, but there is more work to do. Note that in many cases, using code can and should be simplified, removing ugly hacks where possible. > > Feel free to discuss any issues on the ML. > > Sven

May 9, 2018

Re: [Pharo-dev] GT Playground Print It Popup unreadeable

by Hilaire

Problem is this GLPPrinterPopper morph is using the balloon color but not it assorted text color! Replace: Â Â Â Â Â Â textColor: self theme textColor; with Â Â Â textColor: self theme balloonTextColor; It should be fixed. GLPPrinterPopper>>initializeTextMorph Â Â Â textMorph := RubScrolledTextMorph new. Â Â Â textMorph Â Â Â Â Â Â beReadOnly; Â Â Â Â Â Â beWrapped; Â Â Â Â Â Â textFont: self theme textFont; Â Â Â Â Â Â textColor: self theme textColor; Â Â Â Â Â Â backgroundColor: BalloonMorph balloonColor. Le 09/05/2018 Ã 12:08, Hilaire a Ã©critÂ : > Part of the the problem here is using a tooltip to do something else! > Printing the result of of printit as tooltips but it should be another > widget, eventually subclassed. > > Hilaire -- Dr. Geo http://drgeo.eu

May 9, 2018

Re: [Pharo-dev] GT Playground Print It Popup unreadeable

by Hilaire

Part of the the problem here is using a tooltip to do something else! Printing the result of of printit as tooltips but it should be another widget, eventually subclassed. Hilaire Le 08/05/2018 Ã 16:09, Sven Van Caekenberghe a Ã©critÂ : > In the very latest Pharo 7 using the Dark Theme (with the recent > changed Tooltip), the intermediate Popup shown when doing Print It in > a GT Playground is unreadable: -- Dr. Geo http://drgeo.eu

May 9, 2018

Is #openFileStream:writable: used ?

by Sven Van Caekenberghe

Hi, Both FileSystem and FileSystemStore (and its subclasses DiskStore and MemoryStore) implement #openFileStream:writable: However, there are no users and putting a breakpoint there does not trigger when reading/writing files. Candidate for removal or not ? Sven

May 9, 2018

[ Umbrella Issue ] Cleanup remaining DeprecatedFileSystem users

by Sven Van Caekenberghe

Hi, I created the following: https://pharo.manuscript.com/f/cases/21858/Cleanup-remaining-DeprecatedFile… This is an umbrella issue, please create sub issues for each set of changes. It is better to work step by step. The package DeprecatedFileSystem contains classes that should no longer be used, the most important being FileStream, StandardFileStream and MultiByteFileStream MultiByteBinaryOrTextStream and RWBinaryOrTextStream Alternatives exist by using FileSystem's FileReference as well as File and various new (Zn) streams. Let's all work together to make this real. It is important that the image itself makes correct use of ongoing refactoring efforts. We already took great steps, but there is more work to do. Note that in many cases, using code can and should be simplified, removing ugly hacks where possible. Feel free to discuss any issues on the ML. Sven

May 9, 2018

[Pharo 7.0-dev] Build #848: 21856 Balloon and playground printIt colors for DarkTheme should be fixed

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #848 was: SUCCESS. The Pull Request #1320 was integrated: "21856 Balloon and playground printIt colors for DarkTheme should be fixed" Pull request url: https://github.com/pharo-project/pharo/pull/1320 Issue Url: https://pharo.fogbugz.com/f/cases/21856 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 9, 2018