May 2018 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Image format not recognized

by Hilaire

Le 31/05/2018 Ã 21:27, Sven Van Caekenberghe a Ã©critÂ : >> On 31 May 2018, at 13:23, Hilaire<hilaire(a)drgeo.eu> wrote: >> >> Oh, but wait PNG reader seems to break now on another part... See screenshot. > Did you seehttps://github.com/DraagrenKirneh/PngSuiteExplorer ? We score 100% on thehttp://www.schaik.com/pngsuite2011 test suite. > Cool. Nice to know. Hilaire -- Dr. Geo http://drgeo.eu

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Hilaire

Yes, I use only #formFromStream: message now Hilaire Le 31/05/2018 Ã 19:43, Sven Van Caekenberghe a Ã©critÂ : > Great, so you agree that #createAFormFrom: is a candidate for removal ? -- Dr. Geo http://drgeo.eu

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Sven Van Caekenberghe

> On 31 May 2018, at 13:23, Hilaire <hilaire(a)drgeo.eu> wrote: > > Oh, but wait PNG reader seems to break now on another part... See screenshot. Did you see https://github.com/DraagrenKirneh/PngSuiteExplorer ? We score 100% on the http://www.schaik.com/pngsuite2011 test suite.

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Sven Van Caekenberghe

Great, so you agree that #createAFormFrom: is a candidate for removal ? > On 31 May 2018, at 19:01, Hilaire <hilaire(a)drgeo.eu> wrote: > > This is what I did, But I hope this problem will not hit somewhere else. > > > Le 31/05/2018 Ã 18:06, Sven Van Caekenberghe a Ã©crit : >> That is because that particular method (with no users in the image) uses a deprecated class, change it to the simpler >> >> createAFormFrom: data >> | error f | >> error := ''. >> f := [ self formFromStream: data readStream ] ifError: >> [ :a :b | >> error := a printString , ' ' , b printString. >> (StringMorph contents: error) >> color: Color red; >> imageForm ]. >> ^ { f. error } >> >> but honestly, why this method and why not directly do >> >> self formFromStream: data readStream >> >> swallowing errors is so/so, IMHO. Also, the return value is really unusual. You just want the Form, right. It is not the responsibility of a system class to do UI for you, I think. > > -- > Dr. Geo > http://drgeo.eu > > >

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Hilaire

This is what I did, But I hope this problem will not hit somewhere else. Le 31/05/2018 Ã 18:06, Sven Van Caekenberghe a Ã©critÂ : > That is because that particular method (with no users in the image) uses a deprecated class, change it to the simpler > > createAFormFrom: data > | error f | > error := ''. > f := [ self formFromStream: data readStream ] ifError: > [ :a :b | > error := a printString , ' ' , b printString. > (StringMorph contents: error) > color: Color red; > imageForm ]. > ^ { f. error } > > but honestly, why this method and why not directly do > > self formFromStream: data readStream > > swallowing errors is so/so, IMHO. Also, the return value is really unusual. You just want the Form, right. It is not the responsibility of a system class to do UI for you, I think. -- Dr. Geo http://drgeo.eu

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Sven Van Caekenberghe

> On 31 May 2018, at 17:55, Hilaire <hilaire(a)drgeo.eu> wrote: > > Hi Sven, > > Thanks for your in-depth testing. > > The code of the test and the one I posted last year is not the exactly same. And if you try it, it fails. May be a supplementary source of failure. > > Now with the latest P7 image of today, installing DrGeo fails. > > Particularly this enclosed class fails to initialize. It comes with PNG content as ByteArray. I think it is related problems. > > It seem there are different syntax changes I don't understand: > > This code fails NOW: > > PNGReadWriter createAFormFrom: #(137 ... 130) asByteArray > > This code succeeds: > > PNGReadWriter formFromStream: #[137 ... 130] readStream > > > Is it expected failure? That is because that particular method (with no users in the image) uses a deprecated class, change it to the simpler createAFormFrom: data | error f | error := ''. f := [ self formFromStream: data readStream ] ifError: [ :a :b | error := a printString , ' ' , b printString. (StringMorph contents: error) color: Color red; imageForm ]. ^ { f. error } but honestly, why this method and why not directly do self formFromStream: data readStream swallowing errors is so/so, IMHO. Also, the return value is really unusual. You just want the Form, right. It is not the responsibility of a system class to do UI for you, I think. > Hilaire > > > Le 31/05/2018 Ã 16:23, Sven Van Caekenberghe a Ã©crit : >> Hi Hilaire, >> >> On Pharo 7 build 993 it works on both 32 and 64 bits (macOS): >> >> >> >> >> The patch (#normalize calls here and there) seems to have been integrated as well your test case (#testNewFromSampleBytes), with your name in the comments ! >> > > -- > Dr. Geo > http://drgeo.eu > > <DrGLoader.st.zip>

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Hilaire

Hi Sven, Thanks for your in-depth testing. The code of the test and the one I posted last year is not the exactly same. And if you try it, it fails. May be a supplementary source of failure. Now with the latest P7 image of today, installing DrGeo fails. Particularly this enclosed class fails to initialize. It comes with PNG content as ByteArray. I think it is related problems. It seem there are different syntax changes I don't understand: This code fails NOW: PNGReadWriter createAFormFrom: #(137 ... 130) asByteArray This code succeeds: PNGReadWriter formFromStream: #[137 ... 130] readStream Is it expected failure? Hilaire Le 31/05/2018 Ã 16:23, Sven Van Caekenberghe a Ã©critÂ : > Hi Hilaire, > > On Pharo 7 build 993 it works on both 32 and 64 bits (macOS): > > > > > The patch (#normalize calls here and there) seems to have been > integrated as well your test case (#testNewFromSampleBytes), with your > name in the comments ! > -- Dr. Geo http://drgeo.eu

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Sven Van Caekenberghe

Hi Hilaire, On Pharo 7 build 993 it works on both 32 and 64 bits (macOS): The patch (#normalize calls here and there) seems to have been integrated as well your test case (#testNewFromSampleBytes), with your name in the comments ! Sven > On 31 May 2018, at 13:23, Hilaire <hilaire(a)drgeo.eu <mailto:hilaire@drgeo.eu>> wrote: > > Ah, indeed testing on latest P7, this code works. > > Oh, but wait PNG reader seems to break now on another part... See screenshot. > > Oh, it looks like the problem we got almost one years ago... where I suggested code snipped for test inclusion[1] and it now fails again (was not failing on my previous P7 image)... As far as I can see I did not find a test based on it in the Pharo image I tested on. > > At the time it was failing on 64bits, and now it fails on the 32bits I tried it. > > I guess some recent changes on P7 break something. It will be nice to add a test based on the example I provided at [1]. > > > Hilaire > > [1] http://forum.world.st/Regression-with-PNGReaderWriter-in-P6-td4951796.html <http://forum.world.st/Regression-with-PNGReaderWriter-in-P6-td4951796.html> > > > Le 31/05/2018 Ã 12:20, Sven Van Caekenberghe a Ã©crit : >> Hmm, works for me: >> > > -- > Dr. Geo > http://drgeo.eu <http://drgeo.eu/> > > <brokenPNG.png>

May 31, 2018

[Pharo 7.0-dev] Build #994: 20324-Handy-file-automatic-numbering

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #994 was: FAILURE. The Pull Request #1460 was integrated: "20324-Handy-file-automatic-numbering" Pull request url: https://github.com/pharo-project/pharo/pull/1460 Issue Url: https://pharo.fogbugz.com/f/cases/20324 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 31, 2018

Re: [Pharo-dev] Image format not recognized

by Sven Van Caekenberghe

Hi Hilaire, On Pharo 7 build 993 it works on both 32 and 64 bits (macOS): The patch (#normalize calls here and there) seems to have been integrated as well your test case (#testNewFromSampleBytes), with your name in the comments ! Sven > On 31 May 2018, at 13:23, Hilaire <hilaire(a)drgeo.eu> wrote: > > Ah, indeed testing on latest P7, this code works. > > Oh, but wait PNG reader seems to break now on another part... See screenshot. > > Oh, it looks like the problem we got almost one years ago... where I suggested code snipped for test inclusion[1] and it now fails again (was not failing on my previous P7 image)... As far as I can see I did not find a test based on it in the Pharo image I tested on. > > At the time it was failing on 64bits, and now it fails on the 32bits I tried it. > > I guess some recent changes on P7 break something. It will be nice to add a test based on the example I provided at [1]. > > > Hilaire > > [1] http://forum.world.st/Regression-with-PNGReaderWriter-in-P6-td4951796.html > > > Le 31/05/2018 Ã 12:20, Sven Van Caekenberghe a Ã©crit : >> Hmm, works for me: >> > > -- > Dr. Geo > http://drgeo.eu > > <brokenPNG.png>

May 31, 2018