April 2018 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] File/Stream changes: one Integer decoder/encoder to rule them all

by Tudor Girba

Thatâs exactly my feeling as well. Doru > On Apr 22, 2018, at 6:41 PM, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: > > Thanks a lot Sven. This is great to see all this positive energy to > improve this part. > From a core library stand point, streams were the last pieces that > needed to be revisited. > This is great to see this happening. > > Stef > > On Sun, Apr 22, 2018 at 11:04 AM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> >>> On 22 Apr 2018, at 10:22, Tudor Girba <tudor(a)tudorgirba.com> wrote: >>> >>> Hi, >>> >>> I am so looking forward to playing with this (as a user). >>> >>> For various reasons, we are still in Pharo 6.1, but encoding/decoding was always a troublesome issue in Pharo. >> >> Well it should not be, not even in older Pharo versions, as long as you use everything correctly. >> >> But the latest changes are a bold step forward. >> >>> Thanks a lot! >>> >>> Cheers, >>> Doru >>> >>> >>>> On Apr 20, 2018, at 5:24 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>>> >>>> Hi, >>>> >>>> After the File and Stream changes in Pharo 7, a binary read, resp. write stream from/to a file is actually a ZnBuffered(Read|Write)Stream on a BinaryFileStream. You access these using #binary(Read|Write)Stream[Do:] sent to a FileReference. >>>> >>>> As minimal streams the API of ZnBuffered(Read|Write)Stream was different from what existed before. >>>> >>>> Specifically, a number of Integer decoding/encoding methods were missing. It is probably best to add those (an alternative would be a subclass). >>>> >>>> When I looked at what was available, I thought I could improve upon the current situation. In fact, I think all existing ones can be written in terms of just one key method, one for reading and one for writing. The existing methods than become simple aliases, all while offering more functionality. >>>> >>>> (Incidentally this would be an ideal use of a Trait, can we use them again/still ?) >>>> >>>> The key method is #nextIntegerOfSize: numberOfBytes signed: signed bigEndian: bigEndian [put: value] and can be found in the latest version of Zinc-CharacterEncoding-Core with a comprehensive set of unit tests. >>>> >>>> For example, >>>> >>>> int32 >>>> ^ self nextIntegerOfSize: 4 signed: true bigEndian: true >>>> >>>> nextWord >>>> ^ self nextIntegerOfSize: 2 signed: false bigEndian: true >>>> >>>> or non-aliases ones like >>>> >>>> binaryStream nextIntegerOfSize: 3 signed: true bigEndian: false >>>> >>>> I think I nailed it, but I would love a second pair of eyes to check what I did. >>>> >>>> The same functionality could be added to ByteArray in a slight variation (with offsets), where similar integer encoding/decoding methods exist. >>>> >>>> Sven >>> >>> -- >>> www.tudorgirba.com >>> www.feenk.com >>> >>> "From an abstract enough point of view, any two things are similar." >>> >>> >>> >>> >>> >> >> > -- www.tudorgirba.com www.feenk.com "There are no old things, there are only old ways of looking at them."

April 22, 2018

Re: [Pharo-dev] Epicea or the launcher gets confused

by Martin Dias

Hi Stef: I haven't use the launcher in a couple of years, but I can make this supposition: the images share the directory where epicea creates the ombu files. Then what you see are changes done in another image managed by launcher. Is it like that? MartÃn On Sat, Apr 21, 2018 at 5:31 AM, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: > Hi > > I downloaded the latest version of Pharo and I coded. > When I open Epicea, I see changes I did three days ago but this is not > possible > since I just took the image now. > > Stef > >

April 22, 2018

Re: [Pharo-dev] Calypso zero class refs for TComparable

by Denis Kudriashov

Hi 2018-04-22 17:19 GMT+02:00 Hilaire <hilaire(a)drgeo.eu>: > Denis, > > Here is my experience on that: > > 1. I did not expect the trait user radio button, so I did not look at it. > > 2. However I request the contextual menu over the trait and expect > something to see its users, and I get the menu entry "Class ref.", and went > there. > > Other user opinion may be needed, but from my POV 1. is uneeded, 2. "Class > ref." should be replaced by "Users". > Traits are normal classes. They can be used directly in code. It is not common practice but I saw such code. But I am wondering that extra radio button is not intuitive solution for you. It is placed nearly Flat/Hier options because it is another kind of class relationship. To me it is consistent to access it in same way like "class->superclass" relationship. And there is another option "Traits" for classes which uses traits. And notice that we do not show subclasses of class in the result of "Class refs" query. > > It will make your UI more consistent and predictable to the end user. > > Hilaire > > > Le 22/04/2018 Ã 12:45, Denis Kudriashov a Ã©crit : > >> Hi. >> >> When you select trait new hierarchy mode appears: trait users. >> >> > -- > Dr. Geo > http://drgeo.eu > > > >

April 22, 2018

Re: [Pharo-dev] learning about ClassTestCase

by Stephane Ducasse

No idea. May be people were thinking that printOn: were not worth tests. Now I would like to revisit some unused features of Sunit such as the history. On Sun, Apr 22, 2018 at 3:44 AM, Ben Coman <btc(a)openinworld.com> wrote: > I bumped into ClassTestCase for the first time, with class comment... > "This class is intended for unit tests of individual classes and their > metaclasses. > It provides methods to determine the coverage of the unit tests. > > Subclasses are expected to re-implement: > #classesToBeTested and > #selectorsToBeIgnored. > They should also implement to confirm that all methods have been tested. > #testCoverage > super testCoverage. > " > > A few questions to improve my knowledge of how to use this... > > a. there are no implementors of #classesToBeTested but several of > #classToBeTested. I presume the class comment is wrong? > > b. there are no implementors of #testCoverage, so I presume I can ignore > that? (and I've no example to work from) > > c. ClassTestCase is subclassed 73 times, but #selectorsToBeIgnored is only > implemented 9 times. So this seems not critical? But btw, every of those at > least ignores #printOn:. I'm curious why? These are tagged "private", but > is that a good reason not to test it? > > My purpose was to add a new class MagnitudeTest for a new > new method to Magnitude in response to the recent #min:max: discussion. > > cheers -ben

April 22, 2018

Re: [Pharo-dev] Calypso zero class refs for TComparable

by Stephane Ducasse

Yes I'm afraid that you are right. What I did in the past was implementor on class -> class def sender on class -> class ref may be we could do the same for traits Stef On Sun, Apr 22, 2018 at 5:13 PM, Hilaire <hilaire(a)drgeo.eu> wrote: > Le 22/04/2018 Ã 11:59, Cyril Ferlicot a Ã©crit : >> >> >> In Nautilus the Traits are not "referenced", they are used. So you have >> "Find usage" instead of "Find reference". >> > This distinction is confusing, and it will confuse people as it confused Ben > and me as well. > > Hilaire > > -- > Dr. Geo > http://drgeo.eu > > >

April 22, 2018

Re: [Pharo-dev] File/Stream changes: one Integer decoder/encoder to rule them all

by Stephane Ducasse

Thanks a lot Sven. This is great to see all this positive energy to improve this part. >From a core library stand point, streams were the last pieces that needed to be revisited. This is great to see this happening. Stef On Sun, Apr 22, 2018 at 11:04 AM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > >> On 22 Apr 2018, at 10:22, Tudor Girba <tudor(a)tudorgirba.com> wrote: >> >> Hi, >> >> I am so looking forward to playing with this (as a user). >> >> For various reasons, we are still in Pharo 6.1, but encoding/decoding was always a troublesome issue in Pharo. > > Well it should not be, not even in older Pharo versions, as long as you use everything correctly. > > But the latest changes are a bold step forward. > >> Thanks a lot! >> >> Cheers, >> Doru >> >> >>> On Apr 20, 2018, at 5:24 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>> >>> Hi, >>> >>> After the File and Stream changes in Pharo 7, a binary read, resp. write stream from/to a file is actually a ZnBuffered(Read|Write)Stream on a BinaryFileStream. You access these using #binary(Read|Write)Stream[Do:] sent to a FileReference. >>> >>> As minimal streams the API of ZnBuffered(Read|Write)Stream was different from what existed before. >>> >>> Specifically, a number of Integer decoding/encoding methods were missing. It is probably best to add those (an alternative would be a subclass). >>> >>> When I looked at what was available, I thought I could improve upon the current situation. In fact, I think all existing ones can be written in terms of just one key method, one for reading and one for writing. The existing methods than become simple aliases, all while offering more functionality. >>> >>> (Incidentally this would be an ideal use of a Trait, can we use them again/still ?) >>> >>> The key method is #nextIntegerOfSize: numberOfBytes signed: signed bigEndian: bigEndian [put: value] and can be found in the latest version of Zinc-CharacterEncoding-Core with a comprehensive set of unit tests. >>> >>> For example, >>> >>> int32 >>> ^ self nextIntegerOfSize: 4 signed: true bigEndian: true >>> >>> nextWord >>> ^ self nextIntegerOfSize: 2 signed: false bigEndian: true >>> >>> or non-aliases ones like >>> >>> binaryStream nextIntegerOfSize: 3 signed: true bigEndian: false >>> >>> I think I nailed it, but I would love a second pair of eyes to check what I did. >>> >>> The same functionality could be added to ByteArray in a slight variation (with offsets), where similar integer encoding/decoding methods exist. >>> >>> Sven >> >> -- >> www.tudorgirba.com >> www.feenk.com >> >> "From an abstract enough point of view, any two things are similar." >> >> >> >> >> > >

April 22, 2018

Re: [Pharo-dev] Calypso zero class refs for TComparable

by Hilaire

Denis, Here is my experience on that: 1. I did not expect the trait user radio button, so I did not look at it. 2. However I request the contextual menu over the trait and expect something to see its users, and I get the menu entry "Class ref.", and went there. Other user opinion may be needed, but from my POV 1. is uneeded, 2. "Class ref." should be replaced by "Users". It will make your UI more consistent and predictable to the end user. Hilaire Le 22/04/2018 Ã 12:45, Denis Kudriashov a Ã©critÂ : > Hi. > > When you select trait new hierarchy mode appears: trait users. > -- Dr. Geo http://drgeo.eu

April 22, 2018

Re: [Pharo-dev] Calypso zero class refs for TComparable

by Hilaire

Le 22/04/2018 Ã 11:59, Cyril Ferlicot a Ã©critÂ : > > In Nautilus the Traits are not "referenced", they are used. So you > have "Find usage" instead of "Find reference". > This distinction is confusing, and it will confuse people as it confused Ben and me as well. Hilaire -- Dr. Geo http://drgeo.eu

April 22, 2018

Re: [Pharo-dev] Calypso zero class refs for TComparable

by Ben Coman

On 22 April 2018 at 22:16, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > 2018-04-22 16:01 GMT+02:00 Ben Coman <btc(a)openinworld.com>: >> >> On 22 April 2018 at 18:45, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: >> >>> Hi. >>> >>> When you select trait new hierarchy mode appears: trait users. >>> >> >> I see it now, but clicking it for TComparable does't show anything. Is >> that right? >> > > Yes. > > TComparable users ==> #() > > > Can you advise a Trait that shows some results as an example? >> > > ClyTraitChild1 browse > > > Thanks. And now it makes sense. Traits aren't referenced directly in code. cheers -ben

April 22, 2018

Re: [Pharo-dev] Calypso zero class refs for TComparable

by Denis Kudriashov

2018-04-22 16:01 GMT+02:00 Ben Coman <btc(a)openinworld.com>: > > On 22 April 2018 at 18:45, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > >> Hi. >> >> When you select trait new hierarchy mode appears: trait users. >> > > I see it now, but clicking it for TComparable does't show anything. Is > that right? > Yes. TComparable users ==> #() Can you advise a Trait that shows some results as an example? > ClyTraitChild1 browse > cheers -ben >

April 22, 2018