April 2018 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Images, VMs and 32 vs 64bit

by Peter UhnÃ¡k

> images for different platforms (Mac, Linux, Windows) yes It is the responsibility of the VM to contain the differences. Note that there's some "platform-specific" code, but the image contains the code for all platforms at once. Generally speaking you can code on one platform, copy the image files to another and continue your work (although doing this can cause trouble, as e.g. some file paths may now point to non-existing locations). You can download the images independently of the platform too (e.g. Pharo 6 images: http://files.pharo.org/image/60/ ) > VMs (32bit, 64bit) yes? the files are different, but I don't know if there's code difference, or if the images are just built with different memory layouts Peter On Wed, Apr 11, 2018 at 12:13 AM, Benoit St-Jean via Pharo-dev < pharo-dev(a)lists.pharo.org> wrote: > > > ---------- Forwarded message ---------- > From: Benoit St-Jean <bstjean(a)yahoo.com> > To: Pharo Development List <pharo-dev(a)lists.pharo.org> > Cc: > Bcc: > Date: Tue, 10 Apr 2018 22:13:18 +0000 (UTC) > Subject: Images, VMs and 32 vs 64bit > I was wondering if images for different platforms (Mac, Linux, Windows) > and VMs (32bit, 64bit) are, code-wise, the same? By "the same", I mean do > they all have the exact same code base or some classes/methods are in some > and not in others or different? > > ----------------- > BenoÃ®t St-Jean > Yahoo! Messenger: bstjean > Twitter: @BenLeChialeux > Pinterest: benoitstjean > Instagram: Chef_Benito > IRC: lamneth > Blogue: endormitoire.wordpress.com > "A standpoint is an intellectual horizon of radius zero". (A. Einstein) > >

April 10, 2018

Images, VMs and 32 vs 64bit

by Benoit St-Jean

I was wondering if images for different platforms (Mac, Linux, Windows) and VMs (32bit, 64bit) are, code-wise, the same?Â By "the same", I mean do they all have the exact same code base or some classes/methods are in some and not in others or different? ----------------- BenoÃ®t St-Jean Yahoo! Messenger: bstjean Twitter: @BenLeChialeux Pinterest: benoitstjean Instagram: Chef_Benito IRC: lamneth Blogue: endormitoire.wordpress.com "A standpoint is an intellectual horizon of radius zero".Â (A. Einstein)

April 10, 2018

Re: [Pharo-dev] Why String do not implement #displayString?

by Benoit St-Jean

In the "old" days, programmers made sure to respect the following conventions : you implement #storeOn:, #displayString: and #printOn: .Â Eventually, an object will be sent #storeString and #printString and will use your #whateverOn: implementation.Â It looks like that good habit that I've learned at university looooooong ago got lost somewhere.Â It looks like no one uses #displayString anymore and rely solely on #printString instead!Â I had a teacher once telling me #displayString had a crappy implementation : it just sent #printString and that to be "code clean", one should implement #displayOn: and modify #displayString accordingly. But if I recall, VW at the time introduced #displayOn: for widgets and other things, hence why #displayString never sent #displayOn:. To make a long story short of what should have been and what it's always been, here's an excellent paper on the subject! http://esug.org/data/HistoricalDocuments/TheSmalltalkReport/ST07/04wo.pdf ----------------- BenoÃ®t St-Jean Yahoo! Messenger: bstjean Twitter: @BenLeChialeux Pinterest: benoitstjean Instagram: Chef_Benito IRC: lamneth Blogue: endormitoire.wordpress.com "A standpoint is an intellectual horizon of radius zero".Â (A. Einstein) On Tuesday, April 10, 2018, 11:28:57 a.m. EDT, Esteban A. Maringolo <emaringolo(a)gmail.com> wrote: Isn't #displayString implemented in terms of #displayOn: the same way #printString is implemented in terms of "printOn:"? And in the case of String #displayString should return the receiver (it is, self), so the following should be true. | s | s := 'Hello, ''Funny'' World'. s displayString = s. "true" s printString = s. "false" Regards, On 10/04/2018 12:21, Denis Kudriashov wrote: > Hi. > > According to the comment of #displayString it should be used as default > textual representation of objects in the UI: > >Â Â "While printString is about to give a detailled information about an >Â Â object, displayString is a message that should return a short >Â Â string-based representation to be used by list and related UI >Â Â frameworks. By default, simply return printString." >Â Â "asString should not be implemented in Object, and kept for >Â Â conversion between strings, symbols, text and characters." > > But String itself does not respect this message: > >Â Â 'some string' displayString " ==> '''someString''' " > > > Is it bug? Or is there any reason for this? > > Best regards, > Denis -- Esteban A. Maringolo

April 10, 2018

Re: [Pharo-dev] help wanted: normalising LF on tonel for Pharo project

by Peter UhnÃ¡k

> or a .iceberg file? Why not use `.properties`? { #format : #tonel, #eol: #lf } On Tue, Apr 10, 2018 at 11:55 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > or a .iceberg file? > > Esteban > > ps: yep, we need itâ¦ we will have it, why not start now? > > On 10 Apr 2018, at 23:52, Guillermo Polito <guillermopolito(a)gmail.com> > wrote: > > It could be a checkbox in the "create repository dialog". > > "Use lf as default line ending" > > (and set it to true by default (?)) > > On Tue, Apr 10, 2018 at 11:50 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > >> An argument can be made that Pharo would _always_ produce LF. >> I don't think I've ever needed _code_ to be CRLF in a ~decade of using >> git on Windows. It was always just an annoyance. >> >> Peter >> >> On Tue, Apr 10, 2018 at 11:44 PM, Esteban Lorenzano <estebanlm(a)gmail.com> >> wrote: >> >>> hi, >>> >>> > On 10 Apr 2018, at 23:17, Esteban A. Maringolo <emaringolo(a)gmail.com> >>> wrote: >>> > >>> > Not stricly related, or maybe yes, but years ago in InfOil we started >>> > using Dolphin Smalltalk PAX format[1] for packages with Git, and we >>> used >>> > that setting to store code in the repo, we didn't have any issues >>> > >>> > The .gitattributes contained this: >>> > *.img binary >>> > *.chg binary >>> > *.sml binary >>> > OurImage.img merge=ours >>> > OurImage.chg merge=ours >>> > *.pax eol=lf >>> > *.cls eol=lf >>> > >>> > .pax was the "package definition" and "method extensions" (methods not >>> > belonging to the package) file. >>> > .cls was the 1 file per class+class-side used by this scheme >>> > >>> > Even we did everything in Windows for some reason I don't remember (+5 >>> > yrs ago) LF was better for Gitlab. What I also don't remember is if >>> > during the checkout in the Gitlab CI some conversion was used or not. I >>> > don't remember a lot of things, but I can ask them if you want. >>> > >>> > But I can confirm that this "trick" does work. >>> > >>> > Git for Windows even asks you if you want to automatically convert CRLF >>> > to LF during checkin and back to CRLF on checkout. >>> >>> exactly what I want, because pharo/iceberg/tonel uses the system line >>> ending to write the files :) >>> thanks! >>> >>> Esteban >>> >>> ps: otherwise I will need to add some support in-image and I donât think >>> is the best approach. >>> pps: now it remains to see if libgit2 honours the .gitattributes config >>> >>> > >>> > Regards, >>> > >>> > >>> > On 10/04/2018 18:05, Esteban Lorenzano wrote: >>> >> Hi, >>> >> >>> >> Iâve been wondering how to better fix the problem of having windows >>> and >>> >> linux/macOS people contributing and the fact that files are written in >>> >> their native system format (crlf windows, lf for the rest of the >>> world). >>> >> >>> >> I digged a bit and I found a couple a link that helped me (after >>> trying >>> >> to understand the >>> >> doc): https://stackoverflow.com/questions/170961/whats-the-best-cr >>> lf-carriage-return-line-feed-handling-strategy-with-git >>> >> >>> >> and it seems adding a .gitattributes file with this content: >>> >> >>> >> # Auto detect text files and perform LF normalization >>> >> *text=auto >>> >> *.sttext merge=union eol=lf >>> >> >>> >> could fix the problem? >>> >> can someone confirm this? >>> >> >>> >> (I confess this issue confuses me a lot :P) >>> >> >>> >> cheers! >>> >> Esteban >>> > >>> > -- >>> > Esteban A. Maringolo >>> > >>> >>> >>> >> > > > -- > > Guille Polito > Research Engineer > > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - *http://www.cnrs.fr > <http://www.cnrs.fr/>* > > *Web:* *http://guillep.github.io* <http://guillep.github.io/> > *Phone: *+33 06 52 70 66 13 > > >

April 10, 2018

Re: [Pharo-dev] help wanted: normalising LF on tonel for Pharo project

by Guillermo Polito

Both, the checkbox will be used to set the property in disk at some point :). On Tue, Apr 10, 2018 at 11:55 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > or a .iceberg file? > > Esteban > > ps: yep, we need itâ¦ we will have it, why not start now? > > On 10 Apr 2018, at 23:52, Guillermo Polito <guillermopolito(a)gmail.com> > wrote: > > It could be a checkbox in the "create repository dialog". > > "Use lf as default line ending" > > (and set it to true by default (?)) > > On Tue, Apr 10, 2018 at 11:50 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > >> An argument can be made that Pharo would _always_ produce LF. >> I don't think I've ever needed _code_ to be CRLF in a ~decade of using >> git on Windows. It was always just an annoyance. >> >> Peter >> >> On Tue, Apr 10, 2018 at 11:44 PM, Esteban Lorenzano <estebanlm(a)gmail.com> >> wrote: >> >>> hi, >>> >>> > On 10 Apr 2018, at 23:17, Esteban A. Maringolo <emaringolo(a)gmail.com> >>> wrote: >>> > >>> > Not stricly related, or maybe yes, but years ago in InfOil we started >>> > using Dolphin Smalltalk PAX format[1] for packages with Git, and we >>> used >>> > that setting to store code in the repo, we didn't have any issues >>> > >>> > The .gitattributes contained this: >>> > *.img binary >>> > *.chg binary >>> > *.sml binary >>> > OurImage.img merge=ours >>> > OurImage.chg merge=ours >>> > *.pax eol=lf >>> > *.cls eol=lf >>> > >>> > .pax was the "package definition" and "method extensions" (methods not >>> > belonging to the package) file. >>> > .cls was the 1 file per class+class-side used by this scheme >>> > >>> > Even we did everything in Windows for some reason I don't remember (+5 >>> > yrs ago) LF was better for Gitlab. What I also don't remember is if >>> > during the checkout in the Gitlab CI some conversion was used or not. I >>> > don't remember a lot of things, but I can ask them if you want. >>> > >>> > But I can confirm that this "trick" does work. >>> > >>> > Git for Windows even asks you if you want to automatically convert CRLF >>> > to LF during checkin and back to CRLF on checkout. >>> >>> exactly what I want, because pharo/iceberg/tonel uses the system line >>> ending to write the files :) >>> thanks! >>> >>> Esteban >>> >>> ps: otherwise I will need to add some support in-image and I donât think >>> is the best approach. >>> pps: now it remains to see if libgit2 honours the .gitattributes config >>> >>> > >>> > Regards, >>> > >>> > >>> > On 10/04/2018 18:05, Esteban Lorenzano wrote: >>> >> Hi, >>> >> >>> >> Iâve been wondering how to better fix the problem of having windows >>> and >>> >> linux/macOS people contributing and the fact that files are written in >>> >> their native system format (crlf windows, lf for the rest of the >>> world). >>> >> >>> >> I digged a bit and I found a couple a link that helped me (after >>> trying >>> >> to understand the >>> >> doc): https://stackoverflow.com/questions/170961/whats-the-best-cr >>> lf-carriage-return-line-feed-handling-strategy-with-git >>> >> >>> >> and it seems adding a .gitattributes file with this content: >>> >> >>> >> # Auto detect text files and perform LF normalization >>> >> *text=auto >>> >> *.sttext merge=union eol=lf >>> >> >>> >> could fix the problem? >>> >> can someone confirm this? >>> >> >>> >> (I confess this issue confuses me a lot :P) >>> >> >>> >> cheers! >>> >> Esteban >>> > >>> > -- >>> > Esteban A. Maringolo >>> > >>> >>> >>> >> > > > -- > > Guille Polito > Research Engineer > > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - *http://www.cnrs.fr > <http://www.cnrs.fr/>* > > *Web:* *http://guillep.github.io* <http://guillep.github.io/> > *Phone: *+33 06 52 70 66 13 > > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

April 10, 2018

Re: [Pharo-dev] help wanted: normalising LF on tonel for Pharo project

by Esteban Lorenzano

or a .iceberg file? Esteban ps: yep, we need itâ¦ we will have it, why not start now? > On 10 Apr 2018, at 23:52, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > > It could be a checkbox in the "create repository dialog". > > "Use lf as default line ending" > > (and set it to true by default (?)) > > On Tue, Apr 10, 2018 at 11:50 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com <mailto:i.uhnak@gmail.com>> wrote: > An argument can be made that Pharo would _always_ produce LF. > I don't think I've ever needed _code_ to be CRLF in a ~decade of using git on Windows. It was always just an annoyance. > > Peter > > On Tue, Apr 10, 2018 at 11:44 PM, Esteban Lorenzano <estebanlm(a)gmail.com <mailto:estebanlm@gmail.com>> wrote: > hi, > > > On 10 Apr 2018, at 23:17, Esteban A. Maringolo <emaringolo(a)gmail.com <mailto:emaringolo@gmail.com>> wrote: > > > > Not stricly related, or maybe yes, but years ago in InfOil we started > > using Dolphin Smalltalk PAX format[1] for packages with Git, and we used > > that setting to store code in the repo, we didn't have any issues > > > > The .gitattributes contained this: > > *.img binary > > *.chg binary > > *.sml binary > > OurImage.img merge=ours > > OurImage.chg merge=ours > > *.pax eol=lf > > *.cls eol=lf > > > > .pax was the "package definition" and "method extensions" (methods not > > belonging to the package) file. > > .cls was the 1 file per class+class-side used by this scheme > > > > Even we did everything in Windows for some reason I don't remember (+5 > > yrs ago) LF was better for Gitlab. What I also don't remember is if > > during the checkout in the Gitlab CI some conversion was used or not. I > > don't remember a lot of things, but I can ask them if you want. > > > > But I can confirm that this "trick" does work. > > > > Git for Windows even asks you if you want to automatically convert CRLF > > to LF during checkin and back to CRLF on checkout. > > exactly what I want, because pharo/iceberg/tonel uses the system line ending to write the files :) > thanks! > > Esteban > > ps: otherwise I will need to add some support in-image and I donât think is the best approach. > pps: now it remains to see if libgit2 honours the .gitattributes config > > > > > Regards, > > > > > > On 10/04/2018 18:05, Esteban Lorenzano wrote: > >> Hi, > >> > >> Iâve been wondering how to better fix the problem of having windows and > >> linux/macOS people contributing and the fact that files are written in > >> their native system format (crlf windows, lf for the rest of the world). > >> > >> I digged a bit and I found a couple a link that helped me (after trying > >> to understand the > >> doc): https://stackoverflow.com/questions/170961/whats-the-best-crlf-carriage-ret… <https://stackoverflow.com/questions/170961/whats-the-best-crlf-carriage-ret…> > >> > >> and it seems adding a .gitattributes file with this content: > >> > >> # Auto detect text files and perform LF normalization > >> *text=auto > >> *.sttext merge=union eol=lf > >> > >> could fix the problem? > >> can someone confirm this? > >> > >> (I confess this issue confuses me a lot :P) > >> > >> cheers! > >> Esteban > > > > -- > > Esteban A. Maringolo > > > > > > > > > -- > > Guille Polito > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - http://www.cnrs.fr <http://www.cnrs.fr/> > > Web: http://guillep.github.io <http://guillep.github.io/> > Phone: +33 06 52 70 66 13

April 10, 2018

Re: [Pharo-dev] Changed #atEnd primitive - #atEnd vs #next returning nil

by Sven Van Caekenberghe

Alistair, I am replying in-between, please don't take my remarks as being negative, I just like to straighten things out as clear as possible. > On 10 Apr 2018, at 22:14, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi Sven, > > On 10 April 2018 at 19:36, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> I have trouble understanding your problem analysis, and how your proposed solution, would solve it. > > The discussion started with my proposal to modify the Zinc streams to > check the return value of #next for nil rather than using #atEnd to > iterate over the underlying stream. You correctly pointed out that > the intention behind #atEnd is that it can be used to control > iterating over streams. OK >> Where is it being said that #next and/or #atEnd should be blocking or non-blocking ? > > There is existing code that assumes that #atEnd is non-blocking and > that #next is allowed block. I believe that we should keep those > conditions. I fail to see where that is written down, either way. Can you point me to comments stating that, I would really like to know ? >> How is this related to how EOF is signalled ? > > Because, combined with terminal EOF not being known until the user > explicitly flags it (with Ctrl-D) it means that #atEnd can't be used > for iterating over input from stdin connected to a terminal. This seems to me like an exception that only holds for one particular stream in one particular scenario (interactive stdin). I might be wrong. >> It seems to me that there are quite a few classes of streams that are 'special' in the sense that #next could be blocking and/or #atEnd could be unclear - socket/network streams, serial streams, maybe stdio (interactive or not). Without a message like #isDataAvailable you cannot handle those without blocking. > > Right. I think this is a distraction (I was trying to explain some > details, but it's causing more confusion instead of helping). > > The important point is that #atEnd doesn't work for iterating over > streams with terminal input Maybe you should also point to the actual code that fails. I mean you showed a partial stack trace, but not how you got there, precisely. How does the application reading from an interactive stdin do to get into trouble ? >> Reading from stdin seems like a very rare case for a Smalltalk system (not that it should not be possible). > > There's been quite a bit of discussion and several projects recently > related to using pharo for scripting, so it may become more common. > E.g. > > https://www.quora.com/Can-Smalltalk-be-a-batch-file-scripting-language/answ… > https://github.com/rajula96reddy/pharo-cli Still, it is not common at all. >> I have a feeling that too much functionality is being pushed into too small an API. > > This is just about how should Zinc streams be iterating over the > underlying streams. You didn't like checking the result of #next for > nil since it isn't general, correctly pointing out that nil is a valid > value for non-byte oriented streams. But #atEnd doesn't work for > stdin from a terminal. > > > At this point I think there are three options: > > 1. Modify Zinc to check the return value of #next instead of using #atEnd. > > This is what all existing character / byte oriented streams in Squeak > and Pharo do. At that point the Zinc streams can be used on all file > / stdio input and output. I agree that such code exists in many places, but there is lots of stream reading that does not check for nils. > 2. Modify all streams to signal EOF in some other way, i.e. a sentinel > or notification / exception. > > This is what we were discussing below. But it is a decent chunk of > work with significant impact on the existing code base. Agreed. This would be a future extension. > 3. Require anyone who wants to read from stdin to code around Zinc's > inability to handle terminal input. > > I'd prefer to avoid this option if possible. See higher for a more concrete usage example request. > Does that clarify the situation? Yes, it helps. Thanks. But questions remain. > Thanks, > Alistair > > > >>> On 10 Apr 2018, at 18:30, Alistair Grant <akgrant0710(a)gmail.com> wrote: >>> >>> First a quick update: >>> >>> After doing some work on primitiveFileAtEnd, #atEnd now answers >>> correctly for files that don't report their size correctly, e.g. >>> /dev/urandom and /proc/cpuinfo, whether the files are opened directly or >>> redirected through stdin. >>> >>> However determining whether stdin from a terminal has reached the end of >>> file can't be done without making #atEnd blocking since we have to wait >>> for the user to flag the end of file, e.g. by typing Ctrl-D. And #atEnd >>> is assumed to be non-blocking. >>> >>> So currently using ZnCharacterReadStream with stdin from a terminal will >>> result in a stack dump similar to: >>> >>> MessageNotUnderstood: receiver of "<" is nil >>> UndefinedObject(Object)>>doesNotUnderstand: #< >>> ZnUTF8Encoder>>nextCodePointFromStream: >>> ZnUTF8Encoder(ZnCharacterEncoder)>>nextFromStream: >>> ZnCharacterReadStream>>nextElement >>> ZnCharacterReadStream(ZnEncodedReadStream)>>next >>> UndefinedObject>>DoIt >>> >>> >>> Going back through the various suggestions that have been made regarding >>> using a sentinel object vs. raising a notification / exception, my >>> (still to be polished) suggestion is to: >>> >>> 1. Add an endOfStream instance variable >>> 2. When the end of the stream is reached answer the value of the >>> instance variable (i.e. the result of sending #value to the variable). >>> 3. The initial default value would be a block that raises a Deprecation >>> warning and then returns nil. This would allow existing code to >>> function for a changeover period. >>> 4. At the end of the deprecation period the default value would be >>> changed to a unique sentinel object which would answer itself as its >>> #value. >>> >>> At any time users of the stream can set their own sentinel, including a >>> block that raises an exception. >>> >>> >>> Cheers, >>> Alistair >>> >>> >>> On 4 April 2018 at 19:24, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: >>>> Thanks for this discussion. >>>> >>>> On Wed, Apr 4, 2018 at 1:37 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>>>> Alistair, >>>>> >>>>> First off, thanks for the discussions and your contributions, I really appreciate them. >>>>> >>>>> But I want to have a discussion at the high level of the definition and semantics of the stream API in Pharo. >>>>> >>>>>> On 4 Apr 2018, at 13:20, Alistair Grant <akgrant0710(a)gmail.com> wrote: >>>>>> >>>>>> On 4 April 2018 at 12:56, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>>>>>> Playing a bit devil's advocate, the idea is that, in general, >>>>>>> >>>>>>> [ stream atEnd] whileFalse: [ stream next. "..." ]. >>>>>>> >>>>>>> is no longer allowed ? >>>>>> >>>>>> It hasn't been allowed "forever" [1]. It's just been misused for >>>>>> almost as long. >>>>>> >>>>>> [1] Time began when stdio stream support was introduced. :-) >>>>> >>>>> I am still not convinced. Another way to put it would be that the old #atEnd or #upToEnd do not make sense for these streams and some new loop is needed, based on a new test (it exists for socket streams already). >>>>> >>>>> [ stream isDataAvailable ] whileTrue: [ stream next ] >>>>> >>>>>>> And you want to replace it with >>>>>>> >>>>>>> [ stream next ifNil: [ false ] ifNotNil: [ :x | "..." true ] whileTrue. >>>>>>> >>>>>>> That is a pretty big change, no ? >>>>>> >>>>>> That's the way quite a bit of code already operates. >>>>>> >>>>>> As Denis pointed out, it's obviously problematic in the general sense, >>>>>> since nil can be embedded in non-byte oriented streams. I suspect >>>>>> that in practice not many people write code that reads streams from >>>>>> both byte oriented and non-byte oriented streams. >>>>> >>>>> Maybe yes, maybe no. As Denis' example shows there is a clear definition problem. >>>>> >>>>> And I do use streams of byte arrays or strings all the time, this is really important. I want my parsers to work on all kinds of streams. >>>>> >>>>>>> I think/feel like a proper EOF exception would be better, more correct. >>>>>>> >>>>>>> [ [ stream next. "..." true ] on: EOF do: [ false ] ] whileTrue. >>>>>> >>>>>> I agree, but the email thread Nicolas pointed to raises some >>>>>> performance questions about this approach. It should be >>>>>> straightforward to do a basic performance comparison which I'll get >>>>>> around to if other objections aren't raised. >>>>> >>>>> Reading in bigger blocks, using #readInto:startingAt:count: (which is basically Unix's (2) Read sys call), would solve performance problems, I think. >>>>> >>>>>>> Will we throw away #atEnd then ? Do we need it if we cannot use it ? >>>>>> >>>>>> Unix file i/o returns EOF if the end of file has been reach OR if an >>>>>> error occurs. You should still check #atEnd after reading past the >>>>>> end of the file to make sure no error occurred. Another part of the >>>>>> primitive change I'm proposing is to return additional information >>>>>> about what went wrong in the event of an error. >>>>> >>>>> I am sorry, but this kind of semantics (the OR) is way too complex at the general image level, it is too specific and based on certain underlying implementation details. >>>>> >>>>> Sven >>>>> >>>>>> We could modify the read primitive so that it fails if an error has >>>>>> occurred, and then #atEnd wouldn't be required. >>>>>> >>>>>> Cheers, >>>>>> Alistair >>>>>> >>>>>> >>>>>> >>>>>>>> On 4 Apr 2018, at 12:41, Alistair Grant <akgrant0710(a)gmail.com> wrote: >>>>>>>> >>>>>>>> Hi Nicolas, >>>>>>>> >>>>>>>> On 4 April 2018 at 12:36, Nicolas Cellier >>>>>>>> <nicolas.cellier.aka.nice(a)gmail.com> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> 2018-04-04 12:18 GMT+02:00 Alistair Grant <akgrant0710(a)gmail.com>: >>>>>>>>>> >>>>>>>>>> Hi Sven, >>>>>>>>>> >>>>>>>>>> On Wed, Apr 04, 2018 at 11:32:02AM +0200, Sven Van Caekenberghe wrote: >>>>>>>>>>> Somehow, somewhere there was a change to the implementation of the >>>>>>>>>>> primitive called by some streams' #atEnd. >>>>>>>>>> >>>>>>>>>> That's a proposed change by me, but it hasn't been integrated yet. So >>>>>>>>>> the discussion below should apply to the current stable vm (from August >>>>>>>>>> last year). >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> IIRC, someone said it is implemented as 'remaining size being zero' >>>>>>>>>>> and some virtual unix files like /dev/random are zero sized. >>>>>>>>>> >>>>>>>>>> Currently, for files other than sdio (stdout, stderr, stdin) it is >>>>>>>>>> effectively defined as: >>>>>>>>>> >>>>>>>>>> atEnd := stream position >= stream size >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> And, as you say, plenty of virtual unix files report size 0. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> Now, all kinds of changes are being done image size to work around this. >>>>>>>>>> >>>>>>>>>> I would phrase this slightly differently :-) >>>>>>>>>> >>>>>>>>>> Some code does the right thing, while other code doesn't. E.g.: >>>>>>>>>> >>>>>>>>>> MultiByteFileStream>>upToEnd is good, while >>>>>>>>>> FileStream>>contents is incorrect >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> I am a strong believer in simple, real (i.e. infinite) streams, but I >>>>>>>>>>> am not sure we are doing the right thing here. >>>>>>>>>>> >>>>>>>>>>> Point is, I am not sure #next returning nil is official and universal. >>>>>>>>>>> >>>>>>>>>>> Consider the comments: >>>>>>>>>>> >>>>>>>>>>> Stream>>#next >>>>>>>>>>> "Answer the next object accessible by the receiver." >>>>>>>>>>> >>>>>>>>>>> ReadStream>>#next >>>>>>>>>>> "Primitive. Answer the next object in the Stream represented by the >>>>>>>>>>> receiver. Fail if the collection of this stream is not an Array or a >>>>>>>>>>> String. >>>>>>>>>>> Fail if the stream is positioned at its end, or if the position is out >>>>>>>>>>> of >>>>>>>>>>> bounds in the collection. Optional. See Object documentation >>>>>>>>>>> whatIsAPrimitive." >>>>>>>>>>> >>>>>>>>>>> Note how there is no talk about returning nil ! >>>>>>>>>>> >>>>>>>>>>> I think we should discuss about this first. >>>>>>>>>>> >>>>>>>>>>> Was the low level change really correct and the right thing to do ? >>>>>>>>>> >>>>>>>>>> The primitive change proposed doesn't affect this discussion. It will >>>>>>>>>> mean that #atEnd returns false (correctly) sometimes, while currently it >>>>>>>>>> returns true (incorrectly). The end result is still incorrect, e.g. >>>>>>>>>> #contents returns an empty string for /proc/cpuinfo. >>>>>>>>>> >>>>>>>>>> You're correct about no mention of nil, but we have: >>>>>>>>>> >>>>>>>>>> FileStream>>next >>>>>>>>>> >>>>>>>>>> (position >= readLimit and: [self atEnd]) >>>>>>>>>> ifTrue: [^nil] >>>>>>>>>> ifFalse: [^collection at: (position := position + 1)] >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> which has been around for a long time (I suspect, before Pharo existed). >>>>>>>>>> >>>>>>>>>> Having said that, I think that raising an exception is a better >>>>>>>>>> solution, but it is a much, much bigger change than the one I proposed >>>>>>>>>> in https://github.com/pharo-project/pharo/pull/1180. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Cheers, >>>>>>>>>> Alistair >>>>>>>>>> >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> yes, if you are after universal behavior englobing Unix streams, the >>>>>>>>> Exception might be the best way. >>>>>>>>> Because on special stream you can't allways say in advance, you have to try. >>>>>>>>> That's the solution adopted by authors of Xtreams. >>>>>>>>> But there is a runtime penalty associated to it. >>>>>>>>> >>>>>>>>> The penalty once was so high that my proposal to generalize EndOfStream >>>>>>>>> usage was rejected a few years ago by AndreaRaab. >>>>>>>>> http://forum.world.st/EndOfStream-unused-td68806.html >>>>>>>> >>>>>>>> Thanks for this, I'll definitely take a look. >>>>>>>> >>>>>>>> Do you have a sense of how Denis' suggestion of using an EndOfStream >>>>>>>> object would compare? >>>>>>>> >>>>>>>> It would keep the same coding style, but avoid the problems with nil. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Alistair >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> I have regularly benched Xtreams, but stopped a few years ago. >>>>>>>>> Maybe i can excavate and pass on newer VM. >>>>>>>>> >>>>>>>>> In the mean time, i had experimented a programmable end of stream behavior >>>>>>>>> (via a block, or any other valuable) >>>>>>>>> http://www.squeaksource.com/XTream.htm >>>>>>>>> so as to reconcile performance and universality, but it was a source of >>>>>>>>> complexification at implementation side. >>>>>>>>> >>>>>>>>> Nicolas >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> Note also that a Guille introduced something new, #closed which is >>>>>>>>>>> related to the difference between having no more elements (maybe right now, >>>>>>>>>>> like an open network stream) and never ever being able to produce more data. >>>>>>>>>>> >>>>>>>>>>> Sven >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>> >>> >> >> > <stdio.cs>

April 10, 2018

Re: [Pharo-dev] help wanted: normalising LF on tonel for Pharo project

by Guillermo Polito

It could be a checkbox in the "create repository dialog". "Use lf as default line ending" (and set it to true by default (?)) On Tue, Apr 10, 2018 at 11:50 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > An argument can be made that Pharo would _always_ produce LF. > I don't think I've ever needed _code_ to be CRLF in a ~decade of using git > on Windows. It was always just an annoyance. > > Peter > > On Tue, Apr 10, 2018 at 11:44 PM, Esteban Lorenzano <estebanlm(a)gmail.com> > wrote: > >> hi, >> >> > On 10 Apr 2018, at 23:17, Esteban A. Maringolo <emaringolo(a)gmail.com> >> wrote: >> > >> > Not stricly related, or maybe yes, but years ago in InfOil we started >> > using Dolphin Smalltalk PAX format[1] for packages with Git, and we used >> > that setting to store code in the repo, we didn't have any issues >> > >> > The .gitattributes contained this: >> > *.img binary >> > *.chg binary >> > *.sml binary >> > OurImage.img merge=ours >> > OurImage.chg merge=ours >> > *.pax eol=lf >> > *.cls eol=lf >> > >> > .pax was the "package definition" and "method extensions" (methods not >> > belonging to the package) file. >> > .cls was the 1 file per class+class-side used by this scheme >> > >> > Even we did everything in Windows for some reason I don't remember (+5 >> > yrs ago) LF was better for Gitlab. What I also don't remember is if >> > during the checkout in the Gitlab CI some conversion was used or not. I >> > don't remember a lot of things, but I can ask them if you want. >> > >> > But I can confirm that this "trick" does work. >> > >> > Git for Windows even asks you if you want to automatically convert CRLF >> > to LF during checkin and back to CRLF on checkout. >> >> exactly what I want, because pharo/iceberg/tonel uses the system line >> ending to write the files :) >> thanks! >> >> Esteban >> >> ps: otherwise I will need to add some support in-image and I donât think >> is the best approach. >> pps: now it remains to see if libgit2 honours the .gitattributes config >> >> > >> > Regards, >> > >> > >> > On 10/04/2018 18:05, Esteban Lorenzano wrote: >> >> Hi, >> >> >> >> Iâve been wondering how to better fix the problem of having windows and >> >> linux/macOS people contributing and the fact that files are written in >> >> their native system format (crlf windows, lf for the rest of the >> world). >> >> >> >> I digged a bit and I found a couple a link that helped me (after trying >> >> to understand the >> >> doc): https://stackoverflow.com/questions/170961/whats-the-best- >> crlf-carriage-return-line-feed-handling-strategy-with-git >> >> >> >> and it seems adding a .gitattributes file with this content: >> >> >> >> # Auto detect text files and perform LF normalization >> >> *text=auto >> >> *.sttext merge=union eol=lf >> >> >> >> could fix the problem? >> >> can someone confirm this? >> >> >> >> (I confess this issue confuses me a lot :P) >> >> >> >> cheers! >> >> Esteban >> > >> > -- >> > Esteban A. Maringolo >> > >> >> >> > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

April 10, 2018

Re: [Pharo-dev] help wanted: normalising LF on tonel for Pharo project

by Esteban Lorenzano

> On 10 Apr 2018, at 23:47, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > How about > > git config --system core.autocrlf input > > I use this in my opensmalltalk-vm git repository. (I think I saw this option in the appveyor windows-vm build) that may work too. butâ¦ I would like to also have a way to configure automatically that (in any case, please use it while the solution arrives). Esteban > > 2018-04-10 23:44 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com <mailto:estebanlm@gmail.com>>: > hi, > > > On 10 Apr 2018, at 23:17, Esteban A. Maringolo <emaringolo(a)gmail.com <mailto:emaringolo@gmail.com>> wrote: > > > > Not stricly related, or maybe yes, but years ago in InfOil we started > > using Dolphin Smalltalk PAX format[1] for packages with Git, and we used > > that setting to store code in the repo, we didn't have any issues > > > > The .gitattributes contained this: > > *.img binary > > *.chg binary > > *.sml binary > > OurImage.img merge=ours > > OurImage.chg merge=ours > > *.pax eol=lf > > *.cls eol=lf > > > > .pax was the "package definition" and "method extensions" (methods not > > belonging to the package) file. > > .cls was the 1 file per class+class-side used by this scheme > > > > Even we did everything in Windows for some reason I don't remember (+5 > > yrs ago) LF was better for Gitlab. What I also don't remember is if > > during the checkout in the Gitlab CI some conversion was used or not. I > > don't remember a lot of things, but I can ask them if you want. > > > > But I can confirm that this "trick" does work. > > > > Git for Windows even asks you if you want to automatically convert CRLF > > to LF during checkin and back to CRLF on checkout. > > exactly what I want, because pharo/iceberg/tonel uses the system line ending to write the files :) > thanks! > > Esteban > > ps: otherwise I will need to add some support in-image and I donât think is the best approach. > pps: now it remains to see if libgit2 honours the .gitattributes config > > > > > Regards, > > > > > > On 10/04/2018 18:05, Esteban Lorenzano wrote: > >> Hi, > >> > >> Iâve been wondering how to better fix the problem of having windows and > >> linux/macOS people contributing and the fact that files are written in > >> their native system format (crlf windows, lf for the rest of the world). > >> > >> I digged a bit and I found a couple a link that helped me (after trying > >> to understand the > >> doc): https://stackoverflow.com/questions/170961/whats-the-best-crlf-carriage-ret… <https://stackoverflow.com/questions/170961/whats-the-best-crlf-carriage-ret…> > >> > >> and it seems adding a .gitattributes file with this content: > >> > >> # Auto detect text files and perform LF normalization > >> *text=auto > >> *.sttext merge=union eol=lf > >> > >> could fix the problem? > >> can someone confirm this? > >> > >> (I confess this issue confuses me a lot :P) > >> > >> cheers! > >> Esteban > > > > -- > > Esteban A. Maringolo > > > > >

April 10, 2018

Re: [Pharo-dev] help wanted: normalising LF on tonel for Pharo project

by Peter UhnÃ¡k

An argument can be made that Pharo would _always_ produce LF. I don't think I've ever needed _code_ to be CRLF in a ~decade of using git on Windows. It was always just an annoyance. Peter On Tue, Apr 10, 2018 at 11:44 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > hi, > > > On 10 Apr 2018, at 23:17, Esteban A. Maringolo <emaringolo(a)gmail.com> > wrote: > > > > Not stricly related, or maybe yes, but years ago in InfOil we started > > using Dolphin Smalltalk PAX format[1] for packages with Git, and we used > > that setting to store code in the repo, we didn't have any issues > > > > The .gitattributes contained this: > > *.img binary > > *.chg binary > > *.sml binary > > OurImage.img merge=ours > > OurImage.chg merge=ours > > *.pax eol=lf > > *.cls eol=lf > > > > .pax was the "package definition" and "method extensions" (methods not > > belonging to the package) file. > > .cls was the 1 file per class+class-side used by this scheme > > > > Even we did everything in Windows for some reason I don't remember (+5 > > yrs ago) LF was better for Gitlab. What I also don't remember is if > > during the checkout in the Gitlab CI some conversion was used or not. I > > don't remember a lot of things, but I can ask them if you want. > > > > But I can confirm that this "trick" does work. > > > > Git for Windows even asks you if you want to automatically convert CRLF > > to LF during checkin and back to CRLF on checkout. > > exactly what I want, because pharo/iceberg/tonel uses the system line > ending to write the files :) > thanks! > > Esteban > > ps: otherwise I will need to add some support in-image and I donât think > is the best approach. > pps: now it remains to see if libgit2 honours the .gitattributes config > > > > > Regards, > > > > > > On 10/04/2018 18:05, Esteban Lorenzano wrote: > >> Hi, > >> > >> Iâve been wondering how to better fix the problem of having windows and > >> linux/macOS people contributing and the fact that files are written in > >> their native system format (crlf windows, lf for the rest of the world). > >> > >> I digged a bit and I found a couple a link that helped me (after trying > >> to understand the > >> doc): https://stackoverflow.com/questions/170961/whats-the- > best-crlf-carriage-return-line-feed-handling-strategy-with-git > >> > >> and it seems adding a .gitattributes file with this content: > >> > >> # Auto detect text files and perform LF normalization > >> *text=auto > >> *.sttext merge=union eol=lf > >> > >> could fix the problem? > >> can someone confirm this? > >> > >> (I confess this issue confuses me a lot :P) > >> > >> cheers! > >> Esteban > > > > -- > > Esteban A. Maringolo > > > > >

April 10, 2018