April 2018 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Fwd: ByteArray>>at:put:

by Sven Van Caekenberghe

> On 26 Apr 2018, at 20:19, Stephan Eggermont <stephan(a)stack.nl> wrote: > > Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> >>> On 26 Apr 2018, at 15:21, Sean P. DeNigris >>> <sean(a)clipperadams.com> wrote: >>> >>> Relevant to Pharo? >>> >>> From http://forum.world.st/ByteArray-at-put-tp4955848.html : >> >> We don't (want to) mix binary and character collections or streams. Going >> from one to the other is called encoding and decoding, it has to be done >> while being conscious of which encoding you are using. Sending >> #asByteArray to a String or #asString to a ByteArray is dangerous, lazy >> and wrong (in most cases), especially in an international context. > > How do we capture these kinds of decisions? This is crucial information for > people trying to migrate to Pharo. I don't know, so much to do. But in this particular case, doing it the lazy way is really a bug. > Stephan

April 26, 2018

Re: [Pharo-dev] Fwd: ByteArray>>at:put:

by Stephan Eggermont

Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > >> On 26 Apr 2018, at 15:21, Sean P. DeNigris >> <sean(a)clipperadams.com> wrote: >> >> Relevant to Pharo? >> >> From http://forum.world.st/ByteArray-at-put-tp4955848.html : > > We don't (want to) mix binary and character collections or streams. Going > from one to the other is called encoding and decoding, it has to be done > while being conscious of which encoding you are using. Sending > #asByteArray to a String or #asString to a ByteArray is dangerous, lazy > and wrong (in most cases), especially in an international context. How do we capture these kinds of decisions? This is crucial information for people trying to migrate to Pharo. Stephan

April 26, 2018

Re: [Pharo-dev] Is Beacon still planned to be added to P7?

by Norbert Hartl

What do you mean âcopy into pharoâ?? We have a bootstrap process and Beacon has a baseline. What else needs to be decided? Norbert > Am 26.04.2018 um 16:50 schrieb Denis Kudriashov <dionisiydk(a)gmail.com>: > > 2018-04-26 16:27 GMT+02:00 Guillermo Polito <guillermopolito(a)gmail.com <mailto:guillermopolito@gmail.com>>: > > > On Mon, Apr 23, 2018 at 1:13 PM, Tudor Girba <tudor(a)tudorgirba.com <mailto:tudor@tudorgirba.com>> wrote: > I hope so. Beacon is ready to be integrated, but I do not know if there is enough bandwidth right now due to the Iceberg work. > > Well, if people issue a pull request I'll gladly review it. > > The question is how to manage it? Copy into Pharo or external project? > > > Guille > > > Doru > > > On Apr 23, 2018, at 1:08 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com <mailto:i.uhnak@gmail.com>> wrote: > > > > Hi, > > > > in several older discussions there was a mention of Beacon logger being added to Pharo 7 (by default)... is that still the plan? > > > > Thanks, > > Peter > > -- > www.tudorgirba.com <http://www.tudorgirba.com/> > www.feenk.com <http://www.feenk.com/> > > "It's not how it is, it is how we see it." > > > > > > -- > > Guille Polito > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - http://www.cnrs.fr <http://www.cnrs.fr/> > > Web: http://guillep.github.io <http://guillep.github.io/> > Phone: +33 06 52 70 66 13 >

April 26, 2018

Re: [Pharo-dev] Is Beacon still planned to be added to P7?

by Sven Van Caekenberghe

> On 26 Apr 2018, at 16:50, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > 2018-04-26 16:27 GMT+02:00 Guillermo Polito <guillermopolito(a)gmail.com>: > > > On Mon, Apr 23, 2018 at 1:13 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote: > I hope so. Beacon is ready to be integrated, but I do not know if there is enough bandwidth right now due to the Iceberg work. > > Well, if people issue a pull request I'll gladly review it. > > The question is how to manage it? Copy into Pharo or external project? Managing something as an external project only makes sense if it somehow runs on other platforms or older versions of Pharo. Even then, it is a lot of work, probably for little gain. > Guille > > > Doru > > > On Apr 23, 2018, at 1:08 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > > Hi, > > > > in several older discussions there was a mention of Beacon logger being added to Pharo 7 (by default)... is that still the plan? > > > > Thanks, > > Peter > > -- > www.tudorgirba.com > www.feenk.com > > "It's not how it is, it is how we see it." > > > > > > -- > > Guille Polito > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - http://www.cnrs.fr > > Web: http://guillep.github.io > Phone: +33 06 52 70 66 13 >

April 26, 2018

[Pharo 7.0-dev] Build #810: 21794 Correctly deprecate #displayProgressAt:from:to:during: and cleaâ¦

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #810 was: SUCCESS. The Pull Request #1265 was integrated: "21794 Correctly deprecate #displayProgressAt:from:to:during: and cleaâ¦" Pull request url: https://github.com/pharo-project/pharo/pull/1265 Issue Url: https://pharo.fogbugz.com/f/cases/21794 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

April 26, 2018

[Pharo 7.0-dev] Build #809: Move AuthorTest, SmalltalkImageTest, SystemDictionaryTest and other to package "System-Support-Tests"

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #809 was: SUCCESS. The Pull Request #1267 was integrated: "Move AuthorTest, SmalltalkImageTest, SystemDictionaryTest and other to package "System-Support-Tests"" Pull request url: https://github.com/pharo-project/pharo/pull/1267 Issue Url: https://pharo.fogbugz.com/f/cases/21797 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

April 26, 2018

Re: [Pharo-dev] Is Beacon still planned to be added to P7?

by Denis Kudriashov

2018-04-26 16:27 GMT+02:00 Guillermo Polito <guillermopolito(a)gmail.com>: > > > On Mon, Apr 23, 2018 at 1:13 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote: > >> I hope so. Beacon is ready to be integrated, but I do not know if there >> is enough bandwidth right now due to the Iceberg work. >> > > Well, if people issue a pull request I'll gladly review it. > The question is how to manage it? Copy into Pharo or external project? > > Guille > > >> >> Doru >> >> > On Apr 23, 2018, at 1:08 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: >> > >> > Hi, >> > >> > in several older discussions there was a mention of Beacon logger being >> added to Pharo 7 (by default)... is that still the plan? >> > >> > Thanks, >> > Peter >> >> -- >> www.tudorgirba.com >> www.feenk.com >> >> "It's not how it is, it is how we see it." >> >> >> > > > -- > > > > Guille Polito > > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > > CRIStAL - UMR 9189 > > French National Center for Scientific Research - *http://www.cnrs.fr > <http://www.cnrs.fr>* > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 >

April 26, 2018

Re: [Pharo-dev] Is Beacon still planned to be added to P7?

by Guillermo Polito

On Mon, Apr 23, 2018 at 1:13 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote: > I hope so. Beacon is ready to be integrated, but I do not know if there is > enough bandwidth right now due to the Iceberg work. > Well, if people issue a pull request I'll gladly review it. Guille > > Doru > > > On Apr 23, 2018, at 1:08 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > > Hi, > > > > in several older discussions there was a mention of Beacon logger being > added to Pharo 7 (by default)... is that still the plan? > > > > Thanks, > > Peter > > -- > www.tudorgirba.com > www.feenk.com > > "It's not how it is, it is how we see it." > > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

April 26, 2018

Re: [Pharo-dev] Fwd: ByteArray>>at:put:

by Sven Van Caekenberghe

> On 26 Apr 2018, at 15:21, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > Relevant to Pharo? > > From http://forum.world.st/ByteArray-at-put-tp4955848.html : We don't (want to) mix binary and character collections or streams. Going from one to the other is called encoding and decoding, it has to be done while being conscious of which encoding you are using. Sending #asByteArray to a String or #asString to a ByteArray is dangerous, lazy and wrong (in most cases), especially in an international context. > Bert Freudenberg wrote >> On 26 April 2018 at 11:28, marcel.taeumel < > >> Marcel.Taeumel@ > >> > wrote: >> >>> Hi, there. >>> >>> I cannot put a ByteString into a ByteArray via a WriteStream anymore: >>> >>> | s | >>> s := WriteStream on: ByteArray new. >>> s nextPutAll: 'hello'. >>> >>> You need to do: >>> >>> | s | >>> s := WriteStream on: ByteArray new. >>> s nextPutAll: 'hello' asByteArray. >>> >>> This breaks code. >>> >>> Best, >>> Marcel >>> >> >> âTechânically this is an expected error - you simply cannot put Characters >> (the elements of a String) into a ByteArray. However, for convenience we >> do >> support copying Strings into ByteArrays in various places, including >> WriteStream>>nextPutAll:. >> >> However, the test in WriteStream>>nextPutAll: is too strict. It needs to >> be >> "collection class isBits" instead of "collection isString". This makes the >> code actually match its comment: >> >> WriteStream>>nextPutAll: aCollection >> >> | newEnd | >> (collection class == aCollection class >> or: [ collection class isBits >> and: [ aCollection isString >> and: [ collection class format = aCollection class format ] ] ]) "Let >> Strings with the same field size as collection take the quick route too." >> ifFalse: [ ^ super nextPutAll: aCollection ]. >> >> newEnd := position + aCollection size. >> newEnd > writeLimit ifTrue: >> [self growTo: newEnd + 10]. >> >> collection replaceFrom: position+1 to: newEnd with: aCollection >> startingAt: 1. >> position := newEnd. >> ^aCollectionâ >> >> With that change your example works. I think this was the original intent >> of the code. >> >> Fixed in Collections-bf.787 >> >> - Bert - > > > > > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >

April 26, 2018

Fwd: ByteArray>>at:put:

by Sean P. DeNigris

Relevant to Pharo? >From http://forum.world.st/ByteArray-at-put-tp4955848.html : Bert Freudenberg wrote > On 26 April 2018 at 11:28, marcel.taeumel < > Marcel.Taeumel@ > > wrote: > >> Hi, there. >> >> I cannot put a ByteString into a ByteArray via a WriteStream anymore: >> >> | s | >> s := WriteStream on: ByteArray new. >> s nextPutAll: 'hello'. >> >> You need to do: >> >> | s | >> s := WriteStream on: ByteArray new. >> s nextPutAll: 'hello' asByteArray. >> >> This breaks code. >> >> Best, >> Marcel >> > > âTechânically this is an expected error - you simply cannot put Characters > (the elements of a String) into a ByteArray. However, for convenience we > do > support copying Strings into ByteArrays in various places, including > WriteStream>>nextPutAll:. > > However, the test in WriteStream>>nextPutAll: is too strict. It needs to > be > "collection class isBits" instead of "collection isString". This makes the > code actually match its comment: > > WriteStream>>nextPutAll: aCollection > > | newEnd | > (collection class == aCollection class > or: [ collection class isBits > and: [ aCollection isString > and: [ collection class format = aCollection class format ] ] ]) "Let > Strings with the same field size as collection take the quick route too." > ifFalse: [ ^ super nextPutAll: aCollection ]. > > newEnd := position + aCollection size. > newEnd > writeLimit ifTrue: > [self growTo: newEnd + 10]. > > collection replaceFrom: position+1 to: newEnd with: aCollection > startingAt: 1. > position := newEnd. > ^aCollectionâ > > With that change your example works. I think this was the original intent > of the code. > > Fixed in Collections-bf.787 > > - Bert - ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

April 26, 2018