February 2018 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Simplified AST "Suggestions" menu definitions

by Tudor Girba

+1 Doru > On Feb 25, 2018, at 9:25 PM, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: > > This is cool! > This is also why I started to do a pass (first reverse engineering how > ecompletion is working) > We should regularly improve the infrastructure of our tools to enable > the next generation. > I love that! > > marcus because indeed this code needs love. > > On Sun, Feb 25, 2018 at 7:23 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: >> Hi, >> >> I started to simplidy the âSmartSuggestionsâ code. What does it do? It adds the âsuggestionsâ menu to the editor context menu, >> this shows operations that make sense for the AST node a the cursor position. >> >> -> removed lots of state from SugsSuggestion (label, position, â¦). Instead uses methods. >> -> simplified how to define new suggestions. >> >> Here is a small example: a menu to browse the defintion of variables. First we need to make a suclass of >> SugsSuggestion. >> >> 1) add a subclass of SugsSuggestion >> >> SugsSuggestion subclass: #SugsBrowseVariableDefintion >> instanceVariableNames: '' >> classVariableNames: '' >> package: 'SmartSuggestions-Suggestion' >> >> >> 2) define on the class side a method that defines for which AST nodes you want the menu >> to be shown. Here is is all Variable Nodes: >> >> nodes >> ^{RBVariableNode} >> >> 3) On the instance side, we just need to define a label >> >> >> label >> ^ 'Browse Variable definition' translated >> >> 4) and we need to define #execute which just implements what is supposed to happen: >> >> execute >> | semanticVariable | >> semanticVariable := context selectedNode binding. >> semanticVariable isInstance ifTrue: [ ^semanticVariable slot definingClass browse ]. >> semanticVariable isTemp ifTrue: [ ^semanticVariable scope node method browse ]. >> semanticVariable isClassVariable ifTrue: [ ^semanticVariable scope getClass browse ]. >> semanticVariable isGlobal ifTrue: [ Smalltalk globals inspect ]. >> >> DONE. The simplified SmartSuggestions are in the latest Pharo7, so you can play with the code >> there, the SugsBrowseVariableDefintion is not (yet?) in Pharo7. (maybe someone wants to submit it?) >> >> >> Next steps: >> - get rid of the âContextâ and instead embed the AST in the editor. This will be nice for *many* >> other clients (AST Node navigation, code completion, syntax highlightingâ¦) >> >> - liberate the AST menu entries from the âsuggestionsâ submenu: they should just appear >> in the standard editor context menu. >> >> >> Marcus > -- www.tudorgirba.com www.feenk.com "Every thing has its own flow."

Feb. 25, 2018

Re: [Pharo-dev] Simplified AST "Suggestions" menu definitions

by Stephane Ducasse

This is cool! This is also why I started to do a pass (first reverse engineering how ecompletion is working) We should regularly improve the infrastructure of our tools to enable the next generation. I love that! marcus because indeed this code needs love. On Sun, Feb 25, 2018 at 7:23 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > Hi, > > I started to simplidy the âSmartSuggestionsâ code. What does it do? It adds the âsuggestionsâ menu to the editor context menu, > this shows operations that make sense for the AST node a the cursor position. > > -> removed lots of state from SugsSuggestion (label, position, â¦). Instead uses methods. > -> simplified how to define new suggestions. > > Here is a small example: a menu to browse the defintion of variables. First we need to make a suclass of > SugsSuggestion. > > 1) add a subclass of SugsSuggestion > > SugsSuggestion subclass: #SugsBrowseVariableDefintion > instanceVariableNames: '' > classVariableNames: '' > package: 'SmartSuggestions-Suggestion' > > > 2) define on the class side a method that defines for which AST nodes you want the menu > to be shown. Here is is all Variable Nodes: > > nodes > ^{RBVariableNode} > > 3) On the instance side, we just need to define a label > > > label > ^ 'Browse Variable definition' translated > > 4) and we need to define #execute which just implements what is supposed to happen: > > execute > | semanticVariable | > semanticVariable := context selectedNode binding. > semanticVariable isInstance ifTrue: [ ^semanticVariable slot definingClass browse ]. > semanticVariable isTemp ifTrue: [ ^semanticVariable scope node method browse ]. > semanticVariable isClassVariable ifTrue: [ ^semanticVariable scope getClass browse ]. > semanticVariable isGlobal ifTrue: [ Smalltalk globals inspect ]. > > DONE. The simplified SmartSuggestions are in the latest Pharo7, so you can play with the code > there, the SugsBrowseVariableDefintion is not (yet?) in Pharo7. (maybe someone wants to submit it?) > > > Next steps: > - get rid of the âContextâ and instead embed the AST in the editor. This will be nice for *many* > other clients (AST Node navigation, code completion, syntax highlightingâ¦) > > - liberate the AST menu entries from the âsuggestionsâ submenu: they should just appear > in the standard editor context menu. > > > Marcus

Feb. 25, 2018

Simplified AST "Suggestions" menu definitions

by Marcus Denker

Hi, I started to simplidy the âSmartSuggestionsâ code. What does it do? It adds the âsuggestionsâ menu to the editor context menu, this shows operations that make sense for the AST node a the cursor position. -> removed lots of state from SugsSuggestion (label, position, â¦). Instead uses methods. -> simplified how to define new suggestions. Here is a small example: a menu to browse the defintion of variables. First we need to make a suclass of SugsSuggestion. 1) add a subclass of SugsSuggestion SugsSuggestion subclass: #SugsBrowseVariableDefintion instanceVariableNames: '' classVariableNames: '' package: 'SmartSuggestions-Suggestion' 2) define on the class side a method that defines for which AST nodes you want the menu to be shown. Here is is all Variable Nodes: nodes ^{RBVariableNode} 3) On the instance side, we just need to define a label label ^ 'Browse Variable definition' translated 4) and we need to define #execute which just implements what is supposed to happen: execute | semanticVariable | semanticVariable := context selectedNode binding. semanticVariable isInstance ifTrue: [ ^semanticVariable slot definingClass browse ]. semanticVariable isTemp ifTrue: [ ^semanticVariable scope node method browse ]. semanticVariable isClassVariable ifTrue: [ ^semanticVariable scope getClass browse ]. semanticVariable isGlobal ifTrue: [ Smalltalk globals inspect ]. DONE. The simplified SmartSuggestions are in the latest Pharo7, so you can play with the code there, the SugsBrowseVariableDefintion is not (yet?) in Pharo7. (maybe someone wants to submit it?) Next steps: - get rid of the âContextâ and instead embed the AST in the editor. This will be nice for *many* other clients (AST Node navigation, code completion, syntax highlightingâ¦) - liberate the AST menu entries from the âsuggestionsâ submenu: they should just appear in the standard editor context menu. Marcus

Feb. 25, 2018

[Pharo 7.0-dev] Build #604: 21405 Add class comment to HowToContributeHelp

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #604 was: SUCCESS. The Pull Request #955 was integrated: "21405 Add class comment to HowToContributeHelp" Pull request url: https://github.com/pharo-project/pharo/pull/955 Issue Url: https://pharo.fogbugz.com/f/cases/21405 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 25, 2018

Re: [Pharo-dev] "curl https://get.pharo.org/64 | bash" does not work (on Mac)

by K K Subbu

On Sunday 25 February 2018 09:54 PM, Bernhard Pieber wrote: > Hi all, > > Here is the output: > % Total % Received % Xferd Average Speed Time Time Time Current > Dload Upload Total Spent Left Speed > 100 237 100 237 0 0 899 0 --:--:-- --:--:-- --:--:-- 901 > bash: line 1: syntax error near unexpected token `newline' > bash: line 1: `<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">' > > "curl https://get.pharo.org/64/ | bash" does work, though. It is just that in the documentation (https://get.pharo.org/64/) the link has no trailing slash. The URL https://get.pharo.org/64 will return a 301 (Moved permanently) redirect reply. Unlike wget, curl will follow the redirect only if -L option is given, so curl -L https://get.pharo.org/64 | bash will also work fine. The document needs to be updated to use -L option for curl. HTH .. Subbu

Feb. 25, 2018

"curl https://get.pharo.org/64 | bash" does not work (on Mac)

by Bernhard Pieber

Hi all, Here is the output: % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 237 100 237 0 0 899 0 --:--:-- --:--:-- --:--:-- 901 bash: line 1: syntax error near unexpected token `newline' bash: line 1: `<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">' "curl https://get.pharo.org/64/ | bash" does work, though. It is just that in the documentation (https://get.pharo.org/64/) the link has no trailing slash. I am on macOS Sierra 10.12.6. Bernhard

Feb. 25, 2018

[Pharo 7.0-dev] Build #603: 21403-Cleanup-SmartSuggestions-more

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #603 was: SUCCESS. The Pull Request #953 was integrated: "21403-Cleanup-SmartSuggestions-more" Pull request url: https://github.com/pharo-project/pharo/pull/953 Issue Url: https://pharo.fogbugz.com/f/cases/21403 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 25, 2018

Pull Request 20898-MultiByteFileStream-upToAll-does-not-work-correctly-with-UTF-8

by Bernhard Pieber

Hi all, Can somebody please help me get my bugfix from December integrated? For some reason CI fails and I have no idea how to debug that. :-( https://github.com/pharo-project/pharo/pull/632 Bernhard

Feb. 25, 2018

Monticello file out bug during bootstrap

by Alistair Grant

Hi Everyone, I'm working on integrating the file attribute primitives in to the main code during bootstrap. Class methods for FileAttributesPluginPrims are written out as: !FileAttributesPluginPrims classSide methodsFor: 'initialize' stamp: 'nil'! reset "Reload the masks" Default := nil.! ! As you can see, the class name is written with "classSide" instead of "class", resulting in the method quietly being ignored during file in. This comes about in: MCStWriter>>writeMethodPreamble: definition self chunkContents: [:str | stream bang. str nextPutAll: definition fullClassName; nextPutAll: ' methodsFor: '; nextPutAll: definition category asString printString; nextPutAll: ' stamp: '; nextPutAll: definition timeStamp asString printString ] which calls: MCMethodDefinition>>fullClassName "Using #class selector for classes for backwards compatibility" ^ self classIsMeta ifFalse: [self className] ifTrue: [ (self actualClass isNil or: [ self actualClass isTrait ]) ifFalse: [self className, ' class'] ifTrue: [self className, ' classSide']] Because FileAttributesPluginPrims doesn't exist in the image (the code is read in from the git repository and being written out to a .st file), #actualClass returns nil, resulting in "classSide" being used instead of "class". I've never seen "classSide" used in chunk format. Is there any time "classSide" is valid, and any suggestions on how this should be fixed? (My first thought is to just change MCStWriter>>writeMethodPreamble: to only write "class"). Thanks, Alistair

Feb. 25, 2018

Re: [Pharo-dev] control flow graph

by Stephane Ducasse

Yes I know but closing counting closing brackets are easier to do on the AST. Now I imagine that variable reachability is easier with control flow. A control flow is an dedicated abstraction over a program. Now people I met want to use it to support clone detection between different language because this is an abstraction. And I'm curious to see what we can do if we have this kind of trees. stef On Sat, Feb 24, 2018 at 11:51 AM, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > The control flow is just a visualisation, everything can be done without it, > it's just way more convenient to look at. > > On Feb 24, 2018 09:08, "Stephane Ducasse" <stepharo.self(a)gmail.com> wrote: >> >> Clement this analysis can be done without a control flow no? >> >> >> On Fri, Feb 23, 2018 at 11:47 AM, ClÃ©ment Bera <bera.clement(a)gmail.com> >> wrote: >> > I used that in the past on intermediate representations, I feel it is >> > very >> > useful to directly edit the code of methods with large control flows >> > since >> > when you have many closing brackets ] ] ] ] you never know where to >> > write >> > your code. Now it's specific to some use-cases such as algorithms where >> > you >> > write methods with large control flows, in most methods due to object >> > oriented programming convention the control flow is not that big. In >> > this >> > context other things could be possible (Smart suggestions to move code >> > out >> > of loops, etc.) >> > >> > >> > >> > >> > >> > >> > On Fri, Feb 23, 2018 at 11:37 AM, Stephane Ducasse >> > <stepharo.self(a)gmail.com> >> > wrote: >> >> >> >> Hi >> >> >> >> I'm experimenting in building a control flow graph of pharo methods >> >> and I would like to know if you have ideas about what we can do >> >> with them to support our development environment. >> >> >> >> Stef >> >> >> > >> > >> > >> > -- >> > ClÃ©ment BÃ©ra >> > Pharo consortium engineer >> > https://clementbera.wordpress.com/ >> > BÃ¢timent B 40, avenue Halley 59650 Villeneuve d'Ascq >> >

Feb. 25, 2018