February 2018 - Pharo-dev - lists.pharo.org

[Pharo 7.0-dev] Build #503: 21241-remove-comment-Extremely-Slow-from-methodSourceContainingIt

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #503 was: FAILURE. The Pull Request #801 was integrated: "21241-remove-comment-Extremely-Slow-from-methodSourceContainingIt" Pull request url: https://github.com/pharo-project/pharo/pull/801 Issue Url: https://pharo.fogbugz.com/f/cases/21241 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 6, 2018

[Pharo 7.0-dev] Build #502: 19702-glmSubscriptions-not-needed-in-SubscriptionRegistry

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #502 was: SUCCESS. The Pull Request #777 was integrated: "19702-glmSubscriptions-not-needed-in-SubscriptionRegistry" Pull request url: https://github.com/pharo-project/pharo/pull/777 Issue Url: https://pharo.fogbugz.com/f/cases/19702 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 6, 2018

Re: [Pharo-dev] Reviewing Changes ?

by Esteban Lorenzano

there will be a techtalk next thursday :) Esteban ps: btw, in general is no âpainâ, is people adapting and solving problems. I would like to have also a way to measure when people is happy, but thing isâ¦ lists works so people with problems can post them :) > On 6 Feb 2018, at 13:42, Tim Mackinnon <tim(a)testit.works> wrote: > > As an idea - might someone do a tech talk on this and take us through some scenarios? Every time I think about how to help - I read the pain here and shy away from it (yes the mental barrier is mine, and also alack of time to really get to grips with it) - but I was thinking that it someone walked through it - it might make it all much less scary. > > Tim > > >> On 5 Feb 2018, at 15:57, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> Ah, Esteban's PR review tool is exactly what I was looking for. It works ! >> >> Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost. >> >> Docs needed >> >> (1) contribute to Pharo (we have that) >> (2) keep in sync once you have done (1) (we have that, but not about image side) >> (3) review pull requests of others (new, this email to start) >> >> Anyway, thanks for the answers. >> >>> On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: >>> >>> 2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >>>> Hi, >>>> >>>> With pull requests, it is relatively easy to see what changed in GitHub. >>>> >>>> Eg. Marcus' latest fix: >>>> >>>> https://github.com/pharo-project/pharo/pull/797 >>>> >>>> shows 6 files/classes changed, reasonably readable diff. >>>> >>>> How does one review such a PR in an image, to test it out ? >>> >>> The easiest way is to download an image bootstrapped from that PR. >>> Next to the commits you have a validation status (red cross here), >>> click on it, go to "Artifacts" and then download the image >>> (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip) >>> >>> Esteban did a Pull request review tool: >>> >>> - register your local Pharo repository copy to Iceberg >>> - in the "Remotes" open context menu on the pharo-project remote (not >>> origin, which is probably our fork) >>> - GitHub - Review pull requests... >>> - open context menu on an issue and select "Review pull request..." >>> - select the newest commit and check changes >>> - to test it locally, do "Merge into image", answer "Yes" >>> >>>> Has someone written a guide on how to do this best/most-easily ? >>> >>> No idea, but Esteban presented that several times on ESUG and other places. >>> >>>> How is/can this be related to contributing ? >>> >>> If you want to use the PR review tool, you should have own fork and >>> local repository - the same for contributing >>> >>> If you then want to propose a modification fo the PR, you already have >>> a branch from the PR merging. >>> - do your change and synchronize the repository so your branch will be >>> present on your fork. >>> - then go to "Remotes" tab, open context menu on "MarcusDenker" remote >>> (it will be created during merging of the PR into your image) and then >>> do pull request. >>> - in Head select your fork and your issue branch name >>> - in Base select Marcus/Denker/pharo and the issue branch name >>> - click on Create Pull request >>> >>> It will create a PR on the repository that Marcus has. Like >>> https://github.com/MarcusDenker/pharo/pull/1 >>> When he will merge it, his PR to on Pharo repository will be updated >>> automatically. >>> >>> Cheers, >>> -- Pavel >>> >>>> >>>> Sven >> >> > >

Feb. 6, 2018

Re: [Pharo-dev] Reviewing Changes ?

by Tim Mackinnon

As an idea - might someone do a tech talk on this and take us through some scenarios? Every time I think about how to help - I read the pain here and shy away from it (yes the mental barrier is mine, and also alack of time to really get to grips with it) - but I was thinking that it someone walked through it - it might make it all much less scary. Tim > On 5 Feb 2018, at 15:57, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > Ah, Esteban's PR review tool is exactly what I was looking for. It works ! > > Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost. > > Docs needed > > (1) contribute to Pharo (we have that) > (2) keep in sync once you have done (1) (we have that, but not about image side) > (3) review pull requests of others (new, this email to start) > > Anyway, thanks for the answers. > >> On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: >> >> 2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >>> Hi, >>> >>> With pull requests, it is relatively easy to see what changed in GitHub. >>> >>> Eg. Marcus' latest fix: >>> >>> https://github.com/pharo-project/pharo/pull/797 >>> >>> shows 6 files/classes changed, reasonably readable diff. >>> >>> How does one review such a PR in an image, to test it out ? >> >> The easiest way is to download an image bootstrapped from that PR. >> Next to the commits you have a validation status (red cross here), >> click on it, go to "Artifacts" and then download the image >> (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip) >> >> Esteban did a Pull request review tool: >> >> - register your local Pharo repository copy to Iceberg >> - in the "Remotes" open context menu on the pharo-project remote (not >> origin, which is probably our fork) >> - GitHub - Review pull requests... >> - open context menu on an issue and select "Review pull request..." >> - select the newest commit and check changes >> - to test it locally, do "Merge into image", answer "Yes" >> >>> Has someone written a guide on how to do this best/most-easily ? >> >> No idea, but Esteban presented that several times on ESUG and other places. >> >>> How is/can this be related to contributing ? >> >> If you want to use the PR review tool, you should have own fork and >> local repository - the same for contributing >> >> If you then want to propose a modification fo the PR, you already have >> a branch from the PR merging. >> - do your change and synchronize the repository so your branch will be >> present on your fork. >> - then go to "Remotes" tab, open context menu on "MarcusDenker" remote >> (it will be created during merging of the PR into your image) and then >> do pull request. >> - in Head select your fork and your issue branch name >> - in Base select Marcus/Denker/pharo and the issue branch name >> - click on Create Pull request >> >> It will create a PR on the repository that Marcus has. Like >> https://github.com/MarcusDenker/pharo/pull/1 >> When he will merge it, his PR to on Pharo repository will be updated >> automatically. >> >> Cheers, >> -- Pavel >> >>> >>> Sven > >

Feb. 6, 2018

[Pharo 7.0-dev] Build #501: 21240-update-iceberg-to-067

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #501 was: SUCCESS. The Pull Request #800 was integrated: "21240-update-iceberg-to-067" Pull request url: https://github.com/pharo-project/pharo/pull/800 Issue Url: https://pharo.fogbugz.com/f/cases/21240 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 6, 2018

Re: [Pharo-dev] another file reference question

by Alistair Grant

Hi Stef, Assuming I understand what you're trying to do: This is broken out to hopefully make it clear what the steps are: | src srcPrefix dstPrefix dst | src := 'a/b/c/d.pi' asFileReference. srcPrefix := 'a' asFileReference. dstPrefix := 'result' asFileReference. dst := dstPrefix resolve: (src relativeTo: srcPrefix). dst At that point presumably you want: src copyTo: dst. Cheers, Alistair On 6 February 2018 at 21:50, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: > Thanks alistair > > What I want to know is a different of paths between two paths so that > after I can reproduce the structure under another folder. > Example > > a/b/c/d.pi > I should ''copy'' it into result folder and I should get > > result/b/c/d.pi > > now I compute the path > > What is the path of a/b/c/d.pi in a => b/c/d.pi and I should then > 'copy' to result/b/c/d.pi > > On Fri, Feb 2, 2018 at 11:26 PM, Alistair Grant <akgrant0710(a)gmail.com> wrote: >> Hi Stef, >> >> On 2 February 2018 at 20:58, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: >>> Then I do not get why / is expecting a string and cannot accept a path. >>> >>> Then I do not get why we have paths. >>> Stef >> >> Paths are intended to be internal, and not something you ever deal >> with directly. >> >> I'm not sure I understand what you want to do, but maybe try replacing >> #/ with #resolve:, e.g.: >> >> '/home' asFileReference resolve: 'user' asFileReference >> " File @ /home/user" >> >> >> or: >> >> '/home' asFileReference resolve: 'user' asFileReference path >> " File @ /home/user" >> >> >> Cheers, >> Alistair >> >> >>> On Fri, Feb 2, 2018 at 8:22 PM, Stephane Ducasse >>> <stepharo.self(a)gmail.com> wrote: >>>> HI >>>> >>>> I have the following scenario: >>>> >>>> '/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result' >>>> asFileReference / >>>> 'book.pillar' >>>> >>>>>>> >>>> "File @ /Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result/book.pillar" >>>> >>>> ok it works. >>>> >>>> I want to update the contents of a target folder only if a file is >>>> missing or too old compared to a source. >>>> >>>> The idea is that I have a target folder and I need to know if a file >>>> located in the source tree should be copied under the target. >>>> So I compute the difference from the root of the source to the file >>>> and I want to apply this path to the target to check some file >>>> properties. >>>> >>>> now I do not understand how I can get the following working: >>>> >>>> '/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result' >>>> asFileReference >>>> / >>>> >>>> ('/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/book.pillar' >>>> asFileReference path) >>>> relativeTo: ('/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo' >>>> asFileReference path) >>>> >>>> >>>> Stef >>> >> >

Feb. 6, 2018

[Pharo 7.0-dev] Build #500: 21236-Sometimes-the-debugger-opens-with-the-context-one-off

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #500 was: SUCCESS. The Pull Request #797 was integrated: "21236-Sometimes-the-debugger-opens-with-the-context-one-off" Pull request url: https://github.com/pharo-project/pharo/pull/797 Issue Url: https://pharo.fogbugz.com/f/cases/21236 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Feb. 6, 2018

Re: [Pharo-dev] Weird ZnClient benchmarking result

by Stephane Ducasse

Tx this is cool! On Sat, Feb 3, 2018 at 12:17 AM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > https://pharo.fogbugz.com/f/cases/21232/BenchmarkResult-printFrequencyOn-ca… > > https://github.com/pharo-project/pharo/pull/794 > >> On 12 Dec 2017, at 07:22, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: >> >> sven did you submit a fix to get a clearer printout? >> >> Stef >> >> >> On Sun, Dec 10, 2017 at 7:14 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>> @ Henrik >>> >>> Arg, arg, arg, yes of course. >>> I actually did think about that, but still did not look carefully enough !! >>> Really stupid of me. >>> >>> It is even worse because I wrote that code ... >>> >>> Now, the #printOn: of BenchmarkResult is much clearer, less confusing: >>> >>> ZnClient new in: [ :client | >>> [ client get: 'http://localhost:8080' ] benchFor: 5 seconds ]. >>> >>> a BenchmarkResult(14,732 iterations in 5 seconds. 2,946 per second) >>> >>> vs >>> >>> ZnClient new in: [ :client | >>> client loggingOff. >>> [ client get: 'http://localhost:8080' ] benchFor: 5 seconds ]. >>> >>> a BenchmarkResult(42 iterations in 5 seconds 88 milliseconds. 8.255 per second) >>> >>> Still the same issue with $, and $. in frequency, but the iteration count is crystal clear. >>> >>> The reason #bench works like that is backwards compatibility at the time we introduced that. >>> >>> @ Ben >>> >>> Yes, I should have looked at the other side as well, to confirm things actually happened as I imagined them (the did not). >>> >>> Thx and sorry for the noise. >>> >>> Sven >>> >>>> On 10 Dec 2017, at 18:00, Henrik-Nergaard <draagren(a)outlook.com> wrote: >>>> >>>> Hi Sven, >>>> >>>> What you are seeing is most likely a $, vs $. issue. >>>> See BenchmarkResult >>#printFrequenceOn: it uses both decimal and thousand >>>> separators. >>>> >>>> If i run this code: >>>> ----------------------------------------- >>>> | counter | >>>> counter := >>>> ZnClient new in: [ :client | >>>> client loggingOff. >>>> [ client get: 'http://localhost:8080'. counter ] bench >>>> ]. >>>> counter. >>>> ----------------------------------------- >>>> >>>> Then i get 9035 ('1,773 per second') when no inspector is open, and only 22 >>>> ('5.995 per second') when inspecting the logs. >>>> >>>> Best regards, >>>> Henrik >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >>>> >>> >>> >> > >

Feb. 6, 2018

Re: [Pharo-dev] another file reference question

by Stephane Ducasse

Thanks alistair What I want to know is a different of paths between two paths so that after I can reproduce the structure under another folder. Example a/b/c/d.pi I should ''copy'' it into result folder and I should get result/b/c/d.pi now I compute the path What is the path of a/b/c/d.pi in a => b/c/d.pi and I should then 'copy' to result/b/c/d.pi On Fri, Feb 2, 2018 at 11:26 PM, Alistair Grant <akgrant0710(a)gmail.com> wrote: > Hi Stef, > > On 2 February 2018 at 20:58, Stephane Ducasse <stepharo.self(a)gmail.com> wrote: >> Then I do not get why / is expecting a string and cannot accept a path. >> >> Then I do not get why we have paths. >> Stef > > Paths are intended to be internal, and not something you ever deal > with directly. > > I'm not sure I understand what you want to do, but maybe try replacing > #/ with #resolve:, e.g.: > > '/home' asFileReference resolve: 'user' asFileReference > " File @ /home/user" > > > or: > > '/home' asFileReference resolve: 'user' asFileReference path > " File @ /home/user" > > > Cheers, > Alistair > > >> On Fri, Feb 2, 2018 at 8:22 PM, Stephane Ducasse >> <stepharo.self(a)gmail.com> wrote: >>> HI >>> >>> I have the following scenario: >>> >>> '/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result' >>> asFileReference / >>> 'book.pillar' >>> >>>>>> >>> "File @ /Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result/book.pillar" >>> >>> ok it works. >>> >>> I want to update the contents of a target folder only if a file is >>> missing or too old compared to a source. >>> >>> The idea is that I have a target folder and I need to know if a file >>> located in the source tree should be copied under the target. >>> So I compute the difference from the root of the source to the file >>> and I want to apply this path to the target to check some file >>> properties. >>> >>> now I do not understand how I can get the following working: >>> >>> '/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result' >>> asFileReference >>> / >>> >>> ('/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/book.pillar' >>> asFileReference path) >>> relativeTo: ('/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo' >>> asFileReference path) >>> >>> >>> Stef >> >

Feb. 6, 2018

Re: [Pharo-dev] another file reference question

by Stephane Ducasse

HI I have the following scenario: '/PharoBooks/Booklet-AMiniSchemeInPharo/_result' asFileReference / 'book.pillar' >>> "File @ /PharoBooks/Booklet-AMiniSchemeInPharo/_result/book.pillar" ok it works. I want to update the contents of a target folder only if a file is missing or too old compared to a source. The idea is that I have a target folder and I need to know if a file located in the source tree should be copied under the target. So I compute the difference from the root of the source to the file and I want to apply this path to the target to check some file properties. now I do not understand how I can get the following working: '/PharoBooks/Booklet-AMiniSchemeInPharo/_result' asFileReference / ('/PharoBooks/Booklet-AMiniSchemeInPharo/book.pillar' asFileReference path) relativeTo: ('/PharoBooks/Booklet-AMiniSchemeInPharo' asFileReference path) You see relativeTo: should tells me the diff in terms of path between two paths. Stef On Fri, Feb 2, 2018 at 10:27 PM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > Hi > > Can you provide more simple example with shorter paths? I am lost in these > long strings :). > > 2018-02-02 20:22 GMT+01:00 Stephane Ducasse <stepharo.self(a)gmail.com>: >> >> HI >> >> I have the following scenario: >> >> >> '/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result' >> asFileReference / >> 'book.pillar' >> >> >>> >> "File @ >> /Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result/book.pillar" >> >> ok it works. >> >> I want to update the contents of a target folder only if a file is >> missing or too old compared to a source. >> >> The idea is that I have a target folder and I need to know if a file >> located in the source tree should be copied under the target. >> So I compute the difference from the root of the source to the file >> and I want to apply this path to the target to check some file >> properties. >> >> now I do not understand how I can get the following working: >> >> >> '/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/_result' >> asFileReference >> / >> >> >> ('/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo/book.pillar' >> asFileReference path) >> relativeTo: >> ('/Users/ducasse/Workspace/FirstCircle/MyBooks/Bk-Writing/PharoBooks/Booklet-AMiniSchemeInPharo' >> asFileReference path) >> >> >> Stef >> >

Feb. 6, 2018