November 2018 - Pharo-dev - lists.pharo.org

[Pharo 7.0-dev] Build #1376: 22656-Improve-ImageReadWriter-comments

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1376 was: SUCCESS. The Pull Request #1970 was integrated: "22656-Improve-ImageReadWriter-comments" Pull request url: https://github.com/pharo-project/pharo/pull/1970 Issue Url: https://pharo.fogbugz.com/f/cases/22656 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Nov. 11, 2018

Re: [Pharo-dev] Streams and FileDialog in Pharo 6 and 7

by Denis Kudriashov

Ð¿Ð½, 29 Ð¾ÐºÑ. 2018 Ð³. Ð² 10:07, Guillermo Polito <guillermopolito(a)gmail.com>: > Well, there are still variants > - chooseFile* > - fileOpen* > - fileSave* > - chooseFileName* > - chooseFullFileName* > > I prefered rather to be explicit and to avoid confusion with the old API > (which I deprecated, not removed!) > Ok. For current situation it is probably the right thing to do. And monstrous names are easy to rename/deprecate in future. But I don't think that in clean system (without old API) using just a File in such names needs special explanation. Because we postulate that only file references are exposed to users. User chooses a file and Pharo gives him a reference to this file. > > On Sat, Oct 27, 2018 at 2:42 PM Denis Kudriashov <dionisiydk(a)gmail.com> > wrote: > >> What about different names? >> >> UIManager default >> chooseFileIn: aFileReference >> withExtensions: #() >> title: 'title' >> >> UIManager default >> chooseFileForSaveIn: aFileReference >> withExtensions: #() >> title: 'title' >> >> We can just expect file references because it is what is exposed to users >> in pharo file system. Not neccessery to put it in method name. >> >> Ð¿Ñ, 26 Ð¾ÐºÑ. 2018 Ð³., 16:32 Guillermo Polito <guillermopolito(a)gmail.com>: >> >>> Hi all, >>> >>> I've proposed a PR with some cleanups in this respect >>> >>> https://github.com/pharo-project/pharo/pull/1941 >>> >>> This is the proposed replacement API that returns file references >>> instead of streams or file names. >>> >>> "Get existing file reference" >>> UIManager default >>> chooseExistingFileReference: 'title' >>> extensions: nil >>> path: FileSystem workingDirectory. >>> >>> "Get existing file reference filtering by extensions" >>> UIManager default >>> chooseExistingFileReference: 'title' >>> extensions: #('log') >>> path: FileSystem workingDirectory. >>> >>> "Get existing file reference to file" >>> UIManager default >>> chooseExistingFileReference: 'title' >>> extensions: nil >>> path: FileSystem workingDirectory / 'PharoDebug.log'. >>> >>> "Get file reference for save (not necessarily existing)" >>> UIManager default >>> chooseForSaveFileReference: 'title' >>> extensions: #('log') >>> path: 'PharoDebuasdg.log'. >>> >>> On Fri, Oct 26, 2018 at 3:11 PM Guillermo Polito < >>> guillermopolito(a)gmail.com> wrote: >>> >>>> Ok, so can we agree on deprecating the non compatible methods and >>>> redirect the user to the new ones? >>>> >>>> To me, the problem with returning a stream is that from a user >>>> perspective you don't know: >>>> - is the file encoded or binary >>>> - if it is encoded, in which encoding? >>>> - if i receive an open file stream, and I want to delete that file I >>>> have to close it, retrieve the file, delete it? >>>> - IMHO, what is the worst: whose responsibility is it to close the >>>> file? >>>> >>>> On Thu, Sep 6, 2018 at 10:43 PM Peter Uhnak <i.uhnak(a)gmail.com> wrote: >>>> >>>>> > It should return a FileReference, not an open stream. I believe >>>>> there are methods that do that. >>>>> >>>>> There are different APIs for that. >>>>> >>>>> fileOpen*, as the name implies, _opens the file_ and returns the >>>>> stream. (I think this should be the case for fileSave*) >>>>> >>>>> If you want file reference, then you can use e.g. >>>>> >>>>> UIManager default chooseFileMatching: #() label: nil >>>>> >>>>> or `chooseFileMatching:label:`, >>>>> `chooseFileName:extensions:path:preview:`, >>>>> `chooseFullFileName:extensions:path:preview:`, >>>>> `chooseFullFileNameMatching:label:`. >>>>> Also some methods for selecting directories >>>>> (`chooseDirectory:path:`, chooseDirectory:from:`, ...) >>>>> >>>>> iirc some of them actually return String (file path) instead of >>>>> FileReference. ( >>>>> https://gist.github.com/peteruhnak/8ac6667b8eb11daee71517d0172b7355#file-ui… >>>>> ) >>>>> >>>>> So it can be confusing, but the API is already available. >>>>> >>>>> Also iirc UIManager should be preferred over UITheme builder. >>>>> >>>>> Peter >>>>> >>>>> On Thu, Sep 6, 2018 at 9:57 PM Sven Van Caekenberghe <sven(a)stfx.eu> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> > On 6 Sep 2018, at 21:37, Torsten Bergmann <astares(a)gmx.de> wrote: >>>>>> > >>>>>> > Hi, >>>>>> > >>>>>> > A question to those who worked on the new streams for Pharo 7: >>>>>> > >>>>>> > >>>>>> > In PHARO 6 I used the following expression to open a file dialog >>>>>> and let the user choose >>>>>> > a binary file: >>>>>> > >>>>>> > s := UITheme builder fileOpen: 'Choose a file' extensions: >>>>>> #('exe'). >>>>>> > >>>>>> > This returned >>>>>> > - either nil (when file dialog was canceled) >>>>>> > - a "MultiByteFileStream" instance when a file was selected >>>>>> > >>>>>> > The MultiByteFileStream instance already had the name of the file >>>>>> (= full path) and I was >>>>>> > able to query it for further use: >>>>>> > >>>>>> > s := UITheme builder fileOpen: 'Choose a file' extensions: #('exe'). >>>>>> > s name inspect >>>>>> > >>>>>> > (for instance to display which file is processed in a window by >>>>>> showing the full path) >>>>>> > >>>>>> > >>>>>> > >>>>>> > Now in PHARO 7 same expression returns an instance of >>>>>> ZnCharacterReadStream (as MultiByteFileStream >>>>>> > is deprecated): >>>>>> > >>>>>> > s := UITheme builder fileOpen: 'Choose a file' extensions: #('exe'). >>>>>> > >>>>>> > and ZnCharacterReadStream does not understand #name - and in fact >>>>>> the info about the name is >>>>>> > totally lost/not available. To me this looks missing/broken. >>>>>> > >>>>>> > So what is the recommended way in Pharo 7 to open a file dialog, >>>>>> let the use choose a file >>>>>> > and get a file stream but also the name? IMHO this is either broken >>>>>> or missing... >>>>>> > >>>>>> > Thanks >>>>>> > T. >>>>>> >>>>>> It should return a FileReference, not an open stream. I believe there >>>>>> are methods that do that. >>>>>> >>>>>> But that is an incompatible API change (same selector, different >>>>>> return type). So hard to decide. >>>>>> >>>>>> >>>>>> >>>> >>>> -- >>>> >>>> >>>> >>>> Guille Polito >>>> >>>> Research Engineer >>>> >>>> Centre de Recherche en Informatique, Signal et Automatique de Lille >>>> >>>> CRIStAL - UMR 9189 >>>> >>>> French National Center for Scientific Research - *http://www.cnrs.fr >>>> <http://www.cnrs.fr>* >>>> >>>> >>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>> >>>> *Phone: *+33 06 52 70 66 13 >>>> >>> >>> >>> -- >>> >>> >>> >>> Guille Polito >>> >>> Research Engineer >>> >>> Centre de Recherche en Informatique, Signal et Automatique de Lille >>> >>> CRIStAL - UMR 9189 >>> >>> French National Center for Scientific Research - *http://www.cnrs.fr >>> <http://www.cnrs.fr>* >>> >>> >>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>> >>> *Phone: *+33 06 52 70 66 13 >>> >> > > -- > > > > Guille Polito > > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > > CRIStAL - UMR 9189 > > French National Center for Scientific Research - *http://www.cnrs.fr > <http://www.cnrs.fr>* > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 >

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Hilaire

I am quite happy with the new FileReference API. Le 11/11/2018 Ã 13:51, Sven Van Caekenberghe a Ã©critÂ : > API changes are always annoying, but splitting reading and writing as well as binary and character streams is a clear improvement overall. > -- Dr. Geo http://drgeo.eu

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Sven Van Caekenberghe

> On 11 Nov 2018, at 10:29, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > File is a low level API that is only used in limited circumstances, > e.g. bootstrapping when FileSystem isn't yet available. Another reason not to use File is because it is slower as it is unbuffered. For the following file $ file test.png test.png: PNG image data, 950 x 936, 8-bit/color RGBA, non-interlaced $ ls -la test.png -rw-r--r--@ 1 sven staff 241773 Nov 11 13:39 test.png I get [ ImageReadWriter formFromFileNamed: 'test.png' ] bench. "'8.725 per second'" [ ImageReadWriter formFromStream: 'test.png' asFileReference binaryReadStream ] bench. "'8.914 per second'" [ ImageReadWriter formFromStream: (File named: 'test.png') readStream ] bench. "'6.023 per second'" By preventing the auto detection of the type and the subclass lookup, we can improve a little bit more. [ PNGReadWriter formFromStream: 'test.png' asFileReference binaryReadStream ] bench. "'9.113 per second'" Sven

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Sven Van Caekenberghe

> On 11 Nov 2018, at 12:24, Hilaire <hilaire(a)drgeo.eu> wrote: > > Confusion from my part (it was 6 months ago), I have to use > #binaryReadStream to load PNG preview, and utf-8 based file (I was not > doing this distinction previously). > > I changed the code in P7 in several part as it broke and it was confusing. API changes are always annoying, but splitting reading and writing as well as binary and character streams is a clear improvement overall.

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Hilaire

I filled a bug ticket about the change: https://bugs.launchpad.net/drgeo/+bug/1780820 -- Dr. Geo http://drgeo.eu

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Hilaire

Confusion from my part (it was 6 months ago), I have to use #binaryReadStream to load PNG preview, and utf-8 based file (I was not doing this distinction previously). I changed the code in P7 in several part as it broke and it was confusing. https://bazaar.launchpad.net/~drgeo-developers/drgeo/trunk/revision/608#src… Le 11/11/2018 Ã 11:41, Sven Van Caekenberghe a Ã©critÂ : > So how do you load you PNG's then in P7 ? -- Dr. Geo http://drgeo.eu

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Sven Van Caekenberghe

So how do you load you PNG's then in P7 ? > On 11 Nov 2018, at 11:25, Hilaire <hilaire(a)drgeo.eu> wrote: > > In P7, I have to change the code to load PNG image, and I end up not > using binary alternative... > > Le 11/11/2018 Ã 11:18, Sven Van Caekenberghe a Ã©crit : >> I don't understand what you are saying. > > -- > Dr. Geo > http://drgeo.eu > > >

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Hilaire

In P7, I have to change the code to load PNG image, and I end up not using binary alternative... Le 11/11/2018 Ã 11:18, Sven Van Caekenberghe a Ã©critÂ : > I don't understand what you are saying. -- Dr. Geo http://drgeo.eu

Nov. 11, 2018

Re: [Pharo-dev] How do I create a binary stream

by Sven Van Caekenberghe

> On 11 Nov 2018, at 10:59, Hilaire <hilaire(a)drgeo.eu> wrote: > > I met that situation too with P7. It occurred to me that the precise > need of #binaryReadStream message vanished. I don't understand what you are saying. Like Alistair says, FileReference is the public interface. The messages to open streams are #readStream #writeStream for text streams (utf8 character encoded) and #binaryReadStream #binaryWriteStream for raw unencoded binary streams. In most cases, it is better to use the #xDo: variant. It is no longer possible to switch streams using #binary. > Hilaire > > Le 11/11/2018 Ã 10:03, Stephane Ducasse a Ã©crit : >> Hi >> >> I'm checking some of the mooc code in Pharo 70. >> >> The Pharo 50/60 version is >> >> PNGReadWriter createAFormFrom: 'Sprites.png' asFileReference >> binaryReadStream upToEnd >> >> I came up with >> >> PNGReadWriter formFromStream: (File named: 'Sprites.png') readStream >> >> And we can also have >> >> PNGReadWriter formFromStream: 'Sprites.png' asFileReference binaryReadStream >> >> I will add this in the comment of the formFromStream: method. >> >> Stef >> > -- > Dr. Geo > http://drgeo.eu > > >

Nov. 11, 2018