September 2017 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] review pull request changes view

by Cyril Ferlicot

On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > Oh no! > > Now iceberg shows an empty list. Where is the pharo repository gone ? > It took me a week to be at this point :( > > I reenabled the setting "Include system repositories by default", but > still, the window is empty: > > [image: Inline-Bild 1] > > > How can I get back the system repository ? > I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Nicolai Hess

2017-09-01 16:48 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > > > 2017-09-01 16:29 GMT+02:00 Cyril Ferlicot <cyril.ferlicot(a)gmail.com>: > >> On Fri, Sep 1, 2017 at 4:26 PM, Nicolai Hess <nicolaihess(a)gmail.com> >> wrote: >> > >> > >> > >> > update what? pharo ? >> > >> > >> >> You can update Iceberg by executing: >> >> #('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' >> 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' >> 'BaselineOfLibGit') >> do: [ :each | each asPackage removeFromSystem ]. >> >> Metacello new >> baseline: 'Iceberg'; >> repository: 'github://pharo-vcs/iceberg:dev-0.5'; >> load. >> >> >> > Ah, thanks. I will try it out and report back if the crashes still occur. > > Oh no! Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :( I reenabled the setting "Include system repositories by default", but still, the window is empty: [image: Inline-Bild 1] How can I get back the system repository ? > >> -- >> Cyril Ferlicot >> https://ferlicot.fr >> >> http://www.synectique.eu >> 2 rue Jacques PrÃ©vert 01, >> 59650 Villeneuve d'ascq France >> >> >

Sept. 1, 2017

State of 64bits? Errors during configuration loading

by Cyril Ferlicot

Hi, I would like to know the state of the 64bits builds. At Synectique we tried to build on of our tools in 64bits on ubuntu slaves but we get a lot a VM crashes. We get the image/vm with this command: wget --quiet -O - get.pharo.org/64/$PHARO+$VM | bash $PHARO = 61 $VM = vm Here is the command we launch: ./pharo Pharo.image --no-default-preferences eval --save 'Metacello new repository:'\''http://smalltalkhub.com/mc/*******/*********/main'\''; configuration: '\''********'\''; version: #development; load' And I join an example of log we get when the vm crash. Is that a known issue? -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Esteban Lorenzano

> On 1 Sep 2017, at 16:50, Cyril Ferlicot <cyril.ferlicot(a)gmail.com> wrote: > > > > On Fri, Sep 1, 2017 at 4:46 PM, Nicolai Hess <nicolaihess(a)gmail.com <mailto:nicolaihess@gmail.com>> wrote: > > > And how do I know if a pull request / change is already included ? > > I looked at a pull request > and it seems this change is already in my image (a fresh image from 30.08 (Pharo7.0alpha.build.78.sha.35c21c3fac9b557eb38ec569fbbb109f2015c71a) > The pull request (https://api.github.com/repos/pharo-project/pharo/pulls/231 <https://api.github.com/repos/pharo-project/pharo/pulls/231>) is "open", but I can see the new code already in my image. > > The diff view tells me, that the method > UITheme>>warningTextColor changes from > > warningTextColor > ^ Color yellow muchDarker > > to > > warningTextColor > ^ Color yellow > > But the method in the image already looks like this: > > warningTextColor > ^ Color yellow > > > > The *old* implementation is > > warningTextColor > ^ Color yellow > > and the *new* implementation is > > warningTextColor > ^ Color yellow muchDarker > > (See https://github.com/pharo-project/pharo/pull/231/files <https://github.com/pharo-project/pharo/pull/231/files>) > > So, the diff may be inversed. (I did not checked) yep. Damn it :) Esteban > > > -- > Cyril Ferlicot > https://ferlicot.fr <https://ferlicot.fr/> > > http://www.synectique.eu <http://www.synectique.eu/> > 2 rue Jacques PrÃ©vert 01, > 59650 Villeneuve d'ascq France

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Cyril Ferlicot

On Fri, Sep 1, 2017 at 4:46 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > >> > And how do I know if a pull request / change is already included ? > > I looked at a pull request > and it seems this change is already in my image (a fresh image from 30.08 > (Pharo7.0alpha.build.78.sha.35c21c3fac9b557eb38ec569fbbb109f2015c71a) > The pull request (https://api.github.com/repos/ > pharo-project/pharo/pulls/231) is "open", but I can see the new code > already in my image. > > The diff view tells me, that the method > UITheme>>warningTextColor changes from > > warningTextColor > ^ Color yellow muchDarker > > to > > warningTextColor > ^ Color yellow > > But the method in the image already looks like this: > > warningTextColor > ^ Color yellow > > > The *old* implementation is warningTextColor ^ Color yellow and the *new* implementation is warningTextColor ^ Color yellow muchDarker (See https://github.com/pharo-project/pharo/pull/231/files) So, the diff may be inversed. (I did not checked) -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Nicolai Hess

2017-09-01 16:29 GMT+02:00 Cyril Ferlicot <cyril.ferlicot(a)gmail.com>: > On Fri, Sep 1, 2017 at 4:26 PM, Nicolai Hess <nicolaihess(a)gmail.com> > wrote: > > > > > > > > update what? pharo ? > > > > > > You can update Iceberg by executing: > > #('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' > 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' > 'BaselineOfLibGit') > do: [ :each | each asPackage removeFromSystem ]. > > Metacello new > baseline: 'Iceberg'; > repository: 'github://pharo-vcs/iceberg:dev-0.5'; > load. > > > Ah, thanks. I will try it out and report back if the crashes still occur. > > -- > Cyril Ferlicot > https://ferlicot.fr > > http://www.synectique.eu > 2 rue Jacques PrÃ©vert 01, > 59650 Villeneuve d'ascq France > >

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Nicolai Hess

2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > When reviewing a pull request, I see this in the changes view: > The tab title says > "left working copy / right incoming update" > but the code on the right side is what is current in my image > > [image: Inline-Bild 1] > > > And I don't think "working copy" is the correct naming, as this view lets > me diff changes within > that history, so it may be that none of this code is actually in my > "working copy", no ? > And how do I know if a pull request / change is already included ? I looked at a pull request and it seems this change is already in my image (a fresh image from 30.08 (Pharo7.0alpha.build.78.sha.35c21c3fac9b557eb38ec569fbbb109f2015c71a) The pull request (https://api.github.com/repos/pharo-project/pharo/pulls/231) is "open", but I can see the new code already in my image. The diff view tells me, that the method UITheme>>warningTextColor changes from warningTextColor ^ Color yellow muchDarker to warningTextColor ^ Color yellow But the method in the image already looks like this: warningTextColor ^ Color yellow

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Cyril Ferlicot

On Fri, Sep 1, 2017 at 4:26 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > update what? pharo ? > > You can update Iceberg by executing: #('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' 'BaselineOfLibGit') do: [ :each | each asPackage removeFromSystem ]. Metacello new baseline: 'Iceberg'; repository: 'github://pharo-vcs/iceberg:dev-0.5'; load. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Nicolai Hess

2017-09-01 16:13 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > > On 1 Sep 2017, at 16:02, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > > On 1 Sep 2017, at 15:50, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > 2017-09-01 15:03 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > >> >> On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >> >> >> >> 2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: >> >>> When reviewing a pull request, I see this in the changes view: >>> The tab title says >>> "left working copy / right incoming update" >>> but the code on the right side is what is current in my image >>> >>> <grafik.png> >>> >>> >>> And I don't think "working copy" is the correct naming, as this view >>> lets me diff changes within >>> that history, so it may be that none of this code is actually in my >>> "working copy", no ? >>> >> >> >> BTW, this is extremly unstable, reviewing a pull request, crashes a lot >> (the vm) >> >> >> on windows? >> >> >> >> > Yes, > > attached a another crash.dmp (maybe it helps) > > <crash.dmp> > > > can you tell me the PR you were analysing ? > > > ah, and btwâ¦ can you update with latest dev-0.5? I made some changes that > may help there that I still do not merge into master. > update what? pharo ? > > Esteban > > > Esteban > > >

Sept. 1, 2017

Re: [Pharo-dev] review pull request changes view

by Nicolai Hess

2017-09-01 16:02 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > > On 1 Sep 2017, at 15:50, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > 2017-09-01 15:03 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > >> >> On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >> >> >> >> 2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: >> >>> When reviewing a pull request, I see this in the changes view: >>> The tab title says >>> "left working copy / right incoming update" >>> but the code on the right side is what is current in my image >>> >>> <grafik.png> >>> >>> >>> And I don't think "working copy" is the correct naming, as this view >>> lets me diff changes within >>> that history, so it may be that none of this code is actually in my >>> "working copy", no ? >>> >> >> >> BTW, this is extremly unstable, reviewing a pull request, crashes a lot >> (the vm) >> >> >> on windows? >> >> >> >> > Yes, > > attached a another crash.dmp (maybe it helps) > > <crash.dmp> > > > can you tell me the PR you were analysing ? > https://api.github.com/repos/pharo-project/pharo/pulls/237 > > Esteban >

Sept. 1, 2017