August 2017 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Nicolai Hess

2017-08-31 0:28 GMT+02:00 Cyril Ferlicot D. <cyril.ferlicot(a)gmail.com>: > Le 31/08/2017 Ã 00:06, Nicolai Hess a Ã©crit : > > Hi, > > > > I am now able to use iceberg on windows, thanks for the help. > > > > But I am still a bit unsure about how the review and contribution > > workflow should work. > > > > up to pharo 6 I just load a latest image, > > - load the slice from a fogbugz number and was able to review the change > > - or create a slice and upload it to the inbox > > > > in pharo 7 > > - what is the equivalent to "getting the latest image" (and being able > > to load and review a fix), > > up to pharo 6 I just > > - load the latest image in pharolauncher (or from the command line). > > - opened the inbox repository. > > - load and review change/fix > > - throw away this change (close image without save) > > - reopen that image to move on with the next item to review. > > > > Hi, > > I'll not be of a great help here since I only reviewed PR via the github > interface for now but I know that Guille wrote this guide: > https://github.com/guillep/PharoIntegrationProcess/wiki/ > Pharo-Development-Process > > There is a review process discription. > Thank you Cyril. Do we have a list of links to this and other usefull articles or how did you know about this article?

Aug. 30, 2017

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Cyril Ferlicot D.

Le 31/08/2017 Ã 00:06, Nicolai Hess a Ã©critÂ : > Hi, > > I am now able to use iceberg on windows, thanks for the help. > > But I am still a bit unsure about how the review and contribution > workflow should work. > > up to pharo 6 I just load a latest image, > - load the slice from a fogbugz number and was able to review the change > - or create a slice and upload it to the inbox > > in pharo 7 > - what is the equivalent to "getting the latest image" (and being able > to load and review a fix), > Â Â up to pharo 6 I just > Â Â Â - load the latest image in pharolauncher (or from the command line). > Â Â Â - opened the inbox repository. > Â Â Â - load and review change/fix > Â Â Â - throw away this change (close image without save) > Â Â Â - reopen that image to move on with the next item to review. > Hi, I'll not be of a great help here since I only reviewed PR via the github interface for now but I know that Guille wrote this guide: https://github.com/guillep/PharoIntegrationProcess/wiki/Pharo-Development-P… There is a review process discription. > Â Â Â But now, do I have to update my local branch for every new pull > request ? And how do I do this ? In other git project I would, I would > Â Â Â fetch upstream, checkout master, merge with upstream/master, push > the master to my fork origin > Â Â How should this be done with my pharo 7 fork ? (And do we only work > on the development brach instead of the master)? > Â > Â Â And do I this only in the command line or do I manage my fork (and > keep it up to date) from within pharo with iceberg ? > Â Â How do I actually access the pull requests from within pharo ? Maybe > I am stupid, but I just can not find it. > Â Â I would like do this steps, (as I was used to it from the prior > contribution process, by loading code from the inbox) > Â Â - Just look at the changes > Â Â - apply the changes > Â Â - throw away this changes, and move one with the next fix review > > And the same for creating a fix / pull request. Do I need to be up to > date with my own fork, or only the local copy of the pharo repository ? > Again, for pharo 6 I would just load a latest image, make my changes / > code fixes and create a slice. Save to the inbox -> done. > And looking at iceberg, I have really no clue how to upload a fix. > To create a fix you don't really need a fork totally up to date with the origin repository but it's recommended to sync once in a while to not create conflics if changes happen in the same part of the system that you'll change. The process is described here: https://github.com/guillep/PharoIntegrationProcess/wiki/Keep-your-repo-in-s… In general this will do the trick: $ git checkout development (if not already on development) $ git pull [PHARO_ORIGIN] development $ git push [FORK_ORIGIN] development > I see that other people are using the new process, and I feel a bit lost > and closed out of the pharo 7 development process, as I am at the moment > unable to understand how this work. > Are there any other resources I missed ? > > I use the new process but I already had some knowledge of git. I used it to manage team work at the university and I used it with smalltalk's projects and file tree. Also I asked a looot of questions to esteban/pavel/guille. The process need to be improved again and I still often have troubles. (I got one vm crash and two iceberg crash today while contributing for example). I try to report the maximum of my reproducible problem here: https://github.com/pharo-vcs/iceberg/issues If you see trouble with Iceberg it could be cool to give info to help to ease the contribution process. For your last question, the resources I use are mostly the wiki of Guille: https://github.com/guillep/PharoIntegrationProcess/wiki My knowledge of git and the help of people like esteban/guille/pavel/marcusâ¦ I hope some of those resources can help you. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Aug. 30, 2017

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Nicolai Hess

Hi, I am now able to use iceberg on windows, thanks for the help. But I am still a bit unsure about how the review and contribution workflow should work. up to pharo 6 I just load a latest image, - load the slice from a fogbugz number and was able to review the change - or create a slice and upload it to the inbox in pharo 7 - what is the equivalent to "getting the latest image" (and being able to load and review a fix), up to pharo 6 I just - load the latest image in pharolauncher (or from the command line). - opened the inbox repository. - load and review change/fix - throw away this change (close image without save) - reopen that image to move on with the next item to review. But now, do I have to update my local branch for every new pull request ? And how do I do this ? In other git project I would, I would fetch upstream, checkout master, merge with upstream/master, push the master to my fork origin How should this be done with my pharo 7 fork ? (And do we only work on the development brach instead of the master)? And do I this only in the command line or do I manage my fork (and keep it up to date) from within pharo with iceberg ? How do I actually access the pull requests from within pharo ? Maybe I am stupid, but I just can not find it. I would like do this steps, (as I was used to it from the prior contribution process, by loading code from the inbox) - Just look at the changes - apply the changes - throw away this changes, and move one with the next fix review And the same for creating a fix / pull request. Do I need to be up to date with my own fork, or only the local copy of the pharo repository ? Again, for pharo 6 I would just load a latest image, make my changes / code fixes and create a slice. Save to the inbox -> done. And looking at iceberg, I have really no clue how to upload a fix. I see that other people are using the new process, and I feel a bit lost and closed out of the pharo 7 development process, as I am at the moment unable to understand how this work. Are there any other resources I missed ? 2017-08-11 19:30 GMT+02:00 Stephane Ducasse <stepharo.self(a)gmail.com>: > Nicolai > > I started super simple. I clone and point my fresh dled image to the use > the clone. > Then I can do simple PR and review the issues. > I will do the installation several times to learn (but not clone). > > I'm not sure that it is needed but I have > cd /Users/ducasse/Library/Preferences/pharo/7.0 > > StartupPreferencesLoader default executeAtomicItems: { > StartupAction > name: 'Git Settings' > code: [ > FileStream stdout > cr; nextPutAll: 'Setting the ssh > credentials'; cr. > Iceberg enableMetacelloIntegration: true. > IceCredentialsProvider useCustomSsh: true. > IceCredentialsProvider sshCredentials > username: 'git'; > publicKey: > '/Users/ducasse/.ssh/id_rsa.pub'; > privateKey: > '/Users/ducasse/.ssh/id_rsa'. > IceCredentialsProvider > plaintextCredentials: > (IcePlaintextCredentials new username: 'Ducasse'; password: 'xxxx' ; > yourself ). > FileStream stdout > cr; nextPutAll: 'Finished'; cr ]. > }. > > > > On Fri, Aug 11, 2017 at 9:46 AM, Guillermo Polito < > guillermopolito(a)gmail.com> wrote: > >> I extended the document with some windows specific instructions also. >> >> On Fri, Aug 11, 2017 at 9:31 AM, Guillermo Polito < >> guillermopolito(a)gmail.com> wrote: >> >>> >>> >>> On Fri, Aug 11, 2017 at 12:34 AM, Nicolai Hess <nicolaihess(a)gmail.com> >>> wrote: >>> >>>> >>>> >>>> 2017-08-10 17:17 GMT+02:00 Guillermo Polito <guillermopolito(a)gmail.com> >>>> : >>>> >>>>> Hi, >>>>> >>>>> I've made some write up for the pharo part (not metacello or external >>>>> projects) >>>>> >>>>> https://github.com/guillep/PharoIntegrationProcess/wiki/Cont >>>>> ribute-a-fix-to-Pharo >>>>> >>>>> Of course, expect bugs on it :) Not everything is smooth. If you have >>>>> comments, they are welcome. >>>>> >>>> >>>> >>>> >>>> [image: Inline-Bild 1] >>>> >>>> >>>> In option 2, I think this should be "Click on the Edit button", >>>> >>> >>> Thanks, fixed! >>> >>>> >>>> >>>> >>>> >>>>> >>>>> Guille >>>>> >>>>> -- >>>>> >>>>> >>>>> >>>>> Guille Polito >>>>> >>>>> >>>>> Research Engineer >>>>> >>>>> French National Center for Scientific Research - *http://www.cnrs.fr* >>>>> <http://www.cnrs.fr> >>>>> >>>>> >>>>> >>>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>>> >>>>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>>>> >>>> >>>> >>> >>> >>> -- >>> >>> >>> >>> Guille Polito >>> >>> >>> Research Engineer >>> >>> French National Center for Scientific Research - *http://www.cnrs.fr* >>> <http://www.cnrs.fr> >>> >>> >>> >>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>> >>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>> >> >> >> >> -- >> >> >> >> Guille Polito >> >> >> Research Engineer >> >> French National Center for Scientific Research - *http://www.cnrs.fr* >> <http://www.cnrs.fr> >> >> >> >> *Web:* *http://guillep.github.io* <http://guillep.github.io> >> >> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >> > >

Aug. 30, 2017

Re: [Pharo-dev] [Vm-dev] [ANN] Lowtalk, a new Smalltalk dialect that could eventually replace Slang

by Bernardo Ezequiel Contreras

that's a crazy amount of work, congrats!

Aug. 30, 2017

Re: [Pharo-dev] [pharo-project/pharo] 20355-Make-SUnit-Tests-green-on-bootstrapped-image (#230)

by pavel-krivanek

Merged #230. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pharo-project/pharo/pull/230#event-1228400184

Aug. 30, 2017

Re: [Pharo-dev] [pharo-project/pharo] 20355-Make-SUnit-Tests-green-on-bootstrapped-image (#230)

by pavel-krivanek

Pool request results checked. Ready to merge. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pharo-project/pharo/pull/230#issuecomment-326114350

Aug. 30, 2017

Re: [Pharo-dev] [pharo-project/pharo] 20355-Make-SUnit-Tests-green-on-bootstrapped-image (#230)

by pavel-krivanek

@pavel-krivanek pushed 1 commit. 3051d7f add SUnit-Tests to the Hermes packages archive -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/pharo-project/pharo/pull/230/files/c65440cd593828083c59c…

Aug. 30, 2017

[pharo-project/pharo] 20357-New-warning-text-color-is-not-readable-on-white-theme (#231)

by CyrilFerlicot

When I added the warningTextColor I did not test it enough. Now that I try to use it with Iceberg I see that it is not good. This will make it more readable. Case 20357 : https://pharo.fogbugz.com/f/cases/20357/New-warning-text-color-is-not-reada… You can view, comment on, or merge this pull request online at: https://github.com/pharo-project/pharo/pull/231 -- Commit Summary -- * When I added the warningTextColor I did not test it enough. Now that I try to use it with Iceberg I see that it is not good. This will make it more readable. -- File Changes -- M src/Polymorph-Widgets.package/UITheme.class/instance/warningBackgroundColor.st (2) M src/Polymorph-Widgets.package/UITheme.class/instance/warningTextColor.st (2) -- Patch Links -- https://github.com/pharo-project/pharo/pull/231.patch https://github.com/pharo-project/pharo/pull/231.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pharo-project/pharo/pull/231

Aug. 30, 2017

Re: [Pharo-dev] [pharo-project/pharo] 20355-Make-SUnit-Tests-green-on-bootstrapped-image (#230)

by pavel-krivanek

@pavel-krivanek pushed 1 commit. c65440c add SUnit-Tests.hermes to the loading sequence -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/pharo-project/pharo/pull/230/files/e34107f827da7f45e0aa4…

Aug. 30, 2017

[pharo-project/pharo] 20355-Make-SUnit-Tests-green-on-bootstrapped-image (#230)

by pavel-krivanek

https://pharo.fogbugz.com/f/cases/20355/Make-SUnit-Tests-green-on-bootstrap… - make SUnit-Tests green - clean SUnit related bootstrap packages exporting methods - load PerformMessageCommandLineHandler into the image You can view, comment on, or merge this pull request online at: https://github.com/pharo-project/pharo/pull/230 -- Commit Summary -- * - make SUnit-Tests green -- File Changes -- M bootstrap/scripts/runKernelTests.sh (2) D bootstrap/src/Pharo30Bootstrap.package/PBBootstrap.class/instance/exportSUnitPackageNames.st (7) D bootstrap/src/Pharo30Bootstrap.package/PBBootstrap.class/instance/exportSUnitProtocols.st (5) M src/BaselineOfIDE.package/BaselineOfIDE.class/instance/baseline..st (3) M src/BaselineOfIDE.package/BaselineOfIDE.class/instance/groups..st (3) M src/BaselineOfPharoBootstrap.package/BaselineOfPharoBootstrap.class/instance/baseline..st (6) M src/SUnit-Tests.package/ClassFactoryForTestCaseTest.class/instance/testDefaultCategoryCleanUp.st (3) M src/SUnit-Tests.package/ClassFactoryForTestCaseTest.class/instance/testDuplicateClassWithNewName.st (15) M src/SUnit-Tests.package/ClassFactoryForTestCaseTest.class/instance/testPackageCleanUp.st (3) M src/SUnit-Tests.package/ClassFactoryWithOrganizationTest.class/instance/testDefaultCategoryCleanUp.st (3) M src/SUnit-Tests.package/ClassFactoryWithOrganizationTest.class/instance/testPackageCleanUp.st (3) -- Patch Links -- https://github.com/pharo-project/pharo/pull/230.patch https://github.com/pharo-project/pharo/pull/230.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pharo-project/pharo/pull/230

Aug. 30, 2017