August 2017 - Pharo-dev - lists.pharo.org

Maybe better pinning messages? (inspired by [Pinning Objects in Pharo])

by Denis Kudriashov

Hi. We now have very generic message names: - pin - unpin - setPinned: - isPinned Problem that they collide with possible domain related names. For example I implemented pinning of tabs in Calypso and I found that I overrides #pin and #isPinned messages. Then I fix it with different names. Probably menus also uses pin word but without overrides What you think about renaming pinning messages? Something like: - pinMemory - unpinMemory - isMemoryPinned - setPinnedMemory: - pinMemoryDuring: (if we will introduce it) I think it is easy to do now because not much code uses pinning

Aug. 31, 2017

Re: [Pharo-dev] Writeup: how to contribute to Pharo

by Cyril Ferlicot

On Thu, Aug 31, 2017 at 12:42 AM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > Thank you Cyril. > > Do we have a list of links to this and other usefull articles or how did you > know about this article? > > Most of those articles comes from the same wiki that Guille gave in the first message of this thread. I just explored it :) But for the review process one I had to ask to Guille because I did not though I could have found it under "Pharo Development Process". And for some other articles I search on google. (To get the stHub to git migration script of Peter for example) -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Norbert Hartl

> Am 31.08.2017 um 09:30 schrieb Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > > > On Thu, Aug 31, 2017 at 8:45 AM, Norbert Hartl <norbert(a)hartl.name <mailto:norbert@hartl.name>> wrote: > > > > Am 31.08.2017 um 03:32 schrieb Sean P. DeNigris <sean(a)clipperadams.com <mailto:sean@clipperadams.com>>: > > > > https://github.com/pharo-vcs/iceberg/blob/master/README.md <https://github.com/pharo-vcs/iceberg/blob/master/README.md> suggests to > > configure Iceberg with the "Use Custom SSH Keys" setting, part of which > > seems to include pasting one's SSH Key Passphrase into Pharo's settings. Is > > that a good idea (i.e. is that safe)? > > > > > Not at all! > > Just about as safe as storing credentials for SmalltalkHub. (and to be fair, STHub is even worse in that the connection is not encrypted. Imagine someone observing traffic on PharoDays/ESUG conf.) > I didn't say something different. But having one bad solution makes another bad solution not better. Both are no-gos! > If you are not giving your work image to anyone else, I don't see what difference it would make. And if you are worrying about malicious code extracting it from your settings... I would be more worried about full access to your systemâ¦ So you do not put passphrases on your ssh keys? Because you don't give the private key away why protect it? So imagine you have development process that includes a jenkins that needs to build the source and therefor needs access to the repository. What do you do? And it is not only for access to git repos and such. If we want to develop decent systems we need a way to store credentials safe and external to the image. Norbert

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Peter UhnÃ¡k

On Thu, Aug 31, 2017 at 8:45 AM, Norbert Hartl <norbert(a)hartl.name> wrote: > > > > Am 31.08.2017 um 03:32 schrieb Sean P. DeNigris <sean(a)clipperadams.com>: > > > > https://github.com/pharo-vcs/iceberg/blob/master/README.md suggests to > > configure Iceberg with the "Use Custom SSH Keys" setting, part of which > > seems to include pasting one's SSH Key Passphrase into Pharo's settings. > Is > > that a good idea (i.e. is that safe)? > > > > > Not at all! Just about as safe as storing credentials for SmalltalkHub. (and to be fair, STHub is even worse in that the connection is not encrypted. Imagine someone observing traffic on PharoDays/ESUG conf.) If you are not giving your work image to anyone else, I don't see what difference it would make. And if you are worrying about malicious code extracting it from your settings... I would be more worried about full access to your system... Peter

Aug. 31, 2017

Re: [Pharo-dev] Bloc: Safe to Store SSH Passphrase in Pharo?

by Norbert Hartl

> Am 31.08.2017 um 03:32 schrieb Sean P. DeNigris <sean(a)clipperadams.com>: > > https://github.com/pharo-vcs/iceberg/blob/master/README.md suggests to > configure Iceberg with the "Use Custom SSH Keys" setting, part of which > seems to include pasting one's SSH Key Passphrase into Pharo's settings. Is > that a good idea (i.e. is that safe)? > > Not at all! And that's why I nagged Esteban so much until ssh agent work properly. It is a really bad idea to put passwords in the image but I can see that there is a lack of decent support for this and be able to use the password can be considered last resort. Norbert > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 31, 2017

Bloc: Safe to Store SSH Passphrase in Pharo?

by Sean P. DeNigris

https://github.com/pharo-vcs/iceberg/blob/master/README.md suggests to configure Iceberg with the "Use Custom SSH Keys" setting, part of which seems to include pasting one's SSH Key Passphrase into Pharo's settings. Is that a good idea (i.e. is that safe)? ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Aug. 31, 2017

Re: [Pharo-dev] reviewing pull request are adding new remotes

by Cyril Ferlicot

On jeu. 31 aoÃ»t 2017 at 02:15, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > Is it right, that reviewing a pull request will add the others user git > repository in my > list of remotes ? > This may make sense if I actually merge the pull into my branch. But if I > just want > to see the code, or merge it into the image, do I need that repository in > my list of > remotes ? > > > Hi, When we do a PR it's because we have a repository with code that we want to integrate in another repository. If another user of the original repository wants to review this code, he needs to reference the fork of the new code's author because this code is not yet in the original repository. So, if in Pharo you want to see/merge the code of a PR, you need the fork of the author as a remote to be able to fetch/pull the code. Once the review is finished you can delete this remote if you wish. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques PrÃ©vert 01, 59650 Villeneuve d'ascq France

Aug. 31, 2017

reviewing pull request are adding new remotes

by Nicolai Hess

Is it right, that reviewing a pull request will add the others user git repository in my list of remotes ? This may make sense if I actually merge the pull into my branch. But if I just want to see the code, or merge it into the image, do I need that repository in my list of remotes ?

Aug. 31, 2017

Re: [Pharo-dev] Can not review pull request with iceberg

by Nicolai Hess

2017-08-31 1:47 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > Hi, > > I set up my fork and iceberg as it is described in > https://github.com/guillep/PharoIntegrationProcess/wiki/ > Contribute-a-fix-to-Pharo > > now I try to review a pull request from the pharo-project repository. > 1. iceberg asked for the github credientials (why ? I can view pull > request on the webinterface without beeing looged in) > 2. I unchecked the checkbox "'Do you want this credentials to be stored > for future use?'" > 3. after entering the user/password, it asked again for user and password > when selecting one entry from the pull request list, the checkbox is again > checked, so for every operation I have to uncheck the checkbox again and > again. > 4. the dialog for the credentials opens two times right after another, and > I have to enter the user/password two times > 5. now the iceberg pull request list is un-focus-able, and the main > iceberg window too. > Every mouse click on the iceberg window, just shows the world menu > > any ideas what went wrong? > > (this with pharo 7 on windows) > > If I just store the credentials, (but actually I dont really want to), I can open the pull request view. But, when browsing a single pull request, this dialog is extremly slow. Resizing the window or scrolling in the list is slow, does it reload the whole data, everytime the content gets scrolled? Finally iceber crashes, I attached the crash.dmp

Aug. 30, 2017

Can not review pull request with iceberg

by Nicolai Hess

Hi, I set up my fork and iceberg as it is described in https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to… now I try to review a pull request from the pharo-project repository. 1. iceberg asked for the github credientials (why ? I can view pull request on the webinterface without beeing looged in) 2. I unchecked the checkbox "'Do you want this credentials to be stored for future use?'" 3. after entering the user/password, it asked again for user and password when selecting one entry from the pull request list, the checkbox is again checked, so for every operation I have to uncheck the checkbox again and again. 4. the dialog for the credentials opens two times right after another, and I have to enter the user/password two times 5. now the iceberg pull request list is un-focus-able, and the main iceberg window too. Every mouse click on the iceberg window, just shows the world menu any ideas what went wrong? (this with pharo 7 on windows)

Aug. 30, 2017