August 2017 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] SystemVersion>>highestUpdate causes FFISharedPool class>>initialize to fail

by Stephane Ducasse

My impression is that this code is old and we should rewrite it. Now I wonder why the session manager register itself to the tools. The idea of the tool registration was that we can swap them to get different suite of tools. This was never really used and I would replace that by a tool context passed around instead of an ugly global variable (because this is what it is). So I wonder why the logic is like that. SessionManager default registerToolClassNamed: self name I hope that code relying on the DNU aspect of the tool registry does not exist. Now may be I'm confusing the sessionManager tool registry with the toolregistry. We should really reassess some of the solutions we have. stef On Tue, Aug 22, 2017 at 6:58 PM, Guillermo Polito <guillermopolito(a)gmail.com > wrote: > > Le mar. 22 aoÃ»t 2017 Ã 18:33, Alistair Grant <akgrant0710(a)gmail.com> a > Ã©crit : > >> Hi Guille, >> >> On Tue, Aug 22, 2017 at 05:55:22PM +0200, Guillermo Polito wrote: >> > I don't think so... Build number only works from the CI. This means >> > that if you build your image in your machine you'll have no build >> > number and then this piece of code will not work neither. Thus maybe >> > we need to find a separate solution for it? >> >> P.S. Shouldn't the highestUpdate still be set as described below? > > > But how do you do it? Imagine I build my image from outsider the ci. Where > do I get the build number ? In my machine I have no thing such as a build > or a job. > > Pharo should work independently from where it is build. > > We should not mistake build number for version number. They do not mean > the same. > > >> >> This is an image that presumably came from the CI >> (http://files.pharo.org/image/70/latest.zip) >> >> Thanks, >> Alistair >> >> >> > On 8/22/17, Alistair Grant <akgrant0710(a)gmail.com> wrote: >> > > Hi Everyone, >> > > >> > > I'm attempting to update to the latest Pharo7 image (918efe2, 32 bit), >> > > but am getting an error while loading OSsubprocess. >> > > >> > > The error occurs in FFISharedPool class>>initialize: >> > > >> > > >> > > initialize >> > > self flag: #removeIt. >> > > "This IF will be eliminated soon...only here temporary" >> > > (SystemVersion current highestUpdate >= 50558) >> > > ifTrue: [ >> > > SessionManager default registerToolClassNamed: >> self name >> > > ] >> > > ifFalse: [ >> > > Smalltalk addToStartUpList: self. >> > > ] >> > > >> > > >> > > because #highestUpdate is nil. >> > > >> > > >> > > The top of the stack is: >> > > >> > > UndefinedObject(Object)>>doesNotUnderstand: #'>=' >> > > FFISharedPool class>>initialize >> > > MCMethodDefinition>>postloadOver: >> > > [ :each | each postloadOver: (self obsoletionFor: each) ] in >> > > MCPackageLoader>>basicLoadDefinitions in Block: [ :each | each >> postloadOver: >> > > (self obsoletionFor: ...etc... >> > > >> > > >> > > Based on the method above, it looks like highestUpdate used to be set >> > > based on the image number, and has presumably broken during the move >> to >> > > Pharo 7 and git. >> > > >> > > Earlier Pharo 7 images had it set to 0, which doesn't sound right. >> > > >> > > Since a build number was recently introduced (fogbugz 20321), should >> the >> > > highestUpdate be set to 70000+buildNumber? >> > > >> > > E.g. this image has an identifier of: >> > > >> > > Pharo 7.0 >> > > Build information: >> > > alpha.build.56.sha.918efe28fa3e6ad485b059dbf4ce675fd4086cf6 >> > > >> > > So highestUpdate would be 70056. >> > > >> > > >> > > Thanks! >> > > Alistair >> > > >> > > >> > >> > >> > -- >> > >> > >> > >> > >> > Guille Polito >> > >> > >> > Research Engineer >> > >> > French National Center for Scientific Research - *http://www.cnrs.fr* >> > <http://www.cnrs.fr> >> > >> > >> > >> > *Web:* *http://guillep.github.io* <http://guillep.github.io> >> > >> > *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >> > >> >> -- > > > > Guille Polito > > > Research Engineer > > French National Center for Scientific Research - *http://www.cnrs.fr* > <http://www.cnrs.fr> > > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >

Aug. 22, 2017

Re: [Pharo-dev] SystemVersion>>highestUpdate causes FFISharedPool class>>initialize to fail

by Guillermo Polito

Le mar. 22 aoÃ»t 2017 Ã 18:33, Alistair Grant <akgrant0710(a)gmail.com> a Ã©crit : > Hi Guille, > > On Tue, Aug 22, 2017 at 05:55:22PM +0200, Guillermo Polito wrote: > > I don't think so... Build number only works from the CI. This means > > that if you build your image in your machine you'll have no build > > number and then this piece of code will not work neither. Thus maybe > > we need to find a separate solution for it? > > P.S. Shouldn't the highestUpdate still be set as described below? But how do you do it? Imagine I build my image from outsider the ci. Where do I get the build number ? In my machine I have no thing such as a build or a job. Pharo should work independently from where it is build. We should not mistake build number for version number. They do not mean the same. > > This is an image that presumably came from the CI > (http://files.pharo.org/image/70/latest.zip) > > Thanks, > Alistair > > > > On 8/22/17, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > > Hi Everyone, > > > > > > I'm attempting to update to the latest Pharo7 image (918efe2, 32 bit), > > > but am getting an error while loading OSsubprocess. > > > > > > The error occurs in FFISharedPool class>>initialize: > > > > > > > > > initialize > > > self flag: #removeIt. > > > "This IF will be eliminated soon...only here temporary" > > > (SystemVersion current highestUpdate >= 50558) > > > ifTrue: [ > > > SessionManager default registerToolClassNamed: > self name > > > ] > > > ifFalse: [ > > > Smalltalk addToStartUpList: self. > > > ] > > > > > > > > > because #highestUpdate is nil. > > > > > > > > > The top of the stack is: > > > > > > UndefinedObject(Object)>>doesNotUnderstand: #'>=' > > > FFISharedPool class>>initialize > > > MCMethodDefinition>>postloadOver: > > > [ :each | each postloadOver: (self obsoletionFor: each) ] in > > > MCPackageLoader>>basicLoadDefinitions in Block: [ :each | each > postloadOver: > > > (self obsoletionFor: ...etc... > > > > > > > > > Based on the method above, it looks like highestUpdate used to be set > > > based on the image number, and has presumably broken during the move to > > > Pharo 7 and git. > > > > > > Earlier Pharo 7 images had it set to 0, which doesn't sound right. > > > > > > Since a build number was recently introduced (fogbugz 20321), should > the > > > highestUpdate be set to 70000+buildNumber? > > > > > > E.g. this image has an identifier of: > > > > > > Pharo 7.0 > > > Build information: > > > alpha.build.56.sha.918efe28fa3e6ad485b059dbf4ce675fd4086cf6 > > > > > > So highestUpdate would be 70056. > > > > > > > > > Thanks! > > > Alistair > > > > > > > > > > > > -- > > > > > > > > > > Guille Polito > > > > > > Research Engineer > > > > French National Center for Scientific Research - *http://www.cnrs.fr* > > <http://www.cnrs.fr> > > > > > > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > > > *Phone: *+33 06 52 70 66 13 > > > > -- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

Aug. 22, 2017

Re: [Pharo-dev] [ Pharo 70 ] Build 52 to 54

by Denis Kudriashov

Hi. > 1) we have some sporadic test failures (sometimes network, sometimes > some mutex or delay issues). They do not happen all the time and > that's why sometimes there is one or two failing tests. We should > detect these tests and fix them to be more robust I thing I am responsible for Mutex problems because I wrote a bit naive waiting logic in some tests (with the hope that with green threads it will not fail). So if you have list of failing Mutex tests send it to me. I will fix them. 2017-08-22 17:51 GMT+02:00 Guillermo Polito <guillermopolito(a)gmail.com>: > Hi Marcus, > > Please, do not relaunch the build if there is a test failure. That > simply does not fix the problem, it just adds noise. There are two > problems: > > 1) we have some sporadic test failures (sometimes network, sometimes > some mutex or delay issues). They do not happen all the time and > that's why sometimes there is one or two failing tests. We should > detect these tests and fix them to be more robust > > >> Note, is there some brave soul that would like to take action here? > > 2) sometimes the vm crashes while running the tests. We should detect > the bug and fix it. > > >> Note, is there some brave soul that would like to take action here? > > Now, if we are integrating a fix, this means that the PR was **already > validated as green**. That means that the integrated commit can be > bootstrapped and tested (and all tests are green). > > Moreover, running the tests after integration (and its build color) > does not change the integration in itself: the commit was already > merged and pushed into the main branch, so even if it fails always, > it's too late. So, relaunching the build does not really change > anything (besides the impression we may have about the build). > > A complementary solution (that should go together with fixing the > tests) is to add a retry policy while running tests in the CI. > > >> Note, is there some brave soul that would like to take action here? > > Guille, on holidays from the phone. > > On 8/22/17, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > [ Pharo 70 ] Build 52 PR 205 > > index-inst-var-should-move-from-Slot-to-IndexedSlot > > https://github.com/pharo-project/pharo/pull/205 > > https://pharo.fogbugz.com/f/cases/20191 > > > > Build 53: failed, redone as 54 > > > > [ Pharo 70 ] Build 54 PR 193 Integrate WebBrowser-Core package to be > able to > > open a browser on a URL > > https://pharo.fogbugz.com/f/cases/20304 > > https://github.com/pharo-project/pharo/pull/193 > > > > Build 55: failed, redone as 56 (I do not like to use this build numberâ¦ > > with builds failing, we will always get the > > question âand what was in build XX?). > > > > [ Pharo 70 ] Build 56 PR 174 > > 20260-FastTable-not-support-cell-morphs-with-stepping-animation #174 > > https://github.com/pharo-project/pharo/pull/174 > > https://pharo.fogbugz.com/f/cases/20260/ > > > > > > > > > -- > > > > > Guille Polito > > > Research Engineer > > French National Center for Scientific Research - *http://www.cnrs.fr* > <http://www.cnrs.fr> > > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 > >

Aug. 22, 2017

Re: [Pharo-dev] SystemVersion>>highestUpdate causes FFISharedPool class>>initialize to fail

by Alistair Grant

Hi Guille, On Tue, Aug 22, 2017 at 05:55:22PM +0200, Guillermo Polito wrote: > I don't think so... Build number only works from the CI. This means > that if you build your image in your machine you'll have no build > number and then this piece of code will not work neither. Thus maybe > we need to find a separate solution for it? P.S. Shouldn't the highestUpdate still be set as described below? This is an image that presumably came from the CI (http://files.pharo.org/image/70/latest.zip) Thanks, Alistair > On 8/22/17, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi Everyone, > > > > I'm attempting to update to the latest Pharo7 image (918efe2, 32 bit), > > but am getting an error while loading OSsubprocess. > > > > The error occurs in FFISharedPool class>>initialize: > > > > > > initialize > > self flag: #removeIt. > > "This IF will be eliminated soon...only here temporary" > > (SystemVersion current highestUpdate >= 50558) > > ifTrue: [ > > SessionManager default registerToolClassNamed: self name > > ] > > ifFalse: [ > > Smalltalk addToStartUpList: self. > > ] > > > > > > because #highestUpdate is nil. > > > > > > The top of the stack is: > > > > UndefinedObject(Object)>>doesNotUnderstand: #'>=' > > FFISharedPool class>>initialize > > MCMethodDefinition>>postloadOver: > > [ :each | each postloadOver: (self obsoletionFor: each) ] in > > MCPackageLoader>>basicLoadDefinitions in Block: [ :each | each postloadOver: > > (self obsoletionFor: ...etc... > > > > > > Based on the method above, it looks like highestUpdate used to be set > > based on the image number, and has presumably broken during the move to > > Pharo 7 and git. > > > > Earlier Pharo 7 images had it set to 0, which doesn't sound right. > > > > Since a build number was recently introduced (fogbugz 20321), should the > > highestUpdate be set to 70000+buildNumber? > > > > E.g. this image has an identifier of: > > > > Pharo 7.0 > > Build information: > > alpha.build.56.sha.918efe28fa3e6ad485b059dbf4ce675fd4086cf6 > > > > So highestUpdate would be 70056. > > > > > > Thanks! > > Alistair > > > > > > > -- > > > > > Guille Polito > > > Research Engineer > > French National Center for Scientific Research - *http://www.cnrs.fr* > <http://www.cnrs.fr> > > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 >

Aug. 22, 2017

Re: [Pharo-dev] SystemVersion>>highestUpdate causes FFISharedPool class>>initialize to fail

by Alistair Grant

On Tue, Aug 22, 2017 at 05:55:22PM +0200, Guillermo Polito wrote: > I don't think so... Build number only works from the CI. This means > that if you build your image in your machine you'll have no build > number and then this piece of code will not work neither. Thus maybe > we need to find a separate solution for it? Good point. I guess that #registerToolClassNamed: was introduced around image #50558 and didn't exist in earlier versions, so the test could be replaced with: SessionManager default respondsTo: #registerToolClassNamed: I'll see if I can download an older Pharo 5 VM and image and check (pre 50558). Thanks, Alistair > On 8/22/17, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi Everyone, > > > > I'm attempting to update to the latest Pharo7 image (918efe2, 32 bit), > > but am getting an error while loading OSsubprocess. > > > > The error occurs in FFISharedPool class>>initialize: > > > > > > initialize > > self flag: #removeIt. > > "This IF will be eliminated soon...only here temporary" > > (SystemVersion current highestUpdate >= 50558) > > ifTrue: [ > > SessionManager default registerToolClassNamed: self name > > ] > > ifFalse: [ > > Smalltalk addToStartUpList: self. > > ] > > > > > > because #highestUpdate is nil. > > > > > > The top of the stack is: > > > > UndefinedObject(Object)>>doesNotUnderstand: #'>=' > > FFISharedPool class>>initialize > > MCMethodDefinition>>postloadOver: > > [ :each | each postloadOver: (self obsoletionFor: each) ] in > > MCPackageLoader>>basicLoadDefinitions in Block: [ :each | each postloadOver: > > (self obsoletionFor: ...etc... > > > > > > Based on the method above, it looks like highestUpdate used to be set > > based on the image number, and has presumably broken during the move to > > Pharo 7 and git. > > > > Earlier Pharo 7 images had it set to 0, which doesn't sound right. > > > > Since a build number was recently introduced (fogbugz 20321), should the > > highestUpdate be set to 70000+buildNumber? > > > > E.g. this image has an identifier of: > > > > Pharo 7.0 > > Build information: > > alpha.build.56.sha.918efe28fa3e6ad485b059dbf4ce675fd4086cf6 > > > > So highestUpdate would be 70056. > > > > > > Thanks! > > Alistair > > > > > > > -- > > > > > Guille Polito > > > Research Engineer > > French National Center for Scientific Research - *http://www.cnrs.fr* > <http://www.cnrs.fr> > > > > *Web:* *http://guillep.github.io* <http://guillep.github.io> > > *Phone: *+33 06 52 70 66 13 >

Aug. 22, 2017

Re: [Pharo-dev] SystemVersion>>highestUpdate causes FFISharedPool class>>initialize to fail

by Guillermo Polito

I don't think so... Build number only works from the CI. This means that if you build your image in your machine you'll have no build number and then this piece of code will not work neither. Thus maybe we need to find a separate solution for it? On 8/22/17, Alistair Grant <akgrant0710(a)gmail.com> wrote: > Hi Everyone, > > I'm attempting to update to the latest Pharo7 image (918efe2, 32 bit), > but am getting an error while loading OSsubprocess. > > The error occurs in FFISharedPool class>>initialize: > > > initialize > self flag: #removeIt. > "This IF will be eliminated soon...only here temporary" > (SystemVersion current highestUpdate >= 50558) > ifTrue: [ > SessionManager default registerToolClassNamed: self name > ] > ifFalse: [ > Smalltalk addToStartUpList: self. > ] > > > because #highestUpdate is nil. > > > The top of the stack is: > > UndefinedObject(Object)>>doesNotUnderstand: #'>=' > FFISharedPool class>>initialize > MCMethodDefinition>>postloadOver: > [ :each | each postloadOver: (self obsoletionFor: each) ] in > MCPackageLoader>>basicLoadDefinitions in Block: [ :each | each postloadOver: > (self obsoletionFor: ...etc... > > > Based on the method above, it looks like highestUpdate used to be set > based on the image number, and has presumably broken during the move to > Pharo 7 and git. > > Earlier Pharo 7 images had it set to 0, which doesn't sound right. > > Since a build number was recently introduced (fogbugz 20321), should the > highestUpdate be set to 70000+buildNumber? > > E.g. this image has an identifier of: > > Pharo 7.0 > Build information: > alpha.build.56.sha.918efe28fa3e6ad485b059dbf4ce675fd4086cf6 > > So highestUpdate would be 70056. > > > Thanks! > Alistair > > -- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

Aug. 22, 2017

Re: [Pharo-dev] [ Pharo 70 ] Build 52 to 54

by Guillermo Polito

Hi Marcus, Please, do not relaunch the build if there is a test failure. That simply does not fix the problem, it just adds noise. There are two problems: 1) we have some sporadic test failures (sometimes network, sometimes some mutex or delay issues). They do not happen all the time and that's why sometimes there is one or two failing tests. We should detect these tests and fix them to be more robust >> Note, is there some brave soul that would like to take action here? 2) sometimes the vm crashes while running the tests. We should detect the bug and fix it. >> Note, is there some brave soul that would like to take action here? Now, if we are integrating a fix, this means that the PR was **already validated as green**. That means that the integrated commit can be bootstrapped and tested (and all tests are green). Moreover, running the tests after integration (and its build color) does not change the integration in itself: the commit was already merged and pushed into the main branch, so even if it fails always, it's too late. So, relaunching the build does not really change anything (besides the impression we may have about the build). A complementary solution (that should go together with fixing the tests) is to add a retry policy while running tests in the CI. >> Note, is there some brave soul that would like to take action here? Guille, on holidays from the phone. On 8/22/17, Marcus Denker <marcus.denker(a)inria.fr> wrote: > [ Pharo 70 ] Build 52 PR 205 > index-inst-var-should-move-from-Slot-to-IndexedSlot > https://github.com/pharo-project/pharo/pull/205 > https://pharo.fogbugz.com/f/cases/20191 > > Build 53: failed, redone as 54 > > [ Pharo 70 ] Build 54 PR 193 Integrate WebBrowser-Core package to be able to > open a browser on a URL > https://pharo.fogbugz.com/f/cases/20304 > https://github.com/pharo-project/pharo/pull/193 > > Build 55: failed, redone as 56 (I do not like to use this build numberâ¦ > with builds failing, we will always get the > question âand what was in build XX?). > > [ Pharo 70 ] Build 56 PR 174 > 20260-FastTable-not-support-cell-morphs-with-stepping-animation #174 > https://github.com/pharo-project/pharo/pull/174 > https://pharo.fogbugz.com/f/cases/20260/ > > > -- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

Aug. 22, 2017

SystemVersion>>highestUpdate causes FFISharedPool class>>initialize to fail

by Alistair Grant

Hi Everyone, I'm attempting to update to the latest Pharo7 image (918efe2, 32 bit), but am getting an error while loading OSsubprocess. The error occurs in FFISharedPool class>>initialize: initialize self flag: #removeIt. "This IF will be eliminated soon...only here temporary" (SystemVersion current highestUpdate >= 50558) ifTrue: [ SessionManager default registerToolClassNamed: self name ] ifFalse: [ Smalltalk addToStartUpList: self. ] because #highestUpdate is nil. The top of the stack is: UndefinedObject(Object)>>doesNotUnderstand: #'>=' FFISharedPool class>>initialize MCMethodDefinition>>postloadOver: [ :each | each postloadOver: (self obsoletionFor: each) ] in MCPackageLoader>>basicLoadDefinitions in Block: [ :each | each postloadOver: (self obsoletionFor: ...etc... Based on the method above, it looks like highestUpdate used to be set based on the image number, and has presumably broken during the move to Pharo 7 and git. Earlier Pharo 7 images had it set to 0, which doesn't sound right. Since a build number was recently introduced (fogbugz 20321), should the highestUpdate be set to 70000+buildNumber? E.g. this image has an identifier of: Pharo 7.0 Build information: alpha.build.56.sha.918efe28fa3e6ad485b059dbf4ce675fd4086cf6 So highestUpdate would be 70056. Thanks! Alistair

Aug. 22, 2017

[ Pharo 70 ] Build 52 to 54

by Marcus Denker

[ Pharo 70 ] Build 52 PR 205 index-inst-var-should-move-from-Slot-to-IndexedSlot https://github.com/pharo-project/pharo/pull/205 https://pharo.fogbugz.com/f/cases/20191 Build 53: failed, redone as 54 [ Pharo 70 ] Build 54 PR 193 Integrate WebBrowser-Core package to be able to open a browser on a URL https://pharo.fogbugz.com/f/cases/20304 https://github.com/pharo-project/pharo/pull/193 Build 55: failed, redone as 56 (I do not like to use this build numberâ¦ with builds failing, we will always get the question âand what was in build XX?). [ Pharo 70 ] Build 56 PR 174 20260-FastTable-not-support-cell-morphs-with-stepping-animation #174 https://github.com/pharo-project/pharo/pull/174 https://pharo.fogbugz.com/f/cases/20260/

Aug. 22, 2017

Re: [Pharo-dev] TechTalk Dates for the rest of 2017

by Marcus Denker

> On 22 Aug 2017, at 13:02, Alexandre Bergel <alexandre.bergel(a)me.com> wrote: > >>> I'm not sure Pharo tech talk is the good place but would love to see such a presentation. >>> >> Why not? I am sure Alex will have some code in there.. " programming, from scratch, a small artificial intelligenceâ >> if done with Pharo would be a very nice thing todo for the tech talk. > > Yes, that is the plan. It could be a very practical lecture, with a lot of coding (but not many lines of code). > I added it for October 17th: https://association.pharo.org/event-2642664 Marcus

Aug. 22, 2017