April 2017 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] ftp repositories broken

by Eliot Miranda

On Tue, Apr 4, 2017 at 10:00 AM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > 2017-04-04 18:45 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > >> > I think you are wrong because I check it carefully in Squeak and I >> found it on github https://github.com/OpenSmallta >> lk/opensmalltalk-vm/search?utf8=â&q=primitiveFindSubstring&type=. >> >> >> still is not there, because is not the same primitive :) >> > > Does it also means that latest VM is built differently then stable? > (primitive works on stable pharo). I just thought that we already moved to > opensmalltalk build process. > Not yet. We are close. Last week I got angry with Esteban because I thought that the joe was stalled because Pharo didn't want to move to opensmalltalk-vm, but I over reacted. One of the issues preventing the move was indeed this primitive and the fact that someone, without thinking to talk to anyone working with the VM, renamed the primitive, and then someone put it on the wrong class. Esteban and I have spent some hours trying to work around such issues. I wish people would be more considerate. If issues like this can be resolved we are very close to using the opensmalltalk-vm process for stable Pharo VMs. Esteban wants (and has built) a test build that tries to produce sources and generate Vs and runs tests every time VMMaker is committed. On the Squeak side we only try and build VMs when opensmalltalk-vm is committed in git. I don't want to stand in Esteban's way. I *do* want stable VMs to be built from the opensmalltalk-vm tree. _,,,^..^,,,_ best, Eliot

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Eliot Miranda

Hi Denis, On Tue, Apr 4, 2017 at 9:53 AM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > 2017-04-04 18:45 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > >> still is not there, because is not the same primitive :) >> look, this is the way where it is generated: >> >> translatedPrimitives >> "an assorted list of various primitives" >> (ByteString compiledMethodAt: #findSubstringViaPrimitive:in:startingAt:matchTable: >> ifAbsent: []) ifNotNil: >> [^#("Pharo uses findSubstringViaPrimitive:in:startingAt:matchTable:" >> (Bitmap compress:toByteArray:) >> (Bitmap decompress:fromByteArray:at:) >> (Bitmap encodeBytesOf:in:at:) >> (Bitmap encodeInt:in:at:) >> (ByteString compare:with:collated:) >> (ByteString translate:from:to:table:) >> (ByteString findFirstInString:inSet:startingAt:) >> (ByteString indexOfAscii:inString:startingAt:) >> (String findSubstringViaPrimitive:in:startingAt:matchTable:) >> (ByteArray hashBytes:startingWith:) >> (SampledSound convert8bitSignedFrom:to16Bit:))]. >> ^#( >> (Bitmap compress:toByteArray:) >> (Bitmap decompress:fromByteArray:at:) >> (Bitmap encodeBytesOf:in:at:) >> (Bitmap encodeInt:in:at:) >> (ByteString compare:with:collated:) >> (ByteString translate:from:to:table:) >> (ByteString findFirstInString:inSet:startingAt:) >> (ByteString indexOfAscii:inString:startingAt:) >> (ByteString findSubstring:in:startingAt:matchTable:) >> (ByteArray hashBytes:startingWith:) >> (SampledSound convert8bitSignedFrom:to16Bit:) >> ) >> >> means that Pharo uses #indSubstringViaPrimitive:in:startingAt:matchTable: >> while squeak uses #findSubstring:in:startingAt:matchTable:. >> > > Ok maybe I not understand anything :) But to clarify lets look at image > side methods. > in Squeak: > > ByteString>>findSubstring: key in: body startingAt: start matchTable: > matchTable > <primitive: 'primitiveFindSubstring' module: 'MiscPrimitivePlugin'> > > > in Pharo: > > String>>findSubstringViaPrimitive: key in: body startingAt: start > matchTable: matchTable > <primitive: 'primitiveFindSubstring' module: 'MiscPrimitivePlugin'> > > > So to me they both uses same VM primitive primitiveFindSubstring. Does > they are really different inside VM? > No they're not different; they're the same. But the primitive works only with ByteString, so it should not be on String where it will try and work on WideString and return completely incorrect results. -- _,,,^..^,,,_ best, Eliot

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Esteban Lorenzano

> On 4 Apr 2017, at 19:00, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > > 2017-04-04 18:45 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com <mailto:estebanlm@gmail.com>>: >> > I think you are wrong because I check it carefully in Squeak and I found it on github https://github.com/OpenSmalltalk/opensmalltalk-vm/search?utf8=â&q=primiti… <https://github.com/OpenSmalltalk/opensmalltalk-vm/search?utf8=%E2%9C%93&q=p…>. > > still is not there, because is not the same primitive :) > > Does it also means that latest VM is built differently then stable? (primitive works on stable pharo). I just thought that we already moved to opensmalltalk build process. stable works because the bug ByteString>>#findâ¦ instead of String>>#findâ¦ was introduced later.

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Denis Kudriashov

2017-04-04 18:45 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > > I think you are wrong because I check it carefully in Squeak and I found > it on github https://github.com/OpenSmalltalk/opensmalltalk- > vm/search?utf8=â&q=primitiveFindSubstring&type=. > > > still is not there, because is not the same primitive :) > Does it also means that latest VM is built differently then stable? (primitive works on stable pharo). I just thought that we already moved to opensmalltalk build process.

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Eliot Miranda

Hi Esteban, > On Apr 4, 2017, at 9:45 AM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > >> On 4 Apr 2017, at 18:01, Ben Coman <btc(a)openInWorld.com> wrote: >> >> >> >> On Tue, Apr 4, 2017 at 10:12 PM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: >> > >> > >> > 2017-04-04 15:47 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: >> >> >> >> no it doesn't: squeak does not have that primitive, thatâs why it does not fails :) >> > >> > >> > I think you are wrong because I check it carefully in Squeak and I found it on github https://github.com/OpenSmalltalk/opensmalltalk-vm/search?utf8=â&q=primiti…. > > still is not there, because is not the same primitive :) > look, this is the way where it is generated: > > translatedPrimitives > "an assorted list of various primitives" > (ByteString compiledMethodAt: #findSubstringViaPrimitive:in:startingAt:matchTable: ifAbsent: []) ifNotNil: > [^#("Pharo uses findSubstringViaPrimitive:in:startingAt:matchTable:" > (Bitmap compress:toByteArray:) > (Bitmap decompress:fromByteArray:at:) > (Bitmap encodeBytesOf:in:at:) > (Bitmap encodeInt:in:at:) > (ByteString compare:with:collated:) > (ByteString translate:from:to:table:) > (ByteString findFirstInString:inSet:startingAt:) > (ByteString indexOfAscii:inString:startingAt:) > (String findSubstringViaPrimitive:in:startingAt:matchTable:) > (ByteArray hashBytes:startingWith:) > (SampledSound convert8bitSignedFrom:to16Bit:))]. > ^#( > (Bitmap compress:toByteArray:) > (Bitmap decompress:fromByteArray:at:) > (Bitmap encodeBytesOf:in:at:) > (Bitmap encodeInt:in:at:) > (ByteString compare:with:collated:) > (ByteString translate:from:to:table:) > (ByteString findFirstInString:inSet:startingAt:) > (ByteString indexOfAscii:inString:startingAt:) > (ByteString findSubstring:in:startingAt:matchTable:) > (ByteArray hashBytes:startingWith:) > (SampledSound convert8bitSignedFrom:to16Bit:) > ) > > means that Pharo uses #indSubstringViaPrimitive:in:startingAt:matchTable: while squeak uses #findSubstring:in:startingAt:matchTable:. > Now, there is a bug there (because source is in String and not in ByteString), and I can fix that by asking correctly, but: > > 1) this means that sources for pharo and squeak will be different and pharo needs to be generated in pharo. This is contrary to what we are trying to do with the VM: we want all sources to be the same, and differences should come from compilation flags and/or the presence of certain plugins (this is because is a lot easier to debug the VM like that). > 2) I wonderâ¦ why we are using this primitive an squeak is not? maybe we need to deprecate the use? > >> I believe Esteban's point Its not so much whether the VM has it >> (since they are essentially the same VM + extra C-libs for Pharo) >> but whether the Squeak Image is using it. >> >> Squeak does use primitiveFindSubstring, but a difference is attached to ByteString rather than String. >> That was added to Squeak 2015.05.01. Squeak String seems to have never used the primitive (since 2005). > > this is the important thing, I thinkâ¦ soâ¦ why canât we use that instead the other one? > whatâs the difference? You have identified the problem. The bug is that Pharo broke this by renaming and repositioning the primitive to findSubstringViaPrimitive:in:startingAt:matchTable:. If it had stayed where it was things would still be working. So my suggestions are a) restore Pharo to using by the primitive correctly in the exactly the same configuration as Squeak b) no one in the Pharo community changes the definition or position of a primitive without consulting a vm person (and Esteban is a vm person as is ClÃ©ment and arguably Guille). c) we measure the performance of the primitive and the equivalent non-primitive code in StackInterpreter, Cog and Sista configurations (using Spur, the current object representation) for a range of strings and see how much benefit we're getter by from the primitive; maybe we can nuke it. But yes, it is a bad bug to position this primitive in String; it works only for ByteString. > > cheers! > Esteban > > >> >> A diff shows some differences in implementation.. >> https://www.diffchecker.com/CmBJZjB6 >> which anyway wouldn't account for John's observations. >> >> cheers -ben >

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Denis Kudriashov

2017-04-04 18:01 GMT+02:00 Ben Coman <btc(a)openinworld.com>: > > I believe Esteban's point Its not so much whether the VM has it > (since they are essentially the same VM + extra C-libs for Pharo) > but whether the Squeak Image is using it. > > Squeak does use primitiveFindSubstring, but a difference is attached to > ByteString rather than String. > That was added to Squeak 2015.05.01. Squeak String seems to have never > used the primitive (since 2005). You can make experiment. Replace fallback code with "self primitiveFailed" and call this method from comment examples. It works in SqueakVM. And it fails with latest PharoVM. Actually just remove this method from ByteString. And many debuggers will approve that method is used

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Denis Kudriashov

2017-04-04 18:45 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > still is not there, because is not the same primitive :) > look, this is the way where it is generated: > > translatedPrimitives > "an assorted list of various primitives" > (ByteString compiledMethodAt: #findSubstringViaPrimitive:in:startingAt:matchTable: > ifAbsent: []) ifNotNil: > [^#("Pharo uses findSubstringViaPrimitive:in:startingAt:matchTable:" > (Bitmap compress:toByteArray:) > (Bitmap decompress:fromByteArray:at:) > (Bitmap encodeBytesOf:in:at:) > (Bitmap encodeInt:in:at:) > (ByteString compare:with:collated:) > (ByteString translate:from:to:table:) > (ByteString findFirstInString:inSet:startingAt:) > (ByteString indexOfAscii:inString:startingAt:) > (String findSubstringViaPrimitive:in:startingAt:matchTable:) > (ByteArray hashBytes:startingWith:) > (SampledSound convert8bitSignedFrom:to16Bit:))]. > ^#( > (Bitmap compress:toByteArray:) > (Bitmap decompress:fromByteArray:at:) > (Bitmap encodeBytesOf:in:at:) > (Bitmap encodeInt:in:at:) > (ByteString compare:with:collated:) > (ByteString translate:from:to:table:) > (ByteString findFirstInString:inSet:startingAt:) > (ByteString indexOfAscii:inString:startingAt:) > (ByteString findSubstring:in:startingAt:matchTable:) > (ByteArray hashBytes:startingWith:) > (SampledSound convert8bitSignedFrom:to16Bit:) > ) > > means that Pharo uses #indSubstringViaPrimitive:in:startingAt:matchTable: > while squeak uses #findSubstring:in:startingAt:matchTable:. > Ok maybe I not understand anything :) But to clarify lets look at image side methods. in Squeak: ByteString>>findSubstring: key in: body startingAt: start matchTable: matchTable <primitive: 'primitiveFindSubstring' module: 'MiscPrimitivePlugin'> in Pharo: String>>findSubstringViaPrimitive: key in: body startingAt: start matchTable: matchTable <primitive: 'primitiveFindSubstring' module: 'MiscPrimitivePlugin'> So to me they both uses same VM primitive primitiveFindSubstring. Does they are really different inside VM?

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Esteban Lorenzano

> On 4 Apr 2017, at 18:01, Ben Coman <btc(a)openInWorld.com> wrote: > > > > On Tue, Apr 4, 2017 at 10:12 PM, Denis Kudriashov <dionisiydk(a)gmail.com <mailto:dionisiydk@gmail.com>> wrote: > > > > > > 2017-04-04 15:47 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com <mailto:estebanlm@gmail.com>>: > >> > >> no it doesn't: squeak does not have that primitive, thatâs why it does not fails :) > > > > > > I think you are wrong because I check it carefully in Squeak and I found it on github https://github.com/OpenSmalltalk/opensmalltalk-vm/search?utf8=â&q=primiti… <https://github.com/OpenSmalltalk/opensmalltalk-vm/search?utf8=%E2%9C%93&q=p…>. still is not there, because is not the same primitive :) look, this is the way where it is generated: translatedPrimitives "an assorted list of various primitives" (ByteString compiledMethodAt: #findSubstringViaPrimitive:in:startingAt:matchTable: ifAbsent: []) ifNotNil: [^#("Pharo uses findSubstringViaPrimitive:in:startingAt:matchTable:" (Bitmap compress:toByteArray:) (Bitmap decompress:fromByteArray:at:) (Bitmap encodeBytesOf:in:at:) (Bitmap encodeInt:in:at:) (ByteString compare:with:collated:) (ByteString translate:from:to:table:) (ByteString findFirstInString:inSet:startingAt:) (ByteString indexOfAscii:inString:startingAt:) (String findSubstringViaPrimitive:in:startingAt:matchTable:) (ByteArray hashBytes:startingWith:) (SampledSound convert8bitSignedFrom:to16Bit:))]. ^#( (Bitmap compress:toByteArray:) (Bitmap decompress:fromByteArray:at:) (Bitmap encodeBytesOf:in:at:) (Bitmap encodeInt:in:at:) (ByteString compare:with:collated:) (ByteString translate:from:to:table:) (ByteString findFirstInString:inSet:startingAt:) (ByteString indexOfAscii:inString:startingAt:) (ByteString findSubstring:in:startingAt:matchTable:) (ByteArray hashBytes:startingWith:) (SampledSound convert8bitSignedFrom:to16Bit:) ) means that Pharo uses #indSubstringViaPrimitive:in:startingAt:matchTable: while squeak uses #findSubstring:in:startingAt:matchTable:. Now, there is a bug there (because source is in String and not in ByteString), and I can fix that by asking correctly, but: 1) this means that sources for pharo and squeak will be different and pharo needs to be generated in pharo. This is contrary to what we are trying to do with the VM: we want all sources to be the same, and differences should come from compilation flags and/or the presence of certain plugins (this is because is a lot easier to debug the VM like that). 2) I wonderâ¦ why we are using this primitive an squeak is not? maybe we need to deprecate the use? > I believe Esteban's point Its not so much whether the VM has it > (since they are essentially the same VM + extra C-libs for Pharo) > but whether the Squeak Image is using it. > > Squeak does use primitiveFindSubstring, but a difference is attached to ByteString rather than String. > That was added to Squeak 2015.05.01. Squeak String seems to have never used the primitive (since 2005). this is the important thing, I thinkâ¦ soâ¦ why canât we use that instead the other one? whatâs the difference? cheers! Esteban > > A diff shows some differences in implementation.. > https://www.diffchecker.com/CmBJZjB6 <https://www.diffchecker.com/CmBJZjB6> > which anyway wouldn't account for John's observations. > > cheers -ben

April 4, 2017

Re: [Pharo-dev] ftp repositories broken

by Ben Coman

On Tue, Apr 4, 2017 at 10:12 PM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > > 2017-04-04 15:47 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: >> >> no it doesn't: squeak does not have that primitive, thatâs why it does not fails :) > > > I think you are wrong because I check it carefully in Squeak and I found it on github https://github.com/OpenSmalltalk/opensmalltalk-vm/search?utf8=â&q=primiti… . I believe Esteban's point Its not so much whether the VM has it (since they are essentially the same VM + extra C-libs for Pharo) but whether the Squeak Image is using it. Squeak does use primitiveFindSubstring, but a difference is attached to ByteString rather than String. That was added to Squeak 2015.05.01. Squeak String seems to have never used the primitive (since 2005). A diff shows some differences in implementation.. https://www.diffchecker.com/CmBJZjB6 which anyway wouldn't account for John's observations. cheers -ben

April 4, 2017

Re: [Pharo-dev] Glamour Fast List selection bug or incorrect usage?

by Juraj Kubelka

Hi, yes, it is better, but it does not work intuitively. Try the following: 1. execute your script, 2. click on 4 (selection), 3. click on 8 (selection), 4. click on 4 (deselection), 5. click on 4 (selection) You can see that the third list still keeps the number 8. It is necessary to deselect 8 in order to see 4. This part explains to me how the transmit works: ``` tabulator transmit from: #one; to: #three; from: #two; to: #three; transformed: [ :x :y | y ifNil: [ x ] ifNotNil: [ y ] ]; andShow: [ :a | a fastList display: [ :x | Array with: x ] ]. ``` By using #transformed: I can decide what to use (#one or #two). It is nice feature! I think what I need is having to possibility to change the third list also according to what list is active (#one or #two). In the first screenshot, the first list is active (blue border). In the second screenshot, the second list is active. So I would like to update the third list according to the active one. Is it possible? Thanks! Juraj > On Apr 3, 2017, at 18:53, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > > Hi, > > That's actually the default behavior, but I see there is also a bug. > Normally if you want to allow deselection in a presentation you should use allowDeselection. Just I see there is a bug in the fast table renderer because if I add #allowDeselection to the first presentation when clicking again on the selected element the selection port is not cleared. If you use #list instead of #fastList it works. > > I think you can get the desired behaviur using this code: > > ----------------------------------------------------------------- > tabulator := GLMTabulator new. > > tabulator column: #one; column: #two; column: #three. > > tabulator transmit to: #one; andShow: [ :composite | > composite list > allowDeselection; > display: [ :x | Array with: x ] ]. > tabulator transmit to: #two; andShow: [ :composite | > composite list > allowDeselection; > display: [ :x | Array with: 2 * x ] ]. > > tabulator transmit > from: #one; to: #three; > from: #two; to: #three; > transformed: [ :x :y | y ifNil: [ x ] ifNotNil: [ y ] ]; > andShow: [ :a | > a fastList display: [ :x | Array with: x ] ]. > > tabulator openOn: 4. > ----------------------------------------------------------------- > > > Cheers, > Andrei > > On Mon, Apr 3, 2017 at 9:35 PM, Juraj Kubelka <juraj.kubelka(a)icloud.com <mailto:juraj.kubelka@icloud.com>> wrote: > Hi! > > If you create the following Glamour browser: > > ``` > tabulator := GLMTabulator new. > > tabulator column: #one; column: #two; column: #three. > > tabulator transmit to: #one; andShow: [ :composite | > composite fastList display: [ :x | Array with: x ] ]. > tabulator transmit to: #two; andShow: [ :composite | > composite fastList display: [ :x | Array with: 2 * x ] ]. > > tabulator transmit from: #one; to: #three; andShow: [ :a | > a fastList display: [ :x | Array with: x ] ]. > tabulator transmit from: #two; to: #three; andShow: [ :a | > a fastList display: [ :x | Array with: x ] ]. > > tabulator openOn: 4. > ``` > > You will get the following browser: > > <Screen Shot 2017-04-03 at 16.30.28.png> > > if you then select 4, the third list appears. If you then select 8, the value is changed: > > <Screen Shot 2017-04-03 at 16.29.38.png> > > But since then, the third list does not change. It stays with 8 value forever. > > Do I miss something? Should I define it differently? > Or if it is a bug: Can you give me insights how to fix it? > > Tested in the latest Pharo 6. > > Thanks! > Juraj > >

April 4, 2017