January 2017 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] d51704: 60343

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: d51704f977be4ab9d11b0db83377a8b9b02085d8 https://github.com/pharo-project/pharo-core/commit/d51704f977be4ab9d11b0db8… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-01-11 (Wed, 11 Jan 2017) Changed paths: A GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/class/testing/isAbstract.st M GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/definition.st A GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/instance/accessing/actualPreferencesFileName.st R GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/instance/accessing/fileName.st M GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/instance/running/setUp.st M GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/instance/running/setUpPersistenceStrategy.st M GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/instance/running/tearDown.st M GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/instance/tests/testEnsure.st A GT-EventRecorder-Tests.package/GlobalIdentifierTest.class/instance/tests/testPreferenceFilesNotCollideWithRealPreferences.st A GT-EventRecorder-Tests.package/GlobalIdentifierWithDefaultConfiguration.class/README.md A GT-EventRecorder-Tests.package/GlobalIdentifierWithDefaultConfiguration.class/definition.st A GT-EventRecorder-Tests.package/GlobalIdentifierWithDefaultConfiguration.class/instance/accessing/oldPreferencesFileName.st A GT-EventRecorder-Tests.package/GlobalIdentifierWithDefaultConfiguration.class/instance/initialization/setUpPersistenceStrategy.st A GT-EventRecorder-Tests.package/GlobalIdentifierWithDefaultConfiguration.class/instance/running/tearDown.st A GT-EventRecorder-Tests.package/GlobalIdentifierWithDefaultConfiguration.class/instance/tests/testEnsure.st A GT-EventRecorder-Tests.package/GlobalIdentifierWithFuel.class/instance/accessing/actualPreferencesFileName.st R GT-EventRecorder-Tests.package/GlobalIdentifierWithFuel.class/instance/accessing/fileName.st A GT-EventRecorder-Tests.package/GlobalIdentifierWithSton.class/instance/accessing/actualPreferencesFileName.st R GT-EventRecorder-Tests.package/GlobalIdentifierWithSton.class/instance/accessing/fileName.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60342.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60343.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60342.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60343.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Traits.package/TBehavior.class/instance/accessing method dictionary/lookupSelector_.st Log Message: ----------- 60343 19532 Improve TBehaviour >> lookupSelector: https://pharo.fogbugz.com/f/cases/19532 19501 GlobalIdentifierTest leaves a file present in $data directory https://pharo.fogbugz.com/f/cases/19501 http://files.pharo.org/image/60/60343.zip

Jan. 11, 2017

Re: [Pharo-dev] Strange DNU effect on Windows with Pastell

by Esteban Lorenzano

> On 11 Jan 2017, at 10:12, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > at least we should rename it as âtreeMorphHeadââ¦ just âheadâ is too generic. âtreeNodeHeadâ I meant. > > Esteban > > >> On 11 Jan 2017, at 10:03, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> >>> On 11 Jan 2017, at 09:55, Torsten Bergmann <astares(a)gmx.de> wrote: >>> >>>> But why the hell would there be a Object>>#head ?! >>>> >>>> IMHO such general selectors at this level should not be used unless there is a very good reason to do so. >>>> >>> >>> Yes - some Morphic addition. Version says: BenjaminVanRyseghem in 2013 >>> Only used in MorphTreeNodeMorph and to me this smells. We should nuke it. >>> >>> Thx >>> T. >> >> Looking in a 6 image, there is also an even uglier implementation in >> >> Association>>#head >> >> ^ (key isKindOf: Association) >> ifTrue: [ key head ] >> ifFalse: [ key ] >> >> Duh. >> >> And I can't seen any senders... >> >> >

Jan. 11, 2017

Re: [Pharo-dev] Strange DNU effect on Windows with Pastell

by Esteban Lorenzano

at least we should rename it as âtreeMorphHeadââ¦ just âheadâ is too generic. Esteban > On 11 Jan 2017, at 10:03, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > >> On 11 Jan 2017, at 09:55, Torsten Bergmann <astares(a)gmx.de> wrote: >> >>> But why the hell would there be a Object>>#head ?! >>> >>> IMHO such general selectors at this level should not be used unless there is a very good reason to do so. >>> >> >> Yes - some Morphic addition. Version says: BenjaminVanRyseghem in 2013 >> Only used in MorphTreeNodeMorph and to me this smells. We should nuke it. >> >> Thx >> T. > > Looking in a 6 image, there is also an even uglier implementation in > > Association>>#head > > ^ (key isKindOf: Association) > ifTrue: [ key head ] > ifFalse: [ key ] > > Duh. > > And I can't seen any senders... > >

Jan. 11, 2017

Re: [Pharo-dev] Strange DNU effect on Windows with Pastell

by Sven Van Caekenberghe

> On 11 Jan 2017, at 09:55, Torsten Bergmann <astares(a)gmx.de> wrote: > >> But why the hell would there be a Object>>#head ?! >> >> IMHO such general selectors at this level should not be used unless there is a very good reason to do so. >> > > Yes - some Morphic addition. Version says: BenjaminVanRyseghem in 2013 > Only used in MorphTreeNodeMorph and to me this smells. We should nuke it. > > Thx > T. Looking in a 6 image, there is also an even uglier implementation in Association>>#head ^ (key isKindOf: Association) ifTrue: [ key head ] ifFalse: [ key ] Duh. And I can't seen any senders...

Jan. 11, 2017

Re: [Pharo-dev] Strange DNU effect on Windows with Pastell

by Torsten Bergmann

> But why the hell would there be a Object>>#head ?! > > IMHO such general selectors at this level should not be used unless there is a very good reason to do so. > Yes - some Morphic addition. Version says: BenjaminVanRyseghem in 2013 Only used in MorphTreeNodeMorph and to me this smells. We should nuke it. Thx T.

Jan. 11, 2017

Re: [Pharo-dev] Strange DNU effect on Windows with Pastell

by Sven Van Caekenberghe

> On 11 Jan 2017, at 09:33, Torsten Bergmann <astares(a)gmx.de> wrote: > > I've found it: > > Loading Pastell into latest image 60342 using: > > > Metacello new > smalltalkhubUser: 'Pharo' project: 'MetaRepoForPharo50'; > configuration: 'Pastell'; > version: #stable; > load. > > the tests are green now. > > And it is also not a difference between Mac and Windows > > > When the method looks like > > testDNU > | xml document html testElements | > xml := '<html><testElement/><testElement/></html>'. > document := XMLDOMParser parse: xml readStream. > html := document html. > testElements := html testElement. > self assert: testElements size = 2. > self assert: testElements first name = #testElement. > self assert: testElements last name = #testElement > > it works > > > When I exchange the tag "testElement" agains "head" it does not work as I reported > in my last mail: > > testDNU > | xml document html testElements | > xml := '<html><head/><head/></html>'. > document := XMLDOMParser parse: xml readStream. > html := document html. > testElements := html head. > self assert: testElements size = 2. > self assert: testElements first name = #head. > self assert: testElements last name = #head > > Now the assertions fail although only the tag name/message changed. > > Reason is simple: there is a #head method in Object from Morphic just returning > self. For whatever reason but this makes the difference. > > Lesson learned: take care with DNU tricks ;) > > Sorry for the noise! That's not noise, it is an interesting lesson ! But why the hell would there be a Object>>#head ?! IMHO such general selectors at this level should not be used unless there is a very good reason to do so. > Bye > T. > >

Jan. 11, 2017

Re: [Pharo-dev] Strange DNU effect on Windows with Pastell

by Torsten Bergmann

I've found it: Loading Pastell into latest image 60342 using: Metacello new smalltalkhubUser: 'Pharo' project: 'MetaRepoForPharo50'; configuration: 'Pastell'; version: #stable; load. the tests are green now. And it is also not a difference between Mac and Windows When the method looks like testDNU | xml document html testElements | xml := '<html><testElement/><testElement/></html>'. document := XMLDOMParser parse: xml readStream. html := document html. testElements := html testElement. self assert: testElements size = 2. self assert: testElements first name = #testElement. self assert: testElements last name = #testElement it works When I exchange the tag "testElement" agains "head" it does not work as I reported in my last mail: testDNU | xml document html testElements | xml := '<html><head/><head/></html>'. document := XMLDOMParser parse: xml readStream. html := document html. testElements := html head. self assert: testElements size = 2. self assert: testElements first name = #head. self assert: testElements last name = #head Now the assertions fail although only the tag name/message changed. Reason is simple: there is a #head method in Object from Morphic just returning self. For whatever reason but this makes the difference. Lesson learned: take care with DNU tricks ;) Sorry for the noise! Bye T.

Jan. 11, 2017

Re: [Pharo-dev] Which package includes GVGraphViz?

by HernÃ¡n Morales Durand

I don't know which package includes GV GraphViz classes, but in the current Tool-DependencyAnalysis there are missing/moved methods (like #ifGraphVizAbsent:). If you want to generate GraphViz visualizations (assuming you have GraphViz installed and binary path added in your PATH variable) you may load GraphViz from my repository. Metacello new smalltalkhubUser: 'hernan' project: 'GraphViz'; configuration: 'GraphViz'; version: #development; load: 'Tools'. In the Tools menu you will have a new entry named "Package Dependencies Browser" which you may use now. After you clicked "Generate GraphViz file", the generated graph will be available in the dot/ directory. It works at least on Windows. Cheers, HernÃ¡n 2017-01-09 11:07 GMT-03:00 Bernhard Pieber <bernhard(a)pieber.com>: > I just saw found the class DAGraphVizGenerator in Tool-DependencyAnalyser. > It references a class GVGraphViz by name. What package do I have to load to > get it? The GraphViz package in the Pharo Project Catalog does not use the > GV prefix. > > Cheers, > Bernhard >

Jan. 11, 2017

Strange DNU effect on Windows with Pastell

by Torsten Bergmann

I have a strange effect I was not able to find out so far. You can try with any newer Pharo image/VM but here are the exact combination I tried: 1. Load latest VM from https://dl.bintray.com/pharo-project/pharo-vm/ which is as of today (https://dl.bintray.com/pharo-project/pharo-vm/pharo-win-i386-201701091105-b…) Extract in a directory. 2. Download and extract http://files.pharo.org/sources/PharoV50.sources.zip into same directory 3. Use latest image http://files.pharo.org/image/60/60342.zip in same directory 4. Start Pharo and load "Pastell" Metacello new smalltalkhubUser: 'Pharo' project: 'MetaRepoForPharo50'; configuration: 'Pastell'; version: #stable; load. 5. Put some Transcript output into: XMLNodeWithElements>>#doesNotUnderstand: by changing it to: doesNotUnderstand: aMessage "If I have one or more childs whose name is the same as the selector, return them in a PastellCollection. Otherwise, let the DNU propagate" | v | Transcript show: aMessage selector asString;cr. v := self child: aMessage selector. ^ v ifEmpty: [ super doesNotUnderstand: aMessage ] ifNotEmpty: [ v ]. 6. Now evaluate: | xml document htmls html heads | Transcript open;clear. xml := '<html> <head></head> <head></head> </html>'. document := XMLDOMParser parse: xml readStream. htmls := document html. "gives a pastell collection using the #doesNotUnderstand: trick" html := htmls first. "first element from collection, the class is XMLElement, a subclass of XMLNodeWithElements" html head "should call #doesNotUnderstand: again in XMLNodeWithElements but it is not" As you see the #html message triggers the #doesNotUnderstand: while #head does not. For strange reasons the XMLNodeWithElements>>#doesNotUnderstand: is only called once and then not anymore. Did I miss something? Last time Pastell worked was in Pharo 3.0. Is this a Cog issue or something I do not see? It seems to work on Mac (according to Stephan Eggermont). Any idea? Thanks T.

Jan. 11, 2017

Pharo Days 2017: Date?

by Marcus Denker

We checked which dates would make senseâ¦ the idea would be to do it after the release of Pharo6. For the place we are checking Lille, we can get some support from Inria/the University for doing a small event like this. The best here is April, either before or after school holidays. To know if this makes any sense, we have set up a doodle: http://doodle.com/poll/f8n5zhv7p8fqwyih Marcus

Jan. 11, 2017