September 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] SUnit improvements need review and feedback

by Denis Kudriashov

Super!!! It's integrated (In 60201). Thank's integrators. Now we need correct default time limit and mark long tests as long. I opened new issue 19035 <https://pharo.fogbugz.com/f/cases/19035/Default-time-limit-for-tests-should…> . What you think about default value? I would use 200 milliseconds. 2016-08-31 14:10 GMT+02:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > Hi. > > I am working on SUnit improvements. I open issue 19015 > <https://pharo.fogbugz.com/f/cases/19015/Tests-should-never-hang-and-leave-f…>. > Slice is inbox which waits your review and feedback. > I was trying to address three problems: > > *1) Tests should never hang. They should be always executed within time > limit.* > > I give them 10 minutes for now to not change existing behaviour of tests. > At next step it should be really reduced to ~100 milliseconds (?). > Any TestCase could redefine time limit by method #defaultTimeLimit. > Or it could be specified directly in test code by > self timeLimit: 10 seconds > (could be changed at any time of test execution). > > To implement this logic special watch dog process is running for given > test suite to control execution time of tests. It is single process for > full test suite. > > *2) When test completes all forked processes should be terminated.* > > If your tested code produced zombie processes SUnit will take care about > destroying all such garbage. > (it not means that you don't need to clean table in #tearDown but any code > could be broken and running tests should not produce dirty system). > > *3) Any failures inside forked processes should not spawn debugger while > running tests.* > Only when we debug tests we need debugger on forked failed processes. > During normal run SUnit should prevent such "background debuggers" and > mark such tests as failed. > > To implement this behaviour SUnit will handle errors from forked processes > by suspending them and collecting them in special collection. > I introduce TestFailedByForkedProcess error to signal these kind of > problems at the end of tests. This error is resumable and resume will opens > debuggers of suspended failures (in fact it will resume suspended > processes). > So to debug background failures you will need extra Proceed action on > debugger when TestFailedByForkedProcess is signalled. > But in normal run such tests will be just failed by > TestFailedByForkedProcess error. > > *Now details on how it is done:* > > I introduce special process specific variable CurrentExecutionEnvironment. > It is not installed by default and as default value it returns > DefaultExecutionEnvironment instance. > This variable is inheritable. If your install concrete environment into > process it will be installed to any child process. > > So value of variable is instance of ExecutionEnvironment subclasses and > you can install it by: > > anYourExecutionEnvironment beActiveDuring: aBlock > > > When block completes previous environment is restored. > For default environment there is class side method: > > DefaultExecutionEnvironment beActiveDuring: aBlock > > > And to reset current environment to default: > > DefaultExecutionEnvironment beActive. > > > SUnit introduces TestExecutionEnvironment which implements all described > behaviour for time limits and forked processes. > To activate environment there is new method #runCaseManaged. And submitted > slice uses it instead of simple runCase. > > TestCase>>runCaseManaged > CurrentExecutionEnvironment runTestCase: self > > > DefaultExecutionEnvironment will install new TestExecutionEnvironment and > delegate processing to it. And if TestExecutionEnvironment is already > active it will just process new test case. > > Now monkey has problem in checking slice (annoying timeout for loading). > So I can't see real system impact. But it should not stop you from review > :)) > I think it is very important features for all our tests. And environment > idea will lead to very interesting future. > > Best regards, > Denis >

Sept. 3, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60201 Home: https://github.com/pharo-project/pharo-core

Sept. 3, 2016

[pharo-project/pharo-core] 6935ea: 60201

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 6935ea9aa84fa515949c012d529437e1319e763f https://github.com/pharo-project/pharo-core/commit/6935ea9aa84fa515949c012d… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-09-03 (Sat, 03 Sep 2016) Changed paths: M Kernel-Tests.package/BlockClosureTest.class/instance/tests - on-fork/testOnForkErrorExecutesBlock.st A Kernel-Tests.package/ExecutionEnvironmentStub.class/README.md A Kernel-Tests.package/ExecutionEnvironmentStub.class/definition.st A Kernel-Tests.package/ExecutionEnvironmentStub.class/instance/accessing/forkedProcesses.st A Kernel-Tests.package/ExecutionEnvironmentStub.class/instance/accessing/forkedProcesses_.st A Kernel-Tests.package/ExecutionEnvironmentStub.class/instance/controlling/prepareForNewProcess_.st A Kernel-Tests.package/ExecutionEnvironmentStub.class/instance/initialization/initialize.st A Kernel-Tests.package/ProcessSpecificTest.class/instance/testing/testExecutionEnvironment.st A Kernel-Tests.package/ProcessSpecificTest.class/instance/testing/testInheritingExecutionEnvironment.st A Kernel.package/CurrentExecutionEnvironment.class/README.md A Kernel.package/CurrentExecutionEnvironment.class/class/controlling/activate_for_.st A Kernel.package/CurrentExecutionEnvironment.class/class/controlling/restoreDefault.st A Kernel.package/CurrentExecutionEnvironment.class/class/testing/isInheritable.st A Kernel.package/CurrentExecutionEnvironment.class/definition.st A Kernel.package/CurrentExecutionEnvironment.class/instance/accessing/default.st A Kernel.package/CurrentExecutionEnvironment.class/instance/inheriting/installValue_intoForked_from_.st A Kernel.package/DefaultExecutionEnvironment.class/README.md A Kernel.package/DefaultExecutionEnvironment.class/class/accessing/instance.st A Kernel.package/DefaultExecutionEnvironment.class/class/controlling/beActive.st A Kernel.package/DefaultExecutionEnvironment.class/class/controlling/beActiveDuring_.st A Kernel.package/DefaultExecutionEnvironment.class/definition.st A Kernel.package/DefaultExecutionEnvironment.class/instance/controlling/prepareForNewProcess_.st A Kernel.package/ExecutionEnvironment.class/README.md A Kernel.package/ExecutionEnvironment.class/definition.st A Kernel.package/ExecutionEnvironment.class/instance/controlling/activated.st A Kernel.package/ExecutionEnvironment.class/instance/controlling/beActiveDuring_.st A Kernel.package/ExecutionEnvironment.class/instance/controlling/deactivated.st A Kernel.package/ExecutionEnvironment.class/instance/controlling/prepareForNewProcess_.st M Kernel.package/Float.class/instance/truncation and round off/round_.st M Kernel.package/Fraction.class/instance/truncation and round off/round_.st M Kernel.package/Integer.class/instance/truncation and round off/round_.st M Kernel.package/Number.class/instance/truncation and round off/round_.st A Morphic-Widgets-FastTable.package/FTColumn.class/instance/accessing/transform_.st M Morphic-Widgets-FastTable.package/FTDataSource.class/instance/accessing/newDataSourceMatching_.st A Morphic-Widgets-FastTable.package/FTFilter.class/README.md A Morphic-Widgets-FastTable.package/FTFilter.class/class/instance creation/pattern_.st A Morphic-Widgets-FastTable.package/FTFilter.class/definition.st A Morphic-Widgets-FastTable.package/FTFilter.class/instance/accessing/pattern.st A Morphic-Widgets-FastTable.package/FTFilter.class/instance/accessing/pattern_.st A Morphic-Widgets-FastTable.package/FTFilter.class/instance/matching/matches_.st M Morphic-Widgets-FastTable.package/FTFilterFunction.class/definition.st A Morphic-Widgets-FastTable.package/FTFilterFunction.class/instance/accessing/filterClass.st A Morphic-Widgets-FastTable.package/FTFilterFunction.class/instance/accessing/filterClass_.st M Morphic-Widgets-FastTable.package/FTFilterFunction.class/instance/event handling/keyStroke_.st A Morphic-Widgets-FastTable.package/FTFilterFunction.class/instance/initialization/initialize.st M Morphic-Widgets-FastTable.package/FTFilterFunction.class/instance/updating/filter.st A Morphic-Widgets-FastTable.package/FTFilterFunctionWithAction.class/instance/accessing/beExplicite.st A Morphic-Widgets-FastTable.package/FTFunction.class/instance/accessing/beExplicite.st A Morphic-Widgets-FastTable.package/FTFunctionWithField.class/instance/accessing/beExplicite.st A Morphic-Widgets-FastTable.package/FTNilFunction.class/instance/accessing/beExplicite.st M Morphic-Widgets-FastTable.package/FTOutlineDataSource.class/instance/accessing/newDataSourceMatching_.st M Morphic-Widgets-FastTable.package/FTPluggableIconListMorphAdaptorDataSource.class/instance/accessing/cellColumn_row_.st A Morphic-Widgets-FastTable.package/FTPluggableIconListMorphAdaptorDataSource.class/instance/accessing/elements.st M Morphic-Widgets-FastTable.package/FTPluggableIconListMorphAdaptorDataSource.class/instance/accessing/newDataSourceMatching_.st A Morphic-Widgets-FastTable.package/FTPluggableIconListMorphAdaptorDataSource.class/instance/private/createCellText_icon_.st A Morphic-Widgets-FastTable.package/FTRegexFilter.class/README.md A Morphic-Widgets-FastTable.package/FTRegexFilter.class/definition.st A Morphic-Widgets-FastTable.package/FTRegexFilter.class/instance/accessing/pattern_.st A Morphic-Widgets-FastTable.package/FTRegexFilter.class/instance/matching/matches_.st M Morphic-Widgets-FastTable.package/FTSimpleDataSource.class/instance/accessing/newDataSourceMatching_.st A Morphic-Widgets-FastTable.package/FTSubstringFilter.class/README.md A Morphic-Widgets-FastTable.package/FTSubstringFilter.class/definition.st A Morphic-Widgets-FastTable.package/FTSubstringFilter.class/instance/matching/matches_.st A Morphic-Widgets-FastTable.package/FTTableMorph.class/instance/accessing/enableFilter_.st M Morphic-Widgets-FastTable.package/FTTreeDataSource.class/instance/accessing/newDataSourceMatching_.st M Polymorph-Widgets.package/MorphicUIManager.class/instance/debug/debugProcess_context_label_fullView_notification_.st A SUnit-Core.package/LongTestCase.class/instance/accessing/defaultTimeLimit.st A SUnit-Core.package/TestCase.class/instance/accessing/defaultTimeLimit.st A SUnit-Core.package/TestCase.class/instance/accessing/timeLimit_.st A SUnit-Core.package/TestCase.class/instance/running/runCaseManaged.st A SUnit-Core.package/TestExecutionEnvironment.class/README.md A SUnit-Core.package/TestExecutionEnvironment.class/class/controlling/maxTimeForTest_.st A SUnit-Core.package/TestExecutionEnvironment.class/class/fuel support/fuelIgnoredInstanceVariableNames.st A SUnit-Core.package/TestExecutionEnvironment.class/definition.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/accessing/forkedProcesses.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/accessing/forkedProcesses_.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/accessing/maxTimeForTest.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/accessing/maxTimeForTest_.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/accessing/testCase.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/accessing/testCase_.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/controlling/activated.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/controlling/checkForkedProcesses.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/controlling/deactivated.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/controlling/prepareForNewProcess_.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/controlling/runTestCase_.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/controlling/watchDogLoopFor_.st A SUnit-Core.package/TestExecutionEnvironment.class/instance/initialization/initialize.st A SUnit-Core.package/TestFailedByForkedProcess.class/README.md A SUnit-Core.package/TestFailedByForkedProcess.class/definition.st A SUnit-Core.package/TestFailedByForkedProcess.class/instance/initialization/initialize.st A SUnit-Core.package/TestFailedByForkedProcess.class/instance/testing/isResumable.st M SUnit-Core.package/TestResult.class/instance/running/runCaseForDebug_.st M SUnit-Core.package/TestResult.class/instance/running/runCase_.st A SUnit-Core.package/TestTookTooMuchTime.class/README.md A SUnit-Core.package/TestTookTooMuchTime.class/definition.st A SUnit-Core.package/extension/CurrentExecutionEnvironment/class/runTestCase_.st A SUnit-Core.package/extension/DefaultExecutionEnvironment/instance/runTestCase_.st A SUnit-Core.package/extension/ExecutionEnvironment/instance/runTestCase_.st A SUnit-Tests.package/ClassFactoryForTestCaseTest.class/instance/setUp-tearDown/defaultTimeLimit.st A SUnit-Tests.package/ClassFactoryWithOrganizationTest.class/instance/accessing/defaultTimeLimit.st A SUnit-Tests.package/SUnitTest.class/instance/private/failedChildProcessTest.st A SUnit-Tests.package/SUnitTest.class/instance/private/hangedChildProcessTest.st A SUnit-Tests.package/SUnitTest.class/instance/private/longRunningTest.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testErrorShouldResetWatchDog.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testExecutionEnvironmentShouldBeInstalled.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testFailedChildProcessTest.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testGreenTestThenLongRunningTest.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testHangedChildProcessTest.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testLongRunningTest.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testLongRunningTestThenGreenTest.st M SUnit-Tests.package/SUnitTest.class/instance/testing/testRunning.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testRunningLongTime.st A SUnit-Tests.package/SUnitTest.class/instance/testing/testWatchDogProcessShouldNotBeCatchedAsForkedProcess.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60200.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60201.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60200.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60201.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Spec-Core.package/FTArrayIndexColumn.class/README.md A Spec-Core.package/FTArrayIndexColumn.class/class/instance creation/index_.st A Spec-Core.package/FTArrayIndexColumn.class/class/instance creation/index_width_.st A Spec-Core.package/FTArrayIndexColumn.class/definition.st A Spec-Core.package/FTArrayIndexColumn.class/instance/accessing/index.st A Spec-Core.package/FTArrayIndexColumn.class/instance/accessing/index_.st A Spec-Core.package/FTArrayIndexColumn.class/instance/accessing/transform_.st M Spec-Core.package/FastTableModel.class/definition.st A Spec-Core.package/FastTableModel.class/instance/accessing/columns.st A Spec-Core.package/FastTableModel.class/instance/accessing/numberOfColumns_.st A Spec-Core.package/FastTableModel.class/instance/accessing/numberOfColumns_withWidths_.st A Spec-Core.package/FastTableModel.class/instance/initialization/initialize.st A Spec-Core.package/FastTableModel.class/instance/private/prepareForFilteredDataSourceWith_.st M Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/factory/buildWidget.st M Spec-Tools.package/MessageBrowser.class/instance/initialization/initializeWidgets.st M Versionner-Spec-Browser.package/VersionnerSpecBrowser.class/instance/initialization/initializeWidgets.st Log Message: ----------- 60201 19015 Tests should never hang and leave forked processes live https://pharo.fogbugz.com/f/cases/19015 18606 MessageBrowser should use fast table and provide filter field https://pharo.fogbugz.com/f/cases/18606 19034 Improve comment of round: https://pharo.fogbugz.com/f/cases/19034 http://files.pharo.org/image/60/60201.zip

Sept. 3, 2016

Idea: User-Installed Nautilus Package Group

by Sean P. DeNigris

I've often wanted to know which packages I had personally installed in an image (i.e. non-kernel). Our one-level-deep package nesting makes the full list unnavigable, so how about a Nautlius group where all new packages get included automatically? We could clear it out prior to release et voila! What do you think? ----- Cheers, Sean -- View this message in context: http://forum.world.st/Idea-User-Installed-Nautilus-Package-Group-tp4913942.… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Sept. 3, 2016

About file printOn: method

by stepharo

Hi I will implement the following because this is too annoying. currently 'tmp/foo.txt' asFileReference > File @ tmp/foo.txt and it would be much much better to get back 'tmp/foo.txt' asFileReference So that we can get { 'tmp/foo.txt' asFileReference } > { 'tmp/foo.txt' asFileReference } and not "an Array(File @ tmp/foo.txt)" In addition we should turn the current printOn: method into a displayString method so that a list of fileReference can be well display with File @ tmp/foo.txt for example https://pharo.fogbugz.com/f/cases/18956

Sept. 3, 2016

Re: [Pharo-dev] SUnit improvements need review and feedback

by Nicolas Cellier

2016-09-03 11:17 GMT+02:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > > 2016-09-03 9:48 GMT+02:00 Nicolas Cellier <nicolas.cellier.aka.nice@ > gmail.com>: > >> For floating points it would be good to also have something related to >> unit of least precision like I think it exists in google tests: >> >> assert: aFloat isWithin: anInteger ulpFrom: anotherFloat >> ^(aFloat - anotherFloat) abs <= (anotherFloat ulp max: aFloat ulp) >> >> It's testing if the result are the same with a tolerance on least >> significant bits. >> (anotherFloat ulp max: aFloat ulp) is not really necessary, it's only for >> making the comparison symmetric. >> indeed, 2 and 2 predecessor do not have the same exponent, so do not have >> the same ulp. >> If we don't have symmetry, then >> self assert: 2.0 predecessor predecessor isWithin: 1 ulpFrom: 2.0. >> might differ from: >> self assert: 2.0 isWithin: 1 ulpFrom: 2.0 predecessor predecessor . >> >> Note that the this message cannot be used to test for zero result >> (because 0.0 ulp is the smallest denormal). >> For example: >> self assert: 2.0 - 2.0 predecessor isWithin: 4 ulpFrom: 0.0. >> would anwer false, but it makes no sense! >> One should write >> self assert: 2.0 isWithin: 4 ulpFrom: 2.0 predecessor. > > > Bad result will be in other cases too (not only zero): > > expected := 8085- 8084.9999. > computed := (80.85 * 100) - 8084.9999. > (computed - expected) abs <= (computed ulp max: expected ulp) "==> > false" > > > > Fine, this result is not within 1 ulp error because of catastrophic cancellation, the difference is more than 1e7 ulp. That just mean that we have a numerical formulation that is quite unstable (it has half precision of double). I don't see why this invalidate this specific type of assertion, au contraire.

Sept. 3, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60200 Home: https://github.com/pharo-project/pharo-core

Sept. 3, 2016

[pharo-project/pharo-core] 7ba4f9: 60200

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 7ba4f9c5ad6e8b0765f38d6c4baead332aee61bb https://github.com/pharo-project/pharo-core/commit/7ba4f9c5ad6e8b0765f38d6c… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-09-03 (Sat, 03 Sep 2016) Changed paths: M Kernel.package/Deprecation.class/instance/handling/transform.st A Kernel.package/Deprecation.class/instance/private/rewriterClass.st M Manifest-Core.package/extension/RPackage/instance/packageManifest.st R Manifest-Core.package/extension/TBehavior/instance/isManifest.st M RPackage-Core.package/RPackage.class/instance/accessing/packageManifestOrNil.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60199.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60200.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60199.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60200.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Traits.package/TBehavior.class/instance/testing/isManifest.st Log Message: ----------- 60200 19014 Autodeprecation creates a DoIt method on UndefinedObject https://pharo.fogbugz.com/f/cases/19014 19029 SystemAnnouncer allInstances size = 2 https://pharo.fogbugz.com/f/cases/19029 19027 minimal Pharo build failing https://pharo.fogbugz.com/f/cases/19027 http://files.pharo.org/image/60/60200.zip

Sept. 3, 2016

Re: [Pharo-dev] SUnit improvements need review and feedback

by Denis Kudriashov

2016-09-03 9:48 GMT+02:00 Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com>: > For floating points it would be good to also have something related to > unit of least precision like I think it exists in google tests: > > assert: aFloat isWithin: anInteger ulpFrom: anotherFloat > ^(aFloat - anotherFloat) abs <= (anotherFloat ulp max: aFloat ulp) > > It's testing if the result are the same with a tolerance on least > significant bits. > (anotherFloat ulp max: aFloat ulp) is not really necessary, it's only for > making the comparison symmetric. > indeed, 2 and 2 predecessor do not have the same exponent, so do not have > the same ulp. > If we don't have symmetry, then > self assert: 2.0 predecessor predecessor isWithin: 1 ulpFrom: 2.0. > might differ from: > self assert: 2.0 isWithin: 1 ulpFrom: 2.0 predecessor predecessor . > > Note that the this message cannot be used to test for zero result (because > 0.0 ulp is the smallest denormal). > For example: > self assert: 2.0 - 2.0 predecessor isWithin: 4 ulpFrom: 0.0. > would anwer false, but it makes no sense! > One should write > self assert: 2.0 isWithin: 4 ulpFrom: 2.0 predecessor. Bad result will be in other cases too (not only zero): expected := 8085- 8084.9999. computed := (80.85 * 100) - 8084.9999. (computed - expected) abs <= (computed ulp max: expected ulp) "==> false"

Sept. 3, 2016

Re: [Pharo-dev] SUnit improvements need review and feedback

by Denis Kudriashov

2016-09-03 9:22 GMT+02:00 stepharo <stepharo(a)free.fr>: > Denis > > can we also have > > assert: aNumber withPrecision: precision equals: otherNumber > > self > assert: (aNumber round: precision) > equals: otherNumber > > assert: aNumber closeTo: otherNumber > > assert: aNumber withPrecision: self defaultPrecision equals: otherNumber > > defaultPrecision > ^ 2 > > We could add it but as different issue. Also I really want move away from assertions to should expressions. It is much nicer to write things like this (which available in StateSpecs): 10.1234 should equal: 10.12 within: 0.01 "success" 10.1234 should equal: 10.12 within: 0.001 "failure" Also I has idea that float assertions should always use default precision (like 0.00000000001) without special message. (80.85 * 100) should equal: 8085 It will fail now but I want it always succeed in such cases. Because in most cases users don't care about this. And when it has real value users will specify concrete precision

Sept. 3, 2016