August 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by stepharo

Le 3/8/16 Ã 14:21, Peter Uhnak a Ã©crit : >> thatâs a lot better than hardcoding specific expansions, yes. >> I still believe this is work of completion engine, thoughâ¦ >> > I don't know the current status (it's summer holidays), but we had a student that was interested in working on the completion engine as his bachelor thesis next year, so templates and such maybe could be part of it too. If nicolai wants to hack it now let him do. There are plenty of space for completion and to me completion and expansion are not automatically the same. Stef > > Peter > >

Aug. 3, 2016

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by stepharo

> itf<ctrl-e> > > ==> ifTrue: [ ] ifFalse: [ ] > > The could be an interface to define these code expansions - initially > at least on a purely personal basis. > > > And this is not really for adding a new feature. This shortcut > already (always :) ) existed > > With a single shortcut for code expansion, perhaps a few other > existing combinations could be freed up. > > > good idea, some kind of template expansion with user defined templates + 1 like that we can create the one we like :) Excellent idea! Stef

Aug. 3, 2016

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by stepharo

Hi ben I think that this it the way to go: Only one key binding to rule all the expansions :) Stef > On Wed, Aug 3, 2016 at 4:36 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >> I will just re-post my first answer: >> >> if reintroduce them means reintroduce them hardcoded as before, then Iâm >> complete against it and I WILL NOT integrate such solution. >> Iâm sorry for being so strong here, but previous implementation was lame and >> we need to get rid of them. >> >> Now, I understand people are used to use those bindings and also some others >> (no idea which ones because I never used themâ¦ for me ocompletion is good >> enoughâ¦ but those are tastes). So I would be very happy to integrate a >> generic way to define keybindings and outputs (which is already there, with >> keymapping, but I mean an editor or something), and I would be very happy to >> integrate a default configuration (which of course, will include >> #ifTrue:/##ifFalse:) > I would guess code expansions could be many and varied between > different individuals, and quickly consume available keyboard > shortcuts. Perhaps a generic mechanism would be single shortcut for > "code expansion" which processes the letters preceding the cursor. > For example, using shortcut <ctrl-e> for code expansion and typing... > > itf<ctrl-e> > > ==> ifTrue: [ ] ifFalse: [ ] > > The could be an interface to define these code expansions - initially > at least on a purely personal basis. > >> And this is not really for adding a new feature. This shortcut already (always :) ) existed > With a single shortcut for code expansion, perhaps a few other > existing combinations could be freed up. > > cheers -ben > >> Esteban >> >> On 03 Aug 2016, at 10:30, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: >> >> >> 2016-08-03 10:27 GMT+02:00 Guille Polito <guillermopolito(a)gmail.com>: >>> I'm also against. >>> >>> - They take a place in the shortcuts that prevents others to use it >>> - If lazy people really needs this, the code completion should be >>> enhanced. This is a code completion concern... >> >> +1 >> >> >

Aug. 3, 2016

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by stepharo

Le 3/8/16 Ã 10:27, Guille Polito a Ã©crit : > I'm also against. > > - They take a place in the shortcuts that prevents others to use it > - If lazy people really needs this, the code completion should be > enhanced. This is a code completion concern... For your information a student from Prague will start to work on that soon :) Stef > > In general, my rule of thumb is to answer the following questions: > How many people use it? > - if a lot, maybe it makes sense to integrate it > - if not a lot, make it a loadable extension > > How often do people use it? > - if at least 10 times per hour (e.g., reformat code, senders, > implementors, search) the shortcut should be simple > - otherwise we can put it in a more complex combination to leave > place to the common ones. > > Guille > > -------- Original Message -------- >> From a software design perspective it shouldn't be easy to insert >> #ifTrue:ifFalse :) >> >> Norbert >> >>> Am 03.08.2016 um 10:15 schrieb Nicolai Hess <nicolaihess(a)gmail.com >>> <mailto:nicolaihess@gmail.com>>: >>> >>> Any objections on using >>> cmd+t / cmd+f for insert ifTrue/ifFalse >>> (linux/windows this would be alt+t/alt+f, mac this would be >>> cmd+t/cmd+f). >>> >>> 2015-08-12 18:52 GMT+02:00 stepharo <stepharo(a)free.fr>: >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> Le 11/8/15 10:25, Nicolai Hess a >>> Ã©crit : >>> >>> >>>> >>>> >>>> >>>> >>>> >>>> I am nearly finished with converting old shortcut >>>> mapping (Editor/TextEditor cmdActions/shiftCmdAction >>>> map) >>>> >>>> >>>> to our keymapping framework. >>>> >>>> >>>> >>>> >>>> 15619 <https://pharo.fogbugz.com/default.asp?15619> >>>> >>>> >>>> cleanup TextEditors shortcut >>>> definition >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> Thank a lot! >>> >>> >>> >>> Yesterday with guillermo and christophe we spent one full afternoon >>> reading all the recursive dependencies introduced >>> >>> when we just want to have monticello in the bootstrap (to be able to >>> load code). >>> >>> We filled up two black boards and I should say that I was a nice >>> down to see the complexity but we will fix it :). >>> >>> >>> >>> Yesterday Esteban sat with igor and started to integrate the >>> OSWindow integration work of igor (yes igor you should do pull >>> requests :). >>> >>> So there are some problems with the mac vm and this will have to be >>> fixed (probably next week). >>> >>> After I hope that we will get clean events from SDL >>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> I need some more time, one or two vm changes and some people >>>> testing this on a mac. >>>> >>>> >>>> >>>> >>> >>> >>> >>> Tell us we will :) >>> >>> >>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> I know, this is a bit late because we replace our text >>>> components with rubric, but if this >>>> >>>> >>>> is finished and working for "old" PluggableTextMorphs, I will do >>>> the same for rubric. >>>> >>>> >>> >>> Thanks thanks thanks. >>> >>> I often frustrated when I see myself doing things more than twice >>> but this is a pattern. I decided long time ago that >>> >>> if this is necessary to do intermediate actions to lower the stress >>> on the future actions, I'm ready to throw awy what >>> >>> I did to get the ultimate goal reached. >>> >>> >>> >>> >>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> 2015-08-08 14:57 GMT+02:00 >>>> Esteban Lorenzano <estebanlm(a)gmail.com>: >>>> >>>> >>>> if reintroduce >>>> them means reintroduce them hardcoded as >>>> before, then Iâm complete against it and I >>>> WILL NOT integrate such solution. >>>> Iâm sorry for being so strong here, but >>>> previous implementation was lame and we need >>>> to get rid of them. >>>> >>>> >>>> >>>> >>>> Now, I understand people are used to use >>>> those bindings and also some others (no idea >>>> which ones because I never used themâ¦ for me >>>> ocompletion is good enoughâ¦ but those are >>>> tastes). So I would be very happy to >>>> integrate a generic way to define >>>> keybindings and outputs (which is already >>>> there, with keymapping, but I mean an editor >>>> or something), and I would be very happy to >>>> integrate a default configuration (which of >>>> course, will include #ifTrue:/##ifFalse:) >>>> >>>> >>>> >>>> >>>> >>>> Esteban >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>>> >>>>> On 08 Aug 2015, at 12:45, >>>>> Peter UhnÃ¡k <i.uhnak(a)gmail.com> >>>>> >>>>> wrote: >>>>> >>>>> >>>>> >>>>> >>>>> I would also >>>>> appreciate if it was readded, >>>>> as I've been using it >>>>> regularly. >>>>> >>>>> >>>>> >>>>> Peter >>>>> >>>>> >>>>> >>>>> >>>>> On >>>>> Sat, Aug 8, 2015 at 12:21 >>>>> PM, ThomasHeniart <heniart.thomas(a)gmail.com> >>>>> wrote: >>>>> >>>>> >>>>> I think >>>>> it could be nice to keep >>>>> this shortcut :) >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On 08/08/2015 >>>>> 12:12, Franck >>>>> Warlouzet wrote: >>>>> >>>>> >>>>>> >>>>>> Hi, >>>>>> >>>>>> >>>>>> >>>>>> Yes it was not >>>>>> on purpose. It >>>>>> is not >>>>>> implemented in >>>>>> Rubric, but I >>>>>> can do it if >>>>>> there is a need >>>>>> of it (which >>>>>> seems to be the >>>>>> case). >>>>>> >>>>>> >>>>>> >>>>>> Franck >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------ >>>>>> Date: Sat, >>>>>> 8 Aug 2015 >>>>>> 12:09:22 +0200 >>>>>> >>>>>> From: i.uhnak(a)gmail.com >>>>>> >>>>>> To: pharo-dev(a)lists.pharo.org >>>>>> >>>>>> Subject: >>>>>> [Pharo-dev] >>>>>> ifTrue ifFalse >>>>>> shortcuts >>>>>> >>>>>> >>>>>> >>>>>> Hi, >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> was >>>>>> removal of >>>>>> ifTrue/ifFalse >>>>>> shortcuts on >>>>>> purpose, or by >>>>>> accident? >>>>>> >>>>>> https://pharo.fogbugz.com/f/cases/16125/Nautilus-doesn-t-recognize-the-cmd-… >>>>>> >>>>>> >>>>>> (maybe >>>>>> was caused by >>>>>> switch to >>>>>> Rubric?) >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Peter >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >> >> >> >> > >

Aug. 3, 2016

Re: [Pharo-dev] [pharo-project/pharo-core] f57843: 60163

by stepharo

Thanks Martin. We missed yesterday: show only the latest version of every entities. :) Setf Le 3/8/16 Ã 11:23, Marcus Denker a Ã©crit : >> On 03 Aug 2016, at 11:07, GitHub <noreply(a)github.com> wrote: >> >> >> Log Message: >> ----------- >> 60163 >> 18831 Integrate new Epicea version >> https://pharo.fogbugz.com/f/cases/18831 >> > ChangeLog for this: > > - Case 18813: Implement redo and undo of protocol addition and removal. > > - Case 18612: disable drag&drop until TreeModel supports it correctly. > > - Case 18384: Redo and undo: show on any selection (not only when all selected entries are code changes). > > - Enhancement: Improve lost changes detection; show only the events actually lost. > > - Enhancement: Pass on filters. > > - Clean up: Do not show the "absent entry" item anymore since it was not useful at all. > > - Clean up: Remove unused "commit tags" in log browser. > > - Clean up: Remove unused tests. They were good idea, we can re-introduce them but working and covering more cases. > > - Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s hierarchy. It is more meaningful. > > - Workaround: Hide "Open in Sorter" menu action since it is useless until Treemodel drag&drop is fixed. > > > >> 18768 Inlined method const could be implemented by metalinks >> https://pharo.fogbugz.com/f/cases/18768 >> >> 18835 Update RBParser-Nodes class comments >> https://pharo.fogbugz.com/f/cases/18835 >> >> http://files.pharo.org/image/60/60163.zip >> >> > >

Aug. 3, 2016

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by Ben Coman

On Wed, Aug 3, 2016 at 8:05 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > >> On 03 Aug 2016, at 13:47, Cyril Ferlicot Delbecque <cyril.ferlicot(a)gmail.com> wrote: >> >> >> >> On 03/08/2016 10:56, Ben Coman wrote: >>> I would guess code expansions could be many and varied between >>> different individuals, and quickly consume available keyboard >>> shortcuts. Perhaps a generic mechanism would be single shortcut for >>> "code expansion" which processes the letters preceding the cursor. >>> For example, using shortcut <ctrl-e> for code expansion and typing... >>> >>> itf<ctrl-e> >>> >>> ==> ifTrue: [ ] ifFalse: [ ] >>> >>> The could be an interface to define these code expansions - initially >>> at least on a purely personal basis. >>> >>>> And this is not really for adding a new feature. This shortcut already (always :) ) existed >>> >>> With a single shortcut for code expansion, perhaps a few other >>> existing combinations could be freed up. >>> >>> cheers -ben >>> >> >> This would be really cool :) >> If everyone agree, let's open an issue. >> >> There is this kind of things in JetBrains Tools but with autocompletion >> instead of shortcut. You have some expression that make pop the >> autocompletion dialog to change it on piece of code. >> >> For example in Intellij you can type "sout" and the autocompletion will >> propose "System.out.println()â. > > exactlyâ¦ we even have the algorithm implemented for this. > I insist I would enhance ocompletion instead of adding an expansion shortcut. So maybe the shortcut just provides the completion engine an extra hint. Or maybe the expansion could be invoked by a special key series like a double-colon :: (if double-colon has no other special meaning, since single colons are already associated with keyword messages). For example typing itf:: ==> ifTrue: ifFalse: cheers -ben

Aug. 3, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60167 Home: https://github.com/pharo-project/pharo-core

Aug. 3, 2016

[pharo-project/pharo-core] 3dbc9a: 60167

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 3dbc9a34a1ed59a0c76483034e67bda09c12a842 https://github.com/pharo-project/pharo-core/commit/3dbc9a34a1ed59a0c7648303… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-03 (Wed, 03 Aug 2016) Changed paths: A AST-Core.package/BISimpleFormatter.class/instance/private/addSpaceIfNeededForLastArgument_.st A AST-Core.package/BISimpleFormatter.class/instance/private/pragmaArgumentNeedsSeparator_.st M AST-Core.package/BISimpleFormatter.class/instance/visiting/visitPragmaNode_.st A AST-Tests-Core.package/RBFormatterTest.class/instance/testing/testFormatPragmaWithLastIsSymbolArgument.st A BlueInk-Core.package/BIConfigurableFormatter.class/instance/private/addSpaceIfNeededForLastArgument_.st A BlueInk-Core.package/BIConfigurableFormatter.class/instance/private/pragmaArgumentNeedsSeparator_.st M BlueInk-Core.package/BIConfigurableFormatter.class/instance/visiting/visitPragmaNode_.st A Kernel.package/Integer.class/instance/system primitives/digitLength.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60166.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60167.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60166.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60167.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Core.package/RadioButtonModel.class/definition.st M Spec-Examples.package/DynamicSpecExample.class/definition.st Log Message: ----------- 60167 18858 #testUndeclared fails: missing ivars in RadioButtonModel https://pharo.fogbugz.com/f/cases/18858 18821 format code creates invalid pragma statement https://pharo.fogbugz.com/f/cases/18821 18843 #digitLength is implemented in SmallInteger and in BigInteger but not in Integer https://pharo.fogbugz.com/f/cases/18843 http://files.pharo.org/image/60/60167.zip

Aug. 3, 2016

Re: [Pharo-dev] [pharo-project/pharo-core] 94fcf4: 60165

by Ben Coman

Thanks for the follow up log message Marcus. cheers -ben On Wed, Aug 3, 2016 at 7:00 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > >> On 03 Aug 2016, at 12:24, GitHub <noreply(a)github.com> wrote: >> >> Branch: refs/heads/6.0 >> Home: https://github.com/pharo-project/pharo-core >> Commit: 94fcf44742b41d7898726b57a76edc70fb1d9aea >> https://github.com/pharo-project/pharo-core/commit/94fcf44742b41d7898726b57… >> Author: Jenkins Build Server <board(a)pharo-project.org> >> Date: 2016-08-03 (Wed, 03 Aug 2016) >> >> >> Log Message: >> ----------- >> 60165 >> Moose > > > Fixes these issues: > - case 18691 > - case 18471 > - case 18244 > - case 18708 > - GT-InspectorExtensions: only show methods for the current class, added basic example for RBCondition > - Uses Pragma>>#methodSelector instead of Pragma>>#selector (case 18665). > - Uses Behavior>>#classLayout instead of Behavior>>#layout (case 16636). > - Uses CompiledMethod>>#sourceCode instead of CompiledMethod>>#getSource (case 18694). > - GT-EventRecorder: Add a basic recorder event > > Marcus

Aug. 3, 2016

Re: [Pharo-dev] ifTrue ifFalse shortcuts

by Peter Uhnak

> thatâs a lot better than hardcoding specific expansions, yes. > I still believe this is work of completion engine, thoughâ¦ > I don't know the current status (it's summer holidays), but we had a student that was interested in working on the completion engine as his bachelor thesis next year, so templates and such maybe could be part of it too. Peter

Aug. 3, 2016