August 2016 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60179 Home: https://github.com/pharo-project/pharo-core

Aug. 12, 2016

[pharo-project/pharo-core] 631a5a: 60179

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 631a5a977701f9d2a35dad5c42fba3a9bd70d000 https://github.com/pharo-project/pharo-core/commit/631a5a977701f9d2a35dad5c… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-12 (Fri, 12 Aug 2016) Changed paths: M AST-Core.package/RBArrayNode.class/instance/matching/match_inContext_.st A AST-Tests-Core.package/RBParseTreeRewriterTest.class/instance/tests - to be refined/testRewriteDynamicArray.st A AST-Tests-Core.package/RBParseTreeSearcherTest.class/instance/tests - to de refined/testDynamicArrayStatements.st M Kernel.package/AdditionalMethodState.class/instance/accessing/at_ifAbsentPut_.st M Kernel.package/AdditionalMethodState.class/instance/accessing/at_put_.st A Kernel.package/AdditionalMethodState.class/instance/properties-compatibility/propertyValueAt_.st A Kernel.package/AdditionalMethodState.class/instance/properties-compatibility/propertyValueAt_ifAbsent_.st A Kernel.package/AdditionalMethodState.class/instance/properties/propertyAt_.st A Kernel.package/AdditionalMethodState.class/instance/properties/propertyAt_ifAbsent_.st R Kernel.package/AdditionalMethodState.class/instance/properties/propertyValueAt_.st R Kernel.package/AdditionalMethodState.class/instance/properties/propertyValueAt_ifAbsent_.st M Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/hasProperty_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_ifAbsentPut_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_ifAbsent_.st A Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyAt_put_.st R Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyValueAt_.st R Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyValueAt_ifAbsent_.st R Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/propertyValueAt_put_.st M Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/removeProperty_.st M Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/removeProperty_ifAbsent_.st A Kernel.package/CompiledMethod.class/instance/accessing-properties - compatibility/propertyValueAt_.st A Kernel.package/CompiledMethod.class/instance/accessing-properties - compatibility/propertyValueAt_ifAbsent_.st A Kernel.package/CompiledMethod.class/instance/accessing-properties - compatibility/propertyValueAt_put_.st M Kernel.package/Deprecation.class/README.md M Reflectivity.package/extension/CompiledMethod/instance/reflectiveMethod.st M Reflectivity.package/extension/CompiledMethod/instance/reflectiveMethod_.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60178.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60179.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60178.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60179.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/extension/CompiledMethod/instance/saveTemp_.st M Slot.package/extension/CompiledMethod/instance/savedTemps.st Log Message: ----------- 60179 18910 MNU: OrderedCollection>>parent: when trying to rewrite a tree with RBParseTreeRewriter https://pharo.fogbugz.com/f/cases/18910 18911 unify property API of CompiledMethod with all the others (Class, AST...) https://pharo.fogbugz.com/f/cases/18911 18912 update comment Deprecation https://pharo.fogbugz.com/f/cases/18912 http://files.pharo.org/image/60/60179.zip

Aug. 12, 2016

Re: [Pharo-dev] request for improvements in GTInspector or debugger

by Christophe Demarey

Hi Doru, Will the new presentation be the default one? If the new presentation will not be the default presentation for a String, it wonât be useful as we can already use the raw presentation. > Le 12 aoÃ»t 2016 Ã 06:22, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : > > Hi, > > Nice one. > > But, I do not want to change the default text presentation. Instead I would add another presentation. We can call it pharoText. Could you please open an issue for this? > > Doru > > >> On Aug 11, 2016, at 2:12 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >> >> >> >> 2016-08-11 13:44 GMT+02:00 Christophe Demarey <christophe.demarey(a)inria.fr>: >> Hi, >> >>> Le 10 aoÃ»t 2016 Ã 14:11, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : >>> >>> Hi Stef, >>> >>> I agree with what you say in this mail, and I am not sure where this is not the case. >> >> >> By example, it is not available in a String presentation of GTInspector. This one always forces me to go to the raw presentation and use the comment. >> Would it be possible to use global shortcuts in String presentation (cmd+B, cmd+M, cmd+N, etc.)? >> >> Christophe >> >> >> You could change >> GLMMorphicRubricTextRenderer>>#morph to act with smalltalk comment mode >> >> morph >> ^ RubScrolledTextMorph new >> getSelectionSelector: #primarySelectionInterval; >> color: Smalltalk ui theme backgroundColor; >> textColor: Smalltalk ui theme textColor; >> textFont: StandardFonts defaultFont; >> model: textModel; >> beForSmalltalkComment; >> yourself. >> >> >> This way, it behaves like the comment pane in Nautilus, it renders the text as "text" with the default font, no menu, but allows the common code mode shortcuts >> cmd+b cmd+M, ( and some that doesn't make sense for every selection, like cmd+i for inspect). >> >> > > -- > www.tudorgirba.com > www.feenk.com > > "Quality cannot be an afterthought." > >

Aug. 12, 2016

Re: [Pharo-dev] request for improvements in GTInspector or debugger

by Tudor Girba

Hi, Nice one. But, I do not want to change the default text presentation. Instead I would add another presentation. We can call it pharoText. Could you please open an issue for this? Doru > On Aug 11, 2016, at 2:12 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > 2016-08-11 13:44 GMT+02:00 Christophe Demarey <christophe.demarey(a)inria.fr>: > Hi, > > > Le 10 aoÃ»t 2016 Ã 14:11, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : > > > > Hi Stef, > > > > I agree with what you say in this mail, and I am not sure where this is not the case. > > > By example, it is not available in a String presentation of GTInspector. This one always forces me to go to the raw presentation and use the comment. > Would it be possible to use global shortcuts in String presentation (cmd+B, cmd+M, cmd+N, etc.)? > > Christophe > > > You could change > GLMMorphicRubricTextRenderer>>#morph to act with smalltalk comment mode > > morph > ^ RubScrolledTextMorph new > getSelectionSelector: #primarySelectionInterval; > color: Smalltalk ui theme backgroundColor; > textColor: Smalltalk ui theme textColor; > textFont: StandardFonts defaultFont; > model: textModel; > beForSmalltalkComment; > yourself. > > > This way, it behaves like the comment pane in Nautilus, it renders the text as "text" with the default font, no menu, but allows the common code mode shortcuts > cmd+b cmd+M, ( and some that doesn't make sense for every selection, like cmd+i for inspect). > > -- www.tudorgirba.com www.feenk.com "Quality cannot be an afterthought."

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-11 23:11 GMT+02:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > > 2016-08-11 22:19 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > >> This is the changed styler to underline assignments. This makes it easer >> to spot places in long methods, where variables are changed. >> (on the other hand, of course, methods shouldn't be that big :) ) >> > > Let's integrate it. It looks so good > This is not part of the change, just an experiment. I need to change the style tables for this, and before we integrate that change, I would like to make it configurable.

Aug. 11, 2016

Re: FileException only when opening image in certain way...

by Davide Varvello

I opened a bug: https://pharo.fogbugz.com/f/cases/18872/Pharo5-vm-crash-on-mac Davide Pharo Smalltalk Developers mailing list wrote > Moreover, on Pharo4 it's working. > Davide > > > > > Dale Henrichs-3 wrote >> Mariano, >> >> I think your problem might have something to do with how the PWD env var >> is managed in OSX ... Check the value of the 'PWD' in your different >> examples and see if that sheds any light ... >> >> Dale >> >> On 7/26/16 5:49 AM, Mariano Martinez Peck wrote: >>> >>> >>> On Tue, Jul 26, 2016 at 9:48 AM, Mariano Martinez Peck >>> < > >> marianopeck@ > >> <mailto: > >> marianopeck@ > >> >> wrote: >>> >>> Hi guys, >>> >>> Davide Varvello reported me an issue with Fuel, failing to do: >>> >>> FLSerializer serialize: 'whatever' toFileNamed: 'demo.fuel'. >>> >>> Such a thing would bring an error like this: >>> >>> File>>openForWrite: >>> File>>openForWrite >>> File>>writeStream >>> File>>writeStreamDo: >>> FLPharo5Platform>>fileNamed:writeStreamDo: >>> FLSerializer>>serialize:toFileNamed: >>> FLSerializer class>>serialize:toFileNamed: >>> >>> The code is: >>> >>> FLPharo5Platform >> fileNamed: aFilename writeStreamDo: aBlock >>> ^ ((Smalltalk at: #File) named: aFilename) writeStreamDo: [ :stream >>> | >>> stream binary. >>> aBlock value: stream ] >>> >>> >>> Now..I have tried to reproduce it but it happens only depending on >>> how the vm/image was started!!! And I only tested on OSX. >>> >>> Download the oneclick from here: >>> http://files.pharo.org/platform/Pharo5.0-mac.zip and see my results: >>> >>> 1) Executing VM from command line and passing the image as >>> argument: WORKS. >>> 2) Double clicking on the internal Pharo binary (which auto-starts >>> the image): WORKS >>> 3) Double clicking the internal Pharo image and then "Open With" >>> and I select the Pharo VM: DOES NOT WORK. >>> 4) Double clicking the Pharo one click: DOES NOT WORK. >>> >>> >>> I forgot to said... if you create the file in advance, with something >>> like: >>> >>> FileStream forceNewFileNamed: 'demo.fuel' do: [ :aStream | >>> FLSerializer serialize: 'whatever' on: aStream binary ] >>> >>> It does work in all cases. >>> >>> Has anyone experienced something like this? Looks like different >>> file / directory permissions when starting in different ways? >>> >>> Thanks in advance, >>> >>> >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com >>> >>> >>> >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com > > > > > > -- > View this message in context: > http://forum.world.st/FileException-only-when-opening-image-in-certain-way-… > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. -- View this message in context: http://forum.world.st/FileException-only-when-opening-image-in-certain-way-… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Aug. 11, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Denis Kudriashov

2016-08-11 22:19 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > This is the changed styler to underline assignments. This makes it easer > to spot places in long methods, where variables are changed. > (on the other hand, of course, methods shouldn't be that big :) ) > Let's integrate it. It looks so good

Aug. 11, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-11 21:54 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > > > 2016-08-11 21:23 GMT+02:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > >> >> 2016-08-11 13:57 GMT+02:00 Christophe Demarey < >> christophe.demarey(a)inria.fr>: >> >>> Good idea! >>> I like it and it works well. >>> I now wonder if it should not be enabled as default. For that, maybe the >>> highlight should be styled a bit (e.g. lighter colors) to do not perturb >>> the user when not really needed but still easy to see. Another idea would >>> be to show it only if you press a key while mouse over (e.g shift). >>> >> >> I remember another nice idea to underline keyword messages with different >> colors. >> > > Another idea, instead of highlighting the whole message with arguments, > only underline the keywords. This is nice too, but the code to do so (using > rubrics text segements) is much more complex, because > I had to use multiple text segments (one per keyword part). > > Doing the underline for all keyword message is easier with using ordinary > text style attributes. And let the syntax highligher set the proper > attributes. > I already did this once, but not for underlining the keywords but for > emphase variable assignments. > This is the changed styler to underline assignments. This makes it easer to spot places in long methods, where variables are changed. (on the other hand, of course, methods shouldn't be that big :) ) > > >

Aug. 11, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-11 21:23 GMT+02:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > > 2016-08-11 13:57 GMT+02:00 Christophe Demarey <christophe.demarey(a)inria.fr > >: > >> Good idea! >> I like it and it works well. >> I now wonder if it should not be enabled as default. For that, maybe the >> highlight should be styled a bit (e.g. lighter colors) to do not perturb >> the user when not really needed but still easy to see. Another idea would >> be to show it only if you press a key while mouse over (e.g shift). >> > > I remember another nice idea to underline keyword messages with different > colors. > Another idea, instead of highlighting the whole message with arguments, only underline the keywords. This is nice too, but the code to do so (using rubrics text segements) is much more complex, because I had to use multiple text segments (one per keyword part). Doing the underline for all keyword message is easier with using ordinary text style attributes. And let the syntax highligher set the proper attributes. I already did this once, but not for underlining the keywords but for emphase variable assignments.

Aug. 11, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-10 16:48 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > I opened an issue > > 18901 > <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> > Highlight message send selector on mouse over > > with an experimental implementation. > > Just load the slice, enable the setting: > RubAbstractTextArea highlightMessageSend: true. > > Now open a code editor (nautilus/MessageBrowser) and > move the mouse over a message send. > > Or evaluate this code, it opens a text editor on a method, where it is > difficult > to see which part of the code belongs to which method: > > evaluate: > TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) > sourceCode;openWithSpec. > > > feedback welcome. > > nicolai > Attached a screenshot. The mouse cursor is over the #submorphsDo: message, the highlighter highlights the message and all that is part of its arguments (the big block).

Aug. 11, 2016