August 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] let's talk about themes (and GLMBrickThemer)

by Glenn CavarlÃ©

Hi all, just few words about theme/skin concepts in Brick. A skin defines the way a widget is internally composed. The Datepicker is a good example, you can just compare the one in iOS and the one in jQuery, they don't use the same UI components internally and provide a completely different user experience: it is the role of the Skin. The styles are graphical options related to a particular skin. They can be colors, cornerRadii, fonts,... A theme defined a set of consistent skins and related style values for the whole widgets hierarchy. For example, the Material Design is a theme that define both skin and styles to use for all widgets. I think the notion of Palette is interesting to define theme variants without to be forced to create a new theme. Maybe, as a first step, a Palette can be simply something like a QPalette (Qt) which can be used in themes instead of static color values. The current style/theme implementation in Bloc/Brick is at an early stage and don't reflect exactly what it will be. I made a first working implementation of the CSS2+ model as a proof of concept but this doesn't mean that users will be forced to use CSS to style UIs. But i think we have to provide this kind of facility and the concepts under CSS open a lot of possibilities (cascading styles is one of them). Styling and theming are difficult subjects, many ways remain to be explored. Regards, Glenn. ----- Glenn CavarlÃ© -- View this message in context: http://forum.world.st/let-s-talk-about-themes-and-GLMBrickThemer-tp4908930p… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Aug. 12, 2016

Re: [Pharo-dev] missing message pattern in pharo 5.0 gives misleading error message:

by Nicolas Cellier

But the bar is a valid binary selector which takes a text parameter | text | text '|' expected -> := self requestPassword You seem to suggest that the parser should use formatting, presence/absence or spaces/newlines, but it never did so, it just skips/ignores spaces. The parser process as much as possible until the first error. It never did a global analysis to find the minimal error. That's a far more difficult problem. Note that for the same kind of reason, while we could make ^ a binary selector as I proposed once, we didn't yet by fear of interpreting things differently in case of missing period: self seeThePeriodMissingAtEndOfThisSentence ^self 2016-08-13 0:02 GMT+02:00 Dale Henrichs <dale.henrichs(a)gemtalksystems.com>: > > > On 08/12/2016 11:40 AM, Nicolai Hess wrote: > > > > 2016-08-12 20:30 GMT+02:00 Dale Henrichs <dale.henrichs(a)gemtalksystems.com > >: > >> `'|' expected` is not the error message I would expect when the message >> pattern is missing from a method and I try to accept in browser: >> >> >> | text | >> text '|' expected ->:= self requestPassword >> ifTrue: [ UIManager default requestPassword: self prompt ] >> ifFalse: [ UIManager default request: self prompt initialAnswer: >> self template ]. >> ^ (text isNil or: [ text isEmpty ]) >> ifTrue: [ nil ] >> ifFalse: [ text ] >> >> The highlighter was also confused turning red at the `->` instead at the >> very beginning of the method ... >> > > yeah, this is a funny one. > I onced debugged the parser to find out why that's happening. Can you spot > why this is a valid method : > > | text | > | ^ text > > :) > > I cheated and used the syntax highlighting to give me subtle but import > clues :) Things I missed when initially trying to figure out what I had > done wrong ... perhaps an error message that special cases this would be > called for: "'|' expected or missing message message pattern" ... There are > at least two developers who expected the syntax highlighter to do a better > job ... and I sent this thinking about newbies running into what I assume > would be a common mistake ... > > Dale > > >

Aug. 12, 2016

Re: [Pharo-dev] missing message pattern in pharo 5.0 gives misleading error message:

by Dale Henrichs

On 08/12/2016 11:40 AM, Nicolai Hess wrote: > > > 2016-08-12 20:30 GMT+02:00 Dale Henrichs > <dale.henrichs(a)gemtalksystems.com > <mailto:dale.henrichs@gemtalksystems.com>>: > > `'|' expected` is not the error message I would expect when the > message pattern is missing from a method and I try to accept in > browser: > > > | text | > text '|' expected ->:= self requestPassword > ifTrue: [ UIManager default requestPassword: self prompt ] > ifFalse: [ UIManager default request: self prompt > initialAnswer: self template ]. > ^ (text isNil or: [ text isEmpty ]) > ifTrue: [ nil ] > ifFalse: [ text ] > > The highlighter was also confused turning red at the `->` instead > at the very beginning of the method ... > > > yeah, this is a funny one. > I onced debugged the parser to find out why that's happening. Can you > spot why this is a valid method : > > | text | > | ^ text > > :) I cheated and used the syntax highlighting to give me subtle but import clues :) Things I missed when initially trying to figure out what I had done wrong ... perhaps an error message that special cases this would be called for: "'|' expected or missing message message pattern" ... There are at least two developers who expected the syntax highlighter to do a better job ... and I sent this thinking about newbies running into what I assume would be a common mistake ... Dale

Aug. 12, 2016

Re: [Pharo-dev] missing message pattern in pharo 5.0 gives misleading error message:

by Nicolai Hess

2016-08-12 20:30 GMT+02:00 Dale Henrichs <dale.henrichs(a)gemtalksystems.com>: > `'|' expected` is not the error message I would expect when the message > pattern is missing from a method and I try to accept in browser: > > > | text | > text '|' expected ->:= self requestPassword > ifTrue: [ UIManager default requestPassword: self prompt ] > ifFalse: [ UIManager default request: self prompt initialAnswer: > self template ]. > ^ (text isNil or: [ text isEmpty ]) > ifTrue: [ nil ] > ifFalse: [ text ] > > The highlighter was also confused turning red at the `->` instead at the > very beginning of the method ... > yeah, this is a funny one. I onced debugged the parser to find out why that's happening. Can you spot why this is a valid method : | text | | ^ text :) > > Dale > >

Aug. 12, 2016

missing message pattern in pharo 5.0 gives misleading error message:

by Dale Henrichs

`'|' expected` is not the error message I would expect when the message pattern is missing from a method and I try to accept in browser: | text | text '|' expected ->:= self requestPassword ifTrue: [ UIManager default requestPassword: self prompt ] ifFalse: [ UIManager default request: self prompt initialAnswer: self template ]. ^ (text isNil or: [ text isEmpty ]) ifTrue: [ nil ] ifFalse: [ text ] The highlighter was also confused turning red at the `->` instead at the very beginning of the method ... Dale

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-12 19:31 GMT+02:00 stepharo <stepharo(a)free.fr>: > I like the idea to use shift to activate it. > > Ok, I 'll can change it. > Le 12/8/16 Ã 19:19, Nicolai Hess a Ã©crit : > > > > 2016-08-12 19:09 GMT+02:00 stepharo <stepharo(a)free.fr>: > >> Hi nicolai >> >> It is nice. I would not put the border in black. >> >> What is needed to integrate it. >> > I put the issue to "Resolved ", so the monkey can check. > The background color is the same as for "secondary selection" and the > border color is the same "muchDarker". > > Of course, we can integrate it and change the color later. > > > >> Stef >> Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : >> >> I opened an issue >> >> 18901 >> <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> >> Highlight message send selector on mouse over >> >> with an experimental implementation. >> >> Just load the slice, enable the setting: >> RubAbstractTextArea highlightMessageSend: true. >> >> Now open a code editor (nautilus/MessageBrowser) and >> move the mouse over a message send. >> >> Or evaluate this code, it opens a text editor on a method, where it is >> difficult >> to see which part of the code belongs to which method: >> >> evaluate: >> TextModel new beForCode; aboutToStyle:true;behavior: >> MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) >> sourceCode;openWithSpec. >> >> >> feedback welcome. >> >> nicolai >> >> >> > >

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by stepharo

I like the idea to use shift to activate it. Le 12/8/16 Ã 19:19, Nicolai Hess a Ã©crit : > > > 2016-08-12 19:09 GMT+02:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > Hi nicolai > > It is nice. I would not put the border in black. > > What is needed to integrate it. > > I put the issue to "Resolved ", so the monkey can check. > The background color is the same as for "secondary selection" and the > border color is the same "muchDarker". > > Of course, we can integrate it and change the color later. > > Stef > > Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : >> I opened an issue >> >> 18901 >> <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> >> Highlight message send selector on mouse over >> >> with an experimental implementation. >> >> Just load the slice, enable the setting: >> RubAbstractTextArea highlightMessageSend: true. >> >> Now open a code editor (nautilus/MessageBrowser) and >> move the mouse over a message send. >> >> Or evaluate this code, it opens a text editor on a method, where >> it is difficult >> to see which part of the code belongs to which method: >> >> evaluate: >> TextModel new beForCode; aboutToStyle:true;behavior: >> MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) >> sourceCode;openWithSpec. >> >> >> feedback welcome. >> >> nicolai > >

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by Nicolai Hess

2016-08-12 19:09 GMT+02:00 stepharo <stepharo(a)free.fr>: > Hi nicolai > > It is nice. I would not put the border in black. > > What is needed to integrate it. > I put the issue to "Resolved ", so the monkey can check. The background color is the same as for "secondary selection" and the border color is the same "muchDarker". Of course, we can integrate it and change the color later. > Stef > Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : > > I opened an issue > > 18901 > <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> > Highlight message send selector on mouse over > > with an experimental implementation. > > Just load the slice, enable the setting: > RubAbstractTextArea highlightMessageSend: true. > > Now open a code editor (nautilus/MessageBrowser) and > move the mouse over a message send. > > Or evaluate this code, it opens a text editor on a method, where it is > difficult > to see which part of the code belongs to which method: > > evaluate: > TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) > sourceCode;openWithSpec. > > > feedback welcome. > > nicolai > > >

Aug. 12, 2016

Re: [Pharo-dev] Feedback request: Editor with highlighting message-sends on mouse over

by stepharo

Hi nicolai It is nice. I would not put the border in black. What is needed to integrate it. Stef Le 10/8/16 Ã 16:48, Nicolai Hess a Ã©crit : > I opened an issue > > 18901 > <https://pharo.fogbugz.com/f/cases/18901/Highlight-message-send-selector-on-…> > Highlight message send selector on mouse over > > with an experimental implementation. > > Just load the slice, enable the setting: > RubAbstractTextArea highlightMessageSend: true. > > Now open a code editor (nautilus/MessageBrowser) and > move the mouse over a message send. > > Or evaluate this code, it opens a text editor on a method, where it > is difficult > to see which part of the code belongs to which method: > > evaluate: > TextModel new beForCode; aboutToStyle:true;behavior: > MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) > sourceCode;openWithSpec. > > > feedback welcome. > > nicolai

Aug. 12, 2016

Re: [Pharo-dev] request for improvements in GTInspector or debugger

by Tudor Girba

Hi, We will change the presentation for String to use the new one :) Doru > On Aug 12, 2016, at 9:23 AM, Christophe Demarey <christophe.demarey(a)inria.fr> wrote: > > Hi Doru, > > Will the new presentation be the default one? > If the new presentation will not be the default presentation for a String, it wonât be useful as we can already use the raw presentation. > >> Le 12 aoÃ»t 2016 Ã 06:22, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : >> >> Hi, >> >> Nice one. >> >> But, I do not want to change the default text presentation. Instead I would add another presentation. We can call it pharoText. Could you please open an issue for this? >> >> Doru >> >> >>> On Aug 11, 2016, at 2:12 PM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >>> >>> >>> >>> 2016-08-11 13:44 GMT+02:00 Christophe Demarey <christophe.demarey(a)inria.fr>: >>> Hi, >>> >>>> Le 10 aoÃ»t 2016 Ã 14:11, Tudor Girba <tudor(a)tudorgirba.com> a Ã©crit : >>>> >>>> Hi Stef, >>>> >>>> I agree with what you say in this mail, and I am not sure where this is not the case. >>> >>> >>> By example, it is not available in a String presentation of GTInspector. This one always forces me to go to the raw presentation and use the comment. >>> Would it be possible to use global shortcuts in String presentation (cmd+B, cmd+M, cmd+N, etc.)? >>> >>> Christophe >>> >>> >>> You could change >>> GLMMorphicRubricTextRenderer>>#morph to act with smalltalk comment mode >>> >>> morph >>> ^ RubScrolledTextMorph new >>> getSelectionSelector: #primarySelectionInterval; >>> color: Smalltalk ui theme backgroundColor; >>> textColor: Smalltalk ui theme textColor; >>> textFont: StandardFonts defaultFont; >>> model: textModel; >>> beForSmalltalkComment; >>> yourself. >>> >>> >>> This way, it behaves like the comment pane in Nautilus, it renders the text as "text" with the default font, no menu, but allows the common code mode shortcuts >>> cmd+b cmd+M, ( and some that doesn't make sense for every selection, like cmd+i for inspect). >>> >>> >> >> -- >> www.tudorgirba.com >> www.feenk.com >> >> "Quality cannot be an afterthought." >> >> > > -- www.tudorgirba.com www.feenk.com "The coherence of a trip is given by the clearness of the goal."

Aug. 12, 2016