August 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Experience with FileSystem => proposal for improving user experience

by stepharo

>>> Proposal two: >>> >>> We could add withoutBasename >>> >>> withoutBasename >>> >>> ^ self parent >>> >>> >>> I don't see a point of this method, why not just use #parent? >> This is a helper. >> parent is good for navigation now withoutBasename is good for manipulation >> of parts. >> It took me a while to think that I should use parent because I was looking >> for something else. > So the problem then is a documentational one. No I do not want to read a pdf to get it. > >> You convinced me this library is perfect and I will keep these extensions >> for me. > My point is, do we want to add every possible variation and helper for every use case a person can think of? > I believe last year there was a lot of effort put into cleaning up String api; did String end up where it is with similar approach? I don't know, I haven't been here, that's why I am asking. > > Also in other languages it is common to use `dirname` instead of parent => "asking for the directory name of what you have". > > But as you point out in another thread, this is a documentational issue, and not a missing method. I do not want to be forced to read a doc to use a system. The system itself should be discoverable and it is not in this case. This is why I will not write documentation of others code anymore. >>> Proposal three: >>> >>> Not sure that it is worth >>> >>> (note that this is not a rename) >>> >>> withNewExtension: anExtension >>> ^ self parent / self basenameWithoutExtension >>> withExtension: anExtension >>> >>> >>> Is this somehow different than using #withExtension: directly? >> Obviously since I'm with Sven one of the few persons that seem concerned >> with such aspect. > Please, just so there is no misunderstanding. I do care about it and I am not fundamentally against it. > You sent your proposals, I've added my view, and I expect other people will add theirs, so we can collectively discuss this and act on it. You see I could have pushed this change without discussing. I can understand that proposal 3 is useless since this is the same. But the others have a value to me. Now I added them in my private extensions and this is good. > > Peter > >

Aug. 18, 2016

Re: [Pharo-dev] About PythonDocTest for Pharo

by Serge Stinckwich

On Thu, Aug 18, 2016 at 9:34 AM, stepharo <stepharo(a)free.fr> wrote: > Hi guys > > I'm fed up to get methods without comments and without little examples. In +1 ! We can setup a small group of people interested to build examples at ESUG. > FileSystem, I wrote most of the comments and I tried to add an obvious > example: > > basenameWithIndicator > "Returns the basename with the indicator appended, i.e. > /foo/gloops.taz basenameWithIndicator is 'gloops.taz', whereras /foo > basenameWithIndicator is 'foo/'" > > ^ self basename , self indicator > > > Now let us look at: > > withExtension: aString > ^ self withPath: (self path withExtension: aString) > > > Nice comment :( > > I would like to support PythonDoctest (yes we are not the only one to have > ideas let us face is dear friends) +1 https://en.wikipedia.org/wiki/Doctest > def multiply(a, b): > """ > >>> multiply(4, 3) > 12 > >>> multiply('a', 3) > 'aaa' > """ > return a * b > > Because we can make sure that the comments are accurate. > > > withExtension: aString > > "Returns a new file reference with a different file extension" > > <exp: '/tmp/file.txt' asFileReference withExtension: 'log' > > value: '/tmp/file.log' asFileReference > > > ^ self withPath: (self path withExtension: aString) > > > It will help us to have a distinction between printOn: and displayString > > Typically > > '/tmp/file.txt' asFileReference withExtension: 'log' > > printString is bad > > since it returns File @ '/tmp/file.log' which is not an reexecutable > expression > > > > So let me know what you think. > - tell me that we have already test unit (yes the ones I wrote too) > => they do not have the same purpose > > For me this is getting to be important. Maybe a subset of Pharo could be defined as core with a kind of API freeze, so we can spend some time documenting the corresponding methods and classes. -- Serge Stinckwich UCBN & UMI UMMISCO 209 (IRD/UPMC) Every DSL ends up being Smalltalk http://www.doesnotunderstand.org/

Aug. 18, 2016

Re: [Pharo-dev] Experience with FileSystem => proposal for improving user experience

by Peter Uhnak

On Thu, Aug 18, 2016 at 09:35:28AM +0200, stepharo wrote: Just so you don't misunderstandâ¦ I am not opposing those changes, I am just asking. > > > > Proposal one: > > > > We could add withoutExtension > > > > withoutExtension > > > > ^ (self parent / self basenameWithoutExtension) > > > > > > What is the use case for this? > To get everything except the extension. Is it not obvious? > How do you did it else? What I mean is, when would you use such method? The only use case I can see (after using FS libs for years) is to change extension, but we already have a method for that. > > > Proposal two: > > > > We could add withoutBasename > > > > withoutBasename > > > > ^ self parent > > > > > > I don't see a point of this method, why not just use #parent? > This is a helper. > parent is good for navigation now withoutBasename is good for manipulation > of parts. > It took me a while to think that I should use parent because I was looking > for something else. So the problem then is a documentational one. > You convinced me this library is perfect and I will keep these extensions > for me. My point is, do we want to add every possible variation and helper for every use case a person can think of? I believe last year there was a lot of effort put into cleaning up String api; did String end up where it is with similar approach? I don't know, I haven't been here, that's why I am asking. Also in other languages it is common to use `dirname` instead of parent => "asking for the directory name of what you have". But as you point out in another thread, this is a documentational issue, and not a missing method. > > > > Proposal three: > > > > Not sure that it is worth > > > > (note that this is not a rename) > > > > withNewExtension: anExtension > > ^ self parent / self basenameWithoutExtension > > withExtension: anExtension > > > > > > Is this somehow different than using #withExtension: directly? > Obviously since I'm with Sven one of the few persons that seem concerned > with such aspect. Please, just so there is no misunderstanding. I do care about it and I am not fundamentally against it. You sent your proposals, I've added my view, and I expect other people will add theirs, so we can collectively discuss this and act on it. Peter

Aug. 18, 2016

Email bankruptcy: Can not keep up with mails

by Marcus Denker

Hi, Over the summer with holidays email accumulatedâ¦ I started to get them down but there a re now still >300 unread Pharo mails left. I decided I will just delete themâ¦ if you expected an answer/input from me â> send me a private mail. Marcus

Aug. 18, 2016

Re: [Pharo-dev] Experience with FileSystem => proposal for improving user experience

by stepharo

Le 17/8/16 Ã 22:11, Peter UhnÃ¡k a Ã©crit : > > > On Wed, Aug 17, 2016 at 9:44 PM, stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > Hi > > I have a file > > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres-EN/EN_C019SD-W1-S1.srt > > and I would like to generate a new one with a different extension > > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres-EN/EN_C019SD-W1-S1.vtt > > > Why not just myFile withExtension: 'vtt' If you see my code you will see that I could not guess that it was working on a fullpath. Of course since I did not add a proper comment to this method, there is none and learning is always more difficult. I really hate that we have to read and understand the implementation of a method to understand what is does. > e.g. > > f := '/tmp/file.txt' asFileReference. > "File @ /tmp/file.txt" > f withExtension: 'log' > "File @ /tmp/file.log" > > > Now I'm browsing FileReference and I do not find an easy way to do it. > > > It's an AbstractFileReference method. > > > > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres-EN/ > > > Why not just #parent? Some languages also use #dirname. > > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres-EN/EN_C019SD-W1-S1 > > > This one is the one hard to getâ¦ but how often do you need it? Is it > worth the extra method in the API? > If just for changing the extension, then there's #withExtension: > > Proposal one: > > We could add withoutExtension > > withoutExtension > > ^ (self parent / self basenameWithoutExtension) > > > What is the use case for this? To get everything except the extension. Is it not obvious? How do you did it else? > Proposal two: > > We could add withoutBasename > > withoutBasename > > ^ self parent > > > I don't see a point of this method, why not just use #parent? This is a helper. parent is good for navigation now withoutBasename is good for manipulation of parts. It took me a while to think that I should use parent because I was looking for something else. You convinced me this library is perfect and I will keep these extensions for me. > > Proposal three: > > Not sure that it is worth > > (note that this is not a rename) > > withNewExtension: anExtension > ^ self parent / self basenameWithoutExtension > withExtension: anExtension > > > Is this somehow different than using #withExtension: directly? It is the same. I will add a real comment to this method. I hate so much libraries that do not have comments (I'm fed up to lose my time documenting undocumented library). Since I stupidly wrote also the FS chapter I missed such scenario since I was exhausted to reverse engineer and comment. So now this is not in the documentation. Easy and revealing the poor coverage of our documentation. Obviously since I'm with Sven one of the few persons that seem concerned with such aspect. Now I will not work on documenting others code anymore. > Peter

Aug. 18, 2016

About PythonDocTest for Pharo

by stepharo

Hi guys I'm fed up to get methods without comments and without little examples. In FileSystem, I wrote most of the comments and I tried to add an obvious example: basenameWithIndicator "Returns the basename with the indicator appended, i.e. /foo/gloops.taz basenameWithIndicator is 'gloops.taz', whereras /foo basenameWithIndicator is 'foo/'" ^ self basename , self indicator Now let us look at: withExtension: aString ^ self withPath: (self path withExtension: aString) Nice comment :( I would like to support PythonDoctest (yes we are not the only one to have ideas let us face is dear friends) def multiply(a, b): """ >>> multiply(4, 3) 12 >>> multiply('a', 3) 'aaa' """ return a * b Because we can make sure that the comments are accurate. withExtension: aString "Returns a new file reference with a different file extension" <exp: '/tmp/file.txt' asFileReference withExtension: 'log' value: '/tmp/file.log' asFileReference > ^ self withPath: (self path withExtension: aString) It will help us to have a distinction between printOn: and displayString Typically '/tmp/file.txt' asFileReference withExtension: 'log' printString is bad since it returns File @ '/tmp/file.log' which is not an reexecutable expression So let me know what you think. - tell me that we have already test unit (yes the ones I wrote too) => they do not have the same purpose For me this is getting to be important. Stef

Aug. 18, 2016

[Issue tracker] push on old issues needed

by Marcus Denker

Hi, The issue tracker is accumulating issues fastâ¦ lots of them a half-finished, yet saw no action for quite some timeâ¦ Keep in mind that if *you* will not look at an issue you where involved in (or even created), chances are that *nobody* will look at itâ¦ it is your job to push it forward. (e.g. ask for help on the mailinglist or Slackâ¦) So please, everyone, have a look at old issues and push those forward that are ready or close those that are not relevant anymoreâ¦ **every single issue resolved helps!!** https://pharo.fogbugz.com/f/filters/57/All-newest-first <https://pharo.fogbugz.com/f/filters/57/All-newest-first> Marcus

Aug. 18, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60187 Home: https://github.com/pharo-project/pharo-core

Aug. 18, 2016

[pharo-project/pharo-core] 5b4669: 60187

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 5b46698f658ee35055ac458d437d32035630c99a https://github.com/pharo-project/pharo-core/commit/5b46698f658ee35055ac458d… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M Collections-Tests.package/SplitJoinTest.class/instance/running/testSplitJoinBoundaryCases.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/README.md R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/class/accessing/uniqueIdentifierName.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/class/testing/checksClass.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/definition.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/instance/accessing/group.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/instance/accessing/name.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/instance/accessing/rationale.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/instance/accessing/resultClass.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/instance/running/basicCheck_.st R Refactoring-Critics.package/RBClassInstVarNotInitializedRule.class/instance/running/checkClass_.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60186.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60187.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60186.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60187.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/extension/String/instance/asSlotCollection.st Log Message: ----------- 60187 18953 remove Regex dependency from SplitJoinTest>>#testSplitJoinBoundaryCases https://pharo.fogbugz.com/f/cases/18953 18916 simplify asSlotCollection for bootstrap https://pharo.fogbugz.com/f/cases/18916 18938 Remove RBClassInstVarNotInitializedRule, it is a bad rule https://pharo.fogbugz.com/f/cases/18938 http://files.pharo.org/image/60/60187.zip

Aug. 18, 2016

Re: [Pharo-dev] Experience with FileSystem => proposal for improving user experience

by Peter UhnÃ¡k

On Wed, Aug 17, 2016 at 9:44 PM, stepharo <stepharo(a)free.fr> wrote: > Hi > > I have a file > > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres- > EN/EN_C019SD-W1-S1.srt > > and I would like to generate a new one with a different extension > > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres- > EN/EN_C019SD-W1-S1.vtt > Why not just myFile withExtension: 'vtt' e.g. f := '/tmp/file.txt' asFileReference. "File @ /tmp/file.txt" f withExtension: 'log' "File @ /tmp/file.log" > > Now I'm browsing FileReference and I do not find an easy way to do it. > It's an AbstractFileReference method. > > > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres-EN/ > Why not just #parent? Some languages also use #dirname. > /Users/ducasse/PharoMooc/Subtitles/W1/C019SD-W1-sous-titres- > EN/EN_C019SD-W1-S1 > This one is the one hard to getâ¦ but how often do you need it? Is it worth the extra method in the API? If just for changing the extension, then there's #withExtension: > Proposal one: > > We could add withoutExtension > > withoutExtension > > ^ (self parent / self basenameWithoutExtension) > What is the use case for this? > > > Proposal two: > > We could add withoutBasename > > withoutBasename > > ^ self parent > I don't see a point of this method, why not just use #parent? > Proposal three: > > Not sure that it is worth > > (note that this is not a rename) > > withNewExtension: anExtension > ^ self parent / self basenameWithoutExtension withExtension: > anExtension > Is this somehow different than using #withExtension: directly? Peter

Aug. 17, 2016