June 2016 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] 0194d4: 60115

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 0194d494cdac85d5cafc54c90c268f68ae963c7f https://github.com/pharo-project/pharo-core/commit/0194d494cdac85d5cafc54c9… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-06-26 (Sun, 26 Jun 2016) Changed paths: M Kernel.package/Object.class/instance/deprecation/deprecated_transformWith_.st M Kernel.package/UndefinedObject.class/instance/testing/haltIfNil.st R Kernel.package/UndefinedObject.class/instance/testing/ifNil_ifNotNilDo_.st R Kernel.package/UndefinedObject.class/instance/testing/ifNotNilDo_ifNil_.st A Refactoring-Critics.package/RBUncommonMessageSendRule.class/instance/private/isUnknownCapitalizedMessage_.st M Refactoring-Critics.package/RBUncommonMessageSendRule.class/instance/running/checkMethod_.st M Refactoring-Tests-Critics.package/RBSmalllintTest.class/instance/tests/testUncommonMessageSend.st A Refactoring-Tests-Critics.package/RBSmalllintTestObject.class/instance/methods/uncommonMessageSend2.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60114.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60115.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60114.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60115.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Tool-CriticBrowser.package/CriticsCache.class/instance/add%2Fremove/removeFalsePositive_forRule_.st Log Message: ----------- 60115 18598 avoid DNU when reapplying rules targeting a package https://pharo.fogbugz.com/f/cases/18598 18601 #haltIfNil and deprecated:transformWith: have wrong visual https://pharo.fogbugz.com/f/cases/18601 18593 Remove Pharo references to Smalltalk evaluate: https://pharo.fogbugz.com/f/cases/18593 15859 review rule RBUncommonMessageSendRule https://pharo.fogbugz.com/f/cases/15859 http://files.pharo.org/image/60/60115.zip

June 26, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60115 Home: https://github.com/pharo-project/pharo-core

June 26, 2016

Re: [Pharo-dev] Smalltalk books & Smalltalk reports

by Eliot Miranda

John, can you lost the books plz? _,,,^..^,,,_ (phone) > On Jun 25, 2016, at 9:08 PM, John McIntosh <johnmci(a)smalltalkconsulting.com> wrote: > > I've about 20 Smalltalk books and 36 issues of the ancient Smalltalk Reports to give anyway to anyone that will pay the postage from Canada. Decuttering my office and its a shame to send all of it to the shredder. > > > > > > -- > =========================================================================== > John M. McIntosh. Corporate Smalltalk Consulting Ltd https://www.linkedin.com/in/smalltalk > =========================================================================== >

June 26, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60114 Home: https://github.com/pharo-project/pharo-core

June 26, 2016

[pharo-project/pharo-core] d8eeee: 60114

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: d8eeee313de9a05364ecc6fa47f55c5373b9bf1b https://github.com/pharo-project/pharo-core/commit/d8eeee313de9a05364ecc6fa… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-06-26 (Sun, 26 Jun 2016) Changed paths: A Kernel.package/Halt.class/class/once-reset/resetHaltOnCount.st M MonticelloGUI.package/MCWorkingCopyBrowser.class/class/settings/order.st M MonticelloGUI.package/MCWorkingCopyBrowser.class/class/settings/order_.st M MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/morphic ui/order_.st A Morphic-Base.package/extension/WorldState/class/debugOn_.st R Morphic-Core.package/PasteUpMorph.class/instance/world menu/worldMenuAt_.st R Morphic-Core.package/WorldMorph.class/instance/world menu/worldMenuAt_.st A Reflectivity-Tools.package/DoOnlyOnceIconStyler.class/README.md A Reflectivity-Tools.package/DoOnlyOnceIconStyler.class/definition.st A Reflectivity-Tools.package/DoOnlyOnceIconStyler.class/instance/defaults/iconBlock_.st A Reflectivity-Tools.package/DoOnlyOnceIconStyler.class/instance/defaults/iconFor_.st A Reflectivity-Tools.package/DoOnlyOnceIconStyler.class/instance/defaults/iconLabelBlock_.st A Reflectivity-Tools.package/DoOnlyOnceIconStyler.class/instance/testing/shouldStyleNode_.st A Reflectivity-Tools.package/ExecutionCounter.class/class/cleanup/resetAll.st A Reflectivity-Tools.package/ExecutionCounter.class/instance/accessing/count.st R Reflectivity-Tools.package/ExecutionCounter.class/instance/as yet unclassified/count.st R Reflectivity-Tools.package/ExecutionCounter.class/instance/as yet unclassified/increase.st A Reflectivity-Tools.package/ExecutionCounter.class/instance/counter/increase.st A Reflectivity-Tools.package/ExecutionCounter.class/instance/counter/reset.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60113.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60114.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60113.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60114.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M System-Support.package/ExternalSemaphoreTable.class/class/private/freedSlotsIn_ratherThanIncreaseSizeTo_.st M System-Support.package/VirtualMachine.class/instance/attributes/maxExternalSemaphores_.st Log Message: ----------- 60114 18614 add a "Debug" menu for halt / breakpoints https://pharo.fogbugz.com/f/cases/18614 18599 use sendsAnySelectorOf: in RBBadMessageRule https://pharo.fogbugz.com/f/cases/18599 18611 Fix warnings that refer to inexistant methods (maxExternalObjects & maxExternalObjectsSilently:) https://pharo.fogbugz.com/f/cases/18611 18305 MCWorkingCopyBrowser class>>#order would benefit to have a comment https://pharo.fogbugz.com/f/cases/18305 18605 add DoOnlyOnceIconStyler https://pharo.fogbugz.com/f/cases/18605 http://files.pharo.org/image/60/60114.zip

June 26, 2016

Re: [Pharo-dev] pharo 5 segfault (stack size?) [FreeBSD]

by Ben Coman

On Sun, Jun 26, 2016 at 8:37 PM, Petr Fischer <petr.fischer(a)me.com> wrote: > Yes there is "PharoVMBuilder buildFreeBSD", but some "cog*" errors occurs... So I am still building with "PharoVMSpur32Builder buildUnix32" under Linux (CentOS6) and then move compiled vm to my FreeBSD box with Linux compatibility layer. > > I compiled DEBUG vm version according to your advice and this is gdb output: > > Program received signal SIGSEGV, Segmentation fault. > 0x080aefc1 in scavengeReferentsOf (referrer=684415032) at /home/pf/pharo/pharo-vm-debug/src/vm/gcc3x-cointerp.c:39014 > 39014 if (((longAt(referent)) & ((classIndexMask()) - (isForwardedObjectClassIndexPun()))) == 0) { The C files are generated from VMMaker and the line numbers change a lot. If you look upwards in the C file you should see a generated comment that links to the Smalltalk source it was generated from. > > I need to learn a little, how to play this "core C" game in gdb... > What next? I recently learnt a bit of using gdb on the image. I'm planning to write up something but its a few weeks off. The old post How to debug the VM? [1] by Mariano needs a bit of adaption, but got me off to a good start. If you look in VMMaker package where #printAllStacks is defined you'll see some others you can call, that just print the current Smalltalk call stack. [1] https://marianopeck.wordpress.com/2011/04/23/how-to-debug-the-vm/ > > A also compiled PharoS (Pharo Stack) VM, and it's 5x slower, but stable, there is no stack errors (or other crashes) like in cog spur vm. You might also try compiling the VM from upstream sources[2], running either: * vm/build.linux32x86/squeak.cog.spur/build.debug/mvm * vm/build.linux64x64/squeak.cog.spur/build.debug/mvm Did you try the early 64-bit Pharo Image [3] suggested by Esteban in another thread ? Also, you might try Squeak 64-bit Image, since its the platform Eliot develops the VM on, so it is further advanced in 64-bit stability. Run vm/image/buildspurtrunk64image.sh. [2] https://github.com/OpenSmalltalk/vm [3] http://files.pharo.org/get-files/60/pharo-64.zip Now since you are getting down and dirty debugging this at VM level, probably good to shift this thread to [vm-dev]. http://lists.squeakfoundation.org/mailman/listinfo/vm-dev cheers -ben > > pf > > >> You could build a debug VM from here >> https://github.com/pharo-project/pharo-vm >> I also glimpsed some FreeBSD build options there you might try. >> cheers -ben >> >> On Fri, Jun 24, 2016 at 12:05 PM, Petr Fischer <petr.fischer(a)me.com> wrote: >> >> > So... I compiled latest sources (blessed) on CentOS 6.8, fine, moved >> > compiled binaries to FreeBSD and tried to load Seaside to the latest 50760 >> > image. >> > Still stack errors, log here: http://pastebin.com/raw/bf1EpWNt >> > >> > When I run this on CentOS, everything is fine (loading Seaside, no stack >> > errors), but when I run the same on FreeBSD, stack errors (segfaults) >> > occurs. >> > >> > So... There is something bad on FreeBSD side? Can I debug more? >> > >> > pf >> > >> > >> > > Try 50760 from... >> > > http://files.pharo.org/image/50/ >> > > >> > > cheers -ben >> > > >> > > On Sat, Jun 18, 2016 at 12:49 AM, Petr Fischer <petr.fischer(a)me.com> >> > wrote: >> > > > VM version (from >> > https://swing.fit.cvut.cz/jenkins/job/pharo-vm-spur-swing/) >> > > > >> > > > 5.0 #1 Sun Jan 17 14:19:14 CET 2016 gcc 4.7.2 [Production Spur ITHB VM] >> > > > CoInterpreter VMMaker.oscog-eem.1630 uuid: >> > 2ed025ea-f400-4440-8e8b-5aa46d06c9ab Jan 17 2016 >> > > > StackToRegisterMappingCogit VMMaker.oscog-eem.1630 uuid: >> > 2ed025ea-f400-4440-8e8b-5aa46d06c9ab Jan 17 2016 >> > > > https://github.com/estebanlm/pharo-vm.git Commit: >> > 21ec004cce7d26010c18d357c805a0e1a4ffe376 Date: 2016-01-14 11:42:33 +0100 >> > By: Esteban Lorenzano <estebanlm(a)gmail.com> Jenkins build #498 >> > > > Linux swing-hudson-lin64 3.2.0-4-amd64 #1 SMP Debian 3.2.73-2+deb7u2 >> > x86_64 GNU/Linux >> > > > plugin path: /usr/home/pf/Work/Smalltalk/pharo5.0.centos/bin [default: >> > /usr/home/pf/Work/Smalltalk/pharo5.0.centos/bin/] >> > > > >> > > > Image version (from official 5.0 download): >> > > > >> > > > [version] 5.0 #50723 >> > > > >> > > > pf >> > > > >> > > >> in fact, this is not related to FFIâ¦ but it should be fixedâ¦ >> > > >> >> > > >> along with the VM version, which version of Pharo are you using? >> > > >> >> > > >> Esteban >> > > >> >> > > >> > On 17 Jun 2016, at 14:04, Max Leske <maxleske(a)gmail.com> wrote: >> > > >> > >> > > >> > Hi Petr, >> > > >> > >> > > >> > That looks like a bug with FreeType with our FFI. It should >> > actually have been fixed but I donât know if the VM for FreeBSD is up to >> > date. Can you post the output of âSmalltalk vm versionâ? >> > > >> > >> > > >> > Cheers, >> > > >> > Max >> > > >> > >> > > >> >> On 17 Jun 2016, at 13:26, Petr Fischer <petr.fischer(a)me.com> >> > wrote: >> > > >> >> >> > > >> >> Hello, I got some random segfaults (while loading Seaside) with 32 >> > bit spur vm on FreeBSD - can someone (with low level knowledge) decode >> > attached log? >> > > >> >> Is this some problem with stack size? Can I fix this? >> > > >> >> >> > > >> >> Log: >> > > >> >> http://pastebin.com/raw/NpFUnjh0 >> > > >> >> >> > > >> >> There is "**StackOverflow**" lines n the log...

June 26, 2016

Re: [Pharo-dev] UDBCSQLite3Statement>>at:putDateTime: and DateAndTime>>readFrom:defaultOffset:

by Sven Van Caekenberghe

> On 26 Jun 2016, at 14:59, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi All, > > UDBCSQLite3Statement>>at:putDateTime: currently writes date and times > using DateAndTime's default print string, i.e. > YYYY-MM-DDTHH:MM:SS.mmmmmm+hh:ss > > SQLite3 doesn't support timezones, and expects text formatted date/times > to be: > > YYYY-MM-DD HH:MM:SS.mmm > > See: https://www.sqlite.org/datatype3.html > > The concensus, as far as I can tell, is that UTC times should always be > stored (which seems to be the only sensible option). > > Changing UDBCSQLite3Statement>>at:putDateTime: to: > > at: aColumn putDateTime: aDateTime > "Put the supplied DateAndTime in column aColumn. > > SQLite3 supports three date/time formats: text, real (Julian day), integer (unix seconds). > We use the ISO8601 text format: YYYY-MM-DD HH:MM:SS.SSS > See https://www.sqlite.org/datatype3.html" > > | s | > > s := UDBCSQLite3DateTimeString streamContents: [ :stream | |utc | > utc := aDateTime asDateAndTime asUTC. > utc printYMDOn: stream. > stream nextPut: Character space. > utc printHMSOn: stream. > stream nextPut: $.. > stream nextPutAll: ((aDateTime nanoSecond / 1000000) rounded printPaddedWith: $0 to: 3) ]. > ^ self library with: handle at: aColumn putString: s > > > writes date / times in the correct format. > > Note that SQLite3 doesn't do much in the way of format checking, so the > old implementation didn't raise an error, but can cause problems if the > database is shared with other applications that follow the rules (which > is why I hit this problem). > > To provide some backward compatibility, and follow the rule of being > strict in what you write and forgiving in what you read, we need to > modify UDBCSQLite3Statement>>dateTimeAt: to accept timezones when > supplied, or default to UTC time. > > Unfortunately, the current DateAndTime>>readFrom: method assumes the > local timezone if none is specified. > > I can think of two approaches to solve this: > > 1. Modify UDBCSQLite3Statement>>dateTimeAt: to add 'Z' to the string if > no timezone is specified, i.e. make UTC explicit. > > 2. Extend DateAndTime class to support #readFrom:defaultOffset: so > that UTC can be specified as the default, instead of the local timezone, > and modify UDBCSQLite3Statement>>dateTimeAt: to use UTC as the default. > > I prefer the second approach, but realise that this is a change to the > core Pharo classes, so will implement the first if that is the concensus. > I've included the modified methods for the second approach below. Yes, option 2 is the right way to go. Your code looks OK from a cursory look. Please propose a real slice and make certain you add a couple of good unit tests, this is really crucial. > The existing automated tests fail if only #at:putDateTime: is modified, > and succeed if both #at:putDateTime: and #dateTimeAt: are modified. > > What do you think? > > Thanks! > Alistair > > > UDBCSQLite3Statement>>dateTimeAt: aColumn > | utc | > utc := DateAndTime readFrom: (self library stringFrom: handle at: aColumn) readStream defaultOffset: Duration zero. > ^utc offset: DateAndTime localOffset. > > > > All methods from DateAndTime class>> > > > readFrom: aStream defaultOffset: defaultOffset > "Parse and return a new DateAndTime instance from stream, > as a Date, an optional Time and an optional TimeZone offset. > The time defaults to midnight, the timezone to defaultOffset" > "self readFrom: '2013-03-04T23:47:52.876+01:00' readStream" > > | date time offset | > date := Date readFrom: aStream. > [ aStream atEnd or: [ '0123456789Z+-' includes: aStream peek ] ] > whileFalse: [ aStream next ]. > ('0123456789' includes: aStream peek) > ifTrue: [ time := Time readFrom: aStream ] > ifFalse: [ time := Time midnight ]. > aStream skipSeparators. > offset := self readTimezoneOffsetFrom: aStream default: defaultOffset. > ^ self > year: date year > month: date monthIndex > day: date dayOfMonth > hour: time hour > minute: time minute > second: time second > nanoSecond: time nanoSecond > offset: offset > > > > readFrom: aStream > "Parse and return a new DateAndTime instance from stream, > as a Date, an optional Time and an optional TimeZone offset. > The time defaults to midnight, the timezone to the local offset" > "self readFrom: '2013-03-04T23:47:52.876+01:00' readStream" > > ^self readFrom: aStream defaultOffset: self localOffset. > > > > readTimezoneOffsetFrom: stream default: defaultOffset > "Read and return an optional timezone offset in the form of > [+|-]hh[[separator]mm[[separator]ss]] or Z from stream as a duration. > If there is no offset, return the defaultOffset." > > | sign hour minute second | > (stream peekFor: $Z) ifTrue: [ ^ Duration zero ]. > hour := minute := second := 0. > ^ ('+-' includes: stream peek) > ifTrue: [ > sign := stream next = $- ifTrue: [ -1 ] ifFalse: [ 1 ]. > hour := self readTwoDigitIntegerFrom: stream. > (self readOptionalSeparatorFrom: stream) > ifNotNil: [ > minute := self readTwoDigitIntegerFrom: stream. > (self readOptionalSeparatorFrom: stream) > ifNotNil: [ > second := Integer readFrom: stream ] ]. > Duration seconds: sign * ((hour * 3600) + (minute * 60) + second) ] > ifFalse: [ defaultOffset ] > > > > readTimezoneOffsetFrom: stream > "Read and return an optional timezone offset in the form of > [+|-]hh[[separator]mm[[separator]ss]] or Z from stream as a duration. > If there is no offset, return the local offset." > > ^self readTimezoneOffsetFrom: stream default: self localOffset >

June 26, 2016

Re: [Pharo-dev] pharo 5 segfault (stack size?) [FreeBSD]

by Ben Coman

On Fri, Jun 17, 2016 at 8:04 PM, Max Leske <maxleske(a)gmail.com> wrote: > Hi Petr, > > That looks like a bug with FreeType with our FFI. It should actually have been fixed but I donât know if the VM for FreeBSD is up to date. Can you post the output of âSmalltalk vm versionâ? > > Cheers, > Max > Petr, Based on Max's suggestion, have you tried turning FreeType off? World > System > Settings > Apperance > Use Free Type. IIUC this will fall back to using built-in Strike Fonts [1], and maybe just bypass the issue?? [1] http://pharo.gemtalksystems.com/book/LanguageAndLibraries/fonts_in_pharo/st… P.S. Just curious, in the philosophy of trimming down the Pharo Image size, are Strike Fonts a candidate for removal. It seems like having an in-Image fall back is potentially useful when porting to new platforms. cheers -ben >> On 17 Jun 2016, at 13:26, Petr Fischer <petr.fischer(a)me.com> wrote: >> >> Hello, I got some random segfaults (while loading Seaside) with 32 bit spur vm on FreeBSD - can someone (with low level knowledge) decode attached log? >> Is this some problem with stack size? Can I fix this? >> >> Log: >> http://pastebin.com/raw/NpFUnjh0 >> >> There is "**StackOverflow**" lines n the log... >> >> Thanks! pf >> > >

June 26, 2016

UDBCSQLite3Statement>>at:putDateTime: and DateAndTime>>readFrom:defaultOffset:

by Alistair Grant

Hi All, UDBCSQLite3Statement>>at:putDateTime: currently writes date and times using DateAndTime's default print string, i.e. YYYY-MM-DDTHH:MM:SS.mmmmmm+hh:ss SQLite3 doesn't support timezones, and expects text formatted date/times to be: YYYY-MM-DD HH:MM:SS.mmm See: https://www.sqlite.org/datatype3.html The concensus, as far as I can tell, is that UTC times should always be stored (which seems to be the only sensible option). Changing UDBCSQLite3Statement>>at:putDateTime: to: at: aColumn putDateTime: aDateTime "Put the supplied DateAndTime in column aColumn. SQLite3 supports three date/time formats: text, real (Julian day), integer (unix seconds). We use the ISO8601 text format: YYYY-MM-DD HH:MM:SS.SSS See https://www.sqlite.org/datatype3.html" | s | s := UDBCSQLite3DateTimeString streamContents: [ :stream | |utc | utc := aDateTime asDateAndTime asUTC. utc printYMDOn: stream. stream nextPut: Character space. utc printHMSOn: stream. stream nextPut: $.. stream nextPutAll: ((aDateTime nanoSecond / 1000000) rounded printPaddedWith: $0 to: 3) ]. ^ self library with: handle at: aColumn putString: s writes date / times in the correct format. Note that SQLite3 doesn't do much in the way of format checking, so the old implementation didn't raise an error, but can cause problems if the database is shared with other applications that follow the rules (which is why I hit this problem). To provide some backward compatibility, and follow the rule of being strict in what you write and forgiving in what you read, we need to modify UDBCSQLite3Statement>>dateTimeAt: to accept timezones when supplied, or default to UTC time. Unfortunately, the current DateAndTime>>readFrom: method assumes the local timezone if none is specified. I can think of two approaches to solve this: 1. Modify UDBCSQLite3Statement>>dateTimeAt: to add 'Z' to the string if no timezone is specified, i.e. make UTC explicit. 2. Extend DateAndTime class to support #readFrom:defaultOffset: so that UTC can be specified as the default, instead of the local timezone, and modify UDBCSQLite3Statement>>dateTimeAt: to use UTC as the default. I prefer the second approach, but realise that this is a change to the core Pharo classes, so will implement the first if that is the concensus. I've included the modified methods for the second approach below. The existing automated tests fail if only #at:putDateTime: is modified, and succeed if both #at:putDateTime: and #dateTimeAt: are modified. What do you think? Thanks! Alistair UDBCSQLite3Statement>>dateTimeAt: aColumn | utc | utc := DateAndTime readFrom: (self library stringFrom: handle at: aColumn) readStream defaultOffset: Duration zero. ^utc offset: DateAndTime localOffset. All methods from DateAndTime class>> readFrom: aStream defaultOffset: defaultOffset "Parse and return a new DateAndTime instance from stream, as a Date, an optional Time and an optional TimeZone offset. The time defaults to midnight, the timezone to defaultOffset" "self readFrom: '2013-03-04T23:47:52.876+01:00' readStream" | date time offset | date := Date readFrom: aStream. [ aStream atEnd or: [ '0123456789Z+-' includes: aStream peek ] ] whileFalse: [ aStream next ]. ('0123456789' includes: aStream peek) ifTrue: [ time := Time readFrom: aStream ] ifFalse: [ time := Time midnight ]. aStream skipSeparators. offset := self readTimezoneOffsetFrom: aStream default: defaultOffset. ^ self year: date year month: date monthIndex day: date dayOfMonth hour: time hour minute: time minute second: time second nanoSecond: time nanoSecond offset: offset readFrom: aStream "Parse and return a new DateAndTime instance from stream, as a Date, an optional Time and an optional TimeZone offset. The time defaults to midnight, the timezone to the local offset" "self readFrom: '2013-03-04T23:47:52.876+01:00' readStream" ^self readFrom: aStream defaultOffset: self localOffset. readTimezoneOffsetFrom: stream default: defaultOffset "Read and return an optional timezone offset in the form of [+|-]hh[[separator]mm[[separator]ss]] or Z from stream as a duration. If there is no offset, return the defaultOffset." | sign hour minute second | (stream peekFor: $Z) ifTrue: [ ^ Duration zero ]. hour := minute := second := 0. ^ ('+-' includes: stream peek) ifTrue: [ sign := stream next = $- ifTrue: [ -1 ] ifFalse: [ 1 ]. hour := self readTwoDigitIntegerFrom: stream. (self readOptionalSeparatorFrom: stream) ifNotNil: [ minute := self readTwoDigitIntegerFrom: stream. (self readOptionalSeparatorFrom: stream) ifNotNil: [ second := Integer readFrom: stream ] ]. Duration seconds: sign * ((hour * 3600) + (minute * 60) + second) ] ifFalse: [ defaultOffset ] readTimezoneOffsetFrom: stream "Read and return an optional timezone offset in the form of [+|-]hh[[separator]mm[[separator]ss]] or Z from stream as a duration. If there is no offset, return the local offset." ^self readTimezoneOffsetFrom: stream default: self localOffset

June 26, 2016

Re: [Pharo-dev] Having comments for pragma?

by Tudor Girba

Hi, That is what I said. We need a meta-object that describes a Pragma instance. I said that we already had the need to have such a meta-object in Spotter and we created one that is called PragmaType. We can call it PramgaDescription as well, but the key point would be to casually connect the meta object and the instances. For example, besides the description, you still would like to know which parts of the image actually react to such a pragma, and this is where getting an idea of the logic that is making use of a pragma is very useful. For example, in the case of the debuggerCompleteToSender pragma, we have: - 15 annotations of methods - 2 methods that use the pragma So, you have 2 places to look for to understand that logic. You would not see this from a description only. Having a real meta-object allows us to complement a possible description with smarter analyses. Cheers, Doru > On Jun 26, 2016, at 2:29 PM, Alexandre Bergel <alexandre.bergel(a)me.com> wrote: > > I am not sure to get it. Why not simply having a class PragmaDescription that simply associate a comment to a selector ? > > Alexandre > >> On Jun 25, 2016, at 3:18 AM, Tudor Girba <tudor(a)tudorgirba.com> wrote: >> >> Hi, >> >> I believe we are missing a first class entity for a PragmaType. Essentially, I think that the class side of the Pragma class should become a full object. >> >> In fact, we already have a rudimentary version of this in Spotter because we needed an object to be able to browse all definitions of a certain pragma. >> >> So, now, I extended it with the concept of a user which is the list of all senders minus the methods that are annotated with a pragma. This helps distinguish the meaning of a pragma by looking at the code where it is being used. Perhaps we can find a better name than users. >> >> You can see these users in the inspector and in spotter: >> >> <pragma-type-users.png> >> >> I think we should build on this. >> >> What do you think? >> >> Cheers, >> Doru >> >> >>> On Jun 24, 2016, at 3:54 PM, Alexandre Bergel <alexandre.bergel(a)me.com> wrote: >>> >>> Hi! >>> >>> A pragma may be very obscure. For example, I do: >>> Pragma allInstances anyOne >>> => <debuggerCompleteToSender> >>> >>> If I want to know more about this <debuggerCompleteToSender> is actually quite challenging. >>> I see many methods having that pragma, but not idea what it is for. >>> I see that Halt>>signalerContext and Process>>complete: that use that pragma somehow. But still, I have no idea when I should use that pragma in my method. >>> >>> What about having a way to comment pragma? Maybe something like >>> -=-=-=-=-=-= >>> Object subclass: #Pragma >>> instanceVariableNames: 'method keyword arguments comment' >>> -=-=-=-=-=-= >>> >>> And a simple way to annotate pragmas? >>> Just an idea. >>> >>> Cheers, >>> Alexandre >>> -- >>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>> Alexandre Bergel http://www.bergel.eu >>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>> >>> >>> >> >> -- >> www.tudorgirba.com >> www.feenk.com >> >> "What we can governs what we wish." >> >> >> >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > -- www.tudorgirba.com www.feenk.com "Problem solving efficiency grows with the abstractness level of problem understanding."

June 26, 2016