June 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Having comments for pragma?

by Esteban Lorenzano

> On 27 Jun 2016, at 10:36, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > Hi. > > In Java annotations are first class objects. You can put behaviour and state on them. In Smalltalk you can't do this. thatâs why I was suggesting to make them objects instead simple selectors. but seems that people is scared :) > > 2016-06-26 22:00 GMT+02:00 stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>>: > Can be interesting for others: > > Java SE 8 allows type annotations anywhere that a type is used. Previously, annotations were only allowed on definitions. > > https://blogs.oracle.com/java-platform-group/entry/java_8_s_new_type <https://blogs.oracle.com/java-platform-group/entry/java_8_s_new_type> > > >

June 27, 2016

Re: [Pharo-dev] <primitive: 79 error: ec> question

by stepharo

Le 27/6/16 Ã 09:41, ClÃ©ment Bera a Ã©crit : > There is not only #primitive:error: but #primitive:module:error: and > #primitive:error:module: . Ok I understand now. > > Then when you look at Object>>#at:, it's written <primitive: 60> but > you could write <primitive: 60 error: ec>. I don't know why the error > code is not there by default, it could be for performance, but it is > supported and it is used to know why the primitive fails. So you can > look at all of the users of #primitive: and #primitive:module: too. > > When I do this in my Pharo image: > CompiledMethod allInstances count: [ :each | each primitive ~= 0 ] > I have 9136. > And all of them can have error code, though only 268 use it explicitly. Ok so the what is a primitive is the way to go. > > whatIsAPrimitive comment looks correct. There are little details to fix: > - LargeIntegers are 32 or 64 bits, not 16bits. > - the code convention for 'no lookup' is respected, but writting > 'optional' for optional primitive and 'essential' for essential > primitive is not done in many primitives in Pharo. Maybe it makes > sense for numbered primitive only. One needs to check where it's done, > where it's not done and why. Would be nice that someone knowing help us :) > > I think it's good to improve comments related to primitives as this is > one part of the system where you cannot understand what they do just > by reading the Smalltalk code. Thanks for doing that Stef. Yes this is my point. I want that people can learn just reading it. > > > > > On Sun, Jun 26, 2016 at 10:06 PM, stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > There are 28 users of primitive:error: not 400. > > So where can I find the others? Do you know if whatIsAPrimitive > description is up to date? > > Stef > > > Le 26/6/16 Ã 21:00, ClÃ©ment Bera a Ã©crit : >> All the primitives in the Cog have error codes. Pharo does not >> write it explicitly for each primitive, but Pharo could. Knowing >> why a primitive failed is very useful. The Cog support over 400 >> primitives. Do you want to copy that comment 400 times ? I don't >> think so. What if one wants to update that comment, one would >> need to update all the 400 comments ? That's insane and very hard >> to maintain. >> >> It would be nice to update the comment of Object >> class>>#whatIsAPrimitive with a paragraph on error code instead, >> such as the one you wrote. >> >> >> >> On Sun, Jun 26, 2016 at 8:00 PM, stepharo <stepharo(a)free.fr >> <mailto:stepharo@free.fr>> wrote: >> >> So could we have a nice method comments that I can add to all >> the primitive using this ec? >> >> Proposal: >> https://pharo.fogbugz.com/f/cases/18618/Better-additional-comment-for-primi… >> >> "ec is a special temporary variable that holds an error >> code. In the VM primitive, failure is indicated by a variable >> called primFailCode being non-zero. On activating a method >> with a failing primitive, if the index is in bounds of the >> primitiveFailCodes array in the VMspecialObjectsArray then >> the failure code substitutes the symbol in the >> primitiveFailCodes array, otherwise it supplies the integer >> value." >> >> Because what I like the most in smalltalk besides live coding >> is comments. >> >> Stef >> >> >> >> >> Le 22/6/16 Ã 17:25, ClÃ©ment Bera a Ã©crit : >>> It's a special case added a couple year ago to figure out >>> why a primitive fail. >>> >>> It's a special temporary variable that holds an error code. >>> The special object array defines a list of error code that >>> the VM can use to explain to the programmer why the >>> primitive failed, which are currently symbols. >>> >>> >>> >>> On Wed, Jun 22, 2016 at 4:22 PM, Max Leske >>> <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: >>> >>> >>> > On 22 Jun 2016, at 15:59, stepharo <stepharo(a)free.fr >>> <mailto:stepharo@free.fr>> wrote: >>> > >>> > Hi >>> > >>> > I want to explain where ec is coming. >>> > >>> > I thought that the arguments of pragmas could only be >>> literal and when I see ec it looks like a variable set >>> by the VM >>> > >>> > >>> > newMethod: numberOfBytes header: headerWord >>> > "Primitive. Answer an instance of me. The number of >>> literals (and other >>> > information) is specified by the headerWord (see >>> my class comment). >>> > The first argument specifies the number of fields >>> for bytecodes in the >>> > method. Fail if either argument is not a >>> SmallInteger, or if numberOfBytes >>> > is negative, or if memory is low. Once the header >>> of a method is set by >>> > this primitive, it cannot be changed to change the >>> number of literals. >>> > Essential. See Object documentation whatIsAPrimitive." >>> > >>> > <primitive: 79 error: ec> >>> > ec == #'insufficient object memory' ifTrue: >>> > [^self handleFailingNewMethod: numberOfBytes >>> header: headerWord]. >>> > ^self primitiveFailed >>> > >>> > >>> > Stef >>> > >>> > >>> >>> That is correct. Itâs still a literal though. >>> >>> >> >> > >

June 27, 2016

Re: [Pharo-dev] Having comments for pragma?

by Denis Kudriashov

Hi. In Java annotations are first class objects. You can put behaviour and state on them. In Smalltalk you can't do this. 2016-06-26 22:00 GMT+02:00 stepharo <stepharo(a)free.fr>: > Can be interesting for others: > > Java SE 8 allows type annotations anywhere that a type is used. > Previously, annotations were only allowed on definitions. > > https://blogs.oracle.com/java-platform-group/entry/java_8_s_new_type > > >

June 27, 2016

Re: [Pharo-dev] <primitive: 79 error: ec> question

by ClÃ©ment Bera

There is not only #primitive:error: but #primitive:module:error: and #primitive:error:module: . Then when you look at Object>>#at:, it's written <primitive: 60> but you could write <primitive: 60 error: ec>. I don't know why the error code is not there by default, it could be for performance, but it is supported and it is used to know why the primitive fails. So you can look at all of the users of #primitive: and #primitive:module: too. When I do this in my Pharo image: CompiledMethod allInstances count: [ :each | each primitive ~= 0 ] I have 9136. And all of them can have error code, though only 268 use it explicitly. whatIsAPrimitive comment looks correct. There are little details to fix: - LargeIntegers are 32 or 64 bits, not 16bits. - the code convention for 'no lookup' is respected, but writting 'optional' for optional primitive and 'essential' for essential primitive is not done in many primitives in Pharo. Maybe it makes sense for numbered primitive only. One needs to check where it's done, where it's not done and why. I think it's good to improve comments related to primitives as this is one part of the system where you cannot understand what they do just by reading the Smalltalk code. Thanks for doing that Stef. On Sun, Jun 26, 2016 at 10:06 PM, stepharo <stepharo(a)free.fr> wrote: > There are 28 users of primitive:error: not 400. > > So where can I find the others? Do you know if whatIsAPrimitive > description is up to date? > > Stef > > Le 26/6/16 Ã 21:00, ClÃ©ment Bera a Ã©crit : > > All the primitives in the Cog have error codes. Pharo does not write it > explicitly for each primitive, but Pharo could. Knowing why a primitive > failed is very useful. The Cog support over 400 primitives. Do you want to > copy that comment 400 times ? I don't think so. What if one wants to update > that comment, one would need to update all the 400 comments ? That's insane > and very hard to maintain. > > It would be nice to update the comment of Object class>>#whatIsAPrimitive > with a paragraph on error code instead, such as the one you wrote. > > > > On Sun, Jun 26, 2016 at 8:00 PM, stepharo <stepharo(a)free.fr> wrote: > >> So could we have a nice method comments that I can add to all the >> primitive using this ec? >> >> Proposal: >> https://pharo.fogbugz.com/f/cases/18618/Better-additional-comment-for-primi… >> >> "ec is a special temporary variable that holds an error code. In the >> VM primitive, failure is indicated by a variable called primFailCode being >> non-zero. On activating a method with a failing primitive, if the index is >> in bounds of the primitiveFailCodes array in the VMspecialObjectsArray then >> the failure code substitutes the symbol in the primitiveFailCodes array, >> otherwise it supplies the integer value." >> >> Because what I like the most in smalltalk besides live coding is >> comments. >> >> Stef >> >> >> >> >> Le 22/6/16 Ã 17:25, ClÃ©ment Bera a Ã©crit : >> >> It's a special case added a couple year ago to figure out why a primitive >> fail. >> >> It's a special temporary variable that holds an error code. The special >> object array defines a list of error code that the VM can use to explain to >> the programmer why the primitive failed, which are currently symbols. >> >> >> >> On Wed, Jun 22, 2016 at 4:22 PM, Max Leske < <maxleske(a)gmail.com> >> maxleske(a)gmail.com> wrote: >> >>> >>> > On 22 Jun 2016, at 15:59, stepharo <stepharo(a)free.fr> wrote: >>> > >>> > Hi >>> > >>> > I want to explain where ec is coming. >>> > >>> > I thought that the arguments of pragmas could only be literal and when >>> I see ec it looks like a variable set by the VM >>> > >>> > >>> > newMethod: numberOfBytes header: headerWord >>> > "Primitive. Answer an instance of me. The number of literals (and >>> other >>> > information) is specified by the headerWord (see my class comment). >>> > The first argument specifies the number of fields for bytecodes in >>> the >>> > method. Fail if either argument is not a SmallInteger, or if >>> numberOfBytes >>> > is negative, or if memory is low. Once the header of a method is >>> set by >>> > this primitive, it cannot be changed to change the number of >>> literals. >>> > Essential. See Object documentation whatIsAPrimitive." >>> > >>> > <primitive: 79 error: ec> >>> > ec == #'insufficient object memory' ifTrue: >>> > [^self handleFailingNewMethod: numberOfBytes header: >>> headerWord]. >>> > ^self primitiveFailed >>> > >>> > >>> > Stef >>> > >>> > >>> >>> That is correct. Itâs still a literal though. >>> >> >> >> > >

June 27, 2016

Re: [Pharo-dev] [Pharo-users] Image freezes on Linux if it was previously saved on Windows

by Nicolai Hess

Hm, I don't know what exactly happens. It seems this behavior started with Pharo 50574. Since that image version, the UUIDGenerator will be reset on startup. Maybe the initialization of the uuidgenerator (or the random seed) will access the filesystem and at this step the file system initialization traps into an infinit loop. What I don't understand is, why this only happens when the image was saved on a windows platform and reopened on a unix platform. Maybe, saving the image (or the shutDownList) does not fully cleanup the platform settings. Please open a bug entry. 2016-06-25 17:17 GMT+02:00 Maximiliano Tabacman via Pharo-users < pharo-users(a)lists.pharo.org>: > > > ---------- Weitergeleitete Nachricht ---------- > From: Maximiliano Tabacman <mtabacman(a)yahoo.com> > To: Any Question About Pharo Is Welcome <pharo-users(a)lists.pharo.org> > Cc: > Date: Sat, 25 Jun 2016 15:16:27 +0000 (UTC) > Subject: Image freezes on Linux if it was previously saved on Windows > Hi. I am not sure if this issue is known, or what files to provide to help > fix it. > In the latest image (60112, but my guess is that this will happen with all > Pharo 6 images) if I download a clean latest image, start Pharo on Windows, > save the image, then copy it to a Linux environment, and try to start it, > the image freezes even before displaying the workspace (I get an > unresponsive black and white box in Linux, only killable through xkill > command). > I am sure this did not happen back with Pharo 5. > If I output "./pharo Image.image > log.txt" I end up with a huge file > since there seems to be an infinite loop while trying to determine the > FileStore to use. > > The first lines of this output file, before going into the loop, are: > > out of memory > > /home/theUser/Downloads/Pharo6/pharo > pharo VM version: 5.0 #1 Tue Jun 21 12:37:33 CEST 2016 gcc 4.6.3 > [Production Spur ITHB VM] > Built from: CoInterpreter VMMaker.oscog-HolgerHansPeterFreyther.1880 uuid: > 16138eb3-2390-40f5-a6c8-15f0494936f8 Jun 21 2016 > With: StackToRegisterMappingCogit > VMMaker.oscog-HolgerHansPeterFreyther.1880 uuid: > 16138eb3-2390-40f5-a6c8-15f0494936f8 Jun 21 2016 > Revision: https://github.com/pharo-project/pharo-vm.git Commit: > 9638b0190a9fc01479bfb752becd96edfd253c8c Date: 2016-06-21 12:29:26 +0200 > By: GitHub <noreply(a)github.com> Jenkins build #594 > Build host: Linux pharo-linux 3.2.0-31-generic-pae #50-Ubuntu SMP Fri Sep > 7 16:39:45 UTC 2012 i686 i686 i386 GNU/Linux > plugin path: /home/theUser/Downloads/Pharo6/ [default: > /home/theUser/Downloads/Pharo6/] > > > C stack backtrace & registers: > *./pharo[0x80c133c] > ./pharo(error+0x17)[0x80c1547] > ./pharo[0x809a26c] > ./pharo[0x809a301] > ./pharo[0x809a53d] > ./pharo[0x809bf13] > ./pharo[0x80a6b61] > ./pharo[0x80ae4ca] > ./pharo[0x80ae6ba] > ./pharo[0x80af07f] > ./pharo[0x80afcf4] > ./pharo(ceSendsupertonumArgs+0x1d8)[0x80b0098] > [0x990008d] > [0x990de03] > [0x99090af] > [0x9900b70] > [0x990dda3] > [0x990de03] > [0x99090af] > [0x9900b40] > [0xffe95808] > > > Smalltalk stack dump: > 0xffe9e9f8 I MacStore class(Class)>subclassesDo: 0xa3393f0: a(n) MacStore > class > 0xffe9ea14 M MacStore class(Behavior)>allSubclassesDo: 0xa3393f0: a(n) > MacStore class > 0xffe9ea34 M [] in UnixStore class(Behavior)>allSubclassesDo: 0xa339380: > a(n) UnixStore class > 0xffe9ea58 M Array(SequenceableCollection)>do: 0x9ded798: a(n) Array > 0xffe9ea7c I UnixStore class(Class)>subclassesDo: 0xa339380: a(n) > UnixStore class > 0xffe9ea98 M UnixStore class(Behavior)>allSubclassesDo: 0xa339380: a(n) > UnixStore class > 0xffe9eab8 M [] in DiskStore class(Behavior)>allSubclassesDo: 0xa339310: > a(n) DiskStore class > 0xffe9eadc M Array(SequenceableCollection)>do: 0x9ded710: a(n) Array > 0xffe9d7c8 I DiskStore class(Class)>subclassesDo: 0xa339310: a(n) > DiskStore class > 0xffe9d7e4 M DiskStore class(Behavior)>allSubclassesDo: 0xa339310: a(n) > DiskStore class > 0xffe9d800 M DiskStore class>activeClass 0xa339310: a(n) DiskStore class > 0xffe9d81c M DiskStore class>currentFileSystem 0xa339310: a(n) DiskStore > class > 0xffe9d834 M DiskStore class>current 0xa339310: a(n) DiskStore class > 0xffe9d84c M DiskStore class>delimiter 0xa339310: a(n) DiskStore class > 0xffe9d864 M DiskStore(FileSystemStore)>delimiter 0x9deb478: a(n) DiskStore > 0xffe9d884 M DiskStore(FileSystemStore)>pathFromString: 0x9deb478: a(n) > DiskStore > 0xffe9d8a4 M DiskStore>defaultWorkingDirectory 0x9deb478: a(n) DiskStore > 0xffe9d8bc M FileSystem>initializeWithStore: 0x9deb488: a(n) FileSystem > 0xffe9d8dc M FileSystem class>store: 0xa2e2978: a(n) FileSystem class > 0xffe9d8f8 M DiskStore class>currentFileSystem 0xa339310: a(n) DiskStore > class > > ... and so on...from #currentFileSystem to #store: and again... > > Thanks for any feedback and/or insight on how I should proceed to avoid > this from happening, or what bug should I monitor to know when this might > be fixed. > > >

June 26, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60118 Home: https://github.com/pharo-project/pharo-core

June 26, 2016

[pharo-project/pharo-core] 085e0a: 60118

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 085e0a695dc5dad0653056fd2b7817c422689f4d https://github.com/pharo-project/pharo-core/commit/085e0a695dc5dad0653056fd… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-06-26 (Sun, 26 Jun 2016) Changed paths: A Kernel-Tests.package/ClassTest.class/instance/testing - navigation/testMethodsReferencingClass.st A Kernel-Tests.package/ClassTest.class/instance/testing - navigation/testMethodsReferencingClasses.st A Kernel-Tests.package/ClassTest.class/instance/testing - navigation/testReferencedClasses.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60117.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60118.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60117.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60118.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M System-Support.package/extension/CompiledMethod/instance/referencedClasses.st A Traits.package/TBehavior.class/instance/navigation/methodsReferencingClass_.st A Traits.package/TBehavior.class/instance/navigation/methodsReferencingClasses_.st Log Message: ----------- 60118 18334 All classes referenced from a class https://pharo.fogbugz.com/f/cases/18334 http://files.pharo.org/image/60/60118.zip

June 26, 2016

Re: [Pharo-dev] <primitive: 79 error: ec> question

by stepharo

There are 28 users of primitive:error: not 400. So where can I find the others? Do you know if whatIsAPrimitive description is up to date? Stef Le 26/6/16 Ã 21:00, ClÃ©ment Bera a Ã©crit : > All the primitives in the Cog have error codes. Pharo does not write > it explicitly for each primitive, but Pharo could. Knowing why a > primitive failed is very useful. The Cog support over 400 primitives. > Do you want to copy that comment 400 times ? I don't think so. What if > one wants to update that comment, one would need to update all the 400 > comments ? That's insane and very hard to maintain. > > It would be nice to update the comment of Object > class>>#whatIsAPrimitive with a paragraph on error code instead, such > as the one you wrote. > > > > On Sun, Jun 26, 2016 at 8:00 PM, stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > So could we have a nice method comments that I can add to all the > primitive using this ec? > > Proposal: > https://pharo.fogbugz.com/f/cases/18618/Better-additional-comment-for-primi… > > "ec is a special temporary variable that holds an error code. > In the VM primitive, failure is indicated by a variable called > primFailCode being non-zero. On activating a method with a failing > primitive, if the index is in bounds of the primitiveFailCodes > array in the VMspecialObjectsArray then the failure code > substitutes the symbol in the primitiveFailCodes array, otherwise > it supplies the integer value." > > Because what I like the most in smalltalk besides live coding is > comments. > > Stef > > > > > Le 22/6/16 Ã 17:25, ClÃ©ment Bera a Ã©crit : >> It's a special case added a couple year ago to figure out why a >> primitive fail. >> >> It's a special temporary variable that holds an error code. The >> special object array defines a list of error code that the VM can >> use to explain to the programmer why the primitive failed, which >> are currently symbols. >> >> >> >> On Wed, Jun 22, 2016 at 4:22 PM, Max Leske <maxleske(a)gmail.com >> <mailto:maxleske@gmail.com>> wrote: >> >> >> > On 22 Jun 2016, at 15:59, stepharo <stepharo(a)free.fr >> <mailto:stepharo@free.fr>> wrote: >> > >> > Hi >> > >> > I want to explain where ec is coming. >> > >> > I thought that the arguments of pragmas could only be >> literal and when I see ec it looks like a variable set by the VM >> > >> > >> > newMethod: numberOfBytes header: headerWord >> > "Primitive. Answer an instance of me. The number of >> literals (and other >> > information) is specified by the headerWord (see my >> class comment). >> > The first argument specifies the number of fields for >> bytecodes in the >> > method. Fail if either argument is not a SmallInteger, >> or if numberOfBytes >> > is negative, or if memory is low. Once the header of a >> method is set by >> > this primitive, it cannot be changed to change the >> number of literals. >> > Essential. See Object documentation whatIsAPrimitive." >> > >> > <primitive: 79 error: ec> >> > ec == #'insufficient object memory' ifTrue: >> > [^self handleFailingNewMethod: numberOfBytes header: >> headerWord]. >> > ^self primitiveFailed >> > >> > >> > Stef >> > >> > >> >> That is correct. Itâs still a literal though. >> >> > >

June 26, 2016

Re: [Pharo-dev] Having comments for pragma?

by stepharo

Can be interesting for others: Java SE 8 allows type annotations anywhere that a type is used. Previously, annotations were only allowed on definitions. https://blogs.oracle.com/java-platform-group/entry/java_8_s_new_type

June 26, 2016

Re: [Pharo-dev] <primitive: 79 error: ec> question

by ClÃ©ment Bera

All the primitives in the Cog have error codes. Pharo does not write it explicitly for each primitive, but Pharo could. Knowing why a primitive failed is very useful. The Cog support over 400 primitives. Do you want to copy that comment 400 times ? I don't think so. What if one wants to update that comment, one would need to update all the 400 comments ? That's insane and very hard to maintain. It would be nice to update the comment of Object class>>#whatIsAPrimitive with a paragraph on error code instead, such as the one you wrote. On Sun, Jun 26, 2016 at 8:00 PM, stepharo <stepharo(a)free.fr> wrote: > So could we have a nice method comments that I can add to all the > primitive using this ec? > > Proposal: > https://pharo.fogbugz.com/f/cases/18618/Better-additional-comment-for-primi… > > "ec is a special temporary variable that holds an error code. In the > VM primitive, failure is indicated by a variable called primFailCode being > non-zero. On activating a method with a failing primitive, if the index is > in bounds of the primitiveFailCodes array in the VMspecialObjectsArray then > the failure code substitutes the symbol in the primitiveFailCodes array, > otherwise it supplies the integer value." > > Because what I like the most in smalltalk besides live coding is comments. > > Stef > > > > > Le 22/6/16 Ã 17:25, ClÃ©ment Bera a Ã©crit : > > It's a special case added a couple year ago to figure out why a primitive > fail. > > It's a special temporary variable that holds an error code. The special > object array defines a list of error code that the VM can use to explain to > the programmer why the primitive failed, which are currently symbols. > > > > On Wed, Jun 22, 2016 at 4:22 PM, Max Leske <maxleske(a)gmail.com> wrote: > >> >> > On 22 Jun 2016, at 15:59, stepharo < <stepharo(a)free.fr>stepharo(a)free.fr> >> wrote: >> > >> > Hi >> > >> > I want to explain where ec is coming. >> > >> > I thought that the arguments of pragmas could only be literal and when >> I see ec it looks like a variable set by the VM >> > >> > >> > newMethod: numberOfBytes header: headerWord >> > "Primitive. Answer an instance of me. The number of literals (and >> other >> > information) is specified by the headerWord (see my class comment). >> > The first argument specifies the number of fields for bytecodes in >> the >> > method. Fail if either argument is not a SmallInteger, or if >> numberOfBytes >> > is negative, or if memory is low. Once the header of a method is >> set by >> > this primitive, it cannot be changed to change the number of >> literals. >> > Essential. See Object documentation whatIsAPrimitive." >> > >> > <primitive: 79 error: ec> >> > ec == #'insufficient object memory' ifTrue: >> > [^self handleFailingNewMethod: numberOfBytes header: headerWord]. >> > ^self primitiveFailed >> > >> > >> > Stef >> > >> > >> >> That is correct. Itâs still a literal though. >> > > >

June 26, 2016