May 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] lineConversion for WriteStream

by Sven Van Caekenberghe

> On 26 May 2016, at 14:06, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > > On Thu, May 26, 2016 at 1:40 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > > On 26 May 2016, at 13:29, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > > > In general I would say that you should write either something platform specific or you write something specific > > > > Except that I cannot do that because the system doesn't support neither. > > And the fact that the default line ending is CR is just bullshitâ¦ it's 2016, not 1986. > > Yes, that CR is from days long gone ;-) > > > or #cr #lf or #crlf as needed, and/or make that last one a parameter (OSPlatform current lineEnding). > > I am piping unknown content into the file, thus the need for `lineEndConvention:` and the reason of this entire thread. So as I said, the system doesn't support it. > I know I can use #lf or whatnot, but I am not creating the content, I am saving it. > > Peter Well, maybe I don't understand your use case, but if you do not know what is inside, why not save it as is, binary even, not doing any conversions ?

May 26, 2016

Re: [Pharo-dev] lineConversion for WriteStream

by Peter UhnÃ¡k

On Thu, May 26, 2016 at 1:40 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > > On 26 May 2016, at 13:29, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > > > In general I would say that you should write either something > platform specific or you write something specific > > > > Except that I cannot do that because the system doesn't support neither. > > And the fact that the default line ending is CR is just bullshitâ¦ it's > 2016, not 1986. > > Yes, that CR is from days long gone ;-) > > > or #cr #lf or #crlf as needed, and/or make that last one a parameter > (OSPlatform current lineEnding). > I am piping unknown content into the file, thus the need for `lineEndConvention:` and the reason of this entire thread. So as I said, the system doesn't support it. I know I can use #lf or whatnot, but I am not creating the content, I am saving it. Peter

May 26, 2016

Re: [Pharo-dev] lineConversion for WriteStream

by Sven Van Caekenberghe

> On 26 May 2016, at 13:29, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > In general I would say that you should write either something platform specific or you write something specific > > Except that I cannot do that because the system doesn't support neither. > And the fact that the default line ending is CR is just bullshitâ¦ it's 2016, not 1986. Yes, that CR is from days long gone ;-) But you can certainly do whatever you want, you have to use the right streams. Make sure you start with a binary stream, wrap it to do character encoding/decoding, use #readLine, or #cr #lf or #crlf as needed, and/or make that last one a parameter (OSPlatform current lineEnding). > On Thu, May 26, 2016 at 12:37 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > MultiByteFileStream is terrible (too complex) because it does too much (at once). Let's keep WriteStream simple (and even simplify it). You do not want characters that change magically. > > That being said, line end conventions can be a pain. In general I would say that you should write either something platform specific (you can fetch the EOL terminator somewhere), or you write something specific (say CRLF for web stuff), while during reading you should accept anything (that is easy to do). You know: be strict in what you produce, liberal in what you accept. > > > On 26 May 2016, at 11:39, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > > Is there a reason why only MultiByteFileStream provides lineEndConvention: and not WriteStream? > > > > The problem is that if I use MemoryStore in tests it breaks, because DiskStore and MemoryStore return different write streams. > > > > '/tmp/test.txt' asFileReference writeStream ==> "MultiByteFileStream: '/tmp/test.txt'". > > (FileSystem memory / 'test.txt') writeStream ==> "a WriteStream" > > > > Can we either: > > > > a) have `lineEndConvention:` directly in the WriteStream, or > > b) have MemoryStore return MultiByteFileStream, or > > c) both? > > > > Thanks, > > Peter > > >

May 26, 2016

Re: [Pharo-dev] lineConversion for WriteStream

by Peter UhnÃ¡k

> In general I would say that you should write either something platform specific or you write something specific Except that I cannot do that because the system doesn't support neither. And the fact that the default line ending is CR is just bullshitâ¦ it's 2016, not 1986. On Thu, May 26, 2016 at 12:37 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > MultiByteFileStream is terrible (too complex) because it does too much (at > once). Let's keep WriteStream simple (and even simplify it). You do not > want characters that change magically. > > That being said, line end conventions can be a pain. In general I would > say that you should write either something platform specific (you can fetch > the EOL terminator somewhere), or you write something specific (say CRLF > for web stuff), while during reading you should accept anything (that is > easy to do). You know: be strict in what you produce, liberal in what you > accept. > > > On 26 May 2016, at 11:39, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > > Is there a reason why only MultiByteFileStream provides > lineEndConvention: and not WriteStream? > > > > The problem is that if I use MemoryStore in tests it breaks, because > DiskStore and MemoryStore return different write streams. > > > > '/tmp/test.txt' asFileReference writeStream ==> "MultiByteFileStream: > '/tmp/test.txt'". > > (FileSystem memory / 'test.txt') writeStream ==> "a WriteStream" > > > > Can we either: > > > > a) have `lineEndConvention:` directly in the WriteStream, or > > b) have MemoryStore return MultiByteFileStream, or > > c) both? > > > > Thanks, > > Peter > > >

May 26, 2016

Re: [Pharo-dev] lineConversion for WriteStream

by Sven Van Caekenberghe

MultiByteFileStream is terrible (too complex) because it does too much (at once). Let's keep WriteStream simple (and even simplify it). You do not want characters that change magically. That being said, line end conventions can be a pain. In general I would say that you should write either something platform specific (you can fetch the EOL terminator somewhere), or you write something specific (say CRLF for web stuff), while during reading you should accept anything (that is easy to do). You know: be strict in what you produce, liberal in what you accept. > On 26 May 2016, at 11:39, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > Is there a reason why only MultiByteFileStream provides lineEndConvention: and not WriteStream? > > The problem is that if I use MemoryStore in tests it breaks, because DiskStore and MemoryStore return different write streams. > > '/tmp/test.txt' asFileReference writeStream ==> "MultiByteFileStream: '/tmp/test.txt'". > (FileSystem memory / 'test.txt') writeStream ==> "a WriteStream" > > Can we either: > > a) have `lineEndConvention:` directly in the WriteStream, or > b) have MemoryStore return MultiByteFileStream, or > c) both? > > Thanks, > Peter

May 26, 2016

lineConversion for WriteStream

by Peter UhnÃ¡k

Is there a reason why only MultiByteFileStream provides lineEndConvention: and not WriteStream? The problem is that if I use MemoryStore in tests it breaks, because DiskStore and MemoryStore return different write streams. '/tmp/test.txt' asFileReference writeStream ==> "MultiByteFileStream: '/tmp/test.txt'". (FileSystem memory / 'test.txt') writeStream ==> "a WriteStream" Can we either: a) have `lineEndConvention:` directly in the WriteStream, or b) have MemoryStore return MultiByteFileStream, or c) both? Thanks, Peter

May 26, 2016

[pharo-project/pharo-core] 69e298: 60037

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 69e2984f201cba6b44e546813ccf99d1835d29bf https://github.com/pharo-project/pharo-core/commit/69e2984f201cba6b44e54681… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-05-26 (Thu, 26 May 2016) Changed paths: R Morphic-Widgets-PolyTabs.package/TabGroupMorph.class/instance/updating/themeChanged.st A Polymorph-Widgets.package/extension/TabGroupMorph/instance/themeChanged.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60036.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60037.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60036.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60037.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 60037 18323 TabGroupMorph should update the hidden tabs on theme changed https://pharo.fogbugz.com/f/cases/18323 http://files.pharo.org/image/60/60037.zip

May 26, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60037 Home: https://github.com/pharo-project/pharo-core

May 26, 2016

[pharo-project/pharo-core] c7a16f: 60036

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: c7a16f947b2e32fac904ed156f5406da3dd8d8c1 https://github.com/pharo-project/pharo-core/commit/c7a16f947b2e32fac904ed15… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-05-26 (Thu, 26 May 2016) Changed paths: A Deprecated60.package/extension/Object/instance/confirm_orCancel_.st M Kernel-Rules.package/FloatReferencesRule.class/instance/accessing/group.st R Kernel.package/Object.class/instance/user interface/confirm_orCancel_.st M MenuRegistration.package/MenuRegistrationExample.class/class/menu actions/quitSession.st M Morphic-Core.package/WorldState.class/class/world menu items/quitSession.st M Nautilus.package/AbstractNautilusUI.class/instance/styling/addIconStyle.st A Polymorph-Widgets.package/Pharo3DarkTheme.class/instance/accessing colors/lineNumberColor.st A Polymorph-Widgets.package/UITheme.class/instance/accessing colors/lineNumberColor.st M Refactoring-Critics.package/RBMissingTranslationsInMenusRule.class/instance/accessing/group.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60035.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60036.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60035.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60036.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Settings-Polymorph.package/PolymorphSystemSettings.class/class/morphic/morphicMenuSettingsOn_.st Log Message: ----------- 60036 17928 multiple "bug" categories in critics browser https://pharo.fogbugz.com/f/cases/17928 18234 Menus is spelt incorrectly in the setting browser https://pharo.fogbugz.com/f/cases/18234 18295 Object>>#confirm:onCancel: should be deprecated and users should use UIManager https://pharo.fogbugz.com/f/cases/18295 18202 AbstractNautilusUI>>addIconStyle should use allSubclassesDo https://pharo.fogbugz.com/f/cases/18202 18231 Define a color for secondary text in Theme https://pharo.fogbugz.com/f/cases/18231 http://files.pharo.org/image/60/60036.zip

May 26, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60036 Home: https://github.com/pharo-project/pharo-core

May 26, 2016