April 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Class allSubInstances size takes 23 seconds to run on Pharo 5 on OS X

by stepharo

If you know the answer I would like to know it too. Le 21/4/16 06:56, Bernhard Pieber a Ã©crit : > Hi Eliot, > > Right, but in the latest Squeak5.1-trunk with the latest CogSpur.r3663.app it takes only 3 milliseconds. I guess itâs just an optimized implementation, there. (Canât look right now.) > > Cheers, > Bernhard > >> Am 20.04.2016 um 17:43 schrieb Eliot Miranda <eliot.miranda(a)gmail.com>: >> >> Hi Bernhard, >> >> >>> On Apr 20, 2016, at 5:26 AM, Bernhard Pieber <bernhard(a)pieber.com> wrote: >>> >>> Dear Pharoers, >>> >>> I found something strange: >>> Time millisecondsToRun: [ Class allSubInstances size ]. â23617" >> Because it does an allInstances for Class and all its subclasses, and allInstances visits every object in the heap, so this does thousands of scans of the heap. >> >> >>> I did this on a new Pharo 5 image >>> curl get.pharo.org/alpha+vmLatest | bash >>> >>> Can somebody confirm this on their machine? What might be the reason? >>> >>> Cheers, >>> Bernhard > >

April 21, 2016

Smalltalk ui icons foo -> Smalltalk ui icons iconNamed: #foo

by stepharo

Hi guys With the changes made by esteban all the tools should be accessing icons using iconNamed: Yes Yuriy it would be good to have a nice QA rule Smalltalk ui icons foo -> Smalltalk ui icons iconNamed: #foo The DNU trick should be deprecated in Pharo 60. Could you update your tools and we will do it for all the non externally managed ones? Stef

April 21, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50703 Home: https://github.com/pharo-project/pharo-core

April 21, 2016

[pharo-project/pharo-core] 123359: 50703

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 123359bcc35b397dcae930bd0a596778c950edd8 https://github.com/pharo-project/pharo-core/commit/123359bcc35b397dcae930bd… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-04-21 (Thu, 21 Apr 2016) Changed paths: A Kernel.package/Integer.class/instance/private/montgomeryDigitBase.st A Kernel.package/Integer.class/instance/private/montgomeryDigitLength.st A Kernel.package/Integer.class/instance/private/montgomeryDigitMax.st A Kernel.package/Integer.class/instance/private/montgomeryNumberOfDigits.st M Kernel.package/Integer.class/instance/private/montgomeryRaisedTo_times_modulo_mInvModB_.st M Kernel.package/Integer.class/instance/private/montgomeryTimes_modulo_mInvModB_.st M Kernel.package/Integer.class/instance/private/slidingLeftRightRaisedTo_modulo_.st R Monticello.package/MCCacheRepository.class/class/private/resetIfInvalid.st A Monticello.package/MCCacheRepository.class/class/utility/reset.st A Monticello.package/MCCacheRepository.class/class/utility/resetIfInvalid.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50702.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50703.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50702.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50703.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50703 18027 add reset message to MCCacheRepository https://pharo.fogbugz.com/f/cases/18027 18034 testIsPrime is broken with modern VM made with LargeIntegersPlugin v2.0 https://pharo.fogbugz.com/f/cases/18034 http://files.pharo.org/image/50/50703.zip

April 21, 2016

Re: [Pharo-dev] Class allSubInstances size takes 23 seconds to run on Pharo 5 on OS X

by Bernhard Pieber

Hi Eliot, Right, but in the latest Squeak5.1-trunk with the latest CogSpur.r3663.app it takes only 3 milliseconds. I guess itâs just an optimized implementation, there. (Canât look right now.) Cheers, Bernhard > Am 20.04.2016 um 17:43 schrieb Eliot Miranda <eliot.miranda(a)gmail.com>: > > Hi Bernhard, > > >> On Apr 20, 2016, at 5:26 AM, Bernhard Pieber <bernhard(a)pieber.com> wrote: >> >> Dear Pharoers, >> >> I found something strange: >> Time millisecondsToRun: [ Class allSubInstances size ]. â23617" > > Because it does an allInstances for Class and all its subclasses, and allInstances visits every object in the heap, so this does thousands of scans of the heap. > > >> I did this on a new Pharo 5 image >> curl get.pharo.org/alpha+vmLatest | bash >> >> Can somebody confirm this on their machine? What might be the reason? >> >> Cheers, >> Bernhard >

April 21, 2016

Re: [Pharo-dev] Add download+uncompress behavior to Metacello?

by HernÃ¡n Morales Durand

Hi, I checked Metacello configurations but I don't know where to add such methods. One option is to add them to Object but I don't like to add methods there. I guess Metacello uses "template methods" somewhere but this download+uncompress feature is not something used by all projects. Where do you recommend to add them? HernÃ¡n 2016-04-19 10:47 GMT-03:00 stepharo <stepharo(a)free.fr>: > packaged them first :) > > Stef > > Le 19/4/16 15:14, HernÃ¡n Morales Durand a Ã©crit : > > >> Is there a chance to get this methods (or any better versions of them) >> added to Metacello? >> >> >>extractZip: fileRef in: dst >> " If fileRef is a ZIP archive, uncompress its contents in dst and >> delete it " >> >> | zipArchive | >> (fileRef fullName endsWith: '.zip') >> ifFalse: [ ^ self ]. >> zipArchive := ZipArchive new. >> [ zipArchive >> readFrom: fileRef fullName; >> extractAllTo: dst ] >> ensure: [ zipArchive close ]. >> fileRef delete >> >> >> >>extractGZip: fileRef in: dst >> " If fileRef is a ZIP archive, uncompress its contents in dst and >> delete it " >> >> | unzipped | >> (fileRef fullName endsWith: '.gz') >> ifFalse: [ ^ self ]. >> unzipped := GZipReadStream unzip: fileRef basename to: dst. >> (Smalltalk hasClassNamed: #OSProcess) >> ifTrue: [ >> (Smalltalk at: #OSProcess) thisOSProcess >> waitForCommandOutput: 'tar xvf ' , unzipped asFileReference fullName. >> fileRef delete. >> unzipped asFileReference delete ] >> >> >>uncompress: fileRef >> " Private - Uncompress fileRef to the current working directory " >> >> | dst | >> dst := FileSystem workingDirectory. >> self extractZip: fileRef in: dst. >> self extractGZip: fileRef in: dst. >> >> >>downloadResourcesFrom: urlString >> " Private - Download files from urlString " >> >> ^ [ ZnEasy get: urlString ] >> on: ZnEntityTooLarge >> do: [ : ex | ex resume ]. >> >> >> I use them to download external resources for my projects as follows: >> >> First I add a #preLoadDoIt: send in my baseline: >> >> spec for: #'common' do: [ >> spec blessing: #'baseline'. >> spec preLoadDoIt: #preLoad. >> .... >> >> >>preLoad >> >> | url fileRef response | >> >> self logCr: '====== Downloading my resource files...'. >> url := self platformFilesUrl asZnUrl. >> fileRef := FileSystem disk workingDirectory / url pathSegments last. >> (response := self downloadResourcesFrom: url) isSuccess >> ifTrue: [ >> self logCr: '====== Writing resource file...'. >> fileRef writeStreamDo: [ : stream | stream nextPutAll: >> response contents ] ] >> ifFalse: [ self error: 'Cannot download data files' ]. >> self logCr: '====== Uncompressing files...'. >> self uncompress: fileRef. >> >> HernÃ¡n >> >> > >

April 21, 2016

Re: [Pharo-dev] Mocketry names again

by Sean P. DeNigris

Denis Kudriashov wrote > Can we use more short version #haveGot? > ... > mock should haveGot someMessage No ;) The minimum to not sound terrible would be #haveGotten Denis Kudriashov wrote > beReturnedFrom:... Should it be #haveReturnedFrom: This one seems less crucial. #have... would technically be correct since you made the others in the past tense, but as other commenters have pointed out, it would simplify things to keep everything in the present tense. Although there would then be the mismatch with the fact that the things did in fact already happen (hopefully) in the past! ----- Cheers, Sean -- View this message in context: http://forum.world.st/Mocketry-names-again-tp4890941p4891092.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 21, 2016

Re: [Pharo-dev] What the state of unifying Beacon with SystemLogger?

by Denis Kudriashov

Hi Ben. 2016-04-20 21:05 GMT+02:00 Ben Coman <btc(a)openinworld.com>: > Sorry for not having a better reviewed understanding of both > frameworks, but I have some thoughts from perspective of one user... > So if you look at code you will see that what you mention below is not truth for current design (names) > > > > There are few things which I not like in SystemLogger (which not means > that > > everything is good with Beacon): > > > > name Log to represent records of the underlying "physical log". > > > > IMHO Log means exactly end logging backend like text file, syslog or > > external database. Log is the place where we can explore (read) what was > > happen. > > You are considering Log as a noun, but it can also be used as a verb. > defn "13. to enter in a log; keep a record of; e.g. to log a day's > events." [1] > I only mentioned it as noun. But to log objects I want log it in verb meaning anyObject log > Stef said: "Remember that you want to have them short especially for > the main one. This is why in SystemLogger > we have Log instead of what it is LogObject" > from which I understood that Log was the client interface, to be used > like Transcript. I think this is a good idea. It would create the > LogEntry > And in SystemLogger Log is client interface and in same time it is log entry. But why we prefer to use Log? What wrong with direct object message? I would write: object log 'some string message' log 'some debug string message' logForDebug. 'some error string message' logAsError > [1] http://www.dictionary.com/browse/log > > > And now these backends are represented by subclasses of Logger: > > StdoutStreamLogger, SysLogSender. I would call them StdoutLog, SysLog. > > But with such change we need to call log entry differently. It can be > > LogRecord or LogEntry. I not understand what was the problem with such > > names? (there was some explanation why Log was chosen for this) > > Considering a "log" being the final resting point of the logged > objects, that is the external disk text file or database, then within > Pharo we don't have logs, only processes that write to the external > logs, so Logger seems appropriate. This is except for an in memory > log, which for backend might need both MemoryLogger and > MemoryObjectLog. > I can't agree here. Does not we model real world objects with objects and not functions? If I want to read records from SysLog should I create SysLogReader? So in one place I will use SysLogLogger and in another place I will use SysLogReader. I not like such design. If I want to work with SysLog I would represent it with SysLog class. It can support both operations: appending new entries and querying existing entries. Of course internally it can use SysLogReader and SysLogWriter. But as user I want to start with SysLog and internal details should be hidden from me. If you remember before FileSystem we had some kind of file streams and no real object to represent file. And now we have FileReference and we can ask it for #readStream or #writeStream. It's much better. > > Log would create and send theLogEntry to SystemLogger > which forwards theLogEntry to other registered XXXLogger backend. > For me it is bad when same name is used for objects with different roles. If we call backends with suffix "Logger" then we should not use it for anything which is not backend. > > > name SystemLogger for collection based log. > > > > SystemLogger makes me think that it is singleton which is used by system > and > > I should not use it for my own application. > > I guess your application would make use SystemLogger via Log at the > front end, and registering backends with SystemLogger. > Now SystemLogger is MemoryObjectLog. It is not dispatcher for other loggers. Anyway I'm sure using name "system" for general purpose framework is bad idea. If I will need non global logger how I will reuse SystemLogger? It will feel like hack because I will take some global "System" object to use it in my local application. > > > I would call it like ObjectLog or NativeLog (following my first sentence > > about Log). > > NativeLog doesn't seems right. ObjectLog might be suitable for an > in-memory backend, like above I mention MemoryObjectLog. > > > Also it is intercepted with SysLog name and I guess that's why it was > called > > SysLogSender and not SysLogLogger. > > > > name LogDispatcher. > > LogDispatcher is okay, but I'm not sure of convention to be associate > the "doer" with the "target" rather than the "item", where > doer=Dispatcher; item=LogEntry; target=final-backend-log; A little > it sounds like its dispatching a whole log rather than one log entry. > Maybe should be LogEntryDispatcher(??) or... SystemLogger as the > marshalling point to forward to other XXXLoggers. > > > > > Here same problem as Log. What means physical logs dispatching? I know > it is > > introduced around Log as log entry. But it is not intuitive for me (same > as > > Log). > > I don't think Log should be a log entry. It should be the user > interface that creates and sends LogEntries via some XXXLogger. > > > In context of Log as real log (FileLog, SysLog) I would call this > dispatcher > > as Logger with same responsibility to register new events in all > registered > > logs. > > > > > > announcements LogAdded and LogRemoved in the core. > > > > Why any Logger should announce every log entry? > > I think we not need special LoggerUI app. We can just inspect > SystemLogger > > instance to look at all recorded objects. And in perspective of my > > suggestions it will mean that we just explore particular ObjectLog. And > we > > can extend GTInspector for this. > > GTInspector would need good live updating, filtering, clearing, > scrolling to keep cursor position as new entries arrive. > It is already here I guess. If not then it should be improved and I think it is already in plan. What you mention is needed to inspect any collections.

April 20, 2016

Re: [Pharo-dev] Class allSubInstances size takes 23 seconds to run on Pharo 5 on OS X

by Eliot Miranda

Hi Denis, On Wed, Apr 20, 2016 at 9:15 AM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > 2016-04-20 17:47 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > >> Hi Pavel, >> >> On Apr 20, 2016, at 6:54 AM, Pavel Krivanek <pavel.krivanek(a)gmail.com> >> wrote: >> >> That is not real amount of objects in the object memory: >> >> count := 0. >> object := 0 someObject. >> [object == 0] whileFalse: [ >> count := count + 1. >> object := object nextObject ]. >> count. "->724653" >> >> >> Right. allObjects size is approximately equal to Object allSubInstances >> (but much faster to evaluate, since it makes only a single heap >> traversal). Class allSubInstances answers only classes, not those class's >> instances. >> > > But my test was not about Object allSubInstances but about Object > allSubclasses. > I supposed that "Class allSubInstances size" should equal "(Class > *allSubclasses* flatCollect: [ :each | each allInstances ]) size". But it > is not. And it is surprised me. Interesting to know why. > I understand. I was answering Pavel's query. Your question was answered (albeit teasingly) by Ben: "Strange that its out by a factor of two. It's almost like each class is also an object ;)". Class allSubclasses includes only the metaclasses. Object allSubclasses includes the classes too. These two (from a Squeak image) are almost equal: (Class withAllSubclasses asSet addAll: (Class allSubclasses collect: #soleInstance); yourself) size 6468 Object withAllSubclasses size 6456 Class withAllSubclasses first: 5 => an OrderedCollection(Class ProtoObject class Object class ObjectOut class ImageSegmentRootStub class) Class withAllSubclasses last: 5 an OrderedCollection(ScSmiAddOp class ScSmiEqualOp class ScSmiLessOp class ScSmiLessOrEqualOp class ScSmiNotEqualOp class) Object withAllSubclasses first: 5 => an OrderedCollection(Object BalloonState SoundCodec StandardFileMenuResult UndefinedObject) Object withAllSubclasses last: 5 => an OrderedCollection(ScSmiAddOp class ScSmiEqualOp class ScSmiLessOp class ScSmiLessOrEqualOp class ScSmiNotEqualOp class) _,,,^..^,,,_ best, Eliot

April 20, 2016

Re: [Pharo-dev] [Ann] New version of Mocketry 3.0

by Tudor Girba

Thank you! Doru > On Apr 20, 2016, at 10:35 AM, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > > 2016-04-20 2:27 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: > Tudor Girba-2 wrote > > It is your prerogative :), but âshould got" sounds broken :(. > > Sounds like fingernails on a chalkboard IMH-native-english-speaker-O ;) > > Ok. I open new thread about names -- www.tudorgirba.com www.feenk.com "It's not how it is, it is how we see it."

April 20, 2016