February 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [bloc] feature envy -> move method close to data?

by stepharo

Sorry but I do not buy your argument. BlElement is in charge and it delegates it to BlShape. This is a quite common pattern and this is more logical that the object responsible for the shape drawing draw it in fact. It was like that in Bloc before so I do not see why this is not possible now. Le 25/2/16 13:37, Aliaksei Syrel a Ã©crit : > > All arbitrary shapes are being drawing in the same way and it is > enough to have only one method. Allowing shape to render itself would > lead to misunderstanding: bloc user would have to look into two places > (element and shape) to find out where drawing actually happens. > > On Feb 25, 2016 12:56 PM, "stepharo" <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > To me this is pre optimisation > > I do not see why we cannot do > > BlElement>>drawOnAthensCanvas: aCanvas > > self shape drawOnAthensCanvas: aCanvas with: self > > so far only localBounds from BlElement are used. > > And to me this is really strange to have an object responsible for > the drawing not doing it. > It blurs the responsibility. > > Stef > > Le 25/2/16 10:39, Tudor Girba a Ã©crit : > > Hi, > > Good question. > > The reason we want to have the morph be responsible because > subclasses might decide to draw in a different way regardless > of the shape being used. This gives us the maximum freedom for > more specific blocs. Still, this is something to experiment > with once we have more complicated examples built with Bloc. > > Cheers, > Doru > > > On Feb 25, 2016, at 9:56 AM, stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > Hi Blockers > > I do not really understand why drawOnAthensCanvas: is not > defined on BlShape > (especially when we see how many self space are defined in > this method. > And this is one of the few things I thought I understood > from bloc (grouping the rendering in a separate object). > > > drawOnAthensCanvas: aCanvas > "Actually render receiver on aCanvas in local bounds. > Override to customize. > aCanvas is an instance of AthensCanvas > aCanvas must not be nil" > > | pathTransform | > pathTransform := aCanvas pathTransform. > "First we fill" > pathTransform > restoreAfter: > [ | path fillExtent fillTranslation | > "We fill inside natural element's bounds" > fillExtent := self shape path fillExtentFor: > self shape inBounds: self localBounds. > path := self shape path pathOn: aCanvas > forExtent: fillExtent. > "Translate fill if needed" > fillTranslation := self shape path > fillTranslationFor: self shape > inBounds: self localBounds. > pathTransform translateBy: fillTranslation. > aCanvas > setPaint: self shape fillPaint; > drawShape: path ]. > pathTransform > restoreAfter: > [ | path strokeExtent strokeTranslation | > "We stroke inside natural element's bounds" > strokeExtent := self shape path > strokeExtentFor: self shape inBounds: self localBounds. > path := self shape path pathOn: aCanvas > forExtent: strokeExtent. > "Translate stroke if needed" > strokeTranslation := self shape path > strokeTranslationFor: self shape > inBounds: self localBounds. > pathTransform translateBy: strokeTranslation. > aCanvas > setPaint: self shape strokePaint; > drawShape: path ] > > -- > www.tudorgirba.com <http://www.tudorgirba.com> > www.feenk.com <http://www.feenk.com> > > "Sometimes the best solution is not the best solution." > > > > >

Feb. 25, 2016

Re: [Pharo-dev] [pharo-project/pharo-core] c2b19a: 50611

by stepharo

I love the idea that we get more and better rules! Tx Yuriy Le 25/2/16 14:11, GitHub a Ã©crit : > 17685 Add rules to check if Float system classes are referenced > https://pharo.fogbugz.com/f/cases/17685

Feb. 25, 2016

Re: [Pharo-dev] ZTimestamp improvement

by stepharo

Le 25/2/16 15:07, Blondeau Vincent a Ã©crit : > I implemented some tests for the slice. You should be able to reuse them. So cool :) Tx vincent! > >> -----Message d'origine----- >> De : Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] De la part de >> Sven Van Caekenberghe >> EnvoyÃ© : jeudi 25 fÃ©vrier 2016 14:57 >> Ã : Pharo Development List >> Objet : Re: [Pharo-dev] ZTimestamp improvement >> >> Yes I saw what you did and indeed the same fix needs to be applied to >> ZTimestamp. I will do it after adding some tests. Thx! >> >>> On 25 Feb 2016, at 14:06, Blondeau Vincent >> <vincent.blondeau(a)worldline.com> wrote: >>> Hello, >>> >>> I use Ztimestamp to parse a date but the time zone offset is wrongly set: >>> (DateAndTime readTimezoneOffsetFrom: '+0530' readStream) printString >> gives '0:05:00:00' instead of '0:05:30:00'. >>> See https://pharo.fogbugz.com/f/cases/17693/Time-offset-parsing-is-false >> for the DateAndTime issue. >>> As the bug is in DateAndTime>>readOptionalSeparatorFrom: and >> ZTimestamp reuses the same code, I propose to apply the same patch to it. >>> Can I have the commit access to the repo >> (http://smalltalkhub.com/#!/~SvenVanCaekenberghe/Neo) to submit the >> patch? >>> Cheers, >>> Vincent >>> >>> >>> >>> Ce message et les piÃ¨ces jointes sont confidentiels et rÃ©servÃ©s Ã l'usage >> exclusif de ses destinataires. Il peut Ã©galement Ãªtre protÃ©gÃ© par le secret >> professionnel. Si vous recevez ce message par erreur, merci d'en avertir >> immÃ©diatement l'expÃ©diteur et de le dÃ©truire. L'intÃ©gritÃ© du message ne >> pouvant Ãªtre assurÃ©e sur Internet, la responsabilitÃ© de Worldline ne pourra >> Ãªtre recherchÃ©e quant au contenu de ce message. Bien que les meilleurs >> efforts soient faits pour maintenir cette transmission exempte de tout virus, >> l'expÃ©diteur ne donne aucune garantie Ã cet Ã©gard et sa responsabilitÃ© ne >> saurait Ãªtre recherchÃ©e pour tout dommage rÃ©sultant d'un virus transmis. >>> This e-mail and the documents attached are confidential and intended >> solely for the addressee; it may also be privileged. If you receive this e-mail in >> error, please notify the sender immediately and destroy it. As its integrity >> cannot be secured on the Internet, the Worldline liability cannot be triggered >> for the message content. Although the sender endeavours to maintain a >> computer virus-free network, the sender does not warrant that this >> transmission is virus-free and will not be liable for any damages resulting >> from any virus transmitted. >> > > !!!************************************************************************************* > "Ce message et les piÃ¨ces jointes sont confidentiels et rÃ©servÃ©s Ã l'usage exclusif de ses destinataires. Il peut Ã©galement Ãªtre protÃ©gÃ© par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immÃ©diatement l'expÃ©diteur et de le dÃ©truire. L'intÃ©gritÃ© du message ne pouvant Ãªtre assurÃ©e sur Internet, la responsabilitÃ© de Worldline ne pourra Ãªtre recherchÃ©e quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expÃ©diteur ne donne aucune garantie Ã cet Ã©gard et sa responsabilitÃ© ne saurait Ãªtre recherchÃ©e pour tout dommage rÃ©sultant d'un virus transmis. > > This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Worldline liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.!!!"

Feb. 25, 2016

Got some DNU using Spotter but I could not repeat it

by stepharo

Just for the record Got some DNU using Spotter but I could not reproduce it. Stef

Feb. 25, 2016

Re: [Pharo-dev] ZTimestamp improvement

by Sven Van Caekenberghe

Hi Vincent, I did it almost the same, but not quite. The reason is that I use #readOptionalSeparatorFrom: in multiple places. For ZTimestamp the TZ stuff is purely optional while parsing, it always operates in UTC from then on. === Name: ZTimestamp-SvenVanCaekenberghe.54 Author: SvenVanCaekenberghe Time: 25 February 2016, 10:39:29.822907 pm UUID: 8bf489fb-268c-441a-9799-7fb5acdc3734 Ancestors: ZTimestamp-SvenVanCaekenberghe.53 Test optional timezone parsing and fix problem with minutes (thx Vincent Blonde) === ZTimestamp class>>#readTimezoneOffsetFrom: stream "Read and return an optional timezone offset in the form of [+|-]hh[separator][mm] from stream as an Integer seconds. If there is no offset, just return 0" | sign hour minute | (stream atEnd or: [ stream peekFor: $Z ]) ifTrue: [ ^ 0 ]. ^ ('+-' includes: stream peek) ifTrue: [ sign := stream next = $- ifTrue: [ -1 ] ifFalse: [ 1 ]. hour := self readInteger: 2 from: stream. ((self readOptionalSeparatorFrom: stream) notNil or: [ '0123456789' includes: stream peek ]) ifTrue: [ minute := self readInteger: 2 from: stream ] ifFalse: [ minute := 0 ]. sign * ((hour * 3600) + (minute * 60)) ] ifFalse: [ 0 ] ZTimestamp class>>#readOptionalSeparatorFrom: stream "Read an optional separator (non decimal digit) from stream and return it. Return nil if nothing was read" ^ ('0123456789' includes: stream peek) ifTrue: [ nil ] ifFalse: [ stream next ] And my test is (listing all supported variants): testOptionalTimezoneParsing #( '1969-07-20T20:17:40Z' '1969-07-20T20:17:40' '1969-07-20T20:17:40+00:00' '1969-07-20T20:17:40+00' '1969-07-20T20:17:40+0000' '1969-07-20T21:17:40+01:00' '1969-07-20T21:17:40+01' '1969-07-20T21:17:40+0100' '1969-07-20T19:17:40-01:00' '1969-07-20T19:17:40-01' '1969-07-20T19:17:40-0100' '1969-07-20T21:47:40+01:30' '1969-07-20T21:47:40+0130' '1969-07-20T18:47:40-01:30' '1969-07-20T18:47:40-0130' ) do: [ :each | self assert: (ZTimestamp fromString: each) equals: self lunarLanding ] I also saw in your code ':' includes: stream peek which is of course the same as stream peek = $: Note also that normally #peek returns nil when #atEnd, something you can use to simplify code. That is why I use the #includes: instead of #isDigit In any case, thanks for finding this. Sven > On 25 Feb 2016, at 15:07, Blondeau Vincent <vincent.blondeau(a)worldline.com> wrote: > > I implemented some tests for the slice. You should be able to reuse them. > >> -----Message d'origine----- >> De : Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] De la part de >> Sven Van Caekenberghe >> EnvoyÃ© : jeudi 25 fÃ©vrier 2016 14:57 >> Ã : Pharo Development List >> Objet : Re: [Pharo-dev] ZTimestamp improvement >> >> Yes I saw what you did and indeed the same fix needs to be applied to >> ZTimestamp. I will do it after adding some tests. Thx! >> >>> On 25 Feb 2016, at 14:06, Blondeau Vincent >> <vincent.blondeau(a)worldline.com> wrote: >>> >>> Hello, >>> >>> I use Ztimestamp to parse a date but the time zone offset is wrongly set: >>> (DateAndTime readTimezoneOffsetFrom: '+0530' readStream) printString >> gives '0:05:00:00' instead of '0:05:30:00'. >>> See https://pharo.fogbugz.com/f/cases/17693/Time-offset-parsing-is-false >> for the DateAndTime issue. >>> >>> As the bug is in DateAndTime>>readOptionalSeparatorFrom: and >> ZTimestamp reuses the same code, I propose to apply the same patch to it. >>> Can I have the commit access to the repo >> (http://smalltalkhub.com/#!/~SvenVanCaekenberghe/Neo) to submit the >> patch? >>> >>> Cheers, >>> Vincent >>> >>> >>> >>> Ce message et les piÃ¨ces jointes sont confidentiels et rÃ©servÃ©s Ã l'usage >> exclusif de ses destinataires. Il peut Ã©galement Ãªtre protÃ©gÃ© par le secret >> professionnel. Si vous recevez ce message par erreur, merci d'en avertir >> immÃ©diatement l'expÃ©diteur et de le dÃ©truire. L'intÃ©gritÃ© du message ne >> pouvant Ãªtre assurÃ©e sur Internet, la responsabilitÃ© de Worldline ne pourra >> Ãªtre recherchÃ©e quant au contenu de ce message. Bien que les meilleurs >> efforts soient faits pour maintenir cette transmission exempte de tout virus, >> l'expÃ©diteur ne donne aucune garantie Ã cet Ã©gard et sa responsabilitÃ© ne >> saurait Ãªtre recherchÃ©e pour tout dommage rÃ©sultant d'un virus transmis. >>> >>> This e-mail and the documents attached are confidential and intended >> solely for the addressee; it may also be privileged. If you receive this e-mail in >> error, please notify the sender immediately and destroy it. As its integrity >> cannot be secured on the Internet, the Worldline liability cannot be triggered >> for the message content. Although the sender endeavours to maintain a >> computer virus-free network, the sender does not warrant that this >> transmission is virus-free and will not be liable for any damages resulting >> from any virus transmitted. >> > > > !!!************************************************************************************* > "Ce message et les piÃ¨ces jointes sont confidentiels et rÃ©servÃ©s Ã l'usage exclusif de ses destinataires. Il peut Ã©galement Ãªtre protÃ©gÃ© par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immÃ©diatement l'expÃ©diteur et de le dÃ©truire. L'intÃ©gritÃ© du message ne pouvant Ãªtre assurÃ©e sur Internet, la responsabilitÃ© de Worldline ne pourra Ãªtre recherchÃ©e quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expÃ©diteur ne donne aucune garantie Ã cet Ã©gard et sa responsabilitÃ© ne saurait Ãªtre recherchÃ©e pour tout dommage rÃ©sultant d'un virus transmis. > > This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Worldline liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.!!!"

Feb. 25, 2016

Re: [Pharo-dev] How to browse files with Spotter

by stepharo

Thanks! I did a nice videos filtering examples :) What is strange is that #files does not show me the files on my disc. Stef Le 25/2/16 22:31, Tudor Girba a Ã©crit : > #files will list files. ./package-cache is a directory. So, you should use: > #dir ./pa > > Cheers, > Doru > > >> On Feb 25, 2016, at 10:20 PM, stepharo <stepharo(a)free.fr> wrote: >> >> Doru >> >> I started to reproduce some of your videos. >> I tried to reproduce your videos but I cannot find how I can browse for example the package-cache. >> >> I tried >> >> . #files >> >> package-cache #files >> >> ./package-cache #files >> >> But I could not get the list of the current files on the folder image. >> >> Stef >> > -- > www.tudorgirba.com > www.feenk.com > > "No matter how many recipes we know, we still value a chef." > > > > > > > > >

Feb. 25, 2016

Re: [Pharo-dev] How to browse files with Spotter

by Tudor Girba

#files will list files. ./package-cache is a directory. So, you should use: #dir ./pa Cheers, Doru > On Feb 25, 2016, at 10:20 PM, stepharo <stepharo(a)free.fr> wrote: > > Doru > > I started to reproduce some of your videos. > I tried to reproduce your videos but I cannot find how I can browse for example the package-cache. > > I tried > > . #files > > package-cache #files > > ./package-cache #files > > But I could not get the list of the current files on the folder image. > > Stef > -- www.tudorgirba.com www.feenk.com "No matter how many recipes we know, we still value a chef."

Feb. 25, 2016

How to browse files with Spotter

by stepharo

Doru I started to reproduce some of your videos. I tried to reproduce your videos but I cannot find how I can browse for example the package-cache. I tried . #files package-cache #files ./package-cache #files But I could not get the list of the current files on the folder image. Stef

Feb. 25, 2016

Re: [Pharo-dev] New Cog VMs available

by Eliot Miranda

On Thu, Feb 25, 2016 at 9:29 AM, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > ... at http://www.mirandabanda.org/files/Cog/VM/VM.r3632. > > These include 64-bit VMs whose Smalltalk execution and FFI are > functional. However, their SocketPlugin is more than somewhat broken. > Executing the SocketPlugin tests results in a hard lockup, at least on Mac > OS X. This is my next focus for 64-bits. > It turns out that the 64-bit socket issues are Mac OS only. The linux 64-bit VMs seem to be fine. The problems are to do with socket reuse and/or broadcast (SO_REUSEADDR, SO_REUSEPORT & SO_BROADCAST). > > ------------------------------------------------------------------------ > CogVM binaries as per VMMaker.oscog-eem.1700/r3632 > > General: > Fix serious bug in jitted perform: primitive. Thanks to Stephane Rollandin > for finding and to Levente Uzoni for diagnosing the bug. If the argument > count is one greater than the max number of register arguments (2 in Spur, > hence perform:with:with:) then the code to remove the receiver and > arguments > from the stack neglects to remove the receiver and selector. > > Spur: > Fix special selector arithmetic and comparison in the 64-bit Cogit. My > original > code for genJumpNotSmallIntegersIn:andScratchReg: merely jumped if the tags > differed, hence not jumping if both arguments were SmallFloat64s (or both > Characters). The new code requires an additional scratch register; > hence add genJumpNotSmallIntegersIn:andScratch:scratch:. > > Fix bug in markAndTraceWeaklingsFrom:. Fields of weaklings may be > immediate > so must use followOopField:ofObject: not followObjField:ofObject:. > > Fix > https://pharo.fogbugz.com/f/cases/17536/VM-Crash-when-adding-an-iVar-to-a-s… > . > > When weaklings (and when ephemerons) are scan-marked forwarders must be > coped > with. > > 64-bit VMs: > Fix a bug in printHex: for 64-bits (faulty arithmetic). > > ThreadedFFIPlugin: > Fix the remaining 64-bit issues in the ThreadedFFIPlugin. The > X64SysVFFIPlugin > now passes the test suite. Hence include the FFI plugin in 64-bit VMs. > > Make the SqueakFFIPrims plugin internal in the Mac pharo builds. > > Mac VMs: > Have the Mac OS X build install Localizable.strings. Add versions for > Newspeak, Pharo and Squeak. Rename the key to SelectImagePanePrompt. > Temporarily disable the Serial plugin in the Pharo Mac VM until we can > track > down the relevant platforms/iOS support for the Pharo extensions. > > Fix argument access on the iOS platform (Mac OS VMs). > > _,,,^..^,,,_ > best, Eliot > -- _,,,^..^,,,_ best, Eliot

Feb. 25, 2016

Re: [Pharo-dev] Process>>restart

by Eliot Miranda

Hi Ben, On Wed, Feb 24, 2016 at 10:44 PM, Ben Coman <btc(a)openinworld.com> wrote: > On Thu, Feb 25, 2016 at 3:06 AM, Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > > > > > > On Wed, Feb 24, 2016 at 7:23 AM, Ben Coman <btc(a)openinworld.com> wrote: > >> > >> Just sharing a passing thought so I don't forget it before I have time > >> to think more deeply on it. > >> > >> Several parts of Pharo (like SHTextStyler) are designed to have a > >> background process running, and when new input arrives that process is > >> killed so another can be immediately started - and sometimes we seem > >> to end up with large amounts of zombie processes. > >> > >> As I poke around Process>>terminate, I wonder if a different approach > >> would be to have a Process>>restart. I see there is Context>>restart. > >> > >> The starting the background process might look like... > >> > >> stylingProcess := [ [ "do stuff with nextData". self suspend ] > >> repeat ] forkAt: 30. > >> > >> and the code in the main morphic priority 40 thread might look like... > >> > >> sylingProcess suspend. > >> nextData := 'blah'. > >> sylingProcess restart. > > > > > > Hi Ben, so I'm assuming restart differs from resume. Am I right in > thinking > > it cuts back the process to the "start"? Is the start the block from > which > > the process was spawned, the argument to fork or forkAt:? > > Thats right. Essentially like Exception>>retry, to do something like > this... > > restart := false. > workAvailable := Semaphore new. > process := > [ [ Transcript crShow: 'At the start'. > work := 0. > [ work := work + 1. > Transcript crShow: 'working on ' , work printString. > 1 second wait. > work>8 ifTrue: > [ [Transcript crShow: 'Work complete.'] fork. > workAvailable wait. > restart := true. > ]. > restart ifTrue: [self error]. > work > ] repeat. > ] on: Error do: [:err| restart := false. err retry]. > ] newProcess name:'My Restartable Worker'. > process resume. > > "later do..." > restart := true. > "or after work complete..." > workAvailable signal. > > "later still do..." > process terminate > > ...except being able to interrupt the process anytime, > i.e. not needing to wait to get to "restart ifTrue: [self error]." > It can be built simply above signalException:. So... Process class methods for instance creation forBlock: aBlockClosure priority: anInteger "Answer an instance of me that has suspended aContext at priority anInteger." <primitive: 19> "Simulation guard" | newProcess | (newProcess := self new) suspendedContext: [[[newProcess result: aBlockClosure value. false] on: ProcessRestart do: [:ex| true]] whileTrue. "Since control is now at the bottom there is no need to terminate (which runs unwinds) since all unwinds have been run. Simply suspend. Note that we must use this form rather than e.g. Processor suspendActive so that isTerminated answers true. isTerminated requires that if there is a suspended context it is the bottom-most, but using a send would result in the process's suspendedContext /not/ being the bottom-most." newProcess suspend] asContext; priority: anInteger. ^newProcess Process methods for process state change restart self signalException: ProcessRestart btw, The requirement for the fork in "[Transcript crShow: 'Work > complete.'] fork" > is strange. Without it the semaphore does not wait, which seems a bug. > Is there a missing yield somewhere? > > btw2, I needed to hack OCUndeclaredVariableWarning>>defaultAction to > stop the transcript being polluted by unknown playground variables. No > warranty on whether this is suitable to be permanent... > className = 'UndefinedObject' ifFalse: [ > self methodNode selector ifNotNil: [self crTrace: className, > '>>', selector, ' '] > ifNil: [self traceCr:'']. > self traceCr: '(' , varName , ' is Undeclared1) '. > ]. > > > > > On Thu, Feb 25, 2016 at 2:56 AM, Max Leske <maxleske(a)gmail.com> wrote: > > Fast spawning processes are very hard to debug (e.g. in the process > browser). > > This is exactly the use case I was thinking of. Often they've been > and gone before you even know they are there. Having a permanent > process aids discoverability of system background functionality. > > cheers -ben > > -- _,,,^..^,,,_ best, Eliot

Feb. 25, 2016