February 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Thanks nicolai and the sprinter for fixing the selectorTable

by Nicolai Hess

2016-02-01 8:37 GMT+01:00 Cyril Ferlicot Delbecque <cyril.ferlicot(a)gmail.com >: > > > On 01/02/2016 08:24, Nicolai Hess wrote: > > > > unlikely, many 'icon'-methods are now rendered as 'unimplemeted' > > methods, because > > ThemeIcons uses #doesNotUnderstand indirection to create the named > > icons. And that seems to work > > well. > > And the error about > > > > RubShoutStylerDecorator(Object)>>doesNotUnderstand: > #recomposeFrom:to:delta: > > happened already to me, sometimes, before we made this change for the > > (Symbol SelectorTabe). > > > > What exactly had you done when this error occured. editing a new > > method/edit an existing method but > > call a new unimplemented method/writing some code in playground, using > > unimplemented methods? > > > > > > -- > > Cyril > > > > > > In the class TextLink in the latest image I just typed this method, > formated (CMD-Shift-f) and saved: > > = anObject > ^ self species = anObject species and: [ self classAndMethod = > anObject > classAndMethod ] > > Then I got other errors at almost each character I typed in other methods. > Maybe because, TextLink has no accessor for #classAndMethod :) > > -- > Cyril > >

Feb. 1, 2016

Re: [Pharo-dev] Thanks nicolai and the sprinter for fixing the selectorTable

by Cyril Ferlicot Delbecque

On 01/02/2016 08:24, Nicolai Hess wrote: > > unlikely, many 'icon'-methods are now rendered as 'unimplemeted' > methods, because > ThemeIcons uses #doesNotUnderstand indirection to create the named > icons. And that seems to work > well. > And the error about > > RubShoutStylerDecorator(Object)>>doesNotUnderstand: #recomposeFrom:to:delta: > happened already to me, sometimes, before we made this change for the > (Symbol SelectorTabe). > > What exactly had you done when this error occured. editing a new > method/edit an existing method but > call a new unimplemented method/writing some code in playground, using > unimplemented methods? > > > -- > Cyril > > In the class TextLink in the latest image I just typed this method, formated (CMD-Shift-f) and saved: = anObject ^ self species = anObject species and: [ self classAndMethod = anObject classAndMethod ] Then I got other errors at almost each character I typed in other methods. -- Cyril

Feb. 1, 2016

Re: [Pharo-dev] Thanks nicolai and the sprinter for fixing the selectorTable

by Nicolai Hess

2016-01-31 21:52 GMT+01:00 Cyril Ferlicot Delbecque < cyril.ferlicot(a)gmail.com>: > > > On 31/01/2016 15:23, stepharo wrote: > > Hi guys > > > > Thanks for this fix. > > I will start recording videos. > > > > Stef > > > > > In the last image I get errors all the time when I use unimplemented > methods. > I think this might be related if this was done to add syntax > highlighting for unimplemented methods. > unlikely, many 'icon'-methods are now rendered as 'unimplemeted' methods, because ThemeIcons uses #doesNotUnderstand indirection to create the named icons. And that seems to work well. And the error about RubShoutStylerDecorator(Object)>>doesNotUnderstand: #recomposeFrom:to:delta: happened already to me, sometimes, before we made this change for the (Symbol SelectorTabe). What exactly had you done when this error occured. editing a new method/edit an existing method but call a new unimplemented method/writing some code in playground, using unimplemented methods? > RubShoutStylerDecorator(Object)>>doesNotUnderstand: > #recomposeFrom:to:delta: > [ super doesNotUnderstand: aMessage ] in > RubShoutStylerDecorator(RubParagraphDecorator)>>doesNotUnderstand: > #recomposeFrom:to:delta: in Block: [ super doesNotUnderstand: aMessage ] > BlockClosure>>cull: > Context>>evaluateSignal: > Context>>handleSignal: > MessageNotUnderstood(Exception)>>signal > RubCurrentLineBarDecorator(Object)>>doesNotUnderstand: > #recomposeFrom:to:delta: > [ super doesNotUnderstand: aMessage ] in > RubCurrentLineBarDecorator(RubParagraphDecorator)>>doesNotUnderstand: > #recomposeFrom:to:delta: in Block: [ super doesNotUnderstand: aMessage ] > BlockClosure>>cull: > Context>>evaluateSignal: > Context>>handleSignal: > MessageNotUnderstood(Exception)>>signal > RubExtraSelectionDecorator(Object)>>doesNotUnderstand: > #recomposeFrom:to:delta: > [ super doesNotUnderstand: aMessage ] in > RubExtraSelectionDecorator(RubParagraphDecorator)>>doesNotUnderstand: > #recomposeFrom:to:delta: in Block: [ super doesNotUnderstand: aMessage ] > BlockClosure>>cull: > Context>>evaluateSignal: > Context>>handleSignal: > MessageNotUnderstood(Exception)>>signal > RubOpeningClosingDelimiterDecorator(Object)>>doesNotUnderstand: > #recomposeFrom:to:delta: > [ super doesNotUnderstand: aMessage ] in > > RubOpeningClosingDelimiterDecorator(RubParagraphDecorator)>>doesNotUnderstand: > #recomposeFrom:to:delta: in Block: [ super doesNotUnderstand: aMessage ] > BlockClosure>>cull: > Context>>evaluateSignal: > Context>>handleSignal: > MessageNotUnderstood(Exception)>>signal > RubTextMethodLink(Object)>>doesNotUnderstand: #tes > RubTextMethodLink(TextLink)>>= > Array(SequenceableCollection)>>hasEqualElements: > Array(SequenceableCollection)>>= > Array(SequenceableCollection)>>hasEqualElements: > RunArray>>= > > -- > Cyril > >

Feb. 1, 2016

Re: [Pharo-dev] 17502. Morph layoutProperties must not be nil by default

by stepharo

A good solution is to have share by default and instance-based when needed. For that use a classVariable to instantiate only one NullLayoutProperties use an instance variable that points to it by default one demand change the instance variable to point to a new created instance => you can remove all the ifNil:

Feb. 1, 2016

Re: [Pharo-dev] Unused ugly morph methods...

by stepharo

> It is forbidden by contract :) 100% > I like that What would be great is that we can create QA rules dedicated to Bloc and Brick. > On Jan 31, 2016 9:31 PM, "stepharo" <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > I really hope that Bloc will forbid such systematic submorphs use > because it leads to code like that. > > Stef > > > submorphNamed: aName > ^ self submorphNamed: aName ifNone: [nil] > > submorphNamed: aName ifNone: aBlock > "Find the first submorph with this name, or a button with an > action selector of that name" > > > self submorphs do: > [:button | | sub args | > (button respondsTo: #actionSelector) > ifTrue: [button actionSelector == aName ifTrue: > [^button]]. > ((button respondsTo: #arguments) and: [(args := button > arguments) notNil]) > ifTrue: [(args at: 2 ifAbsent: [nil]) == aName > ifTrue: [^button]]. > (button isAlignmentMorph) > ifTrue: [(sub := button submorphNamed: aName > ifNone: [nil]) ifNotNil: [^sub]]]. > ^aBlock value >

Feb. 1, 2016