February 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [pharo-project/pharo-core] 0f7198: 50562

by Marcus Denker

> > Log Message: > ----------- > 50562 > 17515 fix minimal Pharo shrinking build > https://pharo.fogbugz.com/f/cases/17515 <https://pharo.fogbugz.com/f/cases/17515> > > I had to reopen it because it looks not completly integrated. > I will check.. Marcus

Feb. 2, 2016

Re: [Pharo-dev] 17502. Morph layoutProperties must not be nil by default

by David Allouche

> On 1 Feb 2016, at 10:49, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > but layoutProperties are not immutable so if you receive an instance of NullLayoutProperties (singleton), and you do something like this: > > myMorph cellInset: 5, you has to check for correct properties anywayâ¦ thatâs why is implemented as this: > > cellInset: aNumber > "Layout specific. This property specifies an extra inset for each cell in the layout." > self assureTableProperties cellInset: aNumber. > self layoutChanged. > > I do not think answering a null object here is goodâ¦ it will cause infinite problems and you will need to check for correct properties anyway. That's what I thought might be the problem :-) So I think the best compromise performance-wise would be that: Morph>>#layoutProperties returns a new NullLayoutProperties when it currently returns nil. NullLayoutProperties stores the associated morph as an instance variable When NullLayoutProperties receives a mutation message It creates an actual LayoutProperties instance: layoutprops Forward the mutation message to the layoutprops morph layoutProperties: layoutprops self become: layoutprops Yes, that is rather ugly but it is completely encapsulated, and that's the only way I can see that: Allow to remove all the nil checks for Morph>>#layoutProperties Does not break existing code that relies on layoutProperties mutability Has zero cost when Morph>>#layoutProperties is never used Has minimal cost when Morph>>#layoutProperties is not mutated: the allocation of a small, transient object that will be reclaimed quickly by the generational GC. > In any case, I would reject such a change (specially at this moment). I understand that such changes should only be done early in a release cycles.

Feb. 2, 2016

Re: [Pharo-dev] [pharo-project/pharo-core] 0f7198: 50562

by Pavel Krivanek

2016-02-02 10:35 GMT+01:00 GitHub <noreply(a)github.com>: > Branch: refs/heads/5.0 > Home: https://github.com/pharo-project/pharo-core > Commit: 0f71987906596fff89e93063d9ac08c9c2d6815c > > https://github.com/pharo-project/pharo-core/commit/0f71987906596fff89e93063… > Author: Jenkins Build Server <board(a)pharo-project.org> > Date: 2016-02-02 (Tue, 02 Feb 2016) > > Changed paths: > M Kernel-Tests.package/ProcessTest.class/instance/testing/testFork.st > R > Kernel-Tests.package/ProcessTest.class/instance/testing/testHighPriorityOverridesWaitTime.st > A > Kernel-Tests.package/ProcessTest.class/instance/testing/testSchedulingHigherPriorityServedFirst.st > R > Kernel-Tests.package/ProcessTest.class/instance/testing/testSchedulingIsFirstComeFirstServed.st > A > Kernel-Tests.package/ProcessTest.class/instance/testing/testSchedulingSamePriorityFirstComeFirstServed.st > M > Multilingual-Languages.package/LanguageEnvironment.class/class/initialization/ > initialize.st > R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/ > script50561.st > A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/ > script50562.st > R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/ > update50561.st > A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/ > update50562.st > M > ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st > A Spec-Core.package/FastTableModel.class/README.md > A Spec-Core.package/FastTableModel.class/class/example/example.st > A Spec-Core.package/FastTableModel.class/class/specs/adapterName.st > A Spec-Core.package/FastTableModel.class/class/specs/defaultSpec.st > A Spec-Core.package/FastTableModel.class/definition.st > A > Spec-Core.package/FastTableModel.class/instance/api-events/whenIconsChanged_.st > A > Spec-Core.package/FastTableModel.class/instance/api/doubleClickAction.st > A > Spec-Core.package/FastTableModel.class/instance/api/doubleClickAction_.st > A Spec-Core.package/FastTableModel.class/instance/api/doubleClick_.st > A Spec-Core.package/FastTableModel.class/instance/api/getIconFor_.st > A > Spec-Core.package/FastTableModel.class/instance/api/handlesDoubleClick.st > A > Spec-Core.package/FastTableModel.class/instance/api/handlesDoubleClick_.st > A Spec-Core.package/FastTableModel.class/instance/api/icons.st > A Spec-Core.package/FastTableModel.class/instance/api/icons_.st > A Spec-Core.package/FastTableModel.class/instance/as yet > unclassified/registerEvents.st > A Spec-Core.package/FastTableModel.class/instance/as yet > unclassified/wrapItem_.st > A > Spec-Core.package/FastTableModel.class/instance/initialization/initializeValueHolders.st > M Spec-Core.package/ListModel.class/instance/initialization/ > initialize.st > A > Spec-Core.package/ListModel.class/instance/initialization/initializeValueHolders.st > M > Spec-Core.package/SpecAdapterBindings.class/instance/initialize/initializeBindings.st > M > Spec-MorphicAdapters.package/MorphicAdapterBindings.class/instance/initialize/initializeBindings.st > A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/README.md > A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/ > definition.st > A > Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/as yet > unclassified/doubleClick_.st > A > Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/as yet > unclassified/wrapItem_.st > A > Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/factory/buildWidget.st > A > Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/widget > API/getIconFor_.st > M System-Support.package/SystemDictionary.class/instance/classes and > traits/forgetClass_logged_.st > > Log Message: > ----------- > 50562 > 17515 fix minimal Pharo shrinking build > https://pharo.fogbugz.com/f/cases/17515 I had to reopen it because it looks not completly integrated. Cheers, -- Pavel > > > 17512 Spec should use FastTable > https://pharo.fogbugz.com/f/cases/17512 > > 17501 ProcessTest>>testHighPriorityOverridesWaitTime intermittent failures > https://pharo.fogbugz.com/f/cases/17501 > > 17035 The smallSaveIcon is the same as the smallSaveAsIcon > https://pharo.fogbugz.com/f/cases/17035 > > http://files.pharo.org/image/50/50562.zip > > >

Feb. 2, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50562 Home: https://github.com/pharo-project/pharo-core

Feb. 2, 2016

[pharo-project/pharo-core] 0f7198: 50562

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 0f71987906596fff89e93063d9ac08c9c2d6815c https://github.com/pharo-project/pharo-core/commit/0f71987906596fff89e93063… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-02-02 (Tue, 02 Feb 2016) Changed paths: M Kernel-Tests.package/ProcessTest.class/instance/testing/testFork.st R Kernel-Tests.package/ProcessTest.class/instance/testing/testHighPriorityOverridesWaitTime.st A Kernel-Tests.package/ProcessTest.class/instance/testing/testSchedulingHigherPriorityServedFirst.st R Kernel-Tests.package/ProcessTest.class/instance/testing/testSchedulingIsFirstComeFirstServed.st A Kernel-Tests.package/ProcessTest.class/instance/testing/testSchedulingSamePriorityFirstComeFirstServed.st M Multilingual-Languages.package/LanguageEnvironment.class/class/initialization/initialize.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50561.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50562.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50561.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50562.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Spec-Core.package/FastTableModel.class/README.md A Spec-Core.package/FastTableModel.class/class/example/example.st A Spec-Core.package/FastTableModel.class/class/specs/adapterName.st A Spec-Core.package/FastTableModel.class/class/specs/defaultSpec.st A Spec-Core.package/FastTableModel.class/definition.st A Spec-Core.package/FastTableModel.class/instance/api-events/whenIconsChanged_.st A Spec-Core.package/FastTableModel.class/instance/api/doubleClickAction.st A Spec-Core.package/FastTableModel.class/instance/api/doubleClickAction_.st A Spec-Core.package/FastTableModel.class/instance/api/doubleClick_.st A Spec-Core.package/FastTableModel.class/instance/api/getIconFor_.st A Spec-Core.package/FastTableModel.class/instance/api/handlesDoubleClick.st A Spec-Core.package/FastTableModel.class/instance/api/handlesDoubleClick_.st A Spec-Core.package/FastTableModel.class/instance/api/icons.st A Spec-Core.package/FastTableModel.class/instance/api/icons_.st A Spec-Core.package/FastTableModel.class/instance/as yet unclassified/registerEvents.st A Spec-Core.package/FastTableModel.class/instance/as yet unclassified/wrapItem_.st A Spec-Core.package/FastTableModel.class/instance/initialization/initializeValueHolders.st M Spec-Core.package/ListModel.class/instance/initialization/initialize.st A Spec-Core.package/ListModel.class/instance/initialization/initializeValueHolders.st M Spec-Core.package/SpecAdapterBindings.class/instance/initialize/initializeBindings.st M Spec-MorphicAdapters.package/MorphicAdapterBindings.class/instance/initialize/initializeBindings.st A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/README.md A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/definition.st A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/as yet unclassified/doubleClick_.st A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/as yet unclassified/wrapItem_.st A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/factory/buildWidget.st A Spec-MorphicAdapters.package/MorphicFastTableAdapter.class/instance/widget API/getIconFor_.st M System-Support.package/SystemDictionary.class/instance/classes and traits/forgetClass_logged_.st Log Message: ----------- 50562 17515 fix minimal Pharo shrinking build https://pharo.fogbugz.com/f/cases/17515 17512 Spec should use FastTable https://pharo.fogbugz.com/f/cases/17512 17501 ProcessTest>>testHighPriorityOverridesWaitTime intermittent failures https://pharo.fogbugz.com/f/cases/17501 17035 The smallSaveIcon is the same as the smallSaveAsIcon https://pharo.fogbugz.com/f/cases/17035 http://files.pharo.org/image/50/50562.zip

Feb. 2, 2016

GTInspector and PointerExplorer

by Nicolai Hess

Anyone working with GTInspector and inspecting "pointers to" (menu Item "Open pointers to"). Either I make something wrong or it just does not work. The only references I can see in this pointer inspector are the references *from* the inspector itself. I put an EllipseMorph in a Morph and choosed "Open Pointers to" in the inspector of the EllipseMorph. I would expect something like EllipseMorph <- array (submorphs) <- Morph But instead I only see this:

Feb. 2, 2016

Re: [Pharo-dev] what is the relationship between Float and its subclasses?

by Eliot Miranda

Hi Stef, > On Feb 1, 2016, at 11:03 PM, stepharo <stepharo(a)free.fr> wrote: > > What about something like that > > > My instances hold 64-bit Floats in heap objects. This is the only representation on 32-bit systems. But on 64-bit systems SmallFloat64 holds a subset of the full 64-bit double-precision range in immediate objects. > > BoxedFloat64 is the classical VM Float, two 4-bytes word allocated per Float, and is both for 32 bits VM and Float values not fitting in immediate format. This is because 3 bits have been removed from the exponent due to the object internal representation needed for the Spur new garbage collector. > > So on a 32 bits VM Floats are represented either by BoxedFloat64 or Float. No. Float is now an abstract class. There are only instances of BoxedFloat64 or SmallFloat64. And in 32-bits there are only BoxedFloat64 instances. So on a 32 bits VM Floats are represented only by BoxedFloat64. On a 64 bits VM Floats are represented either by BoxedFloat64 or SmallFloat64. > >

Feb. 2, 2016

Re: [Pharo-dev] what is the relationship between Float and its subclasses?

by Eliot Miranda

Stef, in 32-bit Spur there are only BoxedFloat64 instances. In 64-bit Spur there are (already) both BoxedFloat64 instances and SmallFloat64 immediates. In 64-but Spur, if a float's exponent is in the middle 8 bit range of the 11-bit double precision exponent range it is represented as a SmallFloat64 immediate and occupies no space except the slot referencing it, just as with SmallInteger. There is good documentation of the scheme in VMMaker.oscog. When time allows I'll write more informative class comments, but look at the SmallInteger comment, that's not detailed either. _,,,^..^,,,_ (phone) > On Feb 1, 2016, at 11:00 PM, stepharo <stepharo(a)free.fr> wrote: > > Tx nicolas > > I read > > SmallFloat64: My instances represent 64-bit Floats whose exponent fits in 8 bits as immediate objects. This representation is only available on 64-bit systems, not 32-bit systems. > > BoxedFloat64: My instances hold 64-bit Floats in heap objects. This is the only representation on 32-bit systems. But on 64-bit systems SmallFloat64 holds a subset of the full 64-bit double-precision range in immediate objects. > > I think that we can improve such comments but I do not have the knowledge. > > So do I get that we will have instances of Float and BoxedFloat64? > > > Le 1/2/16 21:27, Nicolas Cellier a Ã©crit : >> SmallFloat is like SmallInteger: immediate value encoded in oop, and it is only for 64 bits Spur VM. >> Boxed is the classical VM Float, two 4-bytes word allocated per Float, and is both for 32 bits VM and Float values not fitting in immediate format (3 bits have been stolen from exponent...). >> >> 2016-02-01 20:49 GMT+01:00 stepharo <stepharo(a)free.fr>: >>> Hi >>> >>> I'm updating Pharo by example and the relationship between Float and its subclasses is unclear to me. >>> Do we only get instances of the subclasses now? >>> >>> I got that Boxed is only for 64 bits. >>> But SmallFloat? >>> The class comment is not really self describing. >>> >>> Stef >

Feb. 2, 2016

Re: [Pharo-dev] what is the relationship between Float and its subclasses?

by stepharo

What about something like that My instances hold 64-bit Floats in heap objects. This is the only representation on 32-bit systems. But on 64-bit systems SmallFloat64 holds a subset of the full 64-bit double-precision range in immediate objects. BoxedFloat64 is the classical VM Float, two 4-bytes word allocated per Float, and is both for 32 bits VM and Float values not fitting in immediate format. This is because 3 bits have been removed from the exponent due to the object internal representation needed for the Spur new garbage collector. So on a 32 bits VM Floats are represented either by BoxedFloat64 or Float.

Feb. 2, 2016

Re: [Pharo-dev] what is the relationship between Float and its subclasses?

by stepharo

Tx nicolas I read SmallFloat64: My instances represent 64-bit Floats whose exponent fits in 8 bits as immediate objects. This representation is only available on 64-bit systems, not 32-bit systems. BoxedFloat64: My instances hold 64-bit Floats in heap objects. This is the only representation on 32-bit systems. But on 64-bit systems SmallFloat64 holds a subset of the full 64-bit double-precision range in immediate objects. I think that we can improve such comments but I do not have the knowledge. So do I get that we will have instances of Float and BoxedFloat64? Le 1/2/16 21:27, Nicolas Cellier a Ã©crit : > SmallFloat is like SmallInteger: immediate value encoded in oop, and > it is only for 64 bits Spur VM. > Boxed is the classical VM Float, two 4-bytes word allocated per Float, > and is both for 32 bits VM and Float values not fitting in immediate > format (3 bits have been stolen from exponent...). > > 2016-02-01 20:49 GMT+01:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > Hi > > I'm updating Pharo by example and the relationship between Float > and its subclasses is unclear to me. > Do we only get instances of the subclasses now? > > I got that Boxed is only for 64 bits. > But SmallFloat? > The class comment is not really self describing. > > Stef > >

Feb. 2, 2016