November 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] why RBComment is not called RBCommentNode

by stepharo

> A comment isnât code. The nodes are for code. A comment is more like a token â RBComment basically has the same two instance variables as RBToken. Should tokens also be nodes? For example, should a left paren token be represented as a node? > > If a comment is a node, how is it visited? > For example, if you have (âcomment1â self âcomment2â foo: âcomment3â a bar: âcomment4â b âcomment5â), what is the traversal order for the nodes? To reproduce the code as it was typed why the representation a message is not a sequence. because you need to encode that you have comment1 and self and comment2 We do not have a structure that is responsible for that order. We could have two entries in AST node; one discrete where you can cherrypick what you want receiver arguments selector and one that represent the node placement. Now when we emit bytecode comment would do nothing. How having them as token helps? You will visit the receiver and check if it has a token and place it. I found that strange that comments are not part of the code tree as first class citizen. > Furthermore, if comments are nodes, how do they affect all of the code rewriting and validation that is part of the RB and its rewrite tools With comments cannot act as nullobjects for such operation? Stef

Nov. 3, 2016

Re: [Pharo-dev] why RBComment is not called RBCommentNode

by Nicolai Hess

Am 03.11.2016 17:15 schrieb "John Brant" <brant(a)refactoryworkers.com>: > > > On Nov 3, 2016, at 9:00 AM, stepharo <stepharo(a)free.fr> wrote: > > > > Because like that > > > > we have a correct and nice hierarchy and > > > > all the nodes inherits from it and > > > > we can have a nice visitor and make assumption about the root. > > > > Regularity is nice and it helps controlling complexity. > > > > Why a comment could not have a parent? > > A comment isnât code. The nodes are for code. A comment is more like a token â RBComment basically has the same two instance variables as RBToken. Should tokens also be nodes? For example, should a left paren token be represented as a node? > > If a comment is a node, how is it visited? For example, if you have (âcomment1â self âcomment2â foo: âcomment3â a bar: âcomment4â b âcomment5â), what is the traversal order for the nodes? Furthermore, if comments are nodes, how do they affect all of the code rewriting and validation that is part of the RB and its rewrite tools? > > > John Brant OK, I think I am conceived. Otherwise, it may be easier for the AST-based formatter.

Nov. 3, 2016

Re: [Pharo-dev] why RBComment is not called RBCommentNode

by John Brant

> On Nov 3, 2016, at 9:00 AM, stepharo <stepharo(a)free.fr> wrote: > > Because like that > > we have a correct and nice hierarchy and > > all the nodes inherits from it and > > we can have a nice visitor and make assumption about the root. > > Regularity is nice and it helps controlling complexity. > > Why a comment could not have a parent? A comment isnât code. The nodes are for code. A comment is more like a token â RBComment basically has the same two instance variables as RBToken. Should tokens also be nodes? For example, should a left paren token be represented as a node? If a comment is a node, how is it visited? For example, if you have (âcomment1â self âcomment2â foo: âcomment3â a bar: âcomment4â b âcomment5â), what is the traversal order for the nodes? Furthermore, if comments are nodes, how do they affect all of the code rewriting and validation that is part of the RB and its rewrite tools? John Brant

Nov. 3, 2016

Re: [Pharo-dev] Instructions for Pharo 6 64bits

by Thierry Goubier

Hi Esteban, Another question about Pharo 64 bits. Why are libgit/libSDL/libssh included in the vm? Ubuntu 16.10 provides them with the same version numbers, more or less. (libgit2 is so.0.24.0 on ubuntu instead of so.0.24.2 in the pharo vm, SDL and ssh are the exact same versions). Collectively, those three libs are ~ 5M. Thierry 2016-10-28 11:56 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > VM here: http://bintray.com/estebanlm/pharo-vm/build#files/ > Image here: http://files.pharo.org/get-files/60/pharo-64.zip > > this is still not official (thatâs why is not in official place) so there > are a couple of known problems: > > - version format is different, and that breaks some things in image that > depends on it to know what happens > - command line is different and probably youâll need to play a bit with > options (one or two dashes). > - UFFI has some failing tests (but most of it works). > > I would appreciate some help to report and/or fix the emerging problems. > > cheers, > Esteban > > On 28 Oct 2016, at 10:39, Thierry Goubier <thierry.goubier(a)gmail.com> > wrote: > > Hi all, > > anybody knows how to get (and test) the 64bits version of the Pharo vm and > image? > > Thanks, > > Thierry > > >

Nov. 3, 2016

Re: [Pharo-dev] [Seaside-dev] Build failures

by Marcus Denker

> On 3 Nov 2016, at 15:43, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > >> On 3 Nov 2016, at 15:37, Marcus Denker <marcus.denker(a)inria.fr> wrote: >> >> Hello, >> >> it seems that a 64bit slave was installed without 32bit support. As >> >> sudo aptitude install ia32-libs >> >> did not work (no aptitude), and âapt-getâ did not know ia32-libs, > > This is how I normally do it > > https://github.com/svenvc/pharo-server-tools/blob/master/ubuntu-32bit-suppo… > I will check tomorrow on the sprint Marcus

Nov. 3, 2016

doing a backend change in pharo.org. It will be down for 1h.

by Esteban Lorenzano

subj

Nov. 3, 2016

Re: [Pharo-dev] some little static analysis with great impact

by Nicolai Hess

2016-11-03 15:17 GMT+01:00 stepharo <stepharo(a)free.fr>: > Hi > > I often end up forgetting a period. > > printOn: aStream > super printOn: aStream. > aStream nextPutAll: ' "' > aStream nextPutAll: contents. > aStream nextPutAll: '" '. > > > And statically the system could see it with a simple heuristics: > > if the message as the same name as self, super, a tmp or an argument > > May be there is a missing period. > > Could the compiler get this analysis? > > Stef > > > The highlighter gives some hints ( as in this example, message nextPutAll:nextPutAll: isn't known). And we have the RBUncommonMessageSendRule, but this rule only checks for messagenames like "self" or "true". It does not check the variables or argument names.

Nov. 3, 2016

Re: [Pharo-dev] some little static analysis with great impact

by Esteban Lorenzano

wouldnât this be better to solve this with QA? > On 3 Nov 2016, at 15:17, stepharo <stepharo(a)free.fr> wrote: > > Hi > > I often end up forgetting a period. > > printOn: aStream > super printOn: aStream. > aStream nextPutAll: ' "' > aStream nextPutAll: contents. > aStream nextPutAll: '" '. > > > And statically the system could see it with a simple heuristics: > > if the message as the same name as self, super, a tmp or an argument > > May be there is a missing period. > > Could the compiler get this analysis? > > Stef > >

Nov. 3, 2016

Re: [Pharo-dev] [Seaside-dev] Build failures

by Sven Van Caekenberghe

> On 3 Nov 2016, at 15:37, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Hello, > > it seems that a 64bit slave was installed without 32bit support. As > > sudo aptitude install ia32-libs > > did not work (no aptitude), and âapt-getâ did not know ia32-libs, This is how I normally do it https://github.com/svenvc/pharo-server-tools/blob/master/ubuntu-32bit-suppo… Although maybe more is needed (it is enough for mine applications). > I decided to shut down the slave for now. OK, Thanks. > Marcus > >> On 31 Oct 2016, at 23:28, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> It already got reported twice, there are issues for it, but so far no luck (i.e. no actual resolution). >> >> I would guess that before the linux os of the CI slaves ran in 32-bit, while now it got upgraded to 64-bit. >> >> CC-ing pharo-dev >> >>> On 28 Oct 2016, at 14:12, Johan Brichau <johan(a)inceptive.be> wrote: >>> >>> Does anybody have any idea why this is failing: >>> >>>> /pharo: line 11: <https://ci.inria.fr/pharo-contribution/job/Grease/PHARO=40,VERSION=stable,V…>: No such file or directory >>> >>> Did not look at it yet, but it seems like something changed on de CI server?? >>> >>> Johan_______________________________________________ >>> seaside-dev mailing list >>> seaside-dev(a)lists.squeakfoundation.org >>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >> >> >

Nov. 3, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60277 Home: https://github.com/pharo-project/pharo-core

Nov. 3, 2016