November 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Instructions for Pharo 6 64bits

by Thierry Goubier

Le 03/11/2016 Ã 22:16, Eliot Miranda a Ã©crit : > Hi Thierry, > > On Thu, Nov 3, 2016 at 1:06 PM, Thierry Goubier > <thierry.goubier(a)gmail.com <mailto:thierry.goubier@gmail.com>> wrote: > > Le 03/11/2016 Ã 19:25, Esteban Lorenzano a Ã©crit : > > > On 3 Nov 2016, at 19:12, Casimiro de Almeida Barreto > <casimiro.barreto(a)gmail.com > <mailto:casimiro.barreto@gmail.com> > <mailto:casimiro.barreto@gmail.com > <mailto:casimiro.barreto@gmail.com>>> wrote: > > BTW, the threaded version requires to be run as super user > because it > tries to do a pthread_setschedparam(). I tried to fiddle with > /etc/security/limits.conf... but it's not something fancy to doâ¦ > > > no, is not hard. > you just need to add this file: > > pharo.conf > *hardrtprio2 > *soft rtprio2 > > to: > > /etc/security/limits.d > > > And reboot for this to be applied. > > > To be accurate, one only needs to login again. I'm too accustomed to a single user laptop :) But that 64bits version working is really great. Thierry

Nov. 3, 2016

Re: [Pharo-dev] About setProperty:toValue: vs. valueOfProperty:

by phil＠highoctane.be

Ha, I was busy with these yesterday. Worse bit is not the morphExtension or otherProperties stuffed into them, but rather the fact that when one puts a value into #paneColor for example, themes are not respecting that. The morphExtension rationale is to have lightweight and heavyweight morphs. It is not easy to balance what should be put into a method or kept into those extra places. Now try to make a SystemWindow use the selected window color in the little downarrow menu. You'll get into the morphs creating the sides and having a transparent fillstyle, and override the paneColor thing. I am glad to have the dark theme. I am sad to not be able to set colors on my system windows easily (Yeah, I like the Play-Doh UI). Maybe subclassing those Morphs making up SystemWindows would be a good idea so that we can start having a theming for the windows borders and title. I want put the TilingWindowManager icons in the SystemWindow title bar. So, I need something more focused than just an aligment morph etc. So we will be able to plugin a couple interesting features in it. Phil On Thu, Nov 3, 2016 at 8:47 PM, stepharo <stepharo(a)free.fr> wrote: > I would like to be able to compare the **arguments** passed to > > setProperty:toValue: > > and > > the ones of valueOfProperty:, valueOfProperty:ifAbsent:, > valueOfProperty:ifAbsentPut:, > > and > > hasProperty: > > I quite sure that we will discover more deadcode in morphic. > > Any ideas? > > > > PS: I hope (but I cannot read the code of Bloc because it crashes my vm at > startup) that Bloc and Brick will not use such patterns. > > There are plague and lead to shitty and crappy code. > > > Stef > > >

Nov. 3, 2016

Re: [Pharo-dev] Instructions for Pharo 6 64bits

by Casimiro de Almeida Barreto

Em 03-11-2016 13:53, Thierry Goubier escreveu: > Hi Esteban, > > Another question about Pharo 64 bits. > > Why are libgit/libSDL/libssh included in the vm? Ubuntu 16.10 provides > them with the same version numbers, more or less. > (libgit2 is so.0.24.0 on ubuntu instead of so.0.24.2 in the pharo vm, > SDL and ssh are the exact same versions). > > Collectively, those three libs are ~ 5M. There are some troubles with ssl in Fedora (didn't test it in Ubuntu). While loading Woden (for instance) there's a crash (exception) because ZdcPluginSSLSession fails. > > Thierry > > 2016-10-28 11:56 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com > <mailto:estebanlm@gmail.com>>: > > VM here: http://bintray.com/estebanlm/pharo-vm/build#files/ > <http://bintray.com/estebanlm/pharo-vm/build#files/> > Image here: http://files.pharo.org/get-files/60/pharo-64.zip > <http://files.pharo.org/get-files/60/pharo-64.zip> > > this is still not official (thatâs why is not in official place) > so there are a couple of known problems: > > - version format is different, and that breaks some things in > image that depends on it to know what happens > - command line is different and probably youâll need to play a bit > with options (one or two dashes). > - UFFI has some failing tests (but most of it works). > > I would appreciate some help to report and/or fix the emerging > problems. > > cheers, > Esteban > >> On 28 Oct 2016, at 10:39, Thierry Goubier >> <thierry.goubier(a)gmail.com <mailto:thierry.goubier@gmail.com>> wrote: >> >> Hi all, >> >> anybody knows how to get (and test) the 64bits version of the >> Pharo vm and image? >> >> Thanks, >> >> Thierry > > -- The information contained in this message is confidential and intended to the recipients specified in the headers. If you received this message by error, notify the sender immediately. The unauthorized use, disclosure, copy or alteration of this message are strictly forbidden and subjected to civil and criminal sanctions. == This email may be signed using PGP key *ID: 0x4134A417*

Nov. 3, 2016

Re: [Pharo-dev] Instructions for Pharo 6 64bits

by Eliot Miranda

Hi Thierry, On Thu, Nov 3, 2016 at 1:06 PM, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > Le 03/11/2016 Ã 19:25, Esteban Lorenzano a Ã©crit : > >> >> On 3 Nov 2016, at 19:12, Casimiro de Almeida Barreto >>> <casimiro.barreto(a)gmail.com <mailto:casimiro.barreto@gmail.com>> wrote: >>> >>> BTW, the threaded version requires to be run as super user because it >>> tries to do a pthread_setschedparam(). I tried to fiddle with >>> /etc/security/limits.conf... but it's not something fancy to doâ¦ >>> >> >> no, is not hard. >> you just need to add this file: >> >> pharo.conf >> *hardrtprio2 >> *soft rtprio2 >> >> to: >> >> /etc/security/limits.d >> > > And reboot for this to be applied. > To be accurate, one only needs to login again. > > Thierry > > >> Esteban >> >> >>> Best regards, >>> >>> Casimiro Barreto >>> >>> Em 03-11-2016 13:53, Thierry Goubier escreveu: >>> >>>> Hi Esteban, >>>> >>>> Another question about Pharo 64 bits. >>>> >>>> Why are libgit/libSDL/libssh included in the vm? Ubuntu 16.10 >>>> provides them with the same version numbers, more or less. >>>> (libgit2 is so.0.24.0 on ubuntu instead of so.0.24.2 in the pharo vm, >>>> SDL and ssh are the exact same versions). >>>> >>>> Collectively, those three libs are ~ 5M. >>>> >>>> Thierry >>>> >>>> 2016-10-28 11:56 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com >>>> <mailto:estebanlm@gmail.com>>: >>>> >>>> VM here: http://bintray.com/estebanlm/pharo-vm/build#files/ >>>> <http://bintray.com/estebanlm/pharo-vm/build#files/> >>>> Image here: http://files.pharo.org/get-files/60/pharo-64.zip >>>> <http://files.pharo.org/get-files/60/pharo-64.zip> >>>> >>>> this is still not official (thatâs why is not in official place) >>>> so there are a couple of known problems: >>>> >>>> - version format is different, and that breaks some things in >>>> image that depends on it to know what happens >>>> - command line is different and probably youâll need to play a >>>> bit with options (one or two dashes). >>>> - UFFI has some failing tests (but most of it works). >>>> >>>> I would appreciate some help to report and/or fix the emerging >>>> problems. >>>> >>>> cheers, >>>> Esteban >>>> >>>> On 28 Oct 2016, at 10:39, Thierry Goubier >>>>> <thierry.goubier(a)gmail.com <mailto:thierry.goubier@gmail.com>> >>>>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> anybody knows how to get (and test) the 64bits version of the >>>>> Pharo vm and image? >>>>> >>>>> Thanks, >>>>> >>>>> Thierry >>>>> >>>> >>>> >>>> >>> >>> -- >>> The information contained in this message is confidential and intended >>> to the recipients specified in the headers. If you received this >>> message by error, notify the sender immediately. The unauthorized use, >>> disclosure, copy or alteration of this message are strictly forbidden >>> and subjected to civil and criminal sanctions. >>> >>> == >>> >>> This email may be signed using PGP key *ID: 0x4134A417* >>> >> >> > > -- _,,,^..^,,,_ best, Eliot

Nov. 3, 2016

the kind of code I would like to avoid....

by stepharo

I do not get why a property is useful here and why not just a temp is not good enough. Especially since there are no other users of the property. displayFiltered: evt | matchStr matches feedbackMorph | matchStr := self valueOfProperty: #matchString. matches := self menuItems select: [:m | | isMatch | isMatch := matchStr isEmpty or: [ m contents includesSubstring: matchStr caseSensitive: false ]. m isEnabled: isMatch. isMatch ]. feedbackMorph := self valueOfProperty: #feedbackMorph. feedbackMorph ifNil: [ feedbackMorph := TextMorph new autoFit: true; color: Color darkGray. self addLine; addMorphBack: feedbackMorph lock. self setProperty: #feedbackMorph toValue: feedbackMorph. self fullBounds. "Lay out for submorph adjacency"]. feedbackMorph contents: '<', matchStr, '>'. matchStr isEmpty ifTrue: [ feedbackMorph delete. self lastSubmorph delete. self removeProperty: #feedbackMorph ]. " This method is invoked with evt = nil from MenuMorph >> removeMatchString. The current implementation can't select an item without an event. (Yet :D)" (evt notNil and: [ matches size >= 1 ]) ifTrue: [self selectItem: matches first event: evt]

Nov. 3, 2016

Re: [Pharo-dev] some little static analysis with great impact

by Nicolas Cellier

2016-11-03 21:53 GMT+01:00 Yuriy Tymchuk <yuriy.tymchuk(a)me.com>: > There is already RBUncommonMessageSendRule which checks for #(#self #super > #thisContext #true #false #nil). I could also extend it to temps and args. > > Uko > Hi Uko, I often write things like | abs | abs := self abs. so I would not like the temp/args rule... What make it obvious to our eyes is indentation in this case. >From compiler POV it's just a yet unimplemented message. Can we have rules about indentation? > > > On 3 Nov 2016, at 15:17, stepharo <stepharo(a)free.fr> wrote: > > > > Hi > > > > I often end up forgetting a period. > > > > printOn: aStream > > super printOn: aStream. > > aStream nextPutAll: ' "' > > aStream nextPutAll: contents. > > aStream nextPutAll: '" '. > > > > > > And statically the system could see it with a simple heuristics: > > > > if the message as the same name as self, super, a tmp or an argument > > > > May be there is a missing period. > > > > Could the compiler get this analysis? > > > > Stef > > > > > > >

Nov. 3, 2016

Re: [Pharo-dev] why RBComment is not called RBCommentNode

by stepharo

> But how does this fit with a tree structure. For example, should âcomment5â be associated with the âbâ variable node, or the #foo:bar: message, or the sequence node that contains the #foo:bar: message, or the block or method node that contains the sequence node. You can choose, but only the writer of the comment can tell if you are right. How tokens solves this problem? I think that we do not really care one objective is to be able to recreate the code from the tree. I worked on a project in C where the guys want to know if the code is well commented and we built heuristics to associate the comments to the closest node. > >> We do not have a structure that is responsible for that order. >> We could have two entries in AST node; >> one discrete where you can cherrypick what you want receiver arguments selector >> and one that represent the node placement. >> >> Now when we emit bytecode comment would do nothing. >> >> How having them as token helps? You will visit the receiver and check if it has a token and place it. >> I found that strange that comments are not part of the code tree as first class citizen. > Tokens are essentially what they are now â although they arenât in the RBToken hierarchy. So far, the only advantages that Iâve heard you mention for nodes are visiting nodes and having a parent. The example above shows why neither of these are valid â you canât determine what is the correct parent for the comment. > > Anyway, I think comments should not be in code, but rather on code. When you add a comment, you would select a node or nodes that it applied to. When viewing a method, the comment could be displayed inline (like we have now), off to the side like reviewer comments in word processors, or a highlight that when you move the mouse over would show in a popup. Yes you are right. > Furthermore, there could be different comment types. For example, one could have design comments, todo/review comments, example code comments, bug fix comments, etc. The code view could be customized to show each one differently. Comments could have pictures and other non-string items. It would be really nice to have that. I would put optional type declaration (and they should be optional). Now for the main comment of a method I would not separate it because this is too important. > Having comments as objects outside the methodâs source string would allow them to be easily searched. For example, someone could search for a certain bug fix. Currently, if a bug fix id is in a comment, it requires a full text search of all method text. This is slow. Therefore, many companies start adding these bug fix ids to the code as symbols so that a senders search will work. Iâve seen companies that put symbols like #Fix12345 as statements inside of methods. However, this doesnât work for Smalltalkâs that remove unused literals, so in those cases they do something like adding a statement like #Fix12345 == #Fix12345 which generally isnât optimized away. :) > In addition to comments, I believe that annotations (not primitives) should be on code instead of in code like they are now. With a good implementation one could unify the concepts of comments and annotations. Yes this is interesting. Now the problem with annotations is that you have two kinds; - the ones that decorate - the ones that change or define the semantics (for those ones I would not separate) them >>> Furthermore, if comments are nodes, how do they affect all of the code rewriting and validation that is part of the RB and its rewrite tools >> With comments cannot act as nullobjects for such operation? > Yes, someone could spend time making all of this work with the existing code. However, why not fix the real problem in that comments and methods should not be a single string, but rather objects. Marcus did that during his phd and he blew up memory. So after we got a guy that worked on tree compression but he never finished. Because this is the part that makes all these ideas flying or not. Anyway thanks for the discussion. It lets me think and I learn something. I improved the class comment. Because if it would have been good in the first place I would not even ask the question. > > > John Brant >

Nov. 3, 2016

Keyboard list item navigation in Sender browser is strange

by stepharo

Hi guys If I click on an item in the message browser. The previous item gets deselected and the new one selected. Now if I use arrows, the previous items is greyed out. Are you seeing the same? Stef

Nov. 3, 2016

Re: [Pharo-dev] some little static analysis with great impact

by Yuriy Tymchuk

There is already RBUncommonMessageSendRule which checks for #(#self #super #thisContext #true #false #nil). I could also extend it to temps and args. Uko > On 3 Nov 2016, at 15:17, stepharo <stepharo(a)free.fr> wrote: > > Hi > > I often end up forgetting a period. > > printOn: aStream > super printOn: aStream. > aStream nextPutAll: ' "' > aStream nextPutAll: contents. > aStream nextPutAll: '" '. > > > And statically the system could see it with a simple heuristics: > > if the message as the same name as self, super, a tmp or an argument > > May be there is a missing period. > > Could the compiler get this analysis? > > Stef > >

Nov. 3, 2016

shoreline, GT, renaku dev please listen

by stepharo

Hi guys Please read the following https://pharo.fogbugz.com/f/cases/19288/Sending-translated-should-not-be-th… There is no need to do description: 'blo' translated in setting def. because it is already done internally (how it should be). I hope that yuriy will harvest this nice rule. I browsed the 1099 users of description:/translated and fixed the ones that needed to be fixed. Can you pay attention to merge back in your stream? Stef

Nov. 3, 2016