November 2016 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] 85a546: 60298

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 85a546d67f12bd5795d51e20d5283090faf66d61 https://github.com/pharo-project/pharo-core/commit/85a546d67f12bd5795d51e20… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-11-21 (Mon, 21 Nov 2016) Changed paths: M Nautilus.package/MethodWidget.class/instance/selection/selectedMethodIndex.st R NautilusGroupAutoBuilder.package/VSLoadAndCreateNautilusGroupCommand.class/README.md R NautilusGroupAutoBuilder.package/VSLoadAndCreateNautilusGroupCommand.class/definition.st R NautilusGroupAutoBuilder.package/VSLoadAndCreateNautilusGroupCommand.class/instance/accessing/title.st R NautilusGroupAutoBuilder.package/VSLoadAndCreateNautilusGroupCommand.class/instance/execute/createGroupWithLoadedPackages.st R NautilusGroupAutoBuilder.package/VSLoadAndCreateNautilusGroupCommand.class/instance/execute/execute.st R NautilusGroupAutoBuilder.package/extension/MBAbstractVersionInfo/instance/cmdLoadAndCreateGroup.st R Rubric.package/RubSmalltalkEditor.class/class/accessing/menuOn_.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60297.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60298.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60297.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60298.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A SmartSuggestions.package/extension/RubSmalltalkEditor/class/suggestionsMenuOn_.st M Tool-Finder.package/MethodFinder.class/class/instance creation/methodFor_.st M Tools-Test.package/MethodFinderTest.class/instance/test examples/testMethodFor.st A Versionner-Nautilus.package/VSLoadAndCreateNautilusGroupCommand.class/README.md A Versionner-Nautilus.package/VSLoadAndCreateNautilusGroupCommand.class/definition.st A Versionner-Nautilus.package/VSLoadAndCreateNautilusGroupCommand.class/instance/accessing/title.st A Versionner-Nautilus.package/VSLoadAndCreateNautilusGroupCommand.class/instance/execute/createGroupWithLoadedPackages.st A Versionner-Nautilus.package/VSLoadAndCreateNautilusGroupCommand.class/instance/execute/execute.st A Versionner-Nautilus.package/extension/MBAbstractVersionInfo/instance/cmdLoadAndCreateGroup.st A Versionner-Spec-Browser.package/ManifestVersionnerSpecBrowser.class/README.md A Versionner-Spec-Browser.package/ManifestVersionnerSpecBrowser.class/class/release/preUnload.st A Versionner-Spec-Browser.package/ManifestVersionnerSpecBrowser.class/definition.st Log Message: ----------- 60298 19378 Rendering text in athens is broken (still not fixed) https://pharo.fogbugz.com/f/cases/19378 19363 remove dependency of Rubric on SmartSuggestions https://pharo.fogbugz.com/f/cases/19363 19275 Installing / Uninstalling Metalinks clears method list selection https://pharo.fogbugz.com/f/cases/19275 19358 solve Nautilus-Versionner dependency https://pharo.fogbugz.com/f/cases/19358 19373 MethodFinder class>>#methodFor: should provide sorted result https://pharo.fogbugz.com/f/cases/19373 http://files.pharo.org/image/60/60298.zip

Nov. 21, 2016

Re: [Pharo-dev] Monkey timeout

by Marcus Denker

> On 20 Nov 2016, at 23:59, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > > > 2016-11-18 19:41 GMT+01:00 Nicolai Hess <nicolaihess(a)gmail.com <mailto:nicolaihess@gmail.com>>: > Anything we can do about the monkey timeout > a CIChangeCaseValidationRule: Timeout (after 0:01:40:00) > > This occurs even shortly after the validation starts. > > > > > reboot ? Yes, I think there are problems with the CI slave it is running on. I will reboot it. Marcus

Nov. 21, 2016

Re: [Pharo-dev] Monkey timeout

by Max Leske

> On 18 Nov 2016, at 19:41, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > Anything we can do about the monkey timeout > a CIChangeCaseValidationRule: Timeout (after 0:01:40:00) > +1 This time itâs persistent... > This occurs even shortly after the validation starts. > >

Nov. 21, 2016

Re: [Pharo-dev] Monkey timeout

by Nicolai Hess

2016-11-18 19:41 GMT+01:00 Nicolai Hess <nicolaihess(a)gmail.com>: > Anything we can do about the monkey timeout > a CIChangeCaseValidationRule: Timeout (after 0:01:40:00) > > This occurs even shortly after the validation starts. > > reboot ?

Nov. 20, 2016

Re: [Pharo-dev] Improving comments cool action

by Nicolai Hess

2016-11-20 22:06 GMT+01:00 stepharo <stepharo(a)free.fr>: > Now we have package comments :) so we should take also advantage of them. >>> >> Stupid question, how exactly does one add package comments ? Can it only >> be done in the latest 6 ? Is it somehow compatible with older versions ? >> >> In latest version you press on a package and comment and you can accept > text. > > Is it somehow compatible with older versions ? > > I do not know. I did not check its implementation. > I imagine that the package comments is stored in the manifest. So it is > probably not displayed but not lost if you load your package in Pharo 50. > > Yes, it is stored as a class side method (#description) on the package manifest class

Nov. 20, 2016

Re: [Pharo-dev] Improving comments cool action

by stepharo

>> Now we have package comments :) so we should take also advantage of them. > Stupid question, how exactly does one add package comments ? Can it only be done in the latest 6 ? Is it somehow compatible with older versions ? > In latest version you press on a package and comment and you can accept text. Is it somehow compatible with older versions ? I do not know. I did not check its implementation. I imagine that the package comments is stored in the manifest. So it is probably not displayed but not lost if you load your package in Pharo 50.

Nov. 20, 2016

Re: [Pharo-dev] STON doesn't produce valid JSON - it shouldn't escape quation mark

by Sven Van Caekenberghe

I committed the following in STON (sthub.com, ss3.gemstone.com & github.com) #bleedingEdge: === Name: STON-Core-SvenVanCaekenberghe.78 Author: SvenVanCaekenberghe Time: 20 November 2016, 7:48:23.799323 pm UUID: ee198da8-80e8-4944-ba9b-dffae331c57c Ancestors: STON-Core-SvenVanCaekenberghe.77 In JSON compatibility mode STON should not encode single quotes. (Thanks Peter UhnÃ¡k for reporting this). Patch STONWriter>>#encodeCharacter: Fix the encoding of forward slash ($/). This was already in the (external) documentation. Patch STONWriter class>>#initializeSTONCharacters - force STONWriter class>>#initialize to change too Fix the representation of Time by adding nanoseconds when there are any. This was already in the (external) documentation. Patch Time>>#stonOn: Adjust unit tests accordingly (esp. STONWriterTests>>#testDoubleQuotedString). Minor comment changes. === Name: STON-Tests-SvenVanCaekenberghe.68 Author: SvenVanCaekenberghe Time: 20 November 2016, 7:48:46.115446 pm UUID: 70402f28-f0e8-44e9-8746-3539c4add09b Ancestors: STON-Tests-SvenVanCaekenberghe.67 In JSON compatibility mode STON should not encode single quotes. (Thanks Peter UhnÃ¡k for reporting this). Patch STONWriter>>#encodeCharacter: Fix the encoding of forward slash ($/). This was already in the (external) documentation. Patch STONWriter class>>#initializeSTONCharacters - force STONWriter class>>#initialize to change too Fix the representation of Time by adding nanoseconds when there are any. This was already in the (external) documentation. Patch Time>>#stonOn: Adjust unit tests accordingly (esp. STONWriterTests>>#testDoubleQuotedString). Minor comment changes. === Now you get NeoJSONReader fromString: (STON toJsonString: 'single='' & double="'). "'single='' & double=""'" STON toString: { Time now. Date today. DateAndTime now }. "'[Time[''19:51:15.452023''],Date[''2016-11-20''],DateAndTime[''2016-11-20T19:51:15.454147+01:00'']]'" STON toString: 'back-slash=\ & forward-slash=/'. "'''back-slash=\\ & forward-slash=\/'''" Sven > On 19 Nov 2016, at 20:56, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > Peter, > > You are right, that is a bug. > > STON should be a bit more strict when it is in JSON mode. I'll fix it and let you know. > > Thanks for reporting this issue. > > Sven > >> On 19 Nov 2016, at 17:46, <i.uhnak(a)gmail.com> <i.uhnak(a)gmail.com> wrote: >> >> \â is not a valid JSON escape character, so STONâs JSON ouput is not a valid JSON string. >> >> ston := STON toJsonString: 'element''s'. -> "element\'s" >> neo := NeoJSONWriter toString: 'element''s'. -> "element's" >> >> NeoJSONReader fromString: ston. -> invalid escape character \â >> >> Peter >

Nov. 20, 2016

Re: [Pharo-dev] Improving comments cool action

by Sven Van Caekenberghe

More and better documentation, I am all for it. > On 20 Nov 2016, at 17:26, stepharo <stepharo(a)free.fr> wrote: > > Now we have package comments :) so we should take also advantage of them. Stupid question, how exactly does one add package comments ? Can it only be done in the latest 6 ? Is it somehow compatible with older versions ?

Nov. 20, 2016

Improving comments cool action

by stepharo

Hi guys I would like to see how we could build a concerted action to improve the class and method comments in Pharo. Now we have package comments :) so we should take also advantage of them. I would love that a newbie is highlithed by class comments. So I would like to start to comment key core classes. I'm sure that if we all spend 30 min per week we can really have a huge impact. I was planning to start with collection classes. Now let me know if you want to help. Stef

Nov. 20, 2016

Re: [Pharo-dev] STON doesn't produce valid JSON - it shouldn't escape quation mark

by Sven Van Caekenberghe

Peter, You are right, that is a bug. STON should be a bit more strict when it is in JSON mode. I'll fix it and let you know. Thanks for reporting this issue. Sven > On 19 Nov 2016, at 17:46, <i.uhnak(a)gmail.com> <i.uhnak(a)gmail.com> wrote: > > \â is not a valid JSON escape character, so STONâs JSON ouput is not a valid JSON string. > > ston := STON toJsonString: 'element''s'. -> "element\'s" > neo := NeoJSONWriter toString: 'element''s'. -> "element's" > > NeoJSONReader fromString: ston. -> invalid escape character \â > > Peter

Nov. 19, 2016