January 2016 - Pharo-dev - lists.pharo.org

Fixed Glamour wrong users of LayoutFrame fractions: (0@0 corner: 1@1) fixes

by stepharo

Hi I commited Glamour fixes for LayoutFrame fractions: (0@0 corner: 1@1)) -> LayoutFrame identity It is faster, produces less garbage and easier to read. Now it would be good that Glamourers do the same cleans that I did with Igor on complete Pharo. Check all the uses of fractions: and fractions:offsets: and only use those if you do not create by yourself a rectangle. In addition using rectangles for passing four digits is doomed to create wrong and incorrect rectangles so if you still need to use rectangle better use Margin. A margin is a holder of 1,2 or 4 digits and it is not a rectangle. Tell me if you need more precision. Stef

Jan. 9, 2016

Re: [Pharo-dev] gtdebugger in pharo 5.0

by Tudor Girba

Hi, > On Jan 9, 2016, at 10:43 AM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > (re-send because I exceeded limit.) > > Hi, > > letâs think positive. Thanks :) > the GTDebugger is a step forwardâ¦ it allow a lot of better interactions and of course, it needs some iterations to make it appealing to everybody. > For instance, I took me 2â to tweak the debugger presentation and to get this: Exactly :) We should also remember that it uses GTInspector which should decrease the cost of maintenance for those parts. > <Screen Shot 2016-01-09 at 09.29.59.png> > > (I changed all availableâ¦ is a trivial task) > > and like IMO feels a lot betterâ¦ and I think is a good compromise between the old and the new. > Reasons to suggest this approach: > > - it keeps old approach who(I think) was good (I can see the stack, and the flow feels natural from top to down) > - it preserves âthe importantâ (the code) as central. > - it gives space for adding columns (like the bytecode). Yes, we played with this last night and we can adopt it for now. > Nowâ¦ I can understand you want icons with text, and that can be hacked tooâ¦ > > Soâ¦ can we have an agreement? > > Esteban > > ps: btwâ¦ using GT with Fast Table we can also avoid those annoying paginated lists too Yes. I opened an issue for this: https://pharo.fogbugz.com/f/cases/17362/GTDebugger-should-use-FastTable-to-… Cheers, Doru >> On 09 Jan 2016, at 08:53, stepharo <stepharo(a)free.fr> wrote: >> >> Thanks for your testimony. >> >> I'm not against GTDebugger per se. I believe that we should have better tools >> but we should take time for building better tools (even if this is two years that moosers use or not this new debugger). >> I would appreciate a process where users can give real feedback and we can simplify/shape our tools nicely. >> >> Now for the mooc I will not present GTDebugger. So students will not use Pharo 50 >> >> Stef >> >>> Le 08/01/2016 21:22, stepharo a Ã©crit : >>>> I'm sorry but this debugger should not be the default one. >>>> MONDAY we are filming our mooc and we have to explain the debugger and >>>> personally I do not see the gain: >>>> - It looks a lot more complex to me and I do not want to have to >>>> redo all the screenshots >>>> of our lecture. >>>> - Just that I have to learn the meaning of small icons. >>>> - Why do we need a special pane for the evaluator >>>> - Why there is a type column. >>>> - Sorry but I'm not convinced about the moldable aspect behind the >>>> story (no need to argue I know it) >>>> >>>> I would like to avoid to be forced to use not the latest version of >>>> Pharo for the mooc. >>>> >>>> Such changes are arriving far too late in the release. We do not change >>>> the debugger itself the day of code freeze. >>>> >>>> We decided that the GTDebugger can be included but to me it never meant >>>> that it should be the default one. >>>> I think that experts can choose the debugger they want. The newbies don't. >>>> >>>> Stef >>>> >>>> >>> IMO the old debugger is way more intuitive. >>> When I used the debugger of Eclipse for java I was lost. When I used >>> Spec debugger I thought "Oh, this is not so hard in fact". And I lose >>> the feeling with GTDebugger. And the debugger is one of the main source >>> of interest for newbies. >>> >>> Maybe we could have a button on the spec Debugger "Switch to GTDebugger"? >>> >> >> > -- www.tudorgirba.com www.feenk.com "Don't give to get. Just give."

Jan. 9, 2016

Better class comment version2

by stepharo

I define a transformation frame relative to some rectangle. I'm basic data structure used for graphics. I represent two groups of distances: - The fractional distance (between 0 and 1) to place the morph in its owner's bounds - Fixed pixel offset to apply after fractional positioning (e.g., "10 pixel right of the center of the owner") !! API usage It is important to understand that it is better to use the fine grained API using elementary distances (bottomFraction:, bottomOffset:, leftFraction: ....) than the ones (historical) using points and rectangles (fractions:offsets:) The reason is that the old API (fractions:offsets:) is only interesting if you already have a rectangle and point at hand. If you need to create new ones, then they are created for nothing because they will be destructured to extract their information to be feed into the layoutFrame. So please do not blindly copy and paste code! Example: Favor (LayoutFrame identity leftFraction: 0; yourself); (LayoutFrame identity leftFraction: 0.5; rightFraction: 0.95; (LayoutFrame identity topOffset: topHeight; bottomFraction: 0; bottomOffset: self buttonsBarHeight; leftOffset: -1; rightOffset: 1) over (LayoutFrame fractions: (0 @ 0 corner: 1 @ 1)) For this one in particular it is better to use LayoutFrame identity It is faster and more readable because you are creating for nothing a new rectangle and some points. !! Final point: Do not use Rectangles for specifying layoutFrames If you happen to need to create a rectangle and use the fractions:offsets: class methods, refrain from creating a rectangle. The reason is that a rectangle is not 4 numbers, it represents a space area and when you use a rectangle to represent random numbers you end up creating rectangles with negative extents and this is not good. In this case use Margin, Margin is a nice class holding either one number (the same "margin" on the four sides of a rectangle), or two number (top/bottom, left/right margins) or 4 numbers. !! Implementation Instance variables: The fractional distance (between 0 and 1) to place the morph in its owner's bounds is represented by the following instance variables: leftFraction topFraction rightFraction bottomFraction <Float> Fixed pixel offset to apply after fractional positioning (e.g., "10 pixel right of the center of the owner") is represented by the following instance variables: leftOffset topOffset rightOffset bottomOffset <Integer>

Jan. 9, 2016

Fixed Glamour wrong users of LayoutFrame fractions: (0@0 corner: 1@1) fixes

by stepharo

Hi I commited Glamour fixes for LayoutFrame fractions: (0@0 corner: 1@1)) -> LayoutFrame identity It is faster, produces less garbage and easier to read. Now it would be good that Glamourers do the same cleans that I did with Igor on complete Pharo. Check all the uses of fractions: and fractions:offsets: and only use those if you do not create by yourself a rectangle. In addition using rectangles for passing four digits is doomed to create wrong and incorrect rectangles so if you still need to use rectangle better use Margin. A margin is a holder of 1,2 or 4 digits and it is not a rectangle. Tell me if you need more precision. Stef

Jan. 9, 2016

Re: [Pharo-dev] Why pharo is going over squeaksource when saving code?

by Esteban Lorenzano

no, is true :( the configurations for FFI and Alien are pointing to a place there, and since Monticello isâ¦ wellâ¦ not so goodâ¦ it scans all available repositories to get a version number. Obviously, not good.. And I think we changed that last year, but obviously is back. in the mean time, I have in my todo to make a mirror for FFI and Alien in sthub and do a configuration who will take packages from there. That will minimise the problem, but it will still be there :( Esteban > On 09 Jan 2016, at 10:07, stepharo <stepharo(a)free.fr> wrote: > > may be I'm dreaming this morning but when I saved code in the inbox I saw a query to www.squeaksource.com? > > Stef >

Jan. 9, 2016

Re: [Pharo-dev] About LayoutFrame>>fractions:offsets:

by Esteban Lorenzano

thatâs important. I never understood LayoutFrameâ¦ I always finish doing random stuff until I have something that âmore or lessâ works :) > On 09 Jan 2016, at 09:56, stepharo <stepharo(a)free.fr> wrote: > > Here is the new class comments I'm trying to write. > I hope that it will help people to understand the circumstances under which they should use fractions:offset: creation API. > > > > I define a transformation frame relative to some rectangle. I'm basic data structure used for graphics. > I represent two groups of distances: > - The fractional distance (between 0 and 1) to place the morph in its owner's bounds > - Fixed pixel offset to apply after fractional positioning (e.g., "10 pixel right of the center of the owner") > > !! API usage > It is important to understand that it is better to use the fine grained API using elementary distances (bottomFraction:, bottomOffset:, leftFraction: ....) than the ones (historical) using points and rectangles (fractions:offsets:) > > The reason is that the old API (fractions:offsets:) is only interesting if you already have a rectangle and points at hand. If you need to create new ones, then they are created for nothing because they will be destructured to extract their information to be feed into the layoutFrame. > So please do not blindly copy and paste code! > > Example: > Favor > > (LayoutFrame identity > leftFraction: 0; > yourself); > > (LayoutFrame identity > leftFraction: 0.5; > rightFraction: 0.95; > > (LayoutFrame identity > topOffset: topHeight; > bottomFraction: 0; > bottomOffset: self buttonsBarHeight; > leftOffset: -1; > rightOffset: 1) > over > > (LayoutFrame fractions: (0 @ 0 corner: 1 @ 1)) > > because you are creating for nothing a new rectangle and some points. > > > > !! Implementation > > Instance variables: > The fractional distance (between 0 and 1) to place the morph in its owner's bounds is represented by the following instance variables: > leftFraction > topFraction > rightFraction > bottomFraction <Float> > > > Fixed pixel offset to apply after fractional positioning (e.g., "10 pixel right of the center of the owner") is represented by the following instance variables: > leftOffset > topOffset > rightOffset > bottomOffset <Integer> >

Jan. 9, 2016

Why pharo is going over squeaksource when saving code?

by stepharo

may be I'm dreaming this morning but when I saved code in the inbox I saw a query to www.squeaksource.com? Stef

Jan. 9, 2016

need help improving layoutFrame =

by stepharo

(LayoutFrame fractions: (0 @ 0 corner: 1 @ 1)) = LayoutFrame identity should be true and it is not. I do not have the time to fix it now. Stef

Jan. 9, 2016

Re: [Pharo-dev] Help with FFI crash in latest Spur (only in Linux)

by Esteban Lorenzano

> On 09 Jan 2016, at 05:15, Ben Coman <btc(a)openinworld.com> wrote: > > On Sat, Jan 9, 2016 at 7:12 AM, Mariano Martinez Peck > <marianopeck(a)gmail.com <mailto:marianopeck@gmail.com>> wrote: >> >> On Jan 8, 2016 4:13 PM, "Ben Coman" <btc(a)openinworld.com> wrote: >>> >>> On Sat, Jan 9, 2016 at 2:04 AM, Mariano Martinez Peck >>> <marianopeck(a)gmail.com> wrote: >>>> Hi guys, >>>> >>>> I wonder if someone could give me a hand to find out why a FFI calling I >>>> am >>>> doing is crashing. In OSX it works correct but I am testing in CentOS >>>> and it >>>> fails. I wonder if it also crashes in other Linuxes too. >>> >>> I only had enough time to run it a few time so you know it also >>> crashes in Debian Jessie 32-bit. There were no debug logs. I got >>> these sorts of messages... >>> >> >> Thanks! >> >>> *** Error in `/home/ben/tst/pharo-vm/pharo': free(): invalid next size >>> (fast): 0x08841a70 *** >>> >>> pharo: malloc.c:3695: _int_malloc: Assertion `(unsigned long) (size) >>>> = (unsigned long) (nb)' failed. >>> *** Error in `/home/ben/tst/pharo-vm/pharo': malloc(): memory >>> corruption: 0x0984c1e0 *** >>> >>> >>> Searching github for "posix_spawn_file_actions_init " >>> (https://git.io/vuSPL) >>> I see a lot a function definitions of the form... >>> int posix_spawn_file_actions_init(posix_spawn_file_actions_t *fa) >>> { >>> fa->__actions = 0; >>> return 0; >>> } >>> >>> ...so it seems you need to first allocate the space for the struct and >>> then pass the address of that. >> >> I thought the same. But I also read in glibc that that the init and destroy >> would free and alloc exactly so that you don't have to do it. >> >> In fact, the structure is known to be opaque. I cannot rely in what I see in >> internet since each os may have a different. if it is opaque, they do not provide a function to create one? >> >> And I cant get the size of it from ffi so I cannot allocate accurately. I >> think I am screw. I don't want to go to plugin side grrr .. but you can map it and you will get the size. or you can hardcode it (not so bad, if done in the appropriate place), if is opaque, you do not need to map the structure, just know the size and allocate that. Esteban >> >> And osx does work. >> >> I think I will try against glibc rather than libc. >> >> Another idea? >> >>> { >>> int __allocated; >>> int __used; >>> struct __spawn_action *__actions; >>> int __pad[16]; >>> } posix_spawn_file_actions_t; >>> // http://linux.die.net/include/spawn.h >>> >> >> But that's opaque right? I cannot rely on that > > Your ExternalAddress use only allocates 4 bytes for the pointer. You > need to also allocate the space for the structure. I guess these may > need separate ExternalXXX objects, but just as hack experiment I find > below that n:=68 crashes and n:=69 its fine. > > | posixSpawnFileActionsT n | > n := 68. "n := 69" > posixSpawnFileActionsT := ExternalAddress allocate: n. > OSSUnixSubprocess new primitivePosixSpawnFileActionsInit: > posixSpawnFileActionsT. > posixSpawnFileActionsT free. > > > In trying to understand this I found an interesting article... > http://www.catb.org/esr/structure-packing/ <http://www.catb.org/esr/structure-packing/> > What I don't know is for a 32-bit OS on a 64-bit machine, is my > pointer 4 or 8 bytes? > Assuming 4 I derive the structure size for my 32-bit system is... > 4 int __allocated; > 4 int __used; > 4 struct __spawn_action *__actions; > 64 int __pad[16]; > 76 posix_spawn_file_actions_t; > > 76 - 68 = 8 is an interesting round number, but I can't quite reason it out. > > With FFI how to you allocate some external memory and then get a > pointer to it to pass to primitivePosixSpawnFileActionsInit ? > > cheers -ben > >>>> I am using latest Pharo 5.0 with Spur. To reproduce: >>>> >>>> 1) Get latest Pharo 5.0 and Spur via: >>>> wget -O- get.pharo.org/alpha+vm | bash >>>> >>>> 2) Inside Pharo, load my prototype tool: >>>> >>>> Gofer it >>>> package: 'OSSubprocess'; >>>> url: 'http://smalltalkhub.com/mc/marianopeck/OSSubprocess/main'; >>>> load. >>>> >>>> 3) This is the code I am executing and it's crashing: >>>> >>>> | posixSpawnFileActionsT | posixSpawnFileActionsT := ExternalAddress >>>> allocate: 4. OSSUnixSubprocess new primitivePosixSpawnFileActionsInit: >>>> posixSpawnFileActionsT. posixSpawnFileActionsT free. >>>> 4) The primitive is as simple as: >>>> >>>> primitivePosixSpawnFileActionsInit: aPosixSpawnFileActionsT >>>> ^ self ffiCall: #( int posix_spawn_file_actions_init(void* >>>> aPosixSpawnFileActionsT) ) module: LibC >>>> >>>> I have no idea what I am doing wrong. And again, this works on OSX. The >>>> function I am calling is: int >>>> posix_spawn_file_actions_init(posix_spawn_file_actions_t *file_actions); >>>> as >>>> you can read in [1] >>>> >>>> Below is the stacktrace I get the Linux terminal. >>>> >>>> Any hint is greatly appreciated. >>>> >>>> Thanks, >>>> >>>> >>>> [1] >>>> >>>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_spawn_file_…

Jan. 9, 2016

Re: [Pharo-dev] [Vm-dev] Re: [squeak-dev] Re: problem with become:?

by Esteban Lorenzano

> On 09 Jan 2016, at 01:20, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > Hi Doru, Hi Nicolai, > > On Fri, Jan 8, 2016 at 2:33 PM, Eliot Miranda <eliot.miranda(a)gmail.com <mailto:eliot.miranda@gmail.com>> wrote: > > > On Fri, Jan 8, 2016 at 2:11 PM, Nicolai Hess <nicolaihess(a)gmail.com <mailto:nicolaihess@gmail.com>> wrote: > > > > 2016-01-08 23:09 GMT+01:00 Eliot Miranda <eliot.miranda(a)gmail.com <mailto:eliot.miranda@gmail.com>>: > Hi Doru, > > On Fri, Jan 8, 2016 at 12:02 PM, Tudor Girba <tudor(a)tudorgirba.com <mailto:tudor@tudorgirba.com>> wrote: > Hi, > > If I execute the following code in the latest Pharo image: > > Object subclass: #A > instanceVariableNames: '' > classVariableNames: '' > package: 'AA'. > Object subclass: #B > instanceVariableNames: '' > classVariableNames: '' > package: 'AA'. > a := A new. > b := B new. > a become: b. > a class > > ==> âA". > > In a pre-Spur image, I used to get âBâ. Is this a bug, or is there a change I am not aware of? > > Cheers, > Doru > > Looks like a bug to me. I'll fix it asap. > > > There is another bug report at > http://bugs.squeak.org/view.php?id=7845 <http://bugs.squeak.org/view.php?id=7845> > > | obj1 obj2 | > obj1 := 'string'. > obj2 := 1.234. > obj1 become: obj2. > {obj1. obj2} "=> #('X9 LÃvÂ¾' 'string'). it should be #(1.234 'string') " > > Squeak Cog Supr Virtual Machine 4.0.3427.0 > > > Is it related? > > Thank you, certainly looks like it. > > The good news is that these are not bugs in the simulator. So I need to generate new sources and working VMs (and Esteban will need to rebuild the Pharo 5 VM) and then the bugs should be fixed. There's a slim possibility that this could be due to a Slang bug but I doubt it. yes, Iâm now one month behind but thatâs because of a bug in pharo who is not fixed, so next week I will resume the jobs. If there are not âissuesâ like this, normally VM is available immediately after a VMMaker commit :) Esteban > > > -- > www.tudorgirba.com <http://www.tudorgirba.com/> > www.feenk.com <http://www.feenk.com/> > > "Things happen when they happen, > not when you talk about them happening." > > _,,,^..^,,,_ > best, Eliot > > _,,,^..^,,,_ > best, Eliot > > _,,,^..^,,,_ > best, Eliot

Jan. 9, 2016