September 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Marcus Denker

> On 05 Sep 2015, at 13:07, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Is there an easy way to browse a history of something. Or a blame view? Because âbrowse versionsâ that is available in Nautilus shows only the modifications in the current image. Having quick access to the history can speedup things sooo much > It should still show all changed done since the last condense of the sources/rewrite of the .sources. But yes, the âversionsâ that is not using the data from the revision control system is kind of uselessâ¦ Marcus

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

Is there an easy way to browse a history of something. Or a blame view? Because âbrowse versionsâ that is available in Nautilus shows only the modifications in the current image. Having quick access to the history can speedup things sooo much > On 05 Sep 2015, at 12:59, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Iâm making progress. So the issue is that the selectedClass variable of Nautilus (model) is not set to nil when the class is being removed. I will check why. > >> On 05 Sep 2015, at 12:44, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: >> >> As a side note: can we somehow write UI tests? Because this use-case could be implemented as a test to ensure future auto checks. >> >> Uko >> >> >>> On 05 Sep 2015, at 12:42, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: >>> >>> I will take a look now! >>> >>> >>>> On 05 Sep 2015, at 11:48, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: >>>> >>>> >>>>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>>> >>>>> How can I see the changes? >>>>> Our process is not good. Most of us do not get any chance understanding what is changing. >>>>> >>>> >>>> -> download the image before it was added >>>> -> merge the slice. >>>> >>>> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >>>> *two* reviews, both from people actively contributing to exactly that part of the system. >>>> >>>> If we require more, we will be back at a process where due to Fear we do nothing. >>>> >>>>> >>>>>> Hi, >>>>>> >>>>>> This is a side effect of >>>>>> >>>>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>>>>> >>>>>> (which was reviewed by two people, so not obvious). >>>>>> >>>>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>>>> >>>>>> Should be easy to fix for the people involved in case 16475. >>>>>> >>>>>> Marcus >>>>>> >>>>>> >>>>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>>>> Hi >>>>>> >>>>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>>>> >>>>>> Stef >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -- >>>>>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>>>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>>>> >>>> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

Iâm making progress. So the issue is that the selectedClass variable of Nautilus (model) is not set to nil when the class is being removed. I will check why. > On 05 Sep 2015, at 12:44, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > As a side note: can we somehow write UI tests? Because this use-case could be implemented as a test to ensure future auto checks. > > Uko > > >> On 05 Sep 2015, at 12:42, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: >> >> I will take a look now! >> >> >>> On 05 Sep 2015, at 11:48, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: >>> >>> >>>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>> >>>> How can I see the changes? >>>> Our process is not good. Most of us do not get any chance understanding what is changing. >>>> >>> >>> -> download the image before it was added >>> -> merge the slice. >>> >>> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >>> *two* reviews, both from people actively contributing to exactly that part of the system. >>> >>> If we require more, we will be back at a process where due to Fear we do nothing. >>> >>>> >>>>> Hi, >>>>> >>>>> This is a side effect of >>>>> >>>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>>>> >>>>> (which was reviewed by two people, so not obvious). >>>>> >>>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>>> >>>>> Should be easy to fix for the people involved in case 16475. >>>>> >>>>> Marcus >>>>> >>>>> >>>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>>> Hi >>>>> >>>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>>> >>>>> Stef >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> -- >>>>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>>> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

As a side note: can we somehow write UI tests? Because this use-case could be implemented as a test to ensure future auto checks. Uko > On 05 Sep 2015, at 12:42, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > I will take a look now! > > >> On 05 Sep 2015, at 11:48, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: >> >> >>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>> >>> How can I see the changes? >>> Our process is not good. Most of us do not get any chance understanding what is changing. >>> >> >> -> download the image before it was added >> -> merge the slice. >> >> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >> *two* reviews, both from people actively contributing to exactly that part of the system. >> >> If we require more, we will be back at a process where due to Fear we do nothing. >> >>> >>>> Hi, >>>> >>>> This is a side effect of >>>> >>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>>> >>>> (which was reviewed by two people, so not obvious). >>>> >>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>> >>>> Should be easy to fix for the people involved in case 16475. >>>> >>>> Marcus >>>> >>>> >>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>> Hi >>>> >>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>> >>>> Stef >>>> >>>> >>>> >>>> >>>> -- >>>> -- >>>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

I will take a look now! > On 05 Sep 2015, at 11:48, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > >> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >> >> How can I see the changes? >> Our process is not good. Most of us do not get any chance understanding what is changing. >> > > -> download the image before it was added > -> merge the slice. > > Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. > *two* reviews, both from people actively contributing to exactly that part of the system. > > If we require more, we will be back at a process where due to Fear we do nothing. > >> >>> Hi, >>> >>> This is a side effect of >>> >>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>> >>> (which was reviewed by two people, so not obvious). >>> >>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>> >>> Should be easy to fix for the people involved in case 16475. >>> >>> Marcus >>> >>> >>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>> Hi >>> >>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>> >>> Stef >>> >>> >>> >>> >>> -- >>> -- >>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >> >

Sept. 5, 2015

Re: [Pharo-dev] TextAttributes in source code or class comment?

by Martin Dias

Hi all On Sat, Sep 5, 2015 at 3:44 AM, Ben Coman <btc(a)openinworld.com> wrote: > On Sat, Sep 5, 2015 at 4:43 AM, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: >> >> On Sep 4, 2015, at 1:33 PM, stepharo <stepharo(a)free.fr> wrote: >> >> Nobody defines urls in method comment anymore. >> >> I do. Several places in the Cog JIT contain irks to specification >> documents. I don't care how its implemented (providing it's preserved in >> text, or maybe have the pretty-printer scan comments for http://. But it is >> sad that we can't have hyperlinks in text. >> >> Look I know the implementation stinks, but it can be fixed. But if the >> functionality is lost the system is weakened. Instead of asking what you >> can get rid if why not ask what you can reimplement or enhance more >> elegantly. > > Its a reasonable strategy to start the discussion at the extreme end > and work back from there :) But if its being used we should think > harder about it. What alternatives/workarounds are there? > > First just to clarify, the aim is to remove Text from the image for > the boot-strap? Yes :) I heard that we want to do cut the dependency to Text-Core, so I browsed how to do it. Ben, there is an explanation about ]style[ in the class comment of RemoteString. Eliot, I didn't thought that somebody was using Text. In fact, I don't know how to do it in Pharo... how do you do? I found that ChangeRecord>>fileIn uses #newTextChunk to parse, but I just tested filing-in the attached .st file and it doesn't work. I guess the new CodeImporter replaced the ChangeRecord implementation, and it raises an error when ]style[. MartÃn > > 1. Save the text internally as a string in the stream format and > up-convert to Text only when its being displayed? But I guess these > styles aren't restricted to just occurring in comments and maybe cause > problem for compilation ?? > > 2. As a stepping stone, introduce a TextPlaceholder class within > minimal interface required by compilation which simply strips out all > styles when Text is missing from the Image. When Text is present it > #becomes back to it. Maybe risks loosing styles editing is done on > the raw-stream-format. Maybe any editor would show the raw ]style[ > and the compiler asks for #source which strips styles out. > > 3. Introduce Pillar and convert across. What are the requirements? > a. URLs > b. Class/method links > c. Would you expect that Pillar can only appear in comments? Or > in-line with code? > d. Colouring? > ...? > > btw, I haven't come across this before. Can someone point me to some > url & styled code where I can have a look at it > > cheers -ben > >> Christ you're even using minis paced fonts. It's like the dark >> ages in there ;-) >> >> In addition would prefer to have an explicit syntax as in Pillar or html to >> represent >> an hyperlink. We could have >> *Class>>#method* when pillar is not loaded and else a nicer >> representation. >> ctrl-click on a class should jump on it already and we could map it to >> *Class>>#method* >> >> In class comments we should use pillar and get a real text renderer. >> >> >> Hi Martin, >> >> On Fri, Sep 4, 2015 at 8:13 AM, Martin Dias <tinchodias(a)gmail.com> wrote: >>> >>> Hi all, >>> >>> The source code of a method could be a Text, with TextAttributes. In such >>> case, it will be written down to a stream with a "]style[" suffix. Through a >>> special parsing, the system can reconstruct the original Text. I think the >>> use of Text in source code or class comments is discouraged, but I >>> understand we kept support for some backward compatibility. Now, may be it's >>> time to remove this feature. >>> >>> With Pablo, we looked for uses of ]style[ in the .sources and .changes >>> files of a new Pharo 5.0, and there are no real uses. It appears in some >>> comments only, as examples. >>> >>> We tried to find past discussions about this feature, because we're sure >>> there were, but we couldn't. >>> >>> So, the questions is: >>> >>> Can we remove support for text in source code or class comments in >>> Pharo 5.0? >> >> >> IIUC, ]style[ also supports things like embedding URL links and method >> references in class comments. So I would request that it /not/ be removed. >> It is very useful to put clickable links in class comments. >> >>> >>> >>> I think I can propose a slice. >>> >>> Regards, >>> MartÃn >>> PS: I was trying to cut dependencies of Text-Core with System-Changes and >>> System-Changes. >> >> >> >> >> -- >> _,,,^..^,,,_ >> best, Eliot >> >> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Marcus Denker

> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr> wrote: > > How can I see the changes? > Our process is not good. Most of us do not get any chance understanding what is changing. > -> download the image before it was added -> merge the slice. Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. *two* reviews, both from people actively contributing to exactly that part of the system. If we require more, we will be back at a process where due to Fear we do nothing. > >> Hi, >> >> This is a side effect of >> >> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >> >> (which was reviewed by two people, so not obvious). >> >> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >> >> Should be easy to fix for the people involved in case 16475. >> >> Marcus >> >> >> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >> Hi >> >> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >> >> Stef >> >> >> >> >> -- >> -- >> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >> http://www.marcusdenker.de <http://www.marcusdenker.de/> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by stepharo

How can I see the changes? Our process is not good. Most of us do not get any chance understanding what is changing. > Hi, > > This is a side effect of > > https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… > > (which was reviewed by two people, so not obvious). > > What happened is that #updatePackageGroupAndClassList calls itself via > #selectedClass: leading to a loop. > > Should be easy to fix for the people involved in case 16475. > > Marcus > > > On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > Hi > > I do not know if this is linked to recent changes but we cannot > remove classes or move them to another package. > > Stef > > > > > -- > -- > Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> > http://www.marcusdenker.de

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Marcus Denker

> On 05 Sep 2015, at 09:29, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Hi, > > This is a side effect of > > https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> > > (which was reviewed by two people, so not obvious). > > What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. > > Should be easy to fix for the people involved in case 16475. I added an issue tracker entry: https://pharo.fogbugz.com/f/cases/16484/Endless-loop-on-refresh-after-delet… <https://pharo.fogbugz.com/f/cases/16484/Endless-loop-on-refresh-after-delet…> Marcus

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Marcus Denker

Hi, This is a side effect of https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… (which was reviewed by two people, so not obvious). What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. Should be easy to fix for the people involved in case 16475. Marcus On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr> wrote: > Hi > > I do not know if this is linked to recent changes but we cannot remove > classes or move them to another package. > > Stef > > -- -- Marcus Denker -- denker(a)acm.org http://www.marcusdenker.de

Sept. 5, 2015