September 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Stephan Eggermont

On 05-09-15 14:09, Yuriy Tymchuk wrote: > I found the issue. Fix almost ready. Should I reopen the case, or create a new one? 16488 is a different issue Stephan

Sept. 5, 2015

Re: [Pharo-dev] System announcements fixed?

by Stephan Eggermont

On 05-09-15 08:52, stepharo wrote: > Since when? > Where is the bug entry? > Where is a reproducible case? The easy ones: 16485 Class panes not refreshed when changing package (by Marcus) 16486 Nautilus doesn't update the method pane after adding a method (first time) 16487 Dropping methods on empty areas of class/method category pane raises SubscriptOutOfBounds 16488 Dropping a class from one browser to another package in another browser updates selected package+class in both 16489 Monticello browser doesn't update others after adding repo And there is a more difficult case where changing code in the debugger does not get to (all) nautilus browsers. I had two browsers open and changed code that was in the selected class but not visible in the browsers. One browser was correctly updated, the other was not. This has happened for a few weeks now, and I thought this was known and related to the current Nautilus refactorings. Stephan

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

I found the issue. Fix almost ready. Should I reopen the case, or create a new one? Uko > On 05 Sep 2015, at 13:59, Stephan Eggermont <stephan(a)stack.nl> wrote: > > On 05-09-15 08:51, stepharo wrote: >> Hi >> >> I do not know if this is linked to recent changes but we cannot remove >> classes or move them to another package > > I can move them to another package using drag-and-drop (issue 16488) > in 50305 > > > Stephan > >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Stephan Eggermont

On 05-09-15 08:51, stepharo wrote: > Hi > > I do not know if this is linked to recent changes but we cannot remove > classes or move them to another package I can move them to another package using drag-and-drop (issue 16488) in 50305 Stephan

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

You can see changes for that patch here: https://github.com/pharo-project/pharo-core/commit/2536752ecdd88e15b00c6d3e… > On 05 Sep 2015, at 13:23, stepharo <stepharo(a)free.fr> wrote: > > >>> On 05 Sep 2015, at 11:40, stepharo < <mailto:stepharo@free.fr>stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>> >>> How can I see the changes? >>> Our process is not good. Most of us do not get any chance understanding what is changing. >>> >> >> -> download the image before it was added >> -> merge the slice. >> >> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >> *two* reviews, both from people actively contributing to exactly that part of the system. >> >> If we require more, we will be back at a process where due to Fear we do nothing. > > I do not want to require more. I want to see all the changes that we are doing without having to download an image > and doing merge. > I read many squeak changes like that and IT WORKS. > > Stef >> >>> >>>> Hi, >>>> >>>> This is a side effect of >>>> >>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>>> >>>> (which was reviewed by two people, so not obvious). >>>> >>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>> >>>> Should be easy to fix for the people involved in case 16475. >>>> >>>> Marcus >>>> >>>> >>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo < <mailto:stepharo@free.fr>stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>> Hi >>>> >>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>> >>>> Stef >>>> >>>> >>>> >>>> >>>> -- >>>> -- >>>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] remove MczInstaller?

by stepharo

Hi martin how MCZ are then read? Stef Le 4/9/15 15:18, Martin Dias a Ã©crit : > Hi, > > Does somebody use MczInstaller to load Monticello files? The only > users in the image are it's tests. > > The class comment states: " > An installer for Monticello files with the *.mcz extension. > > MczInstaller installFileNamed: 'MyKillerApp-Core-Author.1.mcz' > " > > MartÃn

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by stepharo

>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr >> <mailto:stepharo@free.fr>> wrote: >> >> How can I see the changes? >> Our process is not good. Most of us do not get any chance >> understanding what is changing. >> > > -> download the image before it was added > -> merge the slice. > > Yes, our process is not goodâ¦ but from a review perspective, this > issue is the best we can do. > *two* reviews, both from people actively contributing to exactly that > part of the system. > > If we require more, we will be back at a process where due to Fear we > do nothing. I do not want to require more. I want to see all the changes that we are doing without having to download an image and doing merge. I read many squeak changes like that and IT WORKS. Stef > >> >>> Hi, >>> >>> This is a side effect of >>> >>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… >>> >>> (which was reviewed by two people, so not obvious). >>> >>> What happened is that #updatePackageGroupAndClassList calls itself >>> via #selectedClass: leading to a loop. >>> >>> Should be easy to fix for the people involved in case 16475. >>> >>> Marcus >>> >>> >>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr >>> <mailto:stepharo@free.fr>> wrote: >>> >>> Hi >>> >>> I do not know if this is linked to recent changes but we cannot >>> remove classes or move them to another package. >>> >>> Stef >>> >>> >>> >>> >>> -- >>> -- >>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by stepharo

This is my all point. I cannot help because I cannot see simply what you did. Le 5/9/15 13:07, Yuriy Tymchuk a Ã©crit : > Is there an easy way to browse a history of something. Or a blame > view? Because âbrowse versionsâ that is available in Nautilus shows > only the modifications in the current image. Having quick access to > the history can speedup things sooo much > >> On 05 Sep 2015, at 12:59, Yuriy Tymchuk <yuriy.tymchuk(a)me.com >> <mailto:yuriy.tymchuk@me.com>> wrote: >> >> Iâm making progress. So the issue is that the selectedClass variable >> of Nautilus (model) is not set to nil when the class is being >> removed. I will check why. >> >>> On 05 Sep 2015, at 12:44, Yuriy Tymchuk <yuriy.tymchuk(a)me.com >>> <mailto:yuriy.tymchuk@me.com>> wrote: >>> >>> As a side note: can we somehow write UI tests? Because this use-case >>> could be implemented as a test to ensure future auto checks. >>> >>> Uko >>> >>> >>>> On 05 Sep 2015, at 12:42, Yuriy Tymchuk <yuriy.tymchuk(a)me.com >>>> <mailto:yuriy.tymchuk@me.com>> wrote: >>>> >>>> I will take a look now! >>>> >>>> >>>>> On 05 Sep 2015, at 11:48, Marcus Denker <marcus.denker(a)inria.fr >>>>> <mailto:marcus.denker@inria.fr>> wrote: >>>>> >>>>> >>>>>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr >>>>>> <mailto:stepharo@free.fr>> wrote: >>>>>> >>>>>> How can I see the changes? >>>>>> Our process is not good. Most of us do not get any chance >>>>>> understanding what is changing. >>>>>> >>>>> >>>>> -> download the image before it was added >>>>> -> merge the slice. >>>>> >>>>> Yes, our process is not goodâ¦ but from a review perspective, this >>>>> issue is the best we can do. >>>>> *two* reviews, both from people actively contributing to exactly >>>>> that part of the system. >>>>> >>>>> If we require more, we will be back at a process where due to Fear >>>>> we do nothing. >>>>> >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> This is a side effect of >>>>>>> >>>>>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… >>>>>>> >>>>>>> (which was reviewed by two people, so not obvious). >>>>>>> >>>>>>> What happened is that #updatePackageGroupAndClassList calls >>>>>>> itself via #selectedClass: leading to a loop. >>>>>>> >>>>>>> Should be easy to fix for the people involved in case 16475. >>>>>>> >>>>>>> Marcus >>>>>>> >>>>>>> >>>>>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr >>>>>>> <mailto:stepharo@free.fr>> wrote: >>>>>>> >>>>>>> Hi >>>>>>> >>>>>>> I do not know if this is linked to recent changes but we >>>>>>> cannot remove classes or move them to another package. >>>>>>> >>>>>>> Stef >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> -- >>>>>>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>>>>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>>>>> >>>>> >>>> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

Ok, so the deepest Iâve got is that âself classWidget getClassesListâ (where self is NautilusUI) always returns an empty list, so removed class is not found in that list, so it is not removed from the model. I have not changes ClassWidget and never worked with it, so from now the investigation will go slower. Iâd appreciate help in any Nautilus people are out there. Uko > On 05 Sep 2015, at 12:59, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Iâm making progress. So the issue is that the selectedClass variable of Nautilus (model) is not set to nil when the class is being removed. I will check why. > >> On 05 Sep 2015, at 12:44, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: >> >> As a side note: can we somehow write UI tests? Because this use-case could be implemented as a test to ensure future auto checks. >> >> Uko >> >> >>> On 05 Sep 2015, at 12:42, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: >>> >>> I will take a look now! >>> >>> >>>> On 05 Sep 2015, at 11:48, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: >>>> >>>> >>>>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>>> >>>>> How can I see the changes? >>>>> Our process is not good. Most of us do not get any chance understanding what is changing. >>>>> >>>> >>>> -> download the image before it was added >>>> -> merge the slice. >>>> >>>> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >>>> *two* reviews, both from people actively contributing to exactly that part of the system. >>>> >>>> If we require more, we will be back at a process where due to Fear we do nothing. >>>> >>>>> >>>>>> Hi, >>>>>> >>>>>> This is a side effect of >>>>>> >>>>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>>>>> >>>>>> (which was reviewed by two people, so not obvious). >>>>>> >>>>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>>>> >>>>>> Should be easy to fix for the people involved in case 16475. >>>>>> >>>>>> Marcus >>>>>> >>>>>> >>>>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>>>> Hi >>>>>> >>>>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>>>> >>>>>> Stef >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -- >>>>>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>>>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>>>> >>>> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] TextAttributes in source code or class comment?

by Nicolai Hess

The same for the ]lang[ tag (see issue 15750) 2015-09-05 12:06 GMT+02:00 Martin Dias <tinchodias(a)gmail.com>: > Hi all > > On Sat, Sep 5, 2015 at 3:44 AM, Ben Coman <btc(a)openinworld.com> wrote: > > On Sat, Sep 5, 2015 at 4:43 AM, Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > >> > >> On Sep 4, 2015, at 1:33 PM, stepharo <stepharo(a)free.fr> wrote: > >> > >> Nobody defines urls in method comment anymore. > >> > >> I do. Several places in the Cog JIT contain irks to specification > >> documents. I don't care how its implemented (providing it's preserved > in > >> text, or maybe have the pretty-printer scan comments for http://. But > it is > >> sad that we can't have hyperlinks in text. > >> > >> Look I know the implementation stinks, but it can be fixed. But if the > >> functionality is lost the system is weakened. Instead of asking what > you > >> can get rid if why not ask what you can reimplement or enhance more > >> elegantly. > > > > Its a reasonable strategy to start the discussion at the extreme end > > and work back from there :) But if its being used we should think > > harder about it. What alternatives/workarounds are there? > > > > First just to clarify, the aim is to remove Text from the image for > > the boot-strap? > > Yes :) I heard that we want to do cut the dependency to Text-Core, so > I browsed how to do it. > > Ben, there is an explanation about ]style[ in the class comment of > RemoteString. > > Eliot, I didn't thought that somebody was using Text. In fact, I don't > know how to do it in Pharo... how do you do? > I found that ChangeRecord>>fileIn uses #newTextChunk to parse, but I > just tested filing-in the attached .st file and it doesn't work. I > guess the new CodeImporter replaced the ChangeRecord implementation, > and it raises an error when ]style[. > > MartÃn > > > > > > 1. Save the text internally as a string in the stream format and > > up-convert to Text only when its being displayed? But I guess these > > styles aren't restricted to just occurring in comments and maybe cause > > problem for compilation ?? > > > > 2. As a stepping stone, introduce a TextPlaceholder class within > > minimal interface required by compilation which simply strips out all > > styles when Text is missing from the Image. When Text is present it > > #becomes back to it. Maybe risks loosing styles editing is done on > > the raw-stream-format. Maybe any editor would show the raw ]style[ > > and the compiler asks for #source which strips styles out. > > > > 3. Introduce Pillar and convert across. What are the requirements? > > a. URLs > > b. Class/method links > > c. Would you expect that Pillar can only appear in comments? Or > > in-line with code? > > d. Colouring? > > ...? > > > > btw, I haven't come across this before. Can someone point me to some > > url & styled code where I can have a look at it > > > > cheers -ben > > > >> Christ you're even using minis paced fonts. It's like the dark > >> ages in there ;-) > >> > >> In addition would prefer to have an explicit syntax as in Pillar or > html to > >> represent > >> an hyperlink. We could have > >> *Class>>#method* when pillar is not loaded and else a nicer > >> representation. > >> ctrl-click on a class should jump on it already and we could map it to > >> *Class>>#method* > >> > >> In class comments we should use pillar and get a real text renderer. > >> > >> > >> Hi Martin, > >> > >> On Fri, Sep 4, 2015 at 8:13 AM, Martin Dias <tinchodias(a)gmail.com> > wrote: > >>> > >>> Hi all, > >>> > >>> The source code of a method could be a Text, with TextAttributes. In > such > >>> case, it will be written down to a stream with a "]style[" suffix. > Through a > >>> special parsing, the system can reconstruct the original Text. I think > the > >>> use of Text in source code or class comments is discouraged, but I > >>> understand we kept support for some backward compatibility. Now, may > be it's > >>> time to remove this feature. > >>> > >>> With Pablo, we looked for uses of ]style[ in the .sources and .changes > >>> files of a new Pharo 5.0, and there are no real uses. It appears in > some > >>> comments only, as examples. > >>> > >>> We tried to find past discussions about this feature, because we're > sure > >>> there were, but we couldn't. > >>> > >>> So, the questions is: > >>> > >>> Can we remove support for text in source code or class comments in > >>> Pharo 5.0? > >> > >> > >> IIUC, ]style[ also supports things like embedding URL links and method > >> references in class comments. So I would request that it /not/ be > removed. > >> It is very useful to put clickable links in class comments. > >> > >>> > >>> > >>> I think I can propose a slice. > >>> > >>> Regards, > >>> MartÃn > >>> PS: I was trying to cut dependencies of Text-Core with System-Changes > and > >>> System-Changes. > >> > >> > >> > >> > >> -- > >> _,,,^..^,,,_ > >> best, Eliot > >> > >> > > >

Sept. 5, 2015