September 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

In fact you couldnât spot the issue by just looking at the patch :) there was a very strange thing that could be fixed with one line, but to identify it Iâve spent probably 1.5 hours :) Uko > On 05 Sep 2015, at 19:03, Nicolai Hess <nicolaihess(a)web.de> wrote: > > > > 2015-09-05 11:48 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>>: > >> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >> >> How can I see the changes? >> Our process is not good. Most of us do not get any chance understanding what is changing. >> > > -> download the image before it was added > -> merge the slice. > > Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. > *two* reviews, both from people actively contributing to exactly that part of the system. > > If we require more, we will be back at a process where due to Fear we do nothing. > > > Nautilus is a difficult beast, you all know. Even if you look close at the merge diff you may > miss some important relation that only really visible during debugging. > I did some test when reviewing this fix. But really, there are so many > ways do you need to consider > - different ways for opening nautilus > - navigate with keys and mouse > - selecting updating / changes from other browser and system changes. > - refactorings > > It is really not that easy and I am happy that Franck and Yuri are actually trying to > improve Nautilus. > you can not easily tests all and make the changes and reviews bullet proof. > > > nicolai > > > >> >>> Hi, >>> >>> This is a side effect of >>> >>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>> >>> (which was reviewed by two people, so not obvious). >>> >>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>> >>> Should be easy to fix for the people involved in case 16475. >>> >>> Marcus >>> >>> >>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>> Hi >>> >>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>> >>> Stef >>> >>> >>> >>> >>> -- >>> -- >>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>> http://www.marcusdenker.de <http://www.marcusdenker.de/>

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Nicolai Hess

2015-09-05 11:48 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr>: > > On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr> wrote: > > How can I see the changes? > Our process is not good. Most of us do not get any chance understanding > what is changing. > > > -> download the image before it was added > -> merge the slice. > > Yes, our process is not goodâ¦ but from a review perspective, this issue is > the best we can do. > *two* reviews, both from people actively contributing to exactly that > part of the system. > > If we require more, we will be back at a process where due to Fear we do > nothing. > > Nautilus is a difficult beast, you all know. Even if you look close at the merge diff you may miss some important relation that only really visible during debugging. I did some test when reviewing this fix. But really, there are so many ways do you need to consider - different ways for opening nautilus - navigate with keys and mouse - selecting updating / changes from other browser and system changes. - refactorings It is really not that easy and I am happy that Franck and Yuri are actually trying to improve Nautilus. you can not easily tests all and make the changes and reviews bullet proof. nicolai > > Hi, > > This is a side effect of > > > https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… > > (which was reviewed by two people, so not obvious). > > What happened is that #updatePackageGroupAndClassList calls itself via > #selectedClass: leading to a loop. > > Should be easy to fix for the people involved in case 16475. > > Marcus > > > On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr> wrote: > >> Hi >> >> I do not know if this is linked to recent changes but we cannot remove >> classes or move them to another package. >> >> Stef >> >> > > > -- > -- > Marcus Denker -- denker(a)acm.org > http://www.marcusdenker.de > > > >

Sept. 5, 2015

Re: [Pharo-dev] remove MczInstaller?

by Martin Dias

On Sat, Sep 5, 2015 at 7:00 PM, Martin Dias <tinchodias(a)gmail.com> wrote: > Hi, > > I logged for which classes MCVersionReader >> > fileReaderServicesForFile:suffix: is invoked: > > In Pharo 4: > > MCVersionReader class > MCMczReader class > MCMcmReader class > MCMcdReader class > > In Pharo 5: > > MCVersionReader class > > > and it should be MCMczReader who adds those services for the MCZ files. > > Note: I tried in Pharo 4, and the list of file services didn't change > after removing MczInstaller. > > > > I sent this email because I was starting to update the change of this method: useNewChangeSetDuring: aBlock | changeHolder oldChanges newChanges | changeHolder := (ChangeSet respondsTo: #newChanges:) ifTrue: [ChangeSet] ifFalse: [Smalltalk]. oldChanges := (ChangeSet respondsTo: #current) ifTrue: [ChangeSet current] ifFalse: [Smalltalk changes]. newChanges := ChangeSet new name: (ChangeSet uniqueNameLike: self extractPackageName). changeHolder newChanges: newChanges. [aBlock value] ensure: [changeHolder newChanges: oldChanges]. to just assume that ChangeSet can respond to those messages, and then I realized that there were no references to the whole class... MartÃn

Sept. 5, 2015

Re: [Pharo-dev] remove MczInstaller?

by Martin Dias

Hi, I logged for which classes MCVersionReader >> fileReaderServicesForFile:suffix: is invoked: In Pharo 4: MCVersionReader class MCMczReader class MCMcmReader class MCMcdReader class In Pharo 5: MCVersionReader class and it should be MCMczReader who adds those services for the MCZ files. Note: I tried in Pharo 4, and the list of file services didn't change after removing MczInstaller. MartÃn On Sat, Sep 5, 2015 at 6:24 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > >> On 05 Sep 2015, at 15:54, stepharo <stepharo(a)free.fr> wrote: >> >> Are you sure that it is not used when we drag an MCZ on the desktop? > > No, at least I do not think so. > > itâs the installer that was added to Squeak before Monticello. The idea is that it can be used > to install .mzc files even when Monticello is not there. > > I was thinking of removing it in the past, but for a real modular system it might be a good idea to keep. > (to load monticello). > > Marcus > > >

Sept. 5, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50306 Home: https://github.com/pharo-project/pharo-core

Sept. 5, 2015

[pharo-project/pharo-core] 948180: 50306

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 9481809ccc4c7874fce2997bb202a34f35dc480f https://github.com/pharo-project/pharo-core/commit/9481809ccc4c7874fce2997b… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-05 (Sat, 05 Sep 2015) Changed paths: M Nautilus.package/Nautilus.class/instance/accessing/selectedPackage_.st M Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/registerSelectionPackage_.st A Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - after/testAfterReturn.st M Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - instead/testInsteadBlock.st M Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - instead/testInsteadReturn.st M Reflectivity.package/RFASTTranslator.class/instance/visitor-double dispatching/visitBlockNode_.st M Reflectivity.package/RFASTTranslator.class/instance/visitor-double dispatching/visitReturnNode_.st A Reflectivity.package/extension/RBReturnNode/instance/link_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50305.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50306.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50305.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50306.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot-Tests.package/SlotEnvironmentTest.class/instance/tests/testBasicEnvironment.st M Slot.package/PharoClassInstaller.class/instance/notifications/classAdded_inCategory_.st M System-Support.package/SystemDictionary.class/instance/accessing/organization.st Log Message: ----------- 50306 16485 Class panes not refreshed when changing package https://pharo.fogbugz.com/f/cases/16485 16479 Creating a class in an empty environment https://pharo.fogbugz.com/f/cases/16479 16481 #instead for Block https://pharo.fogbugz.com/f/cases/16481 http://files.pharo.org/image/50/50306.zip

Sept. 5, 2015

Re: [Pharo-dev] how do I get the git commit diff

by Dimitris Chloupis

the mail is not made for version control, github is. Why you would prefer a static way of doing things, from a very dynamic website ? When you commit to a github repo everyone that watches that repo , that is everyone that is either a contributor to that repo or a github user that has clicked the watch button will be alerted about everything related to that repo. The alerts appear in the front page of github.com when you log in. That includes commits, pull requests, new branches, issues, bugs, feature requests you name it. You could link that feed to your email so you get email alerts but personally I prefer keeping my email seperate from version controlling stuff. The advantages of github are too numerous to go in detail here, just read the github documentation. But to be put short, its easy to link towards other commits, you can comment commits , you can even comment specific lines of code (even using markdown ), and edit and commit on the fly using the website without opening pharo or git pulling to your local repo. Personally I would prefer to see a lot more pull requests because they are a very nice way to chain commits together and view them as one entity since they will concern the same matter. Pull requests also can be chained to issues and bug reports to mark the closed or open. What you list you refer to ? The link https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a…, refers to a single commit with a ton of renamed files. You mean how you can get the list with the diff of each file changed ? thats easy, click on the commit. If you go to the repo for example here https://github.com/pharo-project/pharo-core/commits/4.0 clicking .... will expand the commit message but you if click on the commit itself will send you to the list of the diff log for that commit. Do you mean something else ? On Sat, Sep 5, 2015 at 10:02 AM stepharo <stepharo(a)free.fr> wrote: > Hi > > I still think that I would like in the squeak mailing-list to see the > diff of every commit by mail. > How can we enable that? Marcus you complain that not enough people are > active but we do not engage people by showing > changes. oh yes they can - by reading git commit.... oh boy if we > believe that people systematically have a look at that then > we are pretty naive. > > Now do not tell me that I can browse git commit I know it and this is > not what I need. > I need SYSTEMATIC awareness of a change. I NEED everybody to be able to > have look before deleting a mail. > It is working in Squeak. I can in my mail look at the changes. > > Or of course nobody cares in Pharo about changes and we can get regression. > > Another question: how can I get the list of links to git with the commit > logs like > > https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a… > below? > How can I get the list? so that I can browse (I'm probably one of the > two few interested in fixing bugs after they got introduced). > > > Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core > Commit: 8a1f79b44b14f8eafaf6d91a8bab3c28e673114c > > https://github.com/pharo-project/pharo-core/commit/8a1f79b44b14f8eafaf6d91a… > > Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-04 > (Fri, 04 Sep 2015) > >

Sept. 5, 2015

Re: [Pharo-dev] rb highlighting is not up to the task yet

by Marcus Denker

Hello, Yes, I am aware of that. The idea was to evaluate how good the RB AST colouring is already and maybe find the energy to fix all remaining problemsâ¦ we fixed many but not all. I propose that we keep it for some month more and if we donât improve these problems go back to the old scheme for Pharo5. Then we can re-start to work on this in Pharo6. Marcus > On 05 Sep 2015, at 07:28, Tudor Girba <tudor(a)tudorgirba.com> wrote: > > Hi, > > Here is an example. > > Type this in a playground in a Pharo 5 image, and all statements before the parentheses become black: > | a b c d | > a := 42. > b := a + 1. > c := b + 1. > d := c + 1. > a . b . c . d } > > <Playground-50.png> > > Here is how this looks in a Pharo 4: > > <Playground-40.png> > > Cheers, > Doru > > > On Sat, Sep 5, 2015 at 12:16 AM, Nicolai Hess <nicolaihess(a)web.de <mailto:nicolaihess@web.de>> wrote: > This depends on the kind of error. For example, a missing open or closed parenthesis will most > likely mark the whole (following) code. > > But it should still highlight the preceding code. > Can you give an example. > > > nicolai > > > 2015-09-04 23:10 GMT+02:00 Tudor Girba <tudor(a)tudorgirba.com <mailto:tudor@tudorgirba.com>>: > Hi, > > I think it's nice that we are going towards consolidating our tools around RB. > > However, the highlighting logic is not quite enough because if I have an error anywhere in the code, the whole highlighting disappears. In contrast, Shout manages to limit the problem only to the surrounding code. > > Is anyone working on this part of the highlighting? > > Cheers, > Doru > > -- > www.tudorgirba.com <http://www.tudorgirba.com/> > > "Every thing has its own flow" > > > > > -- > www.tudorgirba.com <http://www.tudorgirba.com/> > > "Every thing has its own flow"

Sept. 5, 2015

Re: [Pharo-dev] remove MczInstaller?

by Marcus Denker

> On 05 Sep 2015, at 15:54, stepharo <stepharo(a)free.fr> wrote: > > Are you sure that it is not used when we drag an MCZ on the desktop? No, at least I do not think so. itâs the installer that was added to Squeak before Monticello. The idea is that it can be used to install .mzc files even when Monticello is not there. I was thinking of removing it in the past, but for a real modular system it might be a good idea to keep. (to load monticello). Marcus

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

I can give you a short explanation for the sake of more people knowing how Nautilus works. Regarding diffs and knowledge sharing, we should have a normal code review support with something like gerrit. Uko > On 05 Sep 2015, at 15:46, stepharo <stepharo(a)free.fr> wrote: > > As you wish. Thanks for your time. > > Now I will get really frustrated because I will not know simply what you did and I will have missed a good occasion > to learn something. This is what sending the diff in text simply give us. > > Stef > > > Le 5/9/15 14:09, Yuriy Tymchuk a Ã©crit : >> I found the issue. Fix almost ready. Should I reopen the case, or create a new one? >> >> Uko >> >> >> >>> On 05 Sep 2015, at 13:59, Stephan Eggermont <stephan(a)stack.nl> wrote: >>> >>> On 05-09-15 08:51, stepharo wrote: >>>> Hi >>>> >>>> I do not know if this is linked to recent changes but we cannot remove >>>> classes or move them to another package >>> I can move them to another package using drag-and-drop (issue 16488) >>> in 50305 >>> >>> >>> Stephan >>> >>> >> >> > >

Sept. 5, 2015