September 2015 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50324 Home: https://github.com/pharo-project/pharo-core

Sept. 15, 2015

[pharo-project/pharo-core] 8cc29c: 50324

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 8cc29ccb564ae0672697d623dbd9e929491d69bd https://github.com/pharo-project/pharo-core/commit/8cc29ccb564ae0672697d623… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-15 (Tue, 15 Sep 2015) Changed paths: M ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/symbolic versions/stable_.st A ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/versions/version1212_.st M ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/symbolic versions/stable_.st A ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/versions/version313Moose51_.st A ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/versions/version321_.st M GT-Spotter.package/GTSpotter.class/instance/accessing/pagerModel.st M GT-Spotter.package/GTSpotterCategoryTitleBrick.class/instance/accessing/stepModel_.st M GT-Spotter.package/GTSpotterContentsBrick.class/instance/accessing/spotterModel_.st M GT-Spotter.package/GTSpotterDropDownMorph.class/instance/accessing/spotterModel_.st M GT-Spotter.package/GTSpotterHeaderBrick.class/instance/accessing/spotterModel_.st M GT-Spotter.package/GTSpotterItemActionbarBrick.class/instance/accessing/stepModel_.st M GT-Spotter.package/GTSpotterItemBrick.class/instance/accessing/stepModel_.st M GT-Spotter.package/GTSpotterMorph.class/instance/accessing/breadcrumbBrick_.st M GT-Spotter.package/GTSpotterMorph.class/instance/accessing/spotterModel_.st M GT-Spotter.package/GTSpotterPreviewArrowBrick.class/instance/accessing/spotterModel_.st M GT-Spotter.package/GTSpotterPreviewArrowBrick.class/instance/event handling/onStepAdded.st M GT-Spotter.package/GTSpotterPreviewBrick.class/instance/accessing/spotterModel_.st M GT-Spotter.package/GTSpotterResultsBrick.class/instance/accessing/stepModel_.st M GT-Spotter.package/GTSpotterResultsBrick.class/instance/initialization/initialize.st M GT-Spotter.package/GTSpotterStepsBreadcrumb.class/instance/accessing/spotterModel_.st M Glamour-Morphic-Brick.package/GLMEditableLabelBrick.class/instance/label-brick-accessing/editBrick_.st M Glamour-Morphic-Pager.package/GLMPagerBarBrick.class/instance/bar-accessing/pagerModel_.st M Glamour-Morphic-Pager.package/GLMPagerBrick.class/instance/pager-accessing/pagerModel_.st M Glamour-Morphic-Pager.package/GLMPagerButtonsPaneBrick.class/instance/buttons-accessing/pagerModel_.st M Glamour-Morphic-Pager.package/GLMPagerButtonsPaneBrick.class/instance/buttons-adding/addButton_.st M Glamour-Morphic-Pager.package/GLMPagerScrollSlidingBrick.class/instance/slider-accessing/pagerModel_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50323.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50324.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50323.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50324.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50324 16561 Remove senders of subscribe:send:to: in GToolkit https://pharo.fogbugz.com/f/cases/16561 16501 Remove senders of subscribe:send:to: in Glamour https://pharo.fogbugz.com/f/cases/16501 http://files.pharo.org/image/50/50324.zip

Sept. 15, 2015

Re: [Pharo-dev] [Vm-dev] Re: issue with large file path on windows

by Nicolai Hess

2015-09-14 23:10 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > > Thanks Nicolai, that's great! I'll merge in your changes. Which files do > I need to look at? > I changed (removed my code, added Marcels) platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c platforms/win32/vm/sqWin32.h platforms/win32/vm/sqWin32Directory.c I added (should be the same as in squeak vm repository) platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c But my changes only about that code that already is in squeaks repository. If we want to merge some of the pharo-vm code into squeaks branch, we first need to wrap that code with some #ifdefs (For the win32 file/directory stuff, this would be code in platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c platforms/win32/vm/sqWin32.h platforms/win32/vm/sqWin32Directory.c and platforms/Cross/plugins/FilePlugin/FilePlugin.h) Maybe Estaban should look at this, and tell which path he would follow to merge those changes. > > On Sat, Sep 12, 2015 at 8:00 AM, Nicolai Hess <nicolaihess(a)web.de> wrote: > >> >> >> >> 2015-09-10 21:31 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com>: >> >>> >>> Hi Nicolai, >>> >>> I'm a bit concerned that this is creating drift with the "official" >>> Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog. >>> Long filename support for win32 was recently added by Marcel Taumel in May >>> of this year. Are you tracking that? How can we keep the sources >>> harmonized? >>> >> >> Ok, I removed all of my code again and merged with sqWin32Directory.c and >> sqWin32FilePrims.c from the official cog source. >> I left only pharos additions for the fileattributes (posixpermissions) >> this should make it easier to merge which the >> squeak vm main branch (wrapped with pharo vm ifdefs). >> >> github branch: >> https://github.com/nicolaihess/pharo-vm/tree/harmonize_win_file_plugin >> I'll create a push request. >> >> >> nicolai >> >> >> >>> >>> On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <nicolaihess(a)web.de> >>> wrote: >>> >>>> For those who had problems with pharo on windows and github based >>>> repositories, >>>> I built a windows vm with support for long paths: >>>> >>>> >>>> https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=shari… >>>> >>>> >>>> For browsing directories with large paths (FileList or Inspect), >>>> you may need one additional change in the image (But I am not really >>>> sure about that) : >>>> >>>> DiskStore>>initialize >>>> super initialize. >>>> maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 >>>> ]. >>>> >>>> >>>> please test and give feedback. >>>> >>>> This wasn't as easy as I thought, and I had to make some more changes >>>> for the file permissions (the stat-functions don't work for files with >>>> long paths). >>>> Please test other file/folder operations. >>>> >>>> >>>> nicolai >>>> >>>> >>>> >>>> >>> >>> >>> -- >>> _,,,^..^,,,_ >>> best, Eliot >>> >>> >> >> > > > -- > _,,,^..^,,,_ > best, Eliot > >

Sept. 15, 2015

Nautilus package search "broken"

by Nicolai Hess

Needs review : https://pharo.fogbugz.com/f/cases/16523 I just provided a possible solution, but I don't really use the package search. Some feedback is needed. nicolai

Sept. 15, 2015

Re: [Pharo-dev] Array literal changes of a compiled method

by Eliot Miranda

Hi Juraj, On Mon, Sep 14, 2015 at 4:56 PM, Juraj Kubelka <juraj.kubelka(a)gmail.com> wrote: > Hi, > > I have a test case like that: > -=-=- > testIncrementBy > prefix := MyObject new numbers: #(1 10); yourself. > prefix incrementBy: 10. > self assert: prefix numbers equals: #(1 20). > -=-=- > > and the byte code starts like that: > -=-=- > 57 <40> pushLit: MyObject > 58 <CC> send: new > 59 <88> dup > 60 <21> pushConstant: #(1 10) > -=-=- > > If I run the test case, it is green, but the byte code changes into: > -=-=- > 57 <40> pushLit: MyObject > 58 <CC> send: new > 59 <88> dup > 60 <21> pushConstant: #(1 *20*) > -=-=- > > The #incrementBy: method looks like: > -=-=- > incrementBy: aNumber > numbers at: 2 put: (numbers at: 2) + aNumber > -=-=- > > Is it correct that it also changes the method byte code? > No, ut this does happen. hat I suspect you're seeing is the fact that in the Pharo and Squeak implementations, literals are not immutable. So if you were to assign to a literal Array in a method's literals that assignment would not cause an error, and worse, would not be visible because the mehtods source code would be unchanged. We shall have a proper fix for this in a future release where we will support fully immutable literals. For now the correct respponse shoudl be to find out where in your code the literal is assigned to and to not do that. Of course adding a copy is also fine. > I can put "#(1 10) copyâ into the test case. > I am just curious if it is a feature or bug. > It's a bug, but an ancient one. Some Smalltalks, such as VisualAge and VisualWorks have fixed this by introducing support for immutable objects, but the {haro/Squeak Vms have yet to provide this. I expect to implement it in Spur some time next year. > > Tested in Pharo4.0, Latest update: #40613. > > Cheers, > Juraj > -- _,,,^..^,,,_ best, Eliot

Sept. 15, 2015

Array literal changes of a compiled method

by Juraj Kubelka

Hi, I have a test case like that: -=-=- testIncrementBy prefix := MyObject new numbers: #(1 10); yourself. prefix incrementBy: 10. self assert: prefix numbers equals: #(1 20). -=-=- and the byte code starts like that: -=-=- 57 <40> pushLit: MyObject 58 <CC> send: new 59 <88> dup 60 <21> pushConstant: #(1 10) -=-=- If I run the test case, it is green, but the byte code changes into: -=-=- 57 <40> pushLit: MyObject 58 <CC> send: new 59 <88> dup 60 <21> pushConstant: #(1 20) -=-=- The #incrementBy: method looks like: -=-=- incrementBy: aNumber numbers at: 2 put: (numbers at: 2) + aNumber -=-=- Is it correct that it also changes the method byte code? I can put "#(1 10) copyâ into the test case. I am just curious if it is a feature or bug. Tested in Pharo4.0, Latest update: #40613. Cheers, Juraj

Sept. 14, 2015

Re: [Pharo-dev] Metacello load script won't update the configuration

by Yuriy Tymchuk

Yes, that is exactly what I need! Thank you! > On 14 Sep 2015, at 23:10, Dale Henrichs <dale.henrichs(a)gemtalksystems.com> wrote: > > Uko, > > The `get` command is used to load a fresh copy of the ConfigurationOf or BaselineOf so the following should do the trick: > > Metacello new > smalltalkhubUser: 'Pharo' > project: 'MetaRepoForPharo40'; > configuration: 'QualityAssistant'; > get; > load > > > I make the loading of the BaselineOf and ConfigurationOf explicit so that the developer can control when and if they want a new copy of the BaselineOf or ConfigurationOf. > > For github urls like github://project/user/project, the `get` command causes the system to invalidate the cache directory so that on the next load, the github cache for the project is freshly downloaded so that you get the latest version of the BaselineOf ... > > Dale > > On 09/14/2015 01:49 PM, Yuriy Tymchuk wrote: >> Hi, >> >> when you use a script like >> >> Metacello new >> smalltalkhubUser: 'Pharo' >> project: 'MetaRepoForPharo40'; >> configuration: 'QualityAssistant'; >> load >> >> and you already have the configuration package loaded, the script is not updating the configuration itself. As the result you cannot update to a newer version. Is there a special expression that has to be used to update the configuration package? If not, maybe it does make sense to update the configuration before loading it? >> >> Cheers! >> Uko >

Sept. 14, 2015

Re: [Pharo-dev] [Vm-dev] Re: issue with large file path on windows

by Eliot Miranda

Thanks Nicolai, that's great! I'll merge in your changes. Which files do I need to look at? On Sat, Sep 12, 2015 at 8:00 AM, Nicolai Hess <nicolaihess(a)web.de> wrote: > > > > 2015-09-10 21:31 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > >> >> Hi Nicolai, >> >> I'm a bit concerned that this is creating drift with the "official" >> Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog. >> Long filename support for win32 was recently added by Marcel Taumel in May >> of this year. Are you tracking that? How can we keep the sources >> harmonized? >> > > Ok, I removed all of my code again and merged with sqWin32Directory.c and > sqWin32FilePrims.c from the official cog source. > I left only pharos additions for the fileattributes (posixpermissions) > this should make it easier to merge which the > squeak vm main branch (wrapped with pharo vm ifdefs). > > github branch: > https://github.com/nicolaihess/pharo-vm/tree/harmonize_win_file_plugin > I'll create a push request. > > > nicolai > > > >> >> On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <nicolaihess(a)web.de> wrote: >> >>> For those who had problems with pharo on windows and github based >>> repositories, >>> I built a windows vm with support for long paths: >>> >>> >>> https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=shari… >>> >>> >>> For browsing directories with large paths (FileList or Inspect), >>> you may need one additional change in the image (But I am not really >>> sure about that) : >>> >>> DiskStore>>initialize >>> super initialize. >>> maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ]. >>> >>> >>> please test and give feedback. >>> >>> This wasn't as easy as I thought, and I had to make some more changes >>> for the file permissions (the stat-functions don't work for files with >>> long paths). >>> Please test other file/folder operations. >>> >>> >>> nicolai >>> >>> >>> >>> >> >> >> -- >> _,,,^..^,,,_ >> best, Eliot >> >> > > -- _,,,^..^,,,_ best, Eliot

Sept. 14, 2015

Re: [Pharo-dev] Metacello load script won't update the configuration

by Dale Henrichs

Uko, The `get` command is used to load a fresh copy of the ConfigurationOf or BaselineOf so the following should do the trick: Metacello new smalltalkhubUser: 'Pharo' project: 'MetaRepoForPharo40'; configuration: 'QualityAssistant'; get; load I make the loading of the BaselineOf and ConfigurationOf explicit so that the developer can control when and if they want a new copy of the BaselineOf or ConfigurationOf. For github urls like github://project/user/project, the `get` command causes the system to invalidate the cache directory so that on the next load, the github cache for the project is freshly downloaded so that you get the latest version of the BaselineOf ... Dale On 09/14/2015 01:49 PM, Yuriy Tymchuk wrote: > Hi, > > when you use a script like > > Metacello new > smalltalkhubUser: 'Pharo' > project: 'MetaRepoForPharo40'; > configuration: 'QualityAssistant'; > load > > and you already have the configuration package loaded, the script is > not updating the configuration itself. As the result you cannot update > to a newer version. Is there a special expression that has to be used > to update the configuration package? If not, maybe it does make sense > to update the configuration before loading it? > > Cheers! > Uko

Sept. 14, 2015

Metacello load script won't update the configuration

by Yuriy Tymchuk

Hi, when you use a script like Metacello new smalltalkhubUser: 'Pharo' project: 'MetaRepoForPharo40'; configuration: 'QualityAssistant'; load and you already have the configuration package loaded, the script is not updating the configuration itself. As the result you cannot update to a newer version. Is there a special expression that has to be used to update the configuration package? If not, maybe it does make sense to update the configuration before loading it? Cheers! Uko

Sept. 14, 2015