September 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] SyntaxError: parentheses; cascades and yourself (Opal vs. old compilers parser)

by Thierry Goubier

2015-09-17 9:10 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: > > > 2015-09-16 15:14 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: > >> Argh, sent too early: >> >> self new color: Color red; yourself >> >> est bien une cascade, non? >> > > Yes, but in > > (self new color: Color red); yourself > the expression in parenthesis looks like "this evalulates first, to > 'anObject' ", so we send " ; yourself", > a cascaded messages with only one message to "anObject". > Yes, agreed of course. In a way, it looks like an error correction type of thing: the parser knows the parenthesis shouldn't be there or the ; shouldn't be there, so it chooses one interpretation out of the two: here it is the parenthesis are unnecessary. By the way, John found another issue with a fix you did in RBParser (RBPatternParser>>parseUnaryMessage) which fail some refactoring expressions. Can you have a look? Thierry > > > > > >> >> >> >> Thierry >> >> >> 2015-09-16 15:12 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: >> >>> >>> >>> 2015-09-16 15:05 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: >>> >>>> OK, I think Sven is right and a cascade needs at least one message send >>>> >>>> "self ; yourself" >>>> >>>> doesn't work too (both parser don't accept this). >>>> >>> >>> But >>> >>> >>> >>>> >>>> There are currently two methods in Pharo 5.0 with this >>>> syntax: >>>> >>>> DAPackageAnalyzerWindow class>>#onPackagesNamed: >>>> DAPackageCycleDetectionTreeModel class>>#onPackagesNamed: >>>> >>>> @Yuri, can you change that. >>>> >>>> >>>> And I think we should fix RBParser. >>>> >>>> >>>> 2015-09-16 11:30 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: >>>> >>>>> Nicolai, >>>>> >>>>> can you try with the RBParser directly? I believe Opal uses the >>>>> RBParser. >>>>> >>>>> RBParser parseMethod: 'createRedMorph >>>>> ^ (self new color:Color red); yourself' >>>>> >>>>> Oh, RBParser sees it as: >>>>> >>>>> self new >>>>> color: Color red; >>>>> yourself >>>>> >>>>> :) >>>>> >>>>> Thierry >>>>> >>>>> >>>>> 2015-09-16 10:56 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: >>>>> >>>>>> The following method compiles with Opal: >>>>>> >>>>>> createRedMorph >>>>>> ^ (self new color:Color red); yourself >>>>>> >>>>>> but gives a syntax error with the old compilers parser >>>>>> >>>>>> createRedMorph >>>>>> ^ (self new color:Color red)End of block expected -> ; yourself >>>>>> >>>>>> >>>>>> removing the parenthesis of course works for both. >>>>>> Who is right ? >>>>>> >>>>>> >>>>>> (for those who understand the ParseTreeSearcher syntax, how would >>>>>> a search expression look, for finding code like: >>>>>> >>>>>> "(some expression);yourself" >>>>>> >>>>>> >>>>>> nicolai >>>>>> >>>>>> >>>>> >>>> >>> >> >

Sept. 17, 2015

Re: [Pharo-dev] SyntaxError: parentheses; cascades and yourself (Opal vs. old compilers parser)

by Nicolai Hess

2015-09-16 15:14 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: > Argh, sent too early: > > self new color: Color red; yourself > > est bien une cascade, non? > Yes, but in (self new color: Color red); yourself the expression in parenthesis looks like "this evalulates first, to 'anObject' ", so we send " ; yourself", a cascaded messages with only one message to "anObject". > > > > Thierry > > > 2015-09-16 15:12 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: > >> >> >> 2015-09-16 15:05 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: >> >>> OK, I think Sven is right and a cascade needs at least one message send >>> >>> "self ; yourself" >>> >>> doesn't work too (both parser don't accept this). >>> >> >> But >> >> >> >>> >>> There are currently two methods in Pharo 5.0 with this >>> syntax: >>> >>> DAPackageAnalyzerWindow class>>#onPackagesNamed: >>> DAPackageCycleDetectionTreeModel class>>#onPackagesNamed: >>> >>> @Yuri, can you change that. >>> >>> >>> And I think we should fix RBParser. >>> >>> >>> 2015-09-16 11:30 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: >>> >>>> Nicolai, >>>> >>>> can you try with the RBParser directly? I believe Opal uses the >>>> RBParser. >>>> >>>> RBParser parseMethod: 'createRedMorph >>>> ^ (self new color:Color red); yourself' >>>> >>>> Oh, RBParser sees it as: >>>> >>>> self new >>>> color: Color red; >>>> yourself >>>> >>>> :) >>>> >>>> Thierry >>>> >>>> >>>> 2015-09-16 10:56 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: >>>> >>>>> The following method compiles with Opal: >>>>> >>>>> createRedMorph >>>>> ^ (self new color:Color red); yourself >>>>> >>>>> but gives a syntax error with the old compilers parser >>>>> >>>>> createRedMorph >>>>> ^ (self new color:Color red)End of block expected -> ; yourself >>>>> >>>>> >>>>> removing the parenthesis of course works for both. >>>>> Who is right ? >>>>> >>>>> >>>>> (for those who understand the ParseTreeSearcher syntax, how would >>>>> a search expression look, for finding code like: >>>>> >>>>> "(some expression);yourself" >>>>> >>>>> >>>>> nicolai >>>>> >>>>> >>>> >>> >> >

Sept. 17, 2015

Re: [Pharo-dev] Remove rule "References an abstract class"

by Yuriy Tymchuk

Hi. First of all: thank you for the feedback Damien! It makes sense, the rule also has higher amount of negative feedback. I will remove it from QA, let it stay in the image, it actually can be useful. Uko > On 17 Sep 2015, at 06:49, Damien Cassou <damien.cassou(a)inria.fr> wrote: > > This lint rule pops up all the times and my code is always ok. I > typically have to reference an abstract class when: > > - the abstract class takes care of choosing the concrete class to > instantiate > > - the abstract class takes care of some shared variable for its > subclasses (e.g., a cache or an shared external object) > > I propose to remove this rule which has never been useful for me. > > -- > Damien Cassou > http://damiencassou.seasidehosting.st > > "Success is the ability to go from one failure to another without > losing enthusiasm." --Winston Churchill >

Sept. 17, 2015

Re: [Pharo-dev] SyntaxError: parentheses; cascades and yourself (Opal vs. old compilers parser)

by Nicolai Hess

2015-09-17 1:18 GMT+02:00 John Brant <brant(a)refactoryworkers.com>: > On 9/16/2015 10:34 AM, Ben Coman wrote: > >> On Wed, Sep 16, 2015 at 4:56 PM, Nicolai Hess <nicolaihess(a)web.de> wrote: >> >>> The following method compiles with Opal: >>> >>> createRedMorph >>> ^ (self new color:Color red); yourself >>> >>> but gives a syntax error with the old compilers parser >>> >>> createRedMorph >>> ^ (self new color:Color red)End of block expected -> ; yourself >>> >>> >>> removing the parenthesis of course works for both. >>> Who is right ? >>> >> >> What is the result in other dialects? >> > > Dolphin lets you do "self ; yourself" as well as the example above. > However, both VW & VA don't allow it. > Thanks for the info. > > This is a potential incompatibility for little gain. >> Anyway I would guess Opal is wrong. >> > > I don't remember if we allowed this on purpose to be compatible with other > Smalltalks or if it was a bug we missed. Anyway, a simple fix is to add " > and: [node parentheses isEmpty]" to the RBParser>>parseCascadeMessage > method: > > parseCascadeMessage > | node receiver messages semicolons | > node := self parseKeywordMessage. > (currentToken isSpecial > and: [currentToken value = $; and: [node isMessage and: > [node parentheses isEmpty]]]) ifFalse: [^node]. > ... > > > > John Brant > > >

Sept. 17, 2015

[Reflectivity] Support for primitive methods

by Marcus Denker

Hi, One thing I added over the last weeks: support to put links on primitives. 1) fail code. You can put links into the smalltalk code that is executed in case of primitive failure. For all primitive methods, we generate code immediately when setting the link, we do not wait till the method is called. (this is in there since a while). 2) links on the method node itself. What we do here is to wrap the original method. It is interesting how simple this was to do: 1) when generating code for a ReflectiveMethod, check if it is a primitive: compileAndInstallCompiledMethod "we install the old one as the compiler might need itâ self installCompiledMethod. compiledMethod isRealPrimitive ifTrue: [ self generatePrimitiveWrapper ]. self recompileAST. self installCompiledMethod. 2) compile a wrapper by building an AST by hand: generatePrimitiveWrapper | wrappedMethod send wrapperMethod | ast compilationContext semanticAnalyzerClass: RFSemanticAnalyzer; astTranslatorClass: RFASTTranslator. ast doSemanticAnalysis. "force semantic analysis" wrappedMethod := ast generate: compiledMethod trailer. send := RBMessageNode receiver: (RBLiteralNode value: wrappedMethod) selector: #valueWithReceiver:arguments: arguments: {RBVariableNode named: #self . RBArrayNode statements: ast variableNodes }. wrapperMethod := RBMethodNode selector: ast selector arguments: ast variableNodes body: (RBReturnNode value: send) asSequenceNode. wrapperMethod methodClass: ast methodClass. wrapperMethod propertyAt: #wrappedPrimitive put: true. ast hasMetalink ifTrue: [wrapperMethod propertyAt: #links put: (ast propertyAt: #links)]. ast := wrapperMethod. This means we copy over the links to the new wrapper. the #wrappedPrimitive marker is there so that, when we destroy the twin when the last link is removed, we remember to unwrap. 3) the compiler plugin that takes the links into account ignores links on MethodNode if itâs a primitive. 4) when getting rid of the Twin (because we remove the last link), we detect if it was a primitive and unwrap: destroyTwin (ast hasProperty: #wrappedPrimitive) ifTrue: [ ast := compiledMethod parseTree]. self recompileAST. self installCompiledMethod. compiledMethod reflectiveMethod: nil. SystemAnnouncer uniqueInstance unsubscribe: self e.g. testBeforeMethodPrimitive | methodNode link | methodNode := (ReflectivityExamples >> #examplePrimitiveMethod) ast. link := MetaLink new metaObject: self; selector: #tagExec. self assert: (ReflectivityExamples>>#examplePrimitiveMethod) isRealPrimitive. methodNode link: link. self assert: methodNode hasMetalink. self assert: (ReflectivityExamples >> #examplePrimitiveMethod) class = CompiledMethod. self assert: tag isNil. self assert: ReflectivityExamples new examplePrimitiveMethod class = ByteString. self deny: (ReflectivityExamples>>#examplePrimitiveMethod) isRealPrimitive. self assert: tag = #yes. self assert: (ReflectivityExamples >> #examplePrimitiveMethod) class = CompiledMethod. link uninstall. self assert: (ReflectivityExamples>>#examplePrimitiveMethod) isRealPrimitive. ReflectivityExamples recompile: #examplePrimitiveMethod Marcus

Sept. 17, 2015

Remove rule "References an abstract class"

by Damien Cassou

This lint rule pops up all the times and my code is always ok. I typically have to reference an abstract class when: - the abstract class takes care of choosing the concrete class to instantiate - the abstract class takes care of some shared variable for its subclasses (e.g., a cache or an shared external object) I propose to remove this rule which has never been useful for me. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill

Sept. 17, 2015

Re: [Pharo-dev] SyntaxError: parentheses; cascades and yourself (Opal vs. old compilers parser)

by John Brant

On 9/16/2015 10:34 AM, Ben Coman wrote: > On Wed, Sep 16, 2015 at 4:56 PM, Nicolai Hess <nicolaihess(a)web.de> wrote: >> The following method compiles with Opal: >> >> createRedMorph >> ^ (self new color:Color red); yourself >> >> but gives a syntax error with the old compilers parser >> >> createRedMorph >> ^ (self new color:Color red)End of block expected -> ; yourself >> >> >> removing the parenthesis of course works for both. >> Who is right ? > > What is the result in other dialects? Dolphin lets you do "self ; yourself" as well as the example above. However, both VW & VA don't allow it. > This is a potential incompatibility for little gain. > Anyway I would guess Opal is wrong. I don't remember if we allowed this on purpose to be compatible with other Smalltalks or if it was a bug we missed. Anyway, a simple fix is to add " and: [node parentheses isEmpty]" to the RBParser>>parseCascadeMessage method: parseCascadeMessage | node receiver messages semicolons | node := self parseKeywordMessage. (currentToken isSpecial and: [currentToken value = $; and: [node isMessage and: [node parentheses isEmpty]]]) ifFalse: [^node]. ... John Brant

Sept. 16, 2015

Contribution scheme confusing ...

by Torsten Bergmann

We are in a transition to use more and more ConfigurationOfxxxx to manage packages included in Pharo 5. But neither the new help topic "How to contribute to Pharo base code" nor the link it points to http://pharo.org/contribute-propose-fix reflects this. Also - how do I know which code has to be managed by a Configuration and where is the original repo if so. How will I submit a fix that includes code to change both: somthing that is managed vai config and something that is a change on a regular slice managed package... Also: I did a simple fix on NautilusGroupAutoBuilder package - there is a ConfigurationOfNautilusGroupAutoBuilder. But is it managed internally or externally now? Thanks T.

Sept. 16, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50328 Home: https://github.com/pharo-project/pharo-core

Sept. 16, 2015

[pharo-project/pharo-core] 3a2205: 50328

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 3a220566b868affc78b29a8fc84cdbb3e8c6af42 https://github.com/pharo-project/pharo-core/commit/3a220566b868affc78b29a8f… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-16 (Wed, 16 Sep 2015) Changed paths: M Collections-Tests.package/ArrayTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/ArrayTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/BagTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/BagTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/DictionaryTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/DictionaryTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/FloatArrayTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/FloatArrayTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/IntervalTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/IntervalTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/LinkedListTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/LinkedListTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/OrderedCollectionTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/OrderedCollectionTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/SetTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/SetTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/SortedCollectionTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/SortedCollectionTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/StringTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/StringTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/SymbolTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/SymbolTest.class/instance/tests - comma and delimiter/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/TAsStringCommaAndDelimiterSequenceableTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/TAsStringCommaAndDelimiterSequenceableTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterLastEmpty.st M Collections-Tests.package/TAsStringCommaAndDelimiterTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterEmpty.st M Collections-Tests.package/TAsStringCommaAndDelimiterTest.class/instance/tests - as string comma delimiter sequenceable/testAsStringOnDelimiterLastEmpty.st M Kernel-Tests.package/DateAndTimeDosEpochTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/DateAndTimeEpochTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/DateAndTimeLeapTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/DateAndTimeUnixEpochTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/DateTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/DateTest.class/instance/tests/testPrintOnFormat.st M Kernel-Tests.package/DateTest.class/instance/tests/testStoreOn.st M Kernel-Tests.package/DurationTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/IntegerTest.class/instance/tests - printing/testPrintOnBaseShowRadix.st M Kernel-Tests.package/StopwatchTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/TimeTest.class/instance/tests printing/testPrint24On.st M Kernel-Tests.package/TimeTest.class/instance/tests printing/testPrint24OnWithPM.st M Kernel-Tests.package/TimeTest.class/instance/tests printing/testPrint24OnWithoutSeconds.st M Kernel-Tests.package/TimeTest.class/instance/tests printing/testPrintOn.st M Kernel-Tests.package/TimeTest.class/instance/tests/testStoreOn.st M Kernel-Tests.package/TimespanTest.class/instance/tests/testPrintOn.st M Kernel-Tests.package/YearMonthWeekTest.class/instance/tests/testMonthPrintOn.st M Kernel-Tests.package/YearMonthWeekTest.class/instance/tests/testYearPrintOn.st M Morphic-Widgets-Basic.package/SimpleButtonMorph.class/instance/menu/setArguments.st M Refactoring-Core.package/RBClass.class/instance/accessing/definitionString.st M Refactoring-Core.package/RBExtractMethodRefactoring.class/instance/transforming/nameNewMethod_.st M Refactoring-Core.package/RBRemoveParameterRefactoring.class/instance/private/computeNewSelector.st A Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - instead/testInsteadSequence.st A Reflectivity-Tests.package/ReflectivityLinkTest.class/instance/tests - reflective disable/testLinkOneShot.st M Reflectivity.package/HookGenerator.class/instance/private/hookFor_.st M Reflectivity.package/RFASTTranslatorForEffect.class/instance/visitor-double dispatching/visitSequenceNode_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50327.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50328.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50327.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50328.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M StartupPreferences.package/StartupPreferencesLoader.class/instance/private/buildStreamFor_.st M System-Support.package/Session.class/definition.st A System-Support.package/Session.class/instance/accessing/sid.st M System-Support.package/Session.class/instance/initialize/initialize.st M Tool-Finder.package/FinderUI.class/instance/text areas behavior/buildDescriptionOf_.st M UIManager.package/UIManager.class/class/utils/createPageTestWorkspace.st Log Message: ----------- 50328 16581 one-shot links https://pharo.fogbugz.com/f/cases/16581 16582 Reflectivity: #instead for sequence nodes https://pharo.fogbugz.com/f/cases/16582 15260 WriteStream on new string https://pharo.fogbugz.com/f/cases/15260 16578 Add an id to Session https://pharo.fogbugz.com/f/cases/16578 http://files.pharo.org/image/50/50328.zip

Sept. 16, 2015