September 2015 - Pharo-dev - lists.pharo.org

- 250 * 1.5 is not the same as 250 * 1.5

by stepharo

Hi guys I think that this is quite bad that - 250 * 1.5 returns -2.25 while -250 * 1.5 return 375 stef

Sept. 23, 2015

Re: [Pharo-dev] ConfigurationOfRoassal2 broken

by Alexandre Bergel

> Can anyone explain ConfigurationOfRoassal2? Not me :-) > Where does that work? I have just added: development: spec <symbolicVersion: #'development'> spec for: #'common' version: '1.4-baseline'. spec for: #'pharo4.x' version: '1.5-baseline'. spec for: #'pharo5.x' version: '1.6-baselineâ. stable: spec <symbolicVersion: #'stable'> spec for: #'common' version: '1.11'. spec for: #'pharo4.x' version: '1.13'. spec for: #'pharo3.x' version: '1.6'. spec for: #'pharo5.x' version: '1.16'. I have no idea whether this is sufficient or not. Alexandre > > stable: spec > <symbolicVersion: #'stable'> > > spec for: #'common' version: '1.11'. > spec for: #'pharo4.x' version: '1.13'. > spec for: #'pharo3.x' version: '1.6'. > > development: spec > <symbolicVersion: #'development'> > > spec for: #'common' version: '1.4-baseline'. > spec for: #'pharo4.x' version: '1.5-baseline'. > > > > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Sept. 22, 2015

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Thierry Goubier

Le 22/09/2015 19:14, Jan Vrany a Ã©crit : > >> RBTransformationRule (you need to activate that verificationBlock >> when >> you create your rewriter). > > Yes, and this is the tricky bit :-) Because there's no guarantee that > this block is functional. For example, it may access context ivar > which, by the time UI is retrieving intervals is already nilled out > or even filled again with some other unrelated context if you're > reusing rule instances (but if not, you may run into performance > problems...) I'm not sure I see the issue. That block is evaluated just when you match, before the rewrite. So, at that point, everything is valid. You're right, the node may not be valid anymore after the rewrite if I record the node. But if I record a copy of that source and the index (you ask complete source to that node and startPosition / stopPosition) then you're set for highlighting. Thierry

Sept. 22, 2015

Re: [Pharo-dev] [Reflectivity] Slides ESUG talk

by Marcus Denker

> On 22 Sep 2015, at 17:23, roberto.minelli(a)usi.ch wrote: > > Hi Marcus, > > I am finally playing with Reflectivity. In the first place, thanks a lot for this contribution! > > I am wondering what is the âcorrectâ way to âremoveâ a MetaLink. Is it enough to call #uninstall on the MetaLink Yes! > or should I also recompile the class/method where the link is installed? If you recompile, you remove all links. (even the ones others installed). In the tests I do that often to be sure everything is clean. > I spotted a problem with the control #after. If you try to pass #arguments to the meta, an error is returned. To reproduce: http://ws.stfx.eu/ONC4K9KQRTNQ > > Is this behavior somewhat desired, or is a bug? > Bug, I will fix it... > Dictionary>>errorKeyNotFound: > [ self errorKeyNotFound: key ] in Dictionary>>at: in Block: [ self errorKeyNotFound: key ] > Dictionary>>at:ifAbsent: > Dictionary>>at: > IRPushClosureCopy>>indexForVarNamed: > IRTranslatorV2>>visitPushTemp: > IRPushTemp>>accept: > IRTranslatorV2(IRVisitor)>>visitNode: > IRTranslatorV2>>visitInstruction: > [ :instr | self visitInstruction: instr ] in IRTranslatorV2(IRVisitor)>>visitSequence: in Block: [ :instr | self visitInstruction: instr ] > OrderedCollection>>do: > IRSequence>>do: > IRTranslatorV2(IRVisitor)>>visitSequence: > IRTranslatorV2>>visitSequence: > IRSequence>>accept: > IRTranslatorV2(IRVisitor)>>visitNode: > [ :each | self visitNode: each ] in IRTranslatorV2(IRVisitor)>>visitNodes: in Block: [ :each | self visitNode: each ] > SortedCollection(OrderedCollection)>>do: > IRTranslatorV2(IRVisitor)>>visitNodes: > IRTranslatorV2>>visitSequences: > IRTranslatorV2>>visitMethod: > IRMethod>>accept: > IRTranslatorV2(IRVisitor)>>visitNode: > IRMethod>>generate: > IRMethod>>compiledMethodWith: > RBMethodNode>>generate: > ReflectiveMethod>>recompileAST > ReflectiveMethod>>compileAndInstallCompiledMethod > ReflectiveMethod>>run:with:in: > UndefinedObject>>DoIt > > Cheers, > Roberto > >> On 04 Sep 2015, at 14:16, Marcus Denker <marcus.denker(a)inria.fr> wrote: >> >> Hi Roberto, >> >> Very good! I am now working on #after for methods+sequence. *And* primitives... this should all be committed early next week. >> >> After that, I need to actually use it to find remaining problems, so this is very good that you will start now. >> >> Marcus >> >> On Thu, Sep 3, 2015 at 2:50 PM, roberto.minelli(a)usi.ch <roberto.minelli(a)usi.ch> wrote: >> Very good talk Marcus. >> >> In the next weeks I will finally have some time to try Reflectivity out! >> >> Thanks a lot for all your effort! >> >> Cheers, >> Roberto >> >>> On 31 Jul 2015, at 13:23, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>> >>> >>>> On 15 Jul 2015, at 10:15, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>> >>>> Hi, >>>> >>>> the slides for my ESUG talk are online: >>>> >>>> http://www.slideshare.net/MarcusDenker/reflection-in-pharo5 >>>> >>>> >>> >>> Video is online, too: >>> >>> https://www.youtube.com/watch?v=Ik539CtjtTI >>> >>> >>> >>> Marcus >>> >> >> >> >> >> -- >> -- >> Marcus Denker -- denker(a)acm.org >> http://www.marcusdenker.de >

Sept. 22, 2015

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Jan Vrany

> RBTransformationRule (you need to activate that verificationBlock > when > you create your rewriter). Yes, and this is the tricky bit :-) Because there's no guarantee that this block is functional. For example, it may access context ivar which, by the time UI is retrieving intervals is already nilled out or even filled again with some other unrelated context if you're reusing rule instances (but if not, you may run into performance problems...)

Sept. 22, 2015

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Thierry Goubier

Le 22/09/2015 17:56, Yuriy Tymchuk a Ã©crit : > Hi everyone, > > I need someone who knows how RBParseTreeRewriter & co. work. May of > quality rules are implemented as rewrite rules which is cool. But > they donât report the interval in source code which can be > highlighted to help with understanding of the issue. > > Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it > possible to obtain the matched string there? Because in that case we > can get highlighting working which will be very useful. Silly me. It's so simple: | rw | rw := RBParseTreeRewriter new. rw replace: ' `#a `{:aNode | aNode value isCharacter}' with: '`#a newMessage' when: [:n | n logCr. false]. Use the when: block argument to trace all the matched nodes. Once you have the nodes, you can highlight them. Thierry > Cheers! Uko >

Sept. 22, 2015

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Thierry Goubier

Le 22/09/2015 18:26, Jan Vrany a Ã©crit : > Yeah, I remember this is a pain. When I did years ago what > you're doing now with QA, I ended up practicing black magic, > sacrificing chickens and other things you'd better not to know. > > IIRC, the trick is to turn rewrite rules in ParseTreeEnvironment > into search rules and then run the searches. Now this is tricky > as these rules quite often refers to blocks, which then refers to outer > contexts and you need these blocks do something different now (report > nodes rather then transform stuff). This is the main problem. I think what you can simply do is trap the place where the rewrites are done, in RBStringReplaceRule. There is a verificationBlock instance variable which sees every match node, as far as I can read through the code, and this would change a bit the interface to call the rewrites in RBTransformationRule (you need to activate that verificationBlock when you create your rewriter). As far as I can see, if verificationBlock print its argument to the Transcript and returns false, your rewriter becomes a searcher which print every match to the transcript. Thierry > If you have the guts, you may find the code here: > > https://bitbucket.org/janvrany/stx-goodies-smallsense > and here: > http://swing.fit.cvut.cz/hg/stx.goodies.refactoryBrowser/ > > (alternatively, downlaod https://swing.fit.cvut.cz/projects/stx-jv/ > and browse the code in Smalltalk browser). > > You may want to trace the code starting from > ParseTreeEnvironment>>selectionIntervalsForSource:tree:do: > RBParseTreeRule>>copyMatchDo: and implementors is also > worth mentioning. > > After doing this, I concluded that SmallLint as it's now is not > well designed for this task and it would need a significant > refactoring. However, as always, I was never given time to do it. > > HTH, Jan > > > On Tue, 2015-09-22 at 17:56 +0200, Yuriy Tymchuk wrote: >> Hi everyone, >> >> I need someone who knows how RBParseTreeRewriter & co. work. May of >> quality rules are implemented as rewrite rules which is cool. But >> they donât report the interval in source code which can be >> highlighted to help with understanding of the issue. >> >> Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it >> possible to obtain the matched string there? Because in that case we >> can get highlighting working which will be very useful. >> >> Cheers! >> Uko >> > >

Sept. 22, 2015

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Jan Vrany

Yeah, I remember this is a pain. When I did years ago what you're doing now with QA, I ended up practicing black magic, sacrificing chickens and other things you'd better not to know. IIRC, the trick is to turn rewrite rules in ParseTreeEnvironment into search rules and then run the searches. Now this is tricky as these rules quite often refers to blocks, which then refers to outer contexts and you need these blocks do something different now (report nodes rather then transform stuff). This is the main problem. If you have the guts, you may find the code here: https://bitbucket.org/janvrany/stx-goodies-smallsense and here: http://swing.fit.cvut.cz/hg/stx.goodies.refactoryBrowser/ (alternatively, downlaod https://swing.fit.cvut.cz/projects/stx-jv/ and browse the code in Smalltalk browser). You may want to trace the code starting from ParseTreeEnvironment>>selectionIntervalsForSource:tree:do: RBParseTreeRule>>copyMatchDo: and implementors is also worth mentioning. After doing this, I concluded that SmallLint as it's now is not well designed for this task and it would need a significant refactoring. However, as always, I was never given time to do it. HTH, Jan On Tue, 2015-09-22 at 17:56 +0200, Yuriy Tymchuk wrote: > Hi everyone, > > I need someone who knows how RBParseTreeRewriter & co. work. May of > quality rules are implemented as rewrite rules which is cool. But > they donât report the interval in source code which can be > highlighted to help with understanding of the issue. > > Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it > possible to obtain the matched string there? Because in that case we > can get highlighting working which will be very useful. > > Cheers! > Uko >

Sept. 22, 2015

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Thierry Goubier

Le 22/09/2015 17:56, Yuriy Tymchuk a Ã©crit : > Hi everyone, > > I need someone who knows how RBParseTreeRewriter & co. work. May of > quality rules are implemented as rewrite rules which is cool. But > they donât report the interval in source code which can be > highlighted to help with understanding of the issue. > > Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it > possible to obtain the matched string there? Because in that case we > can get highlighting working which will be very useful. Hi Uko, it seems all the information is in the context of the RBParseTreeRewriter instance, but I'm not finding how to get the top-level node (the root of the tree which will be replaced), knowing that you may have multiple matches in a method (i.e. that there is multiple nodes). Thierry

Sept. 22, 2015

Help with RBTransformationRule needed!

by Yuriy Tymchuk

Hi everyone, I need someone who knows how RBParseTreeRewriter & co. work. May of quality rules are implemented as rewrite rules which is cool. But they donât report the interval in source code which can be highlighted to help with understanding of the issue. Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it possible to obtain the matched string there? Because in that case we can get highlighting working which will be very useful. Cheers! Uko

Sept. 22, 2015