September 2015 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50342 Home: https://github.com/pharo-project/pharo-core

Sept. 25, 2015

[pharo-project/pharo-core] d938ca: 50342

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: d938ca3b9035a8b02420be64a38bf1685c94ef51 https://github.com/pharo-project/pharo-core/commit/d938ca3b9035a8b02420be64… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-25 (Fri, 25 Sep 2015) Changed paths: M Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - before/testBeforeClassVariable.st M Reflectivity-Tests.package/ReflectivityExamples.class/instance/initialization/initialize.st M Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/running/tearDown.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyGlobalName.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyGlobalValue.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyGlobalVariable.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyIvarName.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyIvarValue.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyIvarVariable.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyTempName.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyTempNewValue.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variablenodes/testReifyTempValue.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyGlobalName.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyGlobalValue.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyGlobalVariable.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyGlobalVariableName.st A Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyGlobalVariableValue.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyIvarName.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyIvarValue.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyIvarVariable.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyTempName.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyTempNewValue.st R Reflectivity-Tests.package/ReflectivityReificationTest.class/instance/tests - variables/testReifyTempValue.st M Reflectivity.package/HookGenerator.class/definition.st M Reflectivity.package/HookGenerator.class/instance/private/genReification_for_.st A Reflectivity.package/HookGeneratorForVariables.class/README.md A Reflectivity.package/HookGeneratorForVariables.class/definition.st M Reflectivity.package/RFNameReification.class/class/plugin interface/nodes.st A Reflectivity.package/RFNameReification.class/instance/generate/genForLiteralVariable.st A Reflectivity.package/RFReification.class/instance/generate/genForClassVariable.st A Reflectivity.package/RFReification.class/instance/generate/genForLiteralVariable.st A Reflectivity.package/RFSemanticAnalyzer.class/instance/visiting/analyseForLinksForNodes_.st A Reflectivity.package/RFSemanticAnalyzer.class/instance/visiting/analyseForLinksForVariables_.st A Reflectivity.package/RFSemanticAnalyzer.class/instance/visiting/analyseForLinks_generator_.st M Reflectivity.package/RFSemanticAnalyzer.class/instance/visiting/visitMethodNode_.st M Reflectivity.package/RFSemanticAnalyzer.class/instance/visiting/visitNode_.st M Reflectivity.package/RFSemanticAnalyzer.class/instance/visiting/visitVarWrite_.st M Reflectivity.package/RFSemanticAnalyzer.class/instance/visiting/visitVariableNode_.st M Reflectivity.package/RFValueReification.class/class/plugin interface/nodes.st A Reflectivity.package/RFValueReification.class/instance/generate/genForLiteralVariable.st M Reflectivity.package/RFValueReification.class/instance/generate/preamble_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50341.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50342.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50341.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50342.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50342 16640 Reflectivity: add support for reifications #name and #value for Class Variables https://pharo.fogbugz.com/f/cases/16640 http://files.pharo.org/image/50/50342.zip

Sept. 25, 2015

Re: [Pharo-dev] - 250 * 1.5 is not the same as 250 * 1.5

by Thierry Goubier

2015-09-25 11:01 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: > > > 2015-09-24 22:39 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: > >> Le 24/09/2015 09:11, Nicolai Hess a Ã©crit : >> >>> >>> >>> 2015-09-24 8:19 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com >>> <mailto:i.uhnak@gmail.com>>: >>> >>> > - 250 * 1.5 returns -2.25 >>> >>> why is this valid syntax? >>> >>> >>> >>> I don't know if this is valid syntax (I always wondered that there is >>> one place in PointTest, that is not compilable with old compiler but >>> compiles >>> fine with opal). >>> But the error happens in >>> RBParser>>#parseNegatedNumber. >>> If a #- is recognized, it tests if a literalnumber follows (but from the >>> token stream, that is, the spaces are ignored). >>> Now the real bug is, that we do two "steps" and concstruct a new >>> literalvaluenode from the now following tokens. >>> RBParser parseExpression:'- 2' -> throws an error, because no following >>> tokens >>> RBParser parseExpression:'- 2 * 3' -> works but actually duplicates the >>> two last tokens "*3 *3. >>> and some funny other things '- 2@1' -> '-1@1' >>> >> >> Another one I found in the tests: would you expect >> >> RBParser parseExpression: '# >> >> 1 = 1' >> >> To be the same thing as '#1 = 1' ? >> > > > And another one: > #t = ##t "-> true" > > I thnk ##t should be allowed. > I would allow it if it doesn't impact the code. At the moment, what I see is that ## is allowed because #scanLiteral is recursive for symbols... sort of side effect of the current implementation. If correcting makes it non-recursive, I won't introduce a special check to allow ## and ### and ####. ## has a special meaning in some smalltalks (Dolphin?). Removing ## would make porting Dolphin code (SmaCC, for example) harder. Thierry > > > >> >> Thierry >> > >

Sept. 25, 2015

Re: [Pharo-dev] SHRBTextStyler and workspace/playground variables

by Andrei Chis

On Fri, Sep 25, 2015 at 8:58 AM, Nicolai Hess <nicolaihess(a)web.de> wrote: > > > 2015-09-24 12:06 GMT+02:00 Andrei Chis <chisvasileandrei(a)gmail.com>: > >> Hi, >> >> Currently SHRBTextStyler does not highlight variables in the playground. >> This could be added by extending SHRBTextStyler >>#resolveStyleFor: with >> >> workspace >> ifNotNil: [(workspace hasBindingOf: aVariableNode name) >> ifTrue: [^ #workspaceVar]]. >> > > Yes, I tried it already, but I couldn't get it to work. > I would like to have some way to add this to the semantic analyser step. > If the workspace is defined as a requestore scope, the variable analysis > should work the same way as if we actual "compile" the code. > I also think this would be a much nicer solution. I looked a bit at the how requestor scopes work but it's not that clear how to add the workspace as a scope. Cheers, Andrei > > >> >> Still this could cause some problems given how MorphicTextAdapter >> integrates Rubric. >> >> MorphicTextAdapter>>setEditingModeFor:withBehavior: can translate >> #beForCode from Spec to #beForSmalltalkScripting in Rubric. >> However for #beForSmalltalkScripting to work the model has to provide >> methods for managing bindings which MorphicTextAdapter does not. >> >> > This is really difficult, especially because the actual model is different > for Nautilus code panes and of course any spec based text/code model. > > >> Maybe there is another way to highlight variables in the playground. >> >> Cheers, >> Andrei >> > >

Sept. 25, 2015

Re: [Pharo-dev] - 250 * 1.5 is not the same as 250 * 1.5

by Nicolai Hess

2015-09-24 22:39 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: > Le 24/09/2015 09:11, Nicolai Hess a Ã©crit : > >> >> >> 2015-09-24 8:19 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com >> <mailto:i.uhnak@gmail.com>>: >> >> > - 250 * 1.5 returns -2.25 >> >> why is this valid syntax? >> >> >> >> I don't know if this is valid syntax (I always wondered that there is >> one place in PointTest, that is not compilable with old compiler but >> compiles >> fine with opal). >> But the error happens in >> RBParser>>#parseNegatedNumber. >> If a #- is recognized, it tests if a literalnumber follows (but from the >> token stream, that is, the spaces are ignored). >> Now the real bug is, that we do two "steps" and concstruct a new >> literalvaluenode from the now following tokens. >> RBParser parseExpression:'- 2' -> throws an error, because no following >> tokens >> RBParser parseExpression:'- 2 * 3' -> works but actually duplicates the >> two last tokens "*3 *3. >> and some funny other things '- 2@1' -> '-1@1' >> > > Another one I found in the tests: would you expect > > RBParser parseExpression: '# > > 1 = 1' > > To be the same thing as '#1 = 1' ? > And another one: #t = ##t "-> true" I thnk ##t should be allowed. > > Thierry >

Sept. 25, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50341 Home: https://github.com/pharo-project/pharo-core

Sept. 25, 2015

[pharo-project/pharo-core] c0bee2: 50341

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: c0bee2ffe7bb27ff8be5d07a05e3ad5acb220b7b https://github.com/pharo-project/pharo-core/commit/c0bee2ffe7bb27ff8be5d07a… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-25 (Fri, 25 Sep 2015) Changed paths: M Graphics-Tests.package/PointTest.class/instance/tests-geometry/testToIntersectsTo.st M Kernel-Tests.package/BehaviorTest.class/instance/tests/testBehaviorRespectsPolymorphismWithTraitBehavior.st M OpalCompiler-Core.package/ManifestOpalCompilerCore.class/class/meta-data - dependency analyser/ignoredDependencies.st M OpalCompiler-Core.package/ManifestOpalCompilerCore.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st A OpalCompiler-Core.package/OCAbstractMethodScope.class/instance/lookup/findVariable_ifNone_.st A OpalCompiler-Core.package/OCClassScope.class/instance/lookup/findVariable_ifNone_.st A OpalCompiler-Core.package/OCInstanceScope.class/instance/lookup/findVariable_ifNone_.st A OpalCompiler-Core.package/extension/SystemDictionary/instance/findVariable_ifNone_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50340.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50341.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50340.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50341.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Slot.package/AbstractClassModification.class/instance/accessing/classLayout.st A Slot.package/AbstractClassModification.class/instance/accessing/classLayout_.st A Slot.package/extension/Behavior/instance/classLayout.st A Slot.package/extension/Behavior/instance/classLayout_.st R TxText-Styler.package/extension/OCAbstractMethodScope/instance/findVariable_ifNone_.st R TxText-Styler.package/extension/OCClassScope/instance/findVariable_ifNone_.st R TxText-Styler.package/extension/OCInstanceScope/instance/findVariable_ifNone_.st R TxText-Styler.package/extension/SystemDictionary/instance/findVariable_ifNone_.st Log Message: ----------- 50341 16591 #findVariable:ifNone: methods needs to go back to Opal https://pharo.fogbugz.com/f/cases/16591 16633 Rename layout to classLayout (step 1 add accessor) https://pharo.fogbugz.com/f/cases/16633 16639 fix non common smalltalk syntax in PointTest https://pharo.fogbugz.com/f/cases/16639 http://files.pharo.org/image/50/50341.zip

Sept. 25, 2015

Re: [Pharo-dev] - 250 * 1.5 is not the same as 250 * 1.5

by Thierry Goubier

2015-09-25 9:53 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: > Note for ref on the original point: > > ANSI Smalltalk allow for space between - and the number token. Squeak is > then non A > > For the new point: > > ANSI Smalltalk does not allow for space between # and the selector, or > between # and the quoted string. > > Should be an easy fix. > Note to self for later: RBScanner>>#scanLiteral call stripSeparators before checking $# and calling again scanLiteral, which means it has a good chance of calling stripSeparators twice when dealing with the beginning of a symbol. Thierry > Marcus, how do we should validate RBParser changes? Reparse all the code > in the image and compares ASTs? > > Thierry > > > 2015-09-25 8:52 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: > >> >> >> 2015-09-24 22:39 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: >> >>> Le 24/09/2015 09:11, Nicolai Hess a Ã©crit : >>> >>>> >>>> >>>> 2015-09-24 8:19 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com >>>> <mailto:i.uhnak@gmail.com>>: >>>> >>>> > - 250 * 1.5 returns -2.25 >>>> >>>> why is this valid syntax? >>>> >>>> >>>> >>>> I don't know if this is valid syntax (I always wondered that there is >>>> one place in PointTest, that is not compilable with old compiler but >>>> compiles >>>> fine with opal). >>>> But the error happens in >>>> RBParser>>#parseNegatedNumber. >>>> If a #- is recognized, it tests if a literalnumber follows (but from the >>>> token stream, that is, the spaces are ignored). >>>> Now the real bug is, that we do two "steps" and concstruct a new >>>> literalvaluenode from the now following tokens. >>>> RBParser parseExpression:'- 2' -> throws an error, because no following >>>> tokens >>>> RBParser parseExpression:'- 2 * 3' -> works but actually duplicates the >>>> two last tokens "*3 *3. >>>> and some funny other things '- 2@1' -> '-1@1' >>>> >>> >>> Another one I found in the tests: would you expect >>> >>> RBParser parseExpression: '# >>> >>> 1 = 1' >>> >>> To be the same thing as '#1 = 1' ? >>> >> >> I tested this in squeak and it seems that >> #1 isn't allowed as symbol, the only way to use a digit as symbol is >> #'1' (is this defined in smalltalks syntax defintion?) >> >> -> Parsing '#' has to be fixed too. >> >> >> >> >>> >>> Thierry >>> >> >> >

Sept. 25, 2015

Re: [Pharo-dev] [Reflectivity] What are the #arguments?

by roberto.minelli＠usi.ch

Thank you very much, Marcus! Concerning the table..we can do a method that lists the #availableReifications or something like that ;) For example, if I am interested in all the available reifications for an RBMethodNode I can do: RFReification subclasses select: [ :e | e nodes includesAny: RBMethodNode withAllSuperclasses ]. Cheers, Roby > On 25 Sep 2015, at 09:51, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Hello, > > every one of these âreificationsâ are defined as a subclass of > RFReification > > There is one subclass for every symbol (e.g. for #arguments, there is RFArgumentsReification). > The class side method #key defines the exact symbol, while #nodes returns the AST node classes > where this reification is available. > > I will make a full table soon that lists everything. > > Marcus > >> On 25 Sep 2015, at 09:36, roberto.minelli(a)usi.ch wrote: >> >> Dear Marcus, >> >> I am wondering where to âdiscoverâ all the possible values for the #arguments: to pass to the MetaLink. >> >> Cheers, >> R >> >

Sept. 25, 2015

Re: [Pharo-dev] - 250 * 1.5 is not the same as 250 * 1.5

by Thierry Goubier

Note for ref on the original point: ANSI Smalltalk allow for space between - and the number token. Squeak is then non A For the new point: ANSI Smalltalk does not allow for space between # and the selector, or between # and the quoted string. Should be an easy fix. Marcus, how do we should validate RBParser changes? Reparse all the code in the image and compares ASTs? Thierry 2015-09-25 8:52 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: > > > 2015-09-24 22:39 GMT+02:00 Thierry Goubier <thierry.goubier(a)gmail.com>: > >> Le 24/09/2015 09:11, Nicolai Hess a Ã©crit : >> >>> >>> >>> 2015-09-24 8:19 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com >>> <mailto:i.uhnak@gmail.com>>: >>> >>> > - 250 * 1.5 returns -2.25 >>> >>> why is this valid syntax? >>> >>> >>> >>> I don't know if this is valid syntax (I always wondered that there is >>> one place in PointTest, that is not compilable with old compiler but >>> compiles >>> fine with opal). >>> But the error happens in >>> RBParser>>#parseNegatedNumber. >>> If a #- is recognized, it tests if a literalnumber follows (but from the >>> token stream, that is, the spaces are ignored). >>> Now the real bug is, that we do two "steps" and concstruct a new >>> literalvaluenode from the now following tokens. >>> RBParser parseExpression:'- 2' -> throws an error, because no following >>> tokens >>> RBParser parseExpression:'- 2 * 3' -> works but actually duplicates the >>> two last tokens "*3 *3. >>> and some funny other things '- 2@1' -> '-1@1' >>> >> >> Another one I found in the tests: would you expect >> >> RBParser parseExpression: '# >> >> 1 = 1' >> >> To be the same thing as '#1 = 1' ? >> > > I tested this in squeak and it seems that > #1 isn't allowed as symbol, the only way to use a digit as symbol is > #'1' (is this defined in smalltalks syntax defintion?) > > -> Parsing '#' has to be fixed too. > > > > >> >> Thierry >> > >

Sept. 25, 2015