August 2015 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] 4f2ad1: 50218

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 4f2ad13a067aa56af55d90c51820207c608c6454 https://github.com/pharo-project/pharo-core/commit/4f2ad13a067aa56af55d90c5… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-10 (Mon, 10 Aug 2015) Changed paths: A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/on_getState_action_label_menu_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50217.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50218.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50217.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50218.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50218 16137 PluggableButtonMorph needs #on:getState:action:label:menu: for backwards compatibility https://pharo.fogbugz.com/f/cases/16137 http://files.pharo.org/image/50/50218.zip

Aug. 10, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50218 Home: https://github.com/pharo-project/pharo-core

Aug. 10, 2015

extension not appearing under package(-tag?)

by Ben Coman

I'm not sure what to make of this... I notice that the class side of Object has protocol *Tools-Debugger contains method #canonicalArgumentName, but class side of that package/tag does not show #canonicalArgumentName, which instead appears under parent "Tools". Also btw, I notice package Tools-Debugger contain KeyPrinterMorph and SyntaxErrorDebugger classes which seem to have no class references. Not that every class needs to be referenced, but just floating this observation in case someone knew if they need to be cleaned up or moved. cheers -ben

Aug. 10, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50217 Home: https://github.com/pharo-project/pharo-core

Aug. 10, 2015

[pharo-project/pharo-core] 30ed32: 50217

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 30ed3248f1e2726a8a01a0bc5c3fb5607c65312c https://github.com/pharo-project/pharo-core/commit/30ed3248f1e2726a8a01a0bc… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-10 (Mon, 10 Aug 2015) Changed paths: M Athens-Morphic.package/AthensWorldMorph.class/instance/world state/restoreMorphicDisplay.st M BaselineOfQualityAssistant.package/BaselineOfQualityAssistant.class/instance/api projectSpec/baseline_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v1%5F1%5F4_.st M ConfigurationOfRenraku.package/ConfigurationOfRenraku.class/instance/symbolic versions/stable_.st A ConfigurationOfRenraku.package/ConfigurationOfRenraku.class/instance/versions/v0%5F3%5F4_.st A FreeType.package/FreeTypeFontProvider.class/class/accessing/resetCurrent.st M FreeType.package/FreeTypeSettings.class/class/system startup/shutDown_.st R Kernel.package/ClassOrganization.class/class/import/importFrom_.st R Kernel.package/ClassOrganization.class/instance/importing/importFrom_.st R Kernel.package/ProtocolOrganizer.class/class/import/importFrom_.st R Kernel.package/ProtocolOrganizer.class/instance/initialization/importFrom_.st M Morphic-Core.package/Morph.class/instance/accessing/color_.st A Morphic-Core.package/Morph.class/instance/change reporting/displayExtentChanged.st M Morphic-Core.package/Morph.class/instance/visual properties/fillStyle_.st M Morphic-Core.package/PasteUpMorph.class/instance/world state/restoreMorphicDisplay.st A Morphic-Examples.package/PluggableButtonMorphExample.class/README.md A Morphic-Examples.package/PluggableButtonMorphExample.class/class/examples/exampleButton.st A Morphic-Examples.package/PluggableButtonMorphExample.class/class/examples/exampleButtonNoLabel.st A Morphic-Examples.package/PluggableButtonMorphExample.class/class/examples/exampleButtonWithIcon.st A Morphic-Examples.package/PluggableButtonMorphExample.class/class/examples/exampleButtonWithIconBottom.st A Morphic-Examples.package/PluggableButtonMorphExample.class/class/examples/exampleButtonWithIconRight.st A Morphic-Examples.package/PluggableButtonMorphExample.class/class/examples/exampleButtonWithIconTop.st A Morphic-Examples.package/PluggableButtonMorphExample.class/definition.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/accessing/icon.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/accessing/icon_.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/accessing/label.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/accessing/label_.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/accessing/state.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/accessing/state_.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/actions/action.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/building/buildButton.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/building/buildButtonNoLabel.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/building/buildButtonWithIcon.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/building/buildButtonWithIconBottom.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/building/buildButtonWithIconRight.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/building/buildButtonWithIconTop.st A Morphic-Examples.package/PluggableButtonMorphExample.class/instance/initialization/initialize.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/README.md A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/class/examples/exampleToggleButton.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/class/examples/exampleToggleButtonNoLabel.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/class/examples/exampleToggleButtonWithIcon.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/definition.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/instance/actions/toggleAction_.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/instance/building/buildToggleButton.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/instance/building/buildToggleButtonNoLabel.st A Morphic-Examples.package/PluggableToggleButtonMorphExample.class/instance/building/buildToggleButtonWithIcon.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/class/instance creation/on_getState_action_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/class/instance creation/on_getState_action_label_.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/class/instance creation/on_getState_action_label_icon_menu_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/class/instance creation/on_getState_action_label_menu_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/definition.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/beIconBottom.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/beIconLeft.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/beIconRight.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/beIconTop.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/icon.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/iconPosition.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/icon_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/label_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/label_font_.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/on_getState_action_label_icon_menu_.st R Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/accessing/on_getState_action_label_menu_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/copying/veryDeepInner_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/drawing/indicateModalChild.st R Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/drawing/layoutBounds_.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/layout/layoutBounds_.st A Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/private/privateColor_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/updating/changed.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/updating/update_.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/README.md A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/definition.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/instance/accessing/bePressed.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/instance/accessing/getModelState.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/instance/accessing/icon.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/instance/accessing/performAction_.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/instance/initialization/initialize.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/instance/private/pressed_.st A Morphic-Widgets-Basic.package/PluggableToggleButtonMorph.class/instance/testing/isPressed.st A Morphic-Widgets-Extra.package/DockingBarMorph.class/instance/change reporting/displayExtentChanged.st A Morphic-Widgets-Taskbar.package/TaskbarMorph.class/instance/change reporting/displayExtentChanged.st A Morphic-Widgets-Windows.package/FullscreenMorph.class/instance/change reporting/displayExtentChanged.st M Renraku.package/ReEngine.class/instance/initialization/initialize.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50216.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50217.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50216.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50217.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50217 16128 Better handling when the Pharo-window is re-sized https://pharo.fogbugz.com/f/cases/16128 16106 Image grows by 3.5MB for every save https://pharo.fogbugz.com/f/cases/16106 16135 Remove RBModifiesCollectionRule from rules run by Renraku (QualityAssistant) https://pharo.fogbugz.com/f/cases/16135 16120 Remove unused #importFrom: in ClassOrganization and ProtocolOrganizer https://pharo.fogbugz.com/f/cases/16120 16116 introduce PluggableButtonMorph with icons and PluggableToggleButtonMorph https://pharo.fogbugz.com/f/cases/16116 http://files.pharo.org/image/50/50217.zip

Aug. 10, 2015

Re: [Pharo-dev] some questions about bloc

by Nicolai Hess

2015-08-10 12:36 GMT+02:00 Aliaksei Syrel <alex.syrel(a)gmail.com>: > Hi Nicolai, > > Thanks for looking into this :) Hierarchy will be optimised. Basically > EnclosedView will gone - ProtoView will be a composition, this will remove > code duplication and simplify addition of new functionality. After that > rounded rectangle and rectangle will be merged. So in the end hierarchy > will be BlProtoView -> BlView -> BlRectangle -> BrStringView -> > BrButtonView which is simple enough. > merging EnclosedView and ProtoView: +1 > As Stephan said theme just provides default values and also skin for > morph. > Ok, yes that makes sense. > Skin provides view and different styles for states like hovered, pressed, > active, focused, disabled and others. > Summarizing, with event listener any arbitrary morph can get dynamic > behaviour on events, with skins any arbitrary morph can be deeply styled. > > Maybe it makes sense to move theme from BlProtoView to BlMorph. > > Cheers, > Alex > On Aug 9, 2015 9:57 PM, "Nicolai Hess" <nicolaihess(a)web.de> wrote: > >> >> >> 2015-08-09 20:17 GMT+02:00 Aliaksei Syrel <alex.syrel(a)gmail.com>: >> >>> Hi >>> >> Thanks for your response. >> >> >>> Animation was copied from other project and has nothing to do with Bloc. >>> However, it is still there for a moment. BTW, example on the class side is >>> still morphic. >>> >> >> Yes, but it only works in a bloc world >> >> >>> Yes, it does not make any sense to theme CircleView and ImageView, but >>> it makes sense to theme their subclasses, like BrButtonView. Theming >>> mechanism is not integrated in Bloc for now. >>> >> >> But why dont we put this into a BlThemeableView ? >> All subclasses of BlProtoView that want to support color or fillstyles, >> now have a theme property too. >> Why do they need a color property if the color is theme-dependent. >> >> Btw. what is that strange hierarchy for BrButtonView: >> BlProtoView -> BlView -> BlEnclosedView -> BlRectangleView -> >> BlRoundedRectangleView -> BrRectangleView -> BrStringView -> BrButtonView >> A BlRectangleView, a RoundedRectangleView and a BrRectangleView? >> >> I think I don't understand bloc >> >> >> Cheers, >>> Alex >>> On Aug 9, 2015 7:29 PM, "Nicolai Hess" <nicolaihess(a)web.de> wrote: >>> >>>> BlAlarmQueue >>>> - split into two classes? >>>> Queue : managing the add/remove/sort >>>> Scheduler : process the Alarms >>>> - alarm/alarmqueue both accessing and check the time "Time now" >>>> I would put both checks to, either the alarm OR the queue/scheduler. >>>> And don't use "Time now" explicit, if we put this behind a method >>>> call, we >>>> can easily create alarm queue mocs for unit tests. >>>> - readding periodic alarms: shouldn't this be done by the alarm itself >>>> - the queue should not care, whether a alarm is periodic. >>>> >>>> Some alarm examples put the queue into the morphs property dictionary. >>>> I could find out why >>>> this is necessary. >>>> >>>> >>>> Layout: >>>> Box/Column/Row Layout and corresponding cells define a double linked >>>> list, we already >>>> have a DoubleLinkedList, can we use the DoubleLinkedList instead of >>>> reimplmenting this >>>> on the layout/cells? >>>> >>>> Tablelayout: is this "work in progress" or abandoned? Currently it >>>> shares much code with >>>> the BoxLayout, but it does not look like it is working. >>>> >>>> Theming: >>>> #theme is a property of BlProtoView - isn't this to low level for >>>> defining theming support? >>>> How would you theme a CircleView or an ImageView? >>>> >>>> >>>> Animation: >>>> what are all these "Logics"? >>>> animationLogic >>>> toLogic >>>> stepLogic and steppedLogic(!?) >>>> ifLogic .... >>>> >>>> Is this a software pattern ? I have never seen this before. >>>> (For example we use "sortBlock" but not "sortLogic"). >>>> How about ValueHolder or good old "Block". >>>> >>>> And "ifLogic" sounds like a condition, why don't we name it. ... >>>> condition? >>>> And putting all this "logic" into one animation class scares me. >>>> >>>> >>>> About the class comment syntax: >>>> - is this pillar syntax? I think this is difficult to read. Do you use >>>> that syntax, because we >>>> want to use a pillar as comment text and build a renderer for this or >>>> is it to share comments between class comments and the bloc doc book, >>>> easily? >>>> >>>> I can help with documenting the classes but I find it difficult to see >>>> which parts of bloc >>>> are just tests/proof of concept or are supposed to be in the final >>>> version. Maybe I miss the big picture? >>>> >>>> >>>> nicolai >>>> >>>> >>>> >>>> >>>> >>>> >>

Aug. 10, 2015

Re: [Pharo-dev] some questions about bloc

by Aliaksei Syrel

Hi Nicolai, Thanks for looking into this :) Hierarchy will be optimised. Basically EnclosedView will gone - ProtoView will be a composition, this will remove code duplication and simplify addition of new functionality. After that rounded rectangle and rectangle will be merged. So in the end hierarchy will be BlProtoView -> BlView -> BlRectangle -> BrStringView -> BrButtonView which is simple enough. As Stephan said theme just provides default values and also skin for morph. Skin provides view and different styles for states like hovered, pressed, active, focused, disabled and others. Summarizing, with event listener any arbitrary morph can get dynamic behaviour on events, with skins any arbitrary morph can be deeply styled. Maybe it makes sense to move theme from BlProtoView to BlMorph. Cheers, Alex On Aug 9, 2015 9:57 PM, "Nicolai Hess" <nicolaihess(a)web.de> wrote: > > > 2015-08-09 20:17 GMT+02:00 Aliaksei Syrel <alex.syrel(a)gmail.com>: > >> Hi >> > Thanks for your response. > > >> Animation was copied from other project and has nothing to do with Bloc. >> However, it is still there for a moment. BTW, example on the class side is >> still morphic. >> > > Yes, but it only works in a bloc world > > >> Yes, it does not make any sense to theme CircleView and ImageView, but it >> makes sense to theme their subclasses, like BrButtonView. Theming mechanism >> is not integrated in Bloc for now. >> > > But why dont we put this into a BlThemeableView ? > All subclasses of BlProtoView that want to support color or fillstyles, > now have a theme property too. > Why do they need a color property if the color is theme-dependent. > > Btw. what is that strange hierarchy for BrButtonView: > BlProtoView -> BlView -> BlEnclosedView -> BlRectangleView -> > BlRoundedRectangleView -> BrRectangleView -> BrStringView -> BrButtonView > A BlRectangleView, a RoundedRectangleView and a BrRectangleView? > > I think I don't understand bloc > > > Cheers, >> Alex >> On Aug 9, 2015 7:29 PM, "Nicolai Hess" <nicolaihess(a)web.de> wrote: >> >>> BlAlarmQueue >>> - split into two classes? >>> Queue : managing the add/remove/sort >>> Scheduler : process the Alarms >>> - alarm/alarmqueue both accessing and check the time "Time now" >>> I would put both checks to, either the alarm OR the queue/scheduler. >>> And don't use "Time now" explicit, if we put this behind a method >>> call, we >>> can easily create alarm queue mocs for unit tests. >>> - readding periodic alarms: shouldn't this be done by the alarm itself >>> - the queue should not care, whether a alarm is periodic. >>> >>> Some alarm examples put the queue into the morphs property dictionary. I >>> could find out why >>> this is necessary. >>> >>> >>> Layout: >>> Box/Column/Row Layout and corresponding cells define a double linked >>> list, we already >>> have a DoubleLinkedList, can we use the DoubleLinkedList instead of >>> reimplmenting this >>> on the layout/cells? >>> >>> Tablelayout: is this "work in progress" or abandoned? Currently it >>> shares much code with >>> the BoxLayout, but it does not look like it is working. >>> >>> Theming: >>> #theme is a property of BlProtoView - isn't this to low level for >>> defining theming support? >>> How would you theme a CircleView or an ImageView? >>> >>> >>> Animation: >>> what are all these "Logics"? >>> animationLogic >>> toLogic >>> stepLogic and steppedLogic(!?) >>> ifLogic .... >>> >>> Is this a software pattern ? I have never seen this before. >>> (For example we use "sortBlock" but not "sortLogic"). >>> How about ValueHolder or good old "Block". >>> >>> And "ifLogic" sounds like a condition, why don't we name it. ... >>> condition? >>> And putting all this "logic" into one animation class scares me. >>> >>> >>> About the class comment syntax: >>> - is this pillar syntax? I think this is difficult to read. Do you use >>> that syntax, because we >>> want to use a pillar as comment text and build a renderer for this or is >>> it to share comments between class comments and the bloc doc book, easily? >>> >>> I can help with documenting the classes but I find it difficult to see >>> which parts of bloc >>> are just tests/proof of concept or are supposed to be in the final >>> version. Maybe I miss the big picture? >>> >>> >>> nicolai >>> >>> >>> >>> >>> >>> >

Aug. 10, 2015

Re: [Pharo-dev] Problem with changes?

by Martin Dias

I did some refactorings in .changes related code, but that was by June, I think. So... not me! :-) El sÃ¡b., 8 de agosto de 2015 15:02, Stephan Eggermont <stephan(a)stack.nl> escribiÃ³: > On 08/08/15 14:16, stepharo wrote: > > Hi > > > > since a couple of versions I have the impression that removing, adding a > > method, browsing a version is sloooooowwwww. > > Do you get the same feeling? > > Something is slow, at least in 50205 > > Stephan > > > >

Aug. 10, 2015

Re: [Pharo-dev] some questions about bloc

by stepharo

Thanks nicolai for all these questions. Writing more tests is cool. I started and each time alain imporved Bloc :) Alain is driving somwhere in vacation with nearly no internet. Stef > BlAlarmQueue > - split into two classes? > Queue : managing the add/remove/sort > Scheduler : process the Alarms > - alarm/alarmqueue both accessing and check the time "Time now" > I would put both checks to, either the alarm OR the queue/scheduler. > And don't use "Time now" explicit, if we put this behind a method > call, we > can easily create alarm queue mocs for unit tests. > - readding periodic alarms: shouldn't this be done by the alarm itself > - the queue should not care, whether a alarm is periodic. > > Some alarm examples put the queue into the morphs property dictionary. > I could find out why > this is necessary. > > > Layout: > Box/Column/Row Layout and corresponding cells define a double linked > list, we already > have a DoubleLinkedList, can we use the DoubleLinkedList instead of > reimplmenting this > on the layout/cells? Yes. > Tablelayout: is this "work in progress" or abandoned? Currently it > shares much code with > the BoxLayout, but it does not look like it is working. I think that this is more a work in progress. > > Theming: > #theme is a property of BlProtoView - isn't this to low level for > defining theming support? > How would you theme a CircleView or an ImageView? > > > Animation: > what are all these "Logics"? > animationLogic > toLogic > stepLogic and steppedLogic(!?) > ifLogic .... I would really like to see if Viva animation could be used in Bloc. StephaneDucasse / PetitsBazars > viva Alex used it for Roassal and this is nice but we need more experience and to check if it is compatible with the design of bloc. Is this a software pattern ? I have never seen this before. > (For example we use "sortBlock" but not "sortLogic"). > How about ValueHolder or good old "Block". > > And "ifLogic" sounds like a condition, why don't we name it. ... > condition? > And putting all this "logic" into one animation class scares me. > > > About the class comment syntax: > - is this pillar syntax? I think this is difficult to read. Do you use > that syntax, because we > want to use a pillar as comment text and build a renderer for this or > is it to share comments between class comments and the bloc doc book, > easily? yes. > I can help with documenting the classes but I find it difficult to see > which parts of bloc > are just tests/proof of concept or are supposed to be in the final > version. Maybe I miss the big picture? > What I can tell is that I tried several times and bloc changed at that time :) Now it is ***much*** more stable so this is the time to push. Did you read a bit the documentation we started on BlocCore? So having tests would be nice. I was planning to start to port some little classes I have around the game such as ledMorph and other to see how it goes. Stef

Aug. 10, 2015

Re: [Pharo-dev] some questions about bloc

by Stephan Eggermont

On 09/08/15 21:57, Nicolai Hess wrote: > But why dont we put this into a BlThemeableView ? > All subclasses of BlProtoView that want to support color or fillstyles, > now have a theme property too. > Why do they need a color property if the color is theme-dependent. Because the theme only provides default values (and reset to theme). Stephan

Aug. 9, 2015