August 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [Experiment] Automatic rewriting of sends to deprecated methods

by Marcus Denker

No, just plain old ParseTreeRewriter.. but integrating Markâs tool would be very nice as a next step. > On 30 Aug 2015, at 14:34, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > Is this based on Mark's Rewrite Tool? > > On Sun, Aug 30, 2015 at 10:27 AM, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: > Hi, > > Small experiment: > > 1) add this method to Object: > > deprecated: anExplanationString rule: aRule > | builder ast rewriteRule method | > builder := RBCompositeRefactoryChange named: 'deprecation'. > method := thisContext sender sender method. > ast := method ast copy. > rewriteRule := RBParseTreeRewriter new replace: aRule key with: aRule value. > > (rewriteRule executeTree: ast) ifTrue: [ > builder compile: rewriteRule tree formattedCode in: method methodClass classified: method protocol ]. > builder execute. > > 2) to see it in action, add it to #ifNotNilDo: in UndefinedObject: > > ifNotNilDo: aBlock > "Please use #ifNotNil: instead" > self > deprecated: 'Please use #ifNotNil: instead' > rule: '`@receiver ifNotNilDo: `@statements'-> '`@receiver ifNotNil: `@statements'. > ^ self > > > â> open a browser and see how it fixes code magically. > > The only problem is that it does a whole-method refactoring while it should only affect the node > that triggered the deprecation. Else there could be wrong transformations if the same selector > is used but only one of the implementations need to be rewritten, while if we are able to rewrite > the exact sender, we can do it fully automatically. > > Marcus >

Aug. 30, 2015

Re: [Pharo-dev] QANautilusPluggin Logic Question

by Marcus Denker

Hi, All methods (and methods of blocks) that are executing already will keep executing the wrong code. As only offsets change, one could do on-stack replacement of these methods, but nobody has implemented that yet. It might be good to have a check that warns when changing layout of classes that are active on the stackâ¦. > On 30 Aug 2015, at 14:49, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Yes, but the situation is weird, because if you look at the variable in the debugger - everything is ok. Is there a way to understand what has not mutated? > > Uko > > >> On 30 Aug 2015, at 13:35, stepharo <stepharo(a)free.fr> wrote: >> >> may be code executing the check did not get mutated when the system changed shape. >> >> Le 30/8/15 11:00, Marcus Denker a Ã©crit : >>>> On 30 Aug 2015, at 10:57, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >>>> >>>> So the byte symbol comes from the âpositionâ inst var of the superclass. Iâm not completely sure how it works on low level, but I guess that because you a a new variable, the others shift and it accesses the value that is actually mapped to another variable. Is it the issue of my implementation? How can I improve it? >>>> >>> The class builder is normally supposed to fix that transparently: You add var, all methods are recompiled and all instances are migrated. There could be bugs there. >>> >>>> Uko >>>> >>>>> On 28 Aug 2015, at 10:50, stepharo <stepharo(a)free.fr> wrote: >>>>> >>>>> When I add an iv to Model I get a ByteSymbol>>entity: >>>>> >>>>> QANautilusPluggin>>initialize >>>>> >>>>> changeHandler := GLMAsyncTask new >>>>> priority: Processor activePriority - 1; >>>>> doInBackground: [ morph entity: self currentEntity ]; >>>>> yourself >>>>> >>>>> And in the debugger morph is a a Morph exactly a QANautilusPluginMorph(493092864) >>>>> >>>>> Yuriy do you use thread? >>>>> >>>>> Stef >>>>> >>>>> >>>>> >>>> >>> >>> >> >> > >

Aug. 30, 2015

Keeping morph vs model

by stepharo

Hi I'm updating my mini browser to FastTable and Rubric and I was wondering if it is better to keep the model of the list instead of the morph in the browser model. Stef

Aug. 30, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50289 Home: https://github.com/pharo-project/pharo-core

Aug. 30, 2015

[pharo-project/pharo-core] 8d8dcc: 50289

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 8d8dccc7cfec41199d85513365f95b5f89b52c30 https://github.com/pharo-project/pharo-core/commit/8d8dccc7cfec41199d855133… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-30 (Sun, 30 Aug 2015) Changed paths: M CodeExport.package/ChunkWriteStream.class/instance/accessing/nextPut_.st M CodeImport.package/ChunkFileFormatParser.class/instance/parsing/parseMethodDeclarations_.st R CodeImport.package/ChunkReadStream.class/instance/accessing/next.st A CodeImport.package/ChunkReadStream.class/instance/decorated/basicNextChunk.st A CodeImport.package/ChunkReadStream.class/instance/decorated/decodeString_andRuns_.st A CodeImport.package/ChunkReadStream.class/instance/decorated/next.st A CodeImport.package/ChunkReadStream.class/instance/decorated/parseLangTagFor_.st R CodeImport.package/ChunkReadStream.class/instance/testing/isChunkEnd.st M Collections-Unordered.package/Dictionary.class/instance/removing/unreferencedKeys.st R Collections-Unordered.package/SmallDictionary.class/instance/accessing - keys/unreferencedKeys.st R Collections-Unordered.package/SmallDictionary.class/instance/removing - keys/removeUnreferencedKeys.st A Graphics-Primitives.package/Color.class/instance/conversions/asHexString.st A Graphics-Tests.package/ColorTest.class/instance/testing/testAsHexString.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50288.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50289.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50288.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50289.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Tests.package/ChunkImportTestCase.class/instance/importing-code/testExportAMethodWithLangTag.st A Tests.package/ChunkImportTestCase.class/instance/importing-code/testImportAMethodWithLangTag.st Log Message: ----------- 50289 16340 ExternalBrowser or "Recover lost changes" broken https://pharo.fogbugz.com/f/cases/16340 16432 add Color>>#asHexString https://pharo.fogbugz.com/f/cases/16432 16421 ChunkWriter does not save correctly wideStrings https://pharo.fogbugz.com/f/cases/16421 16433 simplify #unreferencedKeys https://pharo.fogbugz.com/f/cases/16433 http://files.pharo.org/image/50/50289.zip

Aug. 30, 2015

Re: [Pharo-dev] allChildren raise error when don't have read permission

by stepharo

we should improve this part of fileSystem. We were making a list of the issue and see if we cannot pay someone to fix them because we are too busy. Le 30/8/15 17:21, Brice GOVIN a Ã©crit : > Hi, > I was playing a bit with the FileSystem to get all files on my > computer (/FileSystem root allChildren/) and I had the error > âDirectoryDoesNotExistâ for a directory that actually exists but i > donât have the read permission. > I am not sure wether Iâm not using the right method for what I want or > this method should not do that? > > Is there another method that can gives me all files of my computer? > > Regards, > > */--------------/* > */Brice Govin /* > /PhD student in RMoD research team at INRIA Lille / > /Software Engineer at THALES AIR SYSTEMS Rungis// > ENSTA-Bretagne ENSI2014 > 64 chemin des boeufs 91220 PALAISEAU/ >

Aug. 30, 2015

allChildren raise error when don't have read permission

by Brice GOVIN

Hi, I was playing a bit with the FileSystem to get all files on my computer (FileSystem root allChildren) and I had the error âDirectoryDoesNotExistâ for a directory that actually exists but i donât have the read permission. I am not sure wether Iâm not using the right method for what I want or this method should not do that? Is there another method that can gives me all files of my computer? Regards, -------------- Brice Govin PhD student in RMoD research team at INRIA Lille Software Engineer at THALES AIR SYSTEMS Rungis ENSTA-Bretagne ENSI2014 64 chemin des boeufs 91220 PALAISEAU

Aug. 30, 2015

Re: [Pharo-dev] [Moose-dev] Re: Still some issue with Bloc :-(

by stepharo

Thanks nicolai. Alain told me that he was breaking his fireplace to build a new one so not much bloc to finish the holidays :) Stef Le 30/8/15 16:09, Nicolai Hess a Ã©crit : > fixed: ready to review > > 16267 > <https://pharo.fogbugz.com/f/cases/16267/Fasttable-isn-t-visible-in-athens-i…>Fasttable > isn't visible in athens (in bloc) > > 2015-08-29 18:54 GMT+02:00 Tudor Girba <tudor(a)tudorgirba.com > <mailto:tudor@tudorgirba.com>>: > > FastTable does not work in Bloc. You have to disable it from the > Settings to work with Nautilus. > > Cheers, > Doru > > On Sat, Aug 29, 2015 at 5:31 PM, Alexandre Bergel > <alexandre.bergel(a)me.com <mailto:alexandre.bergel@me.com>> wrote: > > Apparently there is a serious problem with the list and > FTTableContainer. > > I took a Moose 6 and did: > Gofer it > smalltalkhubUser: 'Pharo' project: 'Bloc'; > configurationOf: 'Bloc'; > loadBleedingEdge. > > Gofer it > smalltalkhubUser: 'Pharo' project: 'Brick'; > configurationOf: 'Brick'; > loadBleedingEdge. > > I do not see the classes when I select a package. A second try > opens many debuggers :-( > > How the build is done by the way? > > Cheers, > Alexandre > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > > > -- > www.tudorgirba.com <http://www.tudorgirba.com> > > "Every thing has its own flow" > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > >

Aug. 30, 2015

Re: [Pharo-dev] [Moose-dev] Re: Still some issue with Bloc :-(

by Nicolai Hess

fixed: ready to review 16267 <https://pharo.fogbugz.com/f/cases/16267/Fasttable-isn-t-visible-in-athens-i…> Fasttable isn't visible in athens (in bloc) 2015-08-29 18:54 GMT+02:00 Tudor Girba <tudor(a)tudorgirba.com>: > FastTable does not work in Bloc. You have to disable it from the Settings > to work with Nautilus. > > Cheers, > Doru > > On Sat, Aug 29, 2015 at 5:31 PM, Alexandre Bergel <alexandre.bergel(a)me.com > > wrote: > >> Apparently there is a serious problem with the list and FTTableContainer. >> >> I took a Moose 6 and did: >> Gofer it >> smalltalkhubUser: 'Pharo' project: 'Bloc'; >> configurationOf: 'Bloc'; >> loadBleedingEdge. >> >> Gofer it >> smalltalkhubUser: 'Pharo' project: 'Brick'; >> configurationOf: 'Brick'; >> loadBleedingEdge. >> >> I do not see the classes when I select a package. A second try opens many >> debuggers :-( >> >> How the build is done by the way? >> >> Cheers, >> Alexandre >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> > > > -- > www.tudorgirba.com > > "Every thing has its own flow" > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > >

Aug. 30, 2015

Re: [Pharo-dev] [Experiment] Automatic rewriting of sends to deprecated methods

by Yuriy Tymchuk

But it can be integrated with Rewrite Tool ;), itâs not so easy for everyone to write down a rewrite rule from scratch. Yes, I think that having transformation applied without re-styling will be a huge improvement. Because now there is an âautofixâ button, but I donât use it myself as it restyles all the method. Uko > On 30 Aug 2015, at 16:02, Mark Rizun <mrizun(a)gmail.com> wrote: > > As far as I'm concerned, it's not based on my tool. > > 30 ÑÐµÑÐ¿. 2015 3:34 Ð¿Ð¿ "Peter UhnÃ¡k" <i.uhnak(a)gmail.com <mailto:i.uhnak@gmail.com>> Ð¿Ð¸ÑÐµ: > Is this based on Mark's Rewrite Tool? > > On Sun, Aug 30, 2015 at 10:27 AM, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: > Hi, > > Small experiment: > > 1) add this method to Object: > > deprecated: anExplanationString rule: aRule > | builder ast rewriteRule method | > builder := RBCompositeRefactoryChange named: 'deprecation'. > method := thisContext sender sender method. > ast := method ast copy. > rewriteRule := RBParseTreeRewriter new replace: aRule key with: aRule value. > > (rewriteRule executeTree: ast) ifTrue: [ > builder compile: rewriteRule tree formattedCode in: method methodClass classified: method protocol ]. > builder execute. > > 2) to see it in action, add it to #ifNotNilDo: in UndefinedObject: > > ifNotNilDo: aBlock > "Please use #ifNotNil: instead" > self > deprecated: 'Please use #ifNotNil: instead' > rule: '`@receiver ifNotNilDo: `@statements'-> '`@receiver ifNotNil: `@statements'. > ^ self > > > â> open a browser and see how it fixes code magically. > > The only problem is that it does a whole-method refactoring while it should only affect the node > that triggered the deprecation. Else there could be wrong transformations if the same selector > is used but only one of the implementations need to be rewritten, while if we are able to rewrite > the exact sender, we can do it fully automatically. > > Marcus >

Aug. 30, 2015