July 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] QualityAssistant in Pharo5

by Yuriy Tymchuk

For now there are no summarization features. I.e. When you look at the class you donât see the critics of its methods. As there are no SmallLint rules about packages, I didnât add anything to the package. But this can be an interesting extension in SmallLint at first. Uko > On 23 Jul 2015, at 18:15, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > Excellent, thank you! > > (...and now to fix all offences in my code :)) > > Also this reminds when I used it some time ago... > Can I use it on a package(s) just like Critic Browser? > Or maybe since I see it's available in CompiledMethod/TBehavior I could maybe script it... > > Peter > > On Thu, Jul 23, 2015 at 5:46 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: > Dear all, > > QualityAssistant was integrated in Pharo5. You can read more about its functionality there: https://github.com/Uko/QualityAssistant#quality-assistant- <https://github.com/Uko/QualityAssistant#quality-assistant-> > If you will spot any bug please let me know, or report here: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues> > > Write a good quality code! > Uko >

July 23, 2015

Re: [Pharo-dev] QualityAssistant in Pharo5

by Peter UhnÃ¡k

Excellent, thank you! (...and now to fix all offences in my code :)) Also this reminds when I used it some time ago... Can I use it on a package(s) just like Critic Browser? Or maybe since I see it's available in CompiledMethod/TBehavior I could maybe script it... Peter On Thu, Jul 23, 2015 at 5:46 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > Dear all, > > QualityAssistant was integrated in Pharo5. You can read more about its > functionality there: > https://github.com/Uko/QualityAssistant#quality-assistant- > If you will spot any bug please let me know, or report here: > https://github.com/Uko/QualityAssistant/issues > > Write a good quality code! > Uko >

July 23, 2015

QualityAssistant in Pharo5

by Yuriy Tymchuk

Dear all, QualityAssistant was integrated in Pharo5. You can read more about its functionality there: https://github.com/Uko/QualityAssistant#quality-assistant- <https://github.com/Uko/QualityAssistant#quality-assistant-> If you will spot any bug please let me know, or report here: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues> Write a good quality code! Uko

July 23, 2015

Re: [Pharo-dev] Contributing to VoyageMongo (improving insertion/updating speed)

by Sven Van Caekenberghe

> On 23 Jul 2015, at 16:13, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > Why it doesn't use ==UUIDGenerator default== like UUID new does? > > (I am running on Linux, not OS X so times are not directly comparable with Holger's) > ~~~~~~~~~~~~~~~~~ > [ UUIDGenerator new makeSeed ] bench. "'1,344 per second'" > [ UUID new ] bench. "'15,794 per second'" > ~~~~~~~~~~~~~~~~~ > > On another note...the performance for UUID is still terrible compared to languages like Ruby: > > ~~~~~~~~~~~~ > require 'benchmark' > require 'securerandom' > > n = 1000000 > time = Benchmark.realtime do > n.times do ; SecureRandom.uuid; end > end > > puts "#{n/time} times per second" > ~~~~~~~~~~~~~~ > > "142164.93834009714 times per second" (tenfold improvement) > > Pharo's implementation is for whatever reason really complex, generating the bytes several times, assigning finals bits one by one, etc. Indeed, following a previous discussion, I once wrote my own version (in the Neo repository): | generator | generator := NeoUUIDGenerator new. [ generator next ] bench. "'446,217 per second'" But it all depends on the algorithm and which random generator/source you need/trust/want. > Peter > > > On Thu, Jul 23, 2015 at 1:42 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Good catch, that seems wrong to me, and as you showed it is way too slow. UUIDGenerator should certainly not be reinitialised each time a UUID is needed. There have been other discussions about UUID in the past. > > /dev/urandom is not available on all platforms anyway, so alternatives might be useful. > > Like Stef said, the MongoDB part is out of our scope. > > Please make an issue (about the #makeSeed itself). > > > On 23 Jul 2015, at 13:31, stepharo <stepharo(a)free.fr> wrote: > > > > Hi holger > > > > Esteban is on vacation and I do not who is another manager of the mongo repo. > > > > Stef > > > > Le 23/7/15 12:23, Holger Freyther a Ã©crit : > >> Hi, > >> > >> I wanted to benchmark some look-ups with VoyageMongo and tried to insert > >> some dummy objects and it was quite slow (pharo takes 99% CPU and mongo > >> is idle). Using the nice profiler i noticed that VOMongoRepository>>#newVersion > >> calls UUIDGenerator new makeSeed which will take quite long. > >> > >> > >> [UUIDGenerator new makeSeed] bench '96.9 per second.â > >> > >> I am running this on OSX so it will end up in >>#makeUnixSeed which will open > >> /dev/urandom. I needed cryptographic random numbers in another project and > >> used NativeBoost to call into libcrypto of OpenSSL and use the RAND_bytes > >> function to get them. > >> > >> > >> [ (RAND rand: 4) asInteger ] bench '588,000 per second.â > >> > >> > >> The quality of the random numbers should be comparable and now I wonder how > >> I can help integrating such a change. > >> > >> From my point of view I can either patch Voyage-Mongo-Core to be able to > >> use other random number sources. Or I could add another âseedâ source to > >> the UUIDGenerator. What would be the preferred approach and how to move > >> forward? Is NativeBoost something one could rely on in upcoming Pharo versions? > >> > >> For a simple insertion of a class with a couple (~5) fields the insertion time for > >> 1000 items goes from ~10s to ~250ms. > >> > >> How can I move this forward? > >> > >> holger > >> > > > > > > >

July 23, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50185 Home: https://github.com/pharo-project/pharo-core

July 23, 2015

[pharo-project/pharo-core] 0b9579: 50185

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 0b9579f675973cc853a70b4afeefeb4cf0d4503f https://github.com/pharo-project/pharo-core/commit/0b9579f675973cc853a70b4a… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-07-23 (Thu, 23 Jul 2015) Changed paths: A BaselineOfQualityAssistant.package/BaselineOfQualityAssistant.class/README.md A BaselineOfQualityAssistant.package/BaselineOfQualityAssistant.class/definition.st A BaselineOfQualityAssistant.package/BaselineOfQualityAssistant.class/instance/api projectSpec/baseline_.st A BaselineOfQualityAssistant.package/BaselineOfQualityAssistant.class/instance/pre-post-load-do-its/installPlugin.st A BaselineOfRenraku.package/BaselineOfRenraku.class/README.md A BaselineOfRenraku.package/BaselineOfRenraku.class/definition.st A BaselineOfRenraku.package/BaselineOfRenraku.class/instance/baseline/baseline_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/README.md A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/class/catalog/catalogChangeLog.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/class/catalog/catalogContactInfo.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/class/catalog/catalogDescription.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/class/catalog/catalogKeyClassesAndExample.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/class/catalog/catalogKeywords.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/definition.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/symbolic versions/development_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/symbolic versions/stable_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/pre1%5F2%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F1%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F1%5F1_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F1%5F2_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F2%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F2%5F1_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F2%5F2_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F2%5F3_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F2%5F4_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F2%5F5_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F3%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F4%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F4%5F1_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F4%5F2_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F5%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F5%5F1_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F6%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v0%5F6%5F1_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v1%5F0%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v1%5F1%5F0_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v1%5F1%5F1_.st A QualityAssistant.package/NonfocusablePluggableIconListMorph.class/README.md A QualityAssistant.package/NonfocusablePluggableIconListMorph.class/definition.st A QualityAssistant.package/NonfocusablePluggableIconListMorph.class/instance/event handling/takesKeyboardFocus.st A QualityAssistant.package/QualityAssistantPlugin.class/README.md A QualityAssistant.package/QualityAssistantPlugin.class/class/display/pluginName.st A QualityAssistant.package/QualityAssistantPlugin.class/class/information/possiblePositions.st A QualityAssistant.package/QualityAssistantPlugin.class/class/installing/install.st A QualityAssistant.package/QualityAssistantPlugin.class/class/installing/uninstall.st A QualityAssistant.package/QualityAssistantPlugin.class/class/position/defaultPosition.st A QualityAssistant.package/QualityAssistantPlugin.class/definition.st A QualityAssistant.package/QualityAssistantPlugin.class/instance/announcement handling/selectionChanged_.st A QualityAssistant.package/QualityAssistantPlugin.class/instance/announcement handling/updateMorph.st A QualityAssistant.package/QualityAssistantPlugin.class/instance/display/display.st A QualityAssistant.package/QualityAssistantPlugin.class/instance/initialization/initialize.st A QualityAssistant.package/QualityAssistantPlugin.class/instance/interaction delegation/criticSelected_.st A QualityAssistant.package/QualityAssistantPlugin.class/instance/properties/currentEntity.st A QualityAssistant.package/QualityAssistantPlugin.class/instance/registration/registerTo_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/README.md A QualityAssistant.package/QualityAssistantPluginMorph.class/definition.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/accessing/adoptPaneColor_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/accessing/entity.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/accessing/entity_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/accessing/pluginDelegate.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/accessing/pluginDelegate_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/actions/fixAutomatically_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/actions/guardedReportUseless_andRemove_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/actions/reportUseless_andRemove_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/actions/revalidateEntity.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/actions/updateList.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/announcement handling/qualityChanged_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/confirmation-dialog/buildConfirmationCheckbox_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/confirmation-dialog/buildConfirmationHeader_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/confirmation-dialog/buildConfirmationMessage_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/initialization/createButton.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/initialization/initialize.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/initialization/initializeList.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/initialization/initializeProgress.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/initialization/initializeUpdateTask.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/list-morph/allowToSelect.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/list-morph/getCritics.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/list-morph/iconFor_at_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/list-morph/iconMaxSize.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/list-morph/selected_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/listLine-morph/autofixButtonFor_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/listLine-morph/displayCritic_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/listLine-morph/infoButtonFor_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/listLine-morph/skipButtonFor_.st A QualityAssistant.package/QualityAssistantPluginMorph.class/instance/listLine-morph/uselessButtonFor_.st A QualityAssistant.package/QualityAssistantSettings.class/README.md A QualityAssistant.package/QualityAssistantSettings.class/class/accessing/reportWithoutAsking.st A QualityAssistant.package/QualityAssistantSettings.class/class/accessing/reportWithoutAsking_.st A QualityAssistant.package/QualityAssistantSettings.class/class/settings/reportWithoutAskingSettingOn_.st A QualityAssistant.package/QualityAssistantSettings.class/definition.st A QualityAssistant.package/extension/CompiledMethod/instance/gtInspectorCriticsIn_.st A QualityAssistant.package/extension/CompiledMethod/instance/guidedSkip_.st A QualityAssistant.package/extension/CompiledMethod/instance/spotterQACriticsFor_.st A QualityAssistant.package/extension/ReCritic/instance/gtInspectorDescriptionIn_.st A QualityAssistant.package/extension/ReCritic/instance/gtInspectorSourceCodeIn_.st A QualityAssistant.package/extension/ReCritic/instance/guidedSkip.st A QualityAssistant.package/extension/ReCritic/instance/icon.st A QualityAssistant.package/extension/ReCritic/instance/popDescriptionUp.st A QualityAssistant.package/extension/ReCritic/instance/spotterPreviewCodeIn_.st A QualityAssistant.package/extension/ReCritic/instance/spotterPreviewRationaleIn_.st A QualityAssistant.package/extension/TBehavior/instance/gtInspectorCriticsIn_.st A QualityAssistant.package/extension/TBehavior/instance/guidedSkip_.st A QualityAssistant.package/extension/TBehavior/instance/spotterQACriticsFor_.st A QualityAssistant.package/extension/ThemeIcons/instance/repairIcon.st A QualityAssistant.package/extension/ThemeIcons/instance/repairIconContents.st A QualityAssistant.package/extension/ThemeIcons/instance/smallInformationIcon.st A QualityAssistant.package/extension/ThemeIcons/instance/smallQAIcon.st A QualityAssistant.package/extension/ThemeIcons/instance/smallQAIconContents.st A Renraku-Test.package/ReCriticTest.class/README.md A Renraku-Test.package/ReCriticTest.class/definition.st A Renraku-Test.package/ReCriticTest.class/instance/tests/testDescription.st A Renraku-Test.package/ReCriticTest.class/instance/tests/testIsAutoFixable.st A Renraku-Test.package/ReCriticTest.class/instance/tests/testRule.st A Renraku-Test.package/ReCriticTest.class/instance/tests/testSkip.st A Renraku-Test.package/ReCriticTest.class/instance/tests/testSkip1.st A Renraku-Test.package/ReCriticTest.class/instance/tests/testTarget.st A Renraku-Test.package/ReCriticTest.class/instance/tests/testTitle.st A Renraku-Test.package/RenrakuBaseTestCase.class/README.md A Renraku-Test.package/RenrakuBaseTestCase.class/definition.st A Renraku-Test.package/RenrakuBaseTestCase.class/instance/running/setUp.st A Renraku-Test.package/RenrakuBaseTestCase.class/instance/running/tearDown.st A Renraku-Test.package/RenrakuTest.class/README.md A Renraku-Test.package/RenrakuTest.class/definition.st A Renraku-Test.package/RenrakuTest.class/instance/tests/testNoClassComment.st A Renraku-Test.package/RenrakuTest.class/instance/tests/testSkip.st A Renraku-Test.package/RenrakuTest.class/instance/tests/testSkip1.st A Renraku-Test.package/RenrakuTest.class/instance/tests/testSkip2.st A Renraku-Test.package/RenrakuTest.class/instance/tests/testUnclassifiedMethod.st A Renraku-Test.package/RenrakuTest.class/instance/tests/testUnusedVar.st A Renraku.package/ReComplainer.class/README.md A Renraku.package/ReComplainer.class/class/actions/complainAbout_.st A Renraku.package/ReComplainer.class/class/properties/uuid.st A Renraku.package/ReComplainer.class/definition.st A Renraku.package/ReCritic.class/README.md A Renraku.package/ReCritic.class/class/instance creation/for_by_.st A Renraku.package/ReCritic.class/class/instance creation/for_by_at_.st A Renraku.package/ReCritic.class/definition.st A Renraku.package/ReCritic.class/instance/accessing/description.st A Renraku.package/ReCritic.class/instance/accessing/rule.st A Renraku.package/ReCritic.class/instance/accessing/selection.st A Renraku.package/ReCritic.class/instance/accessing/target.st A Renraku.package/ReCritic.class/instance/accessing/title.st A Renraku.package/ReCritic.class/instance/actions/fixAutomatically.st A Renraku.package/ReCritic.class/instance/actions/reportUselessness.st A Renraku.package/ReCritic.class/instance/actions/skip.st A Renraku.package/ReCritic.class/instance/actions/suggestedCode.st A Renraku.package/ReCritic.class/instance/initialization/initializeRule_target_.st A Renraku.package/ReCritic.class/instance/initialization/initializeRule_target_selection_.st A Renraku.package/ReCritic.class/instance/properties/hasSelection.st A Renraku.package/ReCritic.class/instance/properties/isAutofixable.st A Renraku.package/ReEngine.class/README.md A Renraku.package/ReEngine.class/class/class initialization/initialize.st A Renraku.package/ReEngine.class/class/instance creation/uniqueInstance.st A Renraku.package/ReEngine.class/definition.st A Renraku.package/ReEngine.class/instance/accessing/rules.st A Renraku.package/ReEngine.class/instance/actions/resetCriticCache_.st A Renraku.package/ReEngine.class/instance/announcement handling/classCommented_.st A Renraku.package/ReEngine.class/instance/announcement handling/classDefinitionModified_.st A Renraku.package/ReEngine.class/instance/announcement handling/classModified_.st A Renraku.package/ReEngine.class/instance/announcement handling/methodModified_.st A Renraku.package/ReEngine.class/instance/announcement handling/methodRecategorized_.st A Renraku.package/ReEngine.class/instance/initialization/initialize.st A Renraku.package/ReEngine.class/instance/initialization/subscribe.st A Renraku.package/ReEngine.class/instance/initialization/unSubscribe.st A Renraku.package/ReQualityChanged.class/README.md A Renraku.package/ReQualityChanged.class/class/instance creation/of_.st A Renraku.package/ReQualityChanged.class/definition.st A Renraku.package/ReQualityChanged.class/instance/accessing/entity.st A Renraku.package/ReQualityChanged.class/instance/accessing/entity_.st A Renraku.package/extension/CompiledMethod/instance/cachedCritics.st A Renraku.package/extension/CompiledMethod/instance/critics.st A Renraku.package/extension/CompiledMethod/instance/skip_.st A Renraku.package/extension/CompiledMethod/instance/wipeCritics.st A Renraku.package/extension/RBTransformationRule/instance/suggestedCode_.st A Renraku.package/extension/SystemAnnouncer/instance/qualityChanged_.st A Renraku.package/extension/TBehavior/instance/cachedCritics.st A Renraku.package/extension/TBehavior/instance/critics.st A Renraku.package/extension/TBehavior/instance/skip_.st A Renraku.package/extension/TBehavior/instance/wipeCritics.st A Renraku.package/extension/TheManifestBuilder/instance/skipRule_for_.st A Renraku.package/extension/TheManifestBuilder/instance/skipsRule_for_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50184.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50185.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50184.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50185.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50185 15957 QualityAssistant integration https://pharo.fogbugz.com/f/cases/15957 http://files.pharo.org/image/50/50185.zip

July 23, 2015

Re: [Pharo-dev] Contributing to VoyageMongo (improving insertion/updating speed)

by Holger Freyther

> On 23 Jul 2015, at 16:13, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > Why it doesn't use ==UUIDGenerator default== like UUID new does? >>#newVersion generates a timestamp/version for the serialized object. I think >>#newSeed is abused as on Unix platforms it can provide a somehow cryptographically secure random number. > [ UUIDGenerator new makeSeed ] bench. "'1,344 per secondâ" But you can even have /dev/urandom block if you read too much. So trying to use RAND_bytes appears to be a good idea.

July 23, 2015

Re: [Pharo-dev] Contributing to VoyageMongo (improving insertion/updating speed)

by Peter UhnÃ¡k

Why it doesn't use ==UUIDGenerator default== like UUID new does? (I am running on Linux, not OS X so times are not directly comparable with Holger's) ~~~~~~~~~~~~~~~~~ [ UUIDGenerator new makeSeed ] bench. "'1,344 per second'" [ UUID new ] bench. "'15,794 per second'" ~~~~~~~~~~~~~~~~~ On another note...the performance for UUID is still terrible compared to languages like Ruby: ~~~~~~~~~~~~ require 'benchmark' require 'securerandom' n = 1000000 time = Benchmark.realtime do n.times do ; SecureRandom.uuid; end end puts "#{n/time} times per second" ~~~~~~~~~~~~~~ "142164.93834009714 times per second" (tenfold improvement) Pharo's implementation is for whatever reason really complex, generating the bytes several times, assigning finals bits one by one, etc. Peter On Thu, Jul 23, 2015 at 1:42 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Good catch, that seems wrong to me, and as you showed it is way too slow. > UUIDGenerator should certainly not be reinitialised each time a UUID is > needed. There have been other discussions about UUID in the past. > > /dev/urandom is not available on all platforms anyway, so alternatives > might be useful. > > Like Stef said, the MongoDB part is out of our scope. > > Please make an issue (about the #makeSeed itself). > > > On 23 Jul 2015, at 13:31, stepharo <stepharo(a)free.fr> wrote: > > > > Hi holger > > > > Esteban is on vacation and I do not who is another manager of the mongo > repo. > > > > Stef > > > > Le 23/7/15 12:23, Holger Freyther a Ã©crit : > >> Hi, > >> > >> I wanted to benchmark some look-ups with VoyageMongo and tried to insert > >> some dummy objects and it was quite slow (pharo takes 99% CPU and mongo > >> is idle). Using the nice profiler i noticed that > VOMongoRepository>>#newVersion > >> calls UUIDGenerator new makeSeed which will take quite long. > >> > >> > >> [UUIDGenerator new makeSeed] bench '96.9 per second.â > >> > >> I am running this on OSX so it will end up in >>#makeUnixSeed which > will open > >> /dev/urandom. I needed cryptographic random numbers in another project > and > >> used NativeBoost to call into libcrypto of OpenSSL and use the > RAND_bytes > >> function to get them. > >> > >> > >> [ (RAND rand: 4) asInteger ] bench '588,000 per second.â > >> > >> > >> The quality of the random numbers should be comparable and now I wonder > how > >> I can help integrating such a change. > >> > >> From my point of view I can either patch Voyage-Mongo-Core to be able to > >> use other random number sources. Or I could add another âseedâ source to > >> the UUIDGenerator. What would be the preferred approach and how to move > >> forward? Is NativeBoost something one could rely on in upcoming Pharo > versions? > >> > >> For a simple insertion of a class with a couple (~5) fields the > insertion time for > >> 1000 items goes from ~10s to ~250ms. > >> > >> How can I move this forward? > >> > >> holger > >> > > > > > > >

July 23, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50184 Home: https://github.com/pharo-project/pharo-core

July 23, 2015

[pharo-project/pharo-core] 9631c2: 50184

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 9631c2b9763bfbc9b721a709ad441fd7f24d776a https://github.com/pharo-project/pharo-core/commit/9631c2b9763bfbc9b721a709… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-07-23 (Thu, 23 Jul 2015) Changed paths: M Nautilus.package/AbstractNautilusUI.class/instance/menus behavior/renamePackage.st A Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/as yet unclassified/tearDown.st A Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tests - links/testSetLinkWithPragmaOptions.st A Reflectivity-Tests.package/ReflectivityExamples.class/instance/examples/exampleMethodWithMetaLinkOptions.st A Reflectivity.package/MetaLink.class/instance/accessing/metaLinkOptions_.st M Reflectivity.package/MetaLink.class/instance/installing/installOn_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50183.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50184.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50183.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50184.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st R Tool-Base.package/AbstractTool.class/instance/package/renamePackages_.st Log Message: ----------- 50184 16008 simplify AbstractTool>>renamePackages: https://pharo.fogbugz.com/f/cases/16008 16012 parse link option from method pragma https://pharo.fogbugz.com/f/cases/16012 http://files.pharo.org/image/50/50184.zip

July 23, 2015