May 2015 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] 777bd6: 40612

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 777bd6f3f91181471260b237078a30e049093b00 https://github.com/pharo-project/pharo-core/commit/777bd6f3f91181471260b237… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-05-04 (Mon, 04 May 2015) Changed paths: A FileSystem-Core.package/AbstractFileReference.class/instance/accessing/basenameWithoutExtension_.st A FileSystem-Core.package/Path.class/instance/accessing/basenameWithoutExtension_.st M FileSystem-Tests-Core.package/FileReferenceTest.class/instance/tests/testBasenameWithoutExtension.st M FileSystem-Tests-Core.package/PathTest.class/instance/tests/testBasenameWithoutExtension.st M Morphic-Core.package/WorldState.class/class/world menu items/saveAs.st M SUnit-UI.package/TestRunner.class/instance/accessing-ui/buttons.st M SUnit-UI.package/TestRunner.class/instance/actions/collectCoverageFor_.st R ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script611.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script612.st R ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40611.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40612.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40612 15417 TestRunner does not offer the RunCoverage functionality https://pharo.fogbugz.com/f/cases/15417 15322 "Save As" does not properly save filenames with dots in them https://pharo.fogbugz.com/f/cases/15322 http://files.pharo.org/image/40/40612.zip

May 4, 2015

Re: [Pharo-dev] TxSpan>>#isAtEnd

by Stephan Eggermont

On 04/05/15 05:43, Sean P. DeNigris wrote: > All tests pass with this change, but I'm still very much beginning learning > Tx, so I wanted to run it by everyone to see if I'm missing something... What would need to change with a circular list? Stephan

May 4, 2015

Re: [Pharo-dev] MC: Strange Problem

by Thierry Goubier

Hi Sean, can you point me towards one of those corrupt versions? Maybe there is something to check inside the package itself. Thierry 2015-05-04 7:36 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: > Okay, I'm still not sure how it happened, but I realized v. 48 and 49 were > also corrupt. Rebased off of v. 47. > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/MC-Strange-Problem-tp4824138p4824142.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

May 4, 2015

Re: [Pharo-dev] Improving the About Text of Versionner

by Nicolai Hess

2015-05-04 8:15 GMT+02:00 Ben Coman <btc(a)openinworld.com>: > > On Mon, May 4, 2015 at 11:32 AM, Sean P. DeNigris <sean(a)clipperadams.com> > wrote: > >> Sean P. DeNigris wrote >> > We have two kinds of external projects in Pharo: >> >> Please don't be discouraged! By chance, you stepped into the absolute the >> worst-case scenario. Thankfully, many issues are much easier to integrate >> :) >> >> > This is one reason newcomers are valuable. For any system you work with > for a while, you unconciously step over the wobbly stones in the path > without noticing them. > cheers -ben > I changed the issue title 15480 <https://pharo.fogbugz.com/default.asp?15480> Improving the About information (WindowModel) and added 15482 <https://pharo.fogbugz.com/default.asp?15482> Improving the About information (VersionnerSpecBrowser) So, that we have now two bug entries, one for the change in specs about window title handling and one for the change in Versionner. Who can move and commit sergios change to the versionner repro?

May 4, 2015

Re: [Pharo-dev] New Versionner Tool and Authentication

by Esteban Lorenzano

damnâ¦ can you check if this method looks like this? VSCommitAction>>#commitPackage: packageName comment: comment | remoteRepository version | remoteRepository := self remoteRepository. version := self workingCopy newVersionWithMessage: comment in: remoteRepository. self retryOnCredentialRequest: [ remoteRepository storeVersion: version ] > On 04 May 2015, at 07:06, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > EstebanLM wrote >> should be fixed if you install bleedingEdgeâ¦ > > I installed #bleedingEdge but it is still happening :/ > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/New-Versionner-Tool-and-Authentication-tp4824032p4824… > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

May 4, 2015

Re: [Pharo-dev] Improving the About Text of Versionner

by Ben Coman

On Mon, May 4, 2015 at 11:32 AM, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > Sean P. DeNigris wrote > > We have two kinds of external projects in Pharo: > > Please don't be discouraged! By chance, you stepped into the absolute the > worst-case scenario. Thankfully, many issues are much easier to integrate > :) > > This is one reason newcomers are valuable. For any system you work with for a while, you unconciously step over the wobbly stones in the path without noticing them. cheers -ben

May 4, 2015

Re: [Pharo-dev] Where to start contributing

by Ben Coman

On Mon, May 4, 2015 at 8:27 AM, Sergio Fedi <sergio.fedi(a)gmail.com> wrote: > @Cyril > I tried to do what you suggested, but the amount of cases to resolve is > huge, I'm quite lost on where to begin, and most of them I don't understand > how to solve them > > @Ben > Which ones do you suggest I should begin reviewing? > Any and all that turn up under the "Fixed To review" filter on Fogbugz, from the pull down menu on the <Cases> buttons. > How do I do that reviewing you suggest? > > 1. From the issue description, reproduce the original problem. If there is not sufficient information to do that, ask for clarificationon the issue. Sometimes the person who logs the issue already has a fix and so the desciption to reproduce is limited, but its good to pin down for historical purposes (I've hit some opaque ones tracking down introduced regressions before) 2. Filter on the Pharo5Inbox for the issue number then <Merge> the slice. 3. Report your opinion on the issue being fixed, or other problems introduced. 4. Over time as you feel comfortable, comment on the source code quality/conventions/etc... cheers -ben

May 4, 2015

Re: [Pharo-dev] Beyond resolving a case

by Ben Coman

On Mon, May 4, 2015 at 8:23 AM, Sergio Fedi <sergio.fedi(a)gmail.com> wrote: > How do we state and/or document that further work is needed after a Case? > If there are specific tasks you are already sure should be done, just open another ticket. If your not sure, discussion is best on the mail list - you'll get more opinions :). btw, If you reference your original case like "Case 12345" you'll get a hotlink to it. > > For example, some things I had in mind after finishing this case: > > *While adding the About comment for the Versionner tool I've found that > the About should be modeled (at least to encapsulate the about text and the > about window title, but maybe also for other information such as the > purpose of the tool, the author, external link, further reading, etc).* > > *Should we generate a test for this About behaviour ?* > Probably, but I'm not sure of the convetions for gui testing. Maybe some sub parts. > > *Should we move the About functionality up in the hierarchy and integrate > it more with the classes used to make Tools?* > Note sure. I haven't had a chance to look at it yet -- but this reminds me that I've seen several places where the class comment is copied to an About window. Avoids having to synchronise. Would that be compatible with your implementation? Although probably there are times when the class comment is too much for and About. Maybe it defaults to the class comment - which means we get some About information for free, and maybe a convention to identify and <about>me</about> part of the class comment ? > *I added a method that answers the tool name (as opposed to the tool class > name, usually used in the About title)* > *and I found out there was another implementor on another Tool, but which > I didn't understand the relationship with the Versionner.* > *Is there something that could be done? Maybe make an abstract method?* > Not that I'll know the answer, but it would help to be more specific about the other method. > > *Is there a place where to put all these comments and > questions/comments/ramblings?* > *If there is, where?* > These are probably best to start on the mail list. Then copy pertinant parts to any issues created. cheers -ben

May 4, 2015

Re: [Pharo-dev] MC: Strange Problem

by Sean P. DeNigris

Okay, I'm still not sure how it happened, but I realized v. 48 and 49 were also corrupt. Rebased off of v. 47. ----- Cheers, Sean -- View this message in context: http://forum.world.st/MC-Strange-Problem-tp4824138p4824142.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

May 4, 2015

MC: Strange Problem

by Sean P. DeNigris

I don't know how to describe it. Here is a screenshot from the MC browser showing part of it. I adopted a version from Pharo/TxText and this is what appeared instead of the package name: <http://forum.world.st/file/n4824138/Screenshot_2015-05-04_01.png> I thought maybe it didn't matter, but it really screws up the history, which now shows everything has changed since the previous version (but I only added a version and bumped #stable) ----- Cheers, Sean -- View this message in context: http://forum.world.st/MC-Strange-Problem-tp4824138.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

May 4, 2015