April 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [Moose-dev] QualityAssistant v0.4

by stepharo

Yuriy this is excellent because it will force us to have - better rules - rules with as many as automatic transformations as possible :) Excellent job. Stef

April 22, 2015

[pharo-project/pharo-core] bd8aef: 50004

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: bd8aef00a052613d0e0d41065e9d85ee42cf05c8 https://github.com/pharo-project/pharo-core/commit/bd8aef00a052613d0e0d4106… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-04-22 (Wed, 22 Apr 2015) Changed paths: M MonticelloGUI.package/MCConfigurationBrowser.class/class/opening/open.st M MonticelloGUI.package/MCWorkingCopyBrowser.class/class/instance creation/open.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script612.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script613.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50003.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50004.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M StartupPreferences.package/StartupPreferencesLoader.class/class/example/example.st M StartupPreferences.package/StartupPreferencesLoader.class/instance/private/buildStreamFor_.st M Tool-ConfigurationBrowser.package/MetacelloConfigurationBrowserPane.class/class/defaults/defaultAvailableRepositories.st M Tool-ConfigurationBrowser.package/MetacelloConfigurationBrowserPane.class/class/example/example.st A Tool-ConfigurationBrowser.package/MetacelloConfigurationBrowserPane.class/class/initialization/reset.st Log Message: ----------- 50004 15377 StartupLoader leftovers in StartupPreferencesLoader https://pharo.fogbugz.com/f/cases/15377 15354 Add <script> to #open in Monticello tools https://pharo.fogbugz.com/f/cases/15354 15355 Add MetaRepo for Pharo 40 in 5.0 config browser, also fix example method https://pharo.fogbugz.com/f/cases/15355 http://files.pharo.org/image/50/50004.zip

April 22, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50004 Home: https://github.com/pharo-project/pharo-core

April 22, 2015

Re: [Pharo-dev] [Pharo-users] QualityAssistant v0.4

by Cyril Ferlicot

Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :) On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > Good point, this brings up two problems. > > 1) The rule can improve detection by checking the type is the message is > sent to self > 2) Automatic fixing should display the changes and letting you decide > whether you want to apply them. > > 1st will take some time. 2nd will be soon in QA :) > > Uko > > > On 22 Apr 2015, at 16:33, Johan Fabry <jfabry(a)dcc.uchile.cl> wrote: > > Some weird behavior in quality assistant. Have a look at this method: > > duplicateVar: aVarName > > self show: 'Var: ', aVarName, ' redefinition ignored'. > > This raises the issue: âUse cascaded nextPutAll:âs instead of #, in > nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it > to see how it would transform the code. Result: > > duplicateVar: aVarName > self > show: 'Var: ' , aVarName; > show: ' redefinition ignored' > > Needless to say, thatâs not a behavior preserving transformation. > > > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Please give me a feedback about your experience, as I want to make it even > more useful. Either write me an email, or open an entry at: > https://github.com/Uko/QualityAssistant/issues > > > > > ---> Save our in-boxes! http://emailcharter.org <--- > > Johan Fabry - http://pleiad.cl/~jfabry > PLEIAD lab - Computer Science Department (DCC) - University of Chile > > -- Cheers Cyril Ferlicot

April 22, 2015

Re: [Pharo-dev] [Zinc, ZnPercentEncoder] problem encoding accents

by Sven Van Caekenberghe

Leo, I am sorry but you will have to be more specific and concrete. You are mixing lots of different things (encoding/decoding, form submit, JS - and there are details missing) - there are many places where you could have done something wrong. Please try to isolate your problem with a concrete short piece of code that I can run. Something along the lines of ZnDefaultServerDelegate>>formTest[1|2|3]: maybe. Sven > On 22 Apr 2015, at 15:46, Leo <lpaniceres(a)gmail.com> wrote: > > Sven > I saw the tests and they works fine. > The problem is on the field. > I have a form with javascript that gets addresses from Google Maps, then the form is submitted to my Pharo-Zinc-App. > When the form is submitted by Safari(OS X), Smalltalks receives the character with accent without encoding (no %). > Continuing with the Neuquen example, the 'accented eâ that should be %C3%A9 is received as the raw character. > With Firefox all works fine, the character is received with the correct encoding. > > So the problem is related to âdecode:â > In the research I also saw that some accented characters could be received as one character encoded, for example the 'accented eâ could be also %E9. > > thanks > Leo > > > > > >> El 21/4/2015, a las 18:26, pharo-dev-request(a)lists.pharo.org escribiÃ³: >> >> Date: Tue, 21 Apr 2015 22:59:52 +0200 >> From: Sven Van Caekenberghe <sven(a)stfx.eu> >> To: Pharo Development List <pharo-dev(a)lists.pharo.org> >> Subject: Re: [Pharo-dev] [Zinc, ZnPercentEncoder] problem encoding >> accents >> Message-ID: <D819757B-96B3-4067-AC1F-9A8AD332456E(a)stfx.eu> >> Content-Type: text/plain; charset=utf-8 >> >> Leo, >> >> Are you sure you understand what percent encoding is ? >> >> Check the class comment of ZnPercentEncoding, it has links to a Wikipedia article. >> >> Did you see ZnPercentEncoderTests ? >> >> Anyway, I would think this is what you want to do: >> >> ZnPercentEncoder new encode: 'Neuqu?n, Neuqu?n Province, Argentina'. >> >> => 'Neuqu%C3%A9n%2C%20Neuqu%C3%A9n%20Province%2C%20Argentina' >> >> ZnPercentEncoder new decode: 'Neuqu%C3%A9n%2C%20Neuqu%C3%A9n%20Province%2C%20Argentina'. >> >> => 'Neuqu?n, Neuqu?n Province, Argentina' >> >> Seems to work fine, no ? >> >> What problem do you have with ZnUrl ? >> >> Sven >

April 22, 2015

Re: [Pharo-dev] [Pharo-users] QualityAssistant v0.4

by Yuriy Tymchuk

Good point, this brings up two problems. 1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them. 1st will take some time. 2nd will be soon in QA :) Uko > On 22 Apr 2015, at 16:33, Johan Fabry <jfabry(a)dcc.uchile.cl> wrote: > > Some weird behavior in quality assistant. Have a look at this method: > > duplicateVar: aVarName > > self show: 'Var: ', aVarName, ' redefinition ignored'. > > This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result: > > duplicateVar: aVarName > self > show: 'Var: ' , aVarName; > show: ' redefinition ignored' > > Needless to say, thatâs not a behavior preserving transformation. > > >> On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: >> >> Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues> > > > ---> Save our in-boxes! http://emailcharter.org <http://emailcharter.org/> <--- > > Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/~jfabry> > PLEIAD lab - Computer Science Department (DCC) - University of Chile >

April 22, 2015

Re: [Pharo-dev] [Pharo-users] QualityAssistant v0.4

by Johan Fabry

Some weird behavior in quality assistant. Have a look at this method: duplicateVar: aVarName self show: 'Var: ', aVarName, ' redefinition ignored'. This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result: duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored' Needless to say, thatâs not a behavior preserving transformation. > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues> ---> Save our in-boxes! http://emailcharter.org <--- Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile

April 22, 2015

Re: [Pharo-dev] [Moose-dev] QualityAssistant v0.4

by Yuriy Tymchuk

> On 22 Apr 2015, at 15:59, Johan Fabry <jfabry(a)dcc.uchile.cl> wrote: > > Hola, > > It looks like a really cool tool! I just added it to my LRP development image and I plan on using it full time. I am always interested in writing cleaner code. Thanks :) > > So expect comments from me :-) Actually I already have one: > > For one class I got the critic âReferences an abstract classâ and 'Subclass responsibility not definedâ. Excellent that you found it, but now I have to go through all the methods of the class to see where the first critic comes from, and through all methods of all leaf classes for the second one. :-( :-( :-( Thatâs a lot of work for me to rescue some information which apparently the tool already knows. Please add more information on where the issue is on these kinds of errors, so I can fix them more easily â¦ Yes, this is the major issue with SmallLint. If you are interested in details here it goes: for example "References an abstract classâ is defined to work on a class, and itâs definitely easier to check whether the class is abstract and has any references than taking a method getting all class references and checking is any class is abstract. But as the result you get a critic about the class and not about the methods that access it. Right now Iâm analyzing Small Lint rules to see what issues they have and understanding how to approach the problem. Maybe some temporary hack will be possible for certain rules, otherwise it will be fixed when I get to improving the Small Lint. Nevertheless your feedback is very important, as I get to know what the real issues are. Cheers, Uko > > Thanks and keep up the good work! > >> On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: >> >> Hi everyone! >> >> Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter. >> >> Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects. >> >> Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code. >> >> Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues> >> >> Have a nice week! >> Uko >> >> <critics.jpg> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > > ---> Save our in-boxes! http://emailcharter.org <http://emailcharter.org/> <--- > > Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/~jfabry> > PLEIAD lab - Computer Science Department (DCC) - University of Chile >

April 22, 2015

Re: [Pharo-dev] [Moose-dev] QualityAssistant v0.4

by Johan Fabry

Hola, It looks like a really cool tool! I just added it to my LRP development image and I plan on using it full time. I am always interested in writing cleaner code. So expect comments from me :-) Actually I already have one: For one class I got the critic âReferences an abstract classâ and 'Subclass responsibility not definedâ. Excellent that you found it, but now I have to go through all the methods of the class to see where the first critic comes from, and through all methods of all leaf classes for the second one. :-( :-( :-( Thatâs a lot of work for me to rescue some information which apparently the tool already knows. Please add more information on where the issue is on these kinds of errors, so I can fix them more easily ... Thanks and keep up the good work! > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Hi everyone! > > Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter. > > Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects. > > Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code. > > Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues> > > Have a nice week! > Uko > > <critics.jpg> > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev ---> Save our in-boxes! http://emailcharter.org <--- Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile

April 22, 2015

Re: [Pharo-dev] [Zinc, ZnPercentEncoder] problem encoding accents

by Leo

Sven I saw the tests and they works fine. The problem is on the field. I have a form with javascript that gets addresses from Google Maps, then the form is submitted to my Pharo-Zinc-App. When the form is submitted by Safari(OS X), Smalltalks receives the character with accent without encoding (no %). Continuing with the Neuquen example, the 'accented eâ that should be %C3%A9 is received as the raw character. With Firefox all works fine, the character is received with the correct encoding. So the problem is related to âdecode:â In the research I also saw that some accented characters could be received as one character encoded, for example the 'accented eâ could be also %E9. thanks Leo > El 21/4/2015, a las 18:26, pharo-dev-request(a)lists.pharo.org escribiÃ³: > > Date: Tue, 21 Apr 2015 22:59:52 +0200 > From: Sven Van Caekenberghe <sven(a)stfx.eu <mailto:sven@stfx.eu>> > To: Pharo Development List <pharo-dev(a)lists.pharo.org <mailto:pharo-dev@lists.pharo.org>> > Subject: Re: [Pharo-dev] [Zinc, ZnPercentEncoder] problem encoding > accents > Message-ID: <D819757B-96B3-4067-AC1F-9A8AD332456E(a)stfx.eu <mailto:D819757B-96B3-4067-AC1F-9A8AD332456E@stfx.eu>> > Content-Type: text/plain; charset=utf-8 > > Leo, > > Are you sure you understand what percent encoding is ? > > Check the class comment of ZnPercentEncoding, it has links to a Wikipedia article. > > Did you see ZnPercentEncoderTests ? > > Anyway, I would think this is what you want to do: > > ZnPercentEncoder new encode: 'Neuqu?n, Neuqu?n Province, Argentina'. > > => 'Neuqu%C3%A9n%2C%20Neuqu%C3%A9n%20Province%2C%20Argentina' > > ZnPercentEncoder new decode: 'Neuqu%C3%A9n%2C%20Neuqu%C3%A9n%20Province%2C%20Argentina'. > > => 'Neuqu?n, Neuqu?n Province, Argentina' > > Seems to work fine, no ? > > What problem do you have with ZnUrl ? > > Sven

April 22, 2015