April 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Please Review 15395 ASAP

by Nicolai Hess

+1 looks good 2015-04-24 19:42 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: > If someone can review this quickly, there are a ton of packages touched as > you can see below and I don't want to keep redoing the slice!!! > > Fix in inbox: SLICE-Issue-15395-Cleanup-1-SeanDeNigris.1 > > Various cleanups - most notable is applying the "a >= b and: [a <= c]" -> > "a > between: b and: c" everywhere; also fix typos in comments, etc. > > Dependencies: AsmJit-Extension-SeanDeNigris.9, > AsmJit-Operands-SeanDeNigris.15, Balloon-SeanDeNigris.119, > Collections-Native-SeanDeNigris.10, > Collections-Sequenceable-SeanDeNigris.193, > Collections-Streams-SeanDeNigris.169, FreeType-SeanDeNigris.698, > Graphics-Primitives-SeanDeNigris.158, Kernel-SeanDeNigris.2014, > Morphic-Widgets-List-SeanDeNigris.16, > Morphic-Widgets-Pluggable-SeanDeNigris.45, > Morphic-Widgets-Tree-SeanDeNigris.28, > Morphic-Widgets-Windows-SeanDeNigris.48, > Multilingual-OtherLanguages-SeanDeNigris.13, Network-UUID-SeanDeNigris.30, > RPackage-Core-SeanDeNigris.384, System-Platforms-SeanDeNigris.62, > System-Support-SeanDeNigris.1096, Text-Core-SeanDeNigris.32 > > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/Please-Review-15395-ASAP-tp4821695.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

April 24, 2015

Re: [Pharo-dev] SmalltalkImage>>#imageName

by Nicolai Hess

2015-04-24 19:26 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: > Peter UhnÃ¡k wrote > >> Only sender seems to be Spotter > > Its quite useful for startup scripts. > > Yes, but we have #imageFile fullName already... > And there is FileLocator image resolve > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/SmalltalkImage-imageName-tp4821681p4821692.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

April 24, 2015

Re: [Pharo-dev] Please Review 15395 ASAP

by Sean P. DeNigris

https://pharo.fogbugz.com/default.asp?15395 ----- Cheers, Sean -- View this message in context: http://forum.world.st/Please-Review-15395-ASAP-tp4821695p4821696.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2015

Please Review 15395 ASAP

by Sean P. DeNigris

If someone can review this quickly, there are a ton of packages touched as you can see below and I don't want to keep redoing the slice!!! Fix in inbox: SLICE-Issue-15395-Cleanup-1-SeanDeNigris.1 Various cleanups - most notable is applying the "a >= b and: [a <= c]" -> "a between: b and: c" everywhere; also fix typos in comments, etc. Dependencies: AsmJit-Extension-SeanDeNigris.9, AsmJit-Operands-SeanDeNigris.15, Balloon-SeanDeNigris.119, Collections-Native-SeanDeNigris.10, Collections-Sequenceable-SeanDeNigris.193, Collections-Streams-SeanDeNigris.169, FreeType-SeanDeNigris.698, Graphics-Primitives-SeanDeNigris.158, Kernel-SeanDeNigris.2014, Morphic-Widgets-List-SeanDeNigris.16, Morphic-Widgets-Pluggable-SeanDeNigris.45, Morphic-Widgets-Tree-SeanDeNigris.28, Morphic-Widgets-Windows-SeanDeNigris.48, Multilingual-OtherLanguages-SeanDeNigris.13, Network-UUID-SeanDeNigris.30, RPackage-Core-SeanDeNigris.384, System-Platforms-SeanDeNigris.62, System-Support-SeanDeNigris.1096, Text-Core-SeanDeNigris.32 ----- Cheers, Sean -- View this message in context: http://forum.world.st/Please-Review-15395-ASAP-tp4821695.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2015

Re: [Pharo-dev] Issue 15394: (Launcher) Safer Image Deletion

by Sean P. DeNigris

philippeback wrote > Why not 2 downloads? Easy to do. I'm not sure what you mean. I'm talking about deleting images from the left pane of Luancher via the button. ----- Cheers, Sean -- View this message in context: http://forum.world.st/Issue-15394-Launcher-Safer-Image-Deletion-tp4821635p4… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2015

Re: [Pharo-dev] SmalltalkImage>>#imageName

by Sean P. DeNigris

Peter UhnÃ¡k wrote >> Only sender seems to be Spotter > Its quite useful for startup scripts. Yes, but we have #imageFile fullName already... ----- Cheers, Sean -- View this message in context: http://forum.world.st/SmalltalkImage-imageName-tp4821681p4821692.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2015

Please, No Restate-the-selector Method Comments

by Sean P. DeNigris

I'd like to see the removal of comments like: StandardWindow>>#title "Answer tht window title." Here we have a comment that adds no value, but adds to the maintenance burden because there is a typo. ----- Cheers, Sean -- View this message in context: http://forum.world.st/Please-No-Restate-the-selector-Method-Comments-tp4821… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2015

Re: [Pharo-dev] Issue 15394: (Launcher) Safer Image Deletion

by phil＠highoctane.be

Le 24 avr. 2015 16:11, "Sean P. DeNigris" <sean(a)clipperadams.com> a Ã©crit : > > https://pharo.fogbugz.com/default.asp?15394 > > Especially as we move to push the launcher as the default download for new > users, this will be crucial. Right now, we are deleting via an `rm -fr` like > approach, which is quite harsh for a GUI tool, especially when deleting an > image, which is akin to an operating system. It would be better to remove > the confirmation dialog and move the image to the trash, with an undo if > possible. Why not 2 downloads? Easy to do. > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/Issue-15394-Launcher-Safer-Image-Deletion-tp4821635.h… > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

April 24, 2015

Re: [Pharo-dev] SmalltalkImage>>#imageName

by Peter UhnÃ¡k

+1 > Only sender seems to be Spotter Its quite useful for startup scripts. On Fri, Apr 24, 2015 at 6:23 PM, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > After a brief IRC chat, it seems like returning just the file base (i.e. > without the extension). Any objections before I open an issue? > > SeanDeNigris_: I found it surprising that `Smalltalk imageName` returns the > full path. Just me? > [11:34am] maxleske: ++ > [11:43am] SeanDeNigris_: Worth an issue? Only sender seems to be Spotter > [11:49am] DamienCassou: all these little things are annoying. So, +1 to > create an issue > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/SmalltalkImage-imageName-tp4821681.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

April 24, 2015

SmalltalkImage>>#imageName

by Sean P. DeNigris

After a brief IRC chat, it seems like returning just the file base (i.e. without the extension). Any objections before I open an issue? SeanDeNigris_: I found it surprising that `Smalltalk imageName` returns the full path. Just me? [11:34am] maxleske: ++ [11:43am] SeanDeNigris_: Worth an issue? Only sender seems to be Spotter [11:49am] DamienCassou: all these little things are annoying. So, +1 to create an issue ----- Cheers, Sean -- View this message in context: http://forum.world.st/SmalltalkImage-imageName-tp4821681.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2015