April 2015 - Pharo-dev - lists.pharo.org

[Reflectivity] tiny step: conditions for links

by Marcus Denker

Hi, Now with Pharo5 started, I will try to at least do a tiny increment regularly again on Reflectivity (and hopefully larger ones, too). Today: tiny fix: Link condition is working. The idea is that a meta link can have a condition which is compiled into the code. This tiny change makes it work again: testLinkWithCondition | sendNode link condition | condition := false. sendNode := (ReflectivityExamples>>#exampleMethod) ast body statements first value. link := MetaLink new condition: [condition]; metaObject: self; selector: #tagExec. sendNode link: link. self assert: sendNode hasMetalink. self assert: (ReflectivityExamples>>#exampleMethod) class = ReflectiveMethod. self assert: (tag isNil). self assert: (ReflectivityExamples new exampleMethod = 5). self assert: (tag isNil). condition := true. self assert: (ReflectivityExamples new exampleMethod = 5). self assert: (tag = #yes). This is fixed in #50017 (test is green). Next step: when *changing* the condition object (e.g. to true or false or a different block), we need to re-generate code. ==> we need #invalidate on the MetaLink and call it on #condition:. This is the next step for (hopefully) tomorrow. Marcus

April 28, 2015

Re: [Pharo-dev] [Issue tracker] what about old issues?

by Nicolai Hess

2015-04-28 17:44 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr>: > Hi, > > we have 666 open issues on the issue tracker. > > It seems that older issues do not get looked at muchâ¦ the question is what > to do: the more open issues we have, > the less likely they will ever be looked at. > > I would like to > > -> automatically put them on âclosed, timeoutâ > -> send a mail to the original submitter AND pharo-dev > +1 > > This way people can just re-open important issues, but those issues where > the submitter does not care > and nobody else, either, would be closed after one yearâ¦ > (This would e.g. include lots of issues that got fixed in the meantimeâ¦ or > non-important âit would be niceâ > issues, or those where nobody (eve the submitter) understands what this is > about anymoreâ¦) > > Marcus >

April 28, 2015

[Issue tracker] what about old issues?

by Marcus Denker

Hi, we have 666 open issues on the issue tracker. It seems that older issues do not get looked at muchâ¦ the question is what to do: the more open issues we have, the less likely they will ever be looked at. I would like to -> automatically put them on âclosed, timeoutâ -> send a mail to the original submitter AND pharo-dev This way people can just re-open important issues, but those issues where the submitter does not care and nobody else, either, would be closed after one yearâ¦ (This would e.g. include lots of issues that got fixed in the meantimeâ¦ or non-important âit would be niceâ issues, or those where nobody (eve the submitter) understands what this is about anymoreâ¦) Marcus

April 28, 2015

Re: [Pharo-dev] sometimes Shout changes the selection during styling

by Andrei Chis

Ok. I'll make a slice, at latest by tomorrow afternoon. Cheers, Andrei On Tue, Apr 28, 2015 at 4:45 PM, Ben Coman <btc(a)openinworld.com> wrote: > I was waiting for others to chime in, but they can do that on the issue > once code is there to review. I'd say its worth pushing it through to that > point at least. If you do it, I'll review and then we can call for a second > reviewer. > > Actually, semantically the following may be better... > > DelayWaitTimeout>>waitOnCompletion:onTimeout: > > called from... > > Semaphore>>waitTimeoutSeconds:onCompletion:onTimeout: > > cheers -ben > > > > On Tue, Apr 28, 2015 at 8:12 PM, Andrei Chis <chisvasileandrei(a)gmail.com> > wrote: > >> I made an issue: >> https://pharo.fogbugz.com/f/cases/15422/SHTextStyler-styleInBackgroundProce… >> >> Then do we add waitTimeoutSeconds:ifSignalled:ifTimedOut: to the >> Semaphore class? >> >> On Mon, Apr 27, 2015 at 6:33 PM, Andrei Chis <chisvasileandrei(a)gmail.com> >> wrote: >> >>> That would work for me. Styling the text if the process doing the >>> styling did not finish or is stuck does not feel as the right thing to do. >>> >>> On Mon, Apr 27, 2015 at 6:25 PM, Ben Coman <btc(a)openinworld.com> wrote: >>> >>>> >>>> >>>> On Mon, Apr 27, 2015 at 8:41 PM, Andrei Chis < >>>> chisvasileandrei(a)gmail.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> In the glamour debugger that we use in moose we are now having the >>>>> following problem: >>>>> - the selection of a PluggableTextMorph is, quite randomly , changed >>>>> during styling. >>>>> >>>>> If I revert the fix for issue 15240 >>>>> <https://pharo.fogbugz.com/f/cases/15240> then it works ok. >>>>> Also if I change in SHTextStyler>>#styleInBackgroundProcess: from >>>>> >>>>> sem waitTimeoutSeconds: 5. >>>>> view ifNotNil: [ view stylerStyledInBackground: text ] >>>>> >>>>> to: >>>>> >>>>> (sem waitTimeoutSeconds: 5) ifFalse: [ >>>>> view ifNotNil: [ view stylerStyledInBackground: text ] ] >>>>> >>>>> it works ok. In the second snippet we only do the styling if the >>>>> styler completed. >>>>> >>>>> >>>>> If I look at the senders of styleInBackgroundProcess: there is another >>>>> strange issue. >>>>> First PluggableTextMorph>>#setText: calls either style: >>>>> or styleInBackgroundProcess:, depending in the size of the text. >>>>> Then, PluggableTextMorph>>#setText: >>>>> calls PluggableTextMorph>>#setTextBasic:, which calls >>>>> PluggableTextMorph>>#hasUnacceptedEdits: which in turn >>>>> calls again styleInBackgroundProcess:. >>>>> So when you set the text if the size of the text is small Shout will >>>>> try to style the text with and without a background process. If you call >>>>> hasUnacceptedEdits: >>>>> manually when initializing the morph then three processes will be >>>>> started for doing the styling. >>>>> >>>>> Removing the calls to styleInBackgroundProcess: from >>>>> PluggableTextMorph>>#hasUnacceptedEdits: and >>>>> PluggableTextMorph>>#basicHasUnacceptedEdits:. >>>>> also solves the problem with the changing selection. >>>>> >>>>> Cheers, >>>>> Andrei >>>>> >>>> >>>> Perhaps we should have... >>>> >>>> sem >>>> waitTimeoutSeconds: 5 >>>> ifSignalled: [ view ifNotNil: [ view stylerStyledInBackground: >>>> text ] ] >>>> ifTimedOut: [ "do nothing" ]. >>>> >>>> cheers -ben >>>> >>> >>> >> > > >

April 28, 2015

[Pharo5] Code Reviewers needed!

by Marcus Denker

Hi, With Pharo5 starting to pick up steam, we need people to help commenting /testing fixes: https://pharo.fogbugz.com/f/filters/45/Review Marcus

April 28, 2015

Re: [Pharo-dev] last time I had insomnia...

by Nicolai Hess

2015-04-28 15:32 GMT+02:00 Yuriy Tymchuk <yuriy.tymchuk(a)me.com>: > > > On 28 Apr 2015, at 15:20, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > > > > >> On 28 Apr 2015, at 15:16, Hilaire <hilaire(a)drgeo.eu> wrote: > >> > >> Le 28/04/2015 15:05, Esteban Lorenzano a Ã©crit : > >>> I have to say that I started this because I failed miserably to made > >>> the eclipse icons work fine in Dark mode. Pharo does not understand > >>> SVG out of the box, Roassal does it but in the conversion things where > >>> not rightâ¦ so I found this solution. > >>> > >>> Btwâ¦ they look good also in standard theme: > >>> > >> > >> Thanks Esteban, looks is simple, clean. > >> Did you convert the svg to png or can you import the svg form? > > > > No, I failed to convert svg to png (probably just my ignorance) then I > took this icons who where already in png but with good transparencies :) > > > > Esteban > > But on which stage are Athens? Because maybe we can use them for SVG? > It is not that bad. I just fixed one bug with linear gradient construction (used deprecated/removed api). You can load the latest configuration from the Athens repository. And if you have a folder with some svg icons: |files| files := ('A_FOLDER_WITH_SVG_FILES' asFileReference allChildrenMatching:'*.svg'). files collect:[: file ||form| [form := ((ASVGMorph fromFile:file)setZoom:5; imageForm) ] on:Error do:[:ex | ]] many icons are "loadable" but I did not compare the results > > Uko > > > > >> > >> Hilaire > >> > >> -- > >> Dr. Geo - http://drgeo.eu > >> iStoa - http://istoa.drgeo.eu > >> > >> > >> > > > > > > >

April 28, 2015

Re: [Pharo-dev] last time I had insomnia...

by Ben Coman

On Tue, Apr 28, 2015 at 8:49 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > so, I spend some time doing this: > > Gofer it > smalltalkhubUser: 'estebanlm' project: 'IconsForPharo'; > package: 'Polymorph-Icons-Idea'; > load. > ThemeIcons current: IdeaUIThemeIcons new. > AbstractNautilusUI resetIconCaches. > > Looks real nice. Thanks Esteban. cheers -ben

April 28, 2015

Re: [Pharo-dev] sometimes Shout changes the selection during styling

by Ben Coman

I was waiting for others to chime in, but they can do that on the issue once code is there to review. I'd say its worth pushing it through to that point at least. If you do it, I'll review and then we can call for a second reviewer. Actually, semantically the following may be better... DelayWaitTimeout>>waitOnCompletion:onTimeout: called from... Semaphore>>waitTimeoutSeconds:onCompletion:onTimeout: cheers -ben On Tue, Apr 28, 2015 at 8:12 PM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > I made an issue: > https://pharo.fogbugz.com/f/cases/15422/SHTextStyler-styleInBackgroundProce… > > Then do we add waitTimeoutSeconds:ifSignalled:ifTimedOut: to the Semaphore > class? > > On Mon, Apr 27, 2015 at 6:33 PM, Andrei Chis <chisvasileandrei(a)gmail.com> > wrote: > >> That would work for me. Styling the text if the process doing the styling >> did not finish or is stuck does not feel as the right thing to do. >> >> On Mon, Apr 27, 2015 at 6:25 PM, Ben Coman <btc(a)openinworld.com> wrote: >> >>> >>> >>> On Mon, Apr 27, 2015 at 8:41 PM, Andrei Chis <chisvasileandrei(a)gmail.com >>> > wrote: >>> >>>> Hi, >>>> >>>> In the glamour debugger that we use in moose we are now having the >>>> following problem: >>>> - the selection of a PluggableTextMorph is, quite randomly , changed >>>> during styling. >>>> >>>> If I revert the fix for issue 15240 >>>> <https://pharo.fogbugz.com/f/cases/15240> then it works ok. >>>> Also if I change in SHTextStyler>>#styleInBackgroundProcess: from >>>> >>>> sem waitTimeoutSeconds: 5. >>>> view ifNotNil: [ view stylerStyledInBackground: text ] >>>> >>>> to: >>>> >>>> (sem waitTimeoutSeconds: 5) ifFalse: [ >>>> view ifNotNil: [ view stylerStyledInBackground: text ] ] >>>> >>>> it works ok. In the second snippet we only do the styling if the styler >>>> completed. >>>> >>>> >>>> If I look at the senders of styleInBackgroundProcess: there is another >>>> strange issue. >>>> First PluggableTextMorph>>#setText: calls either style: >>>> or styleInBackgroundProcess:, depending in the size of the text. >>>> Then, PluggableTextMorph>>#setText: >>>> calls PluggableTextMorph>>#setTextBasic:, which calls >>>> PluggableTextMorph>>#hasUnacceptedEdits: which in turn >>>> calls again styleInBackgroundProcess:. >>>> So when you set the text if the size of the text is small Shout will >>>> try to style the text with and without a background process. If you call >>>> hasUnacceptedEdits: >>>> manually when initializing the morph then three processes will be >>>> started for doing the styling. >>>> >>>> Removing the calls to styleInBackgroundProcess: from >>>> PluggableTextMorph>>#hasUnacceptedEdits: and >>>> PluggableTextMorph>>#basicHasUnacceptedEdits:. >>>> also solves the problem with the changing selection. >>>> >>>> Cheers, >>>> Andrei >>>> >>> >>> Perhaps we should have... >>> >>> sem >>> waitTimeoutSeconds: 5 >>> ifSignalled: [ view ifNotNil: [ view stylerStyledInBackground: >>> text ] ] >>> ifTimedOut: [ "do nothing" ]. >>> >>> cheers -ben >>> >> >> >

April 28, 2015

Re: [Pharo-dev] last time I had insomnia...

by Esteban Lorenzano

> On 28 Apr 2015, at 15:32, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > >> >> On 28 Apr 2015, at 15:20, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >> >> >>> On 28 Apr 2015, at 15:16, Hilaire <hilaire(a)drgeo.eu> wrote: >>> >>> Le 28/04/2015 15:05, Esteban Lorenzano a Ã©crit : >>>> I have to say that I started this because I failed miserably to made >>>> the eclipse icons work fine in Dark mode. Pharo does not understand >>>> SVG out of the box, Roassal does it but in the conversion things where >>>> not rightâ¦ so I found this solution. >>>> >>>> Btwâ¦ they look good also in standard theme: >>>> >>> >>> Thanks Esteban, looks is simple, clean. >>> Did you convert the svg to png or can you import the svg form? >> >> No, I failed to convert svg to png (probably just my ignorance) then I took this icons who where already in png but with good transparencies :) >> >> Esteban > > But on which stage are Athens? Because maybe we can use them for SVG? as I said, tried and failed. it was also 3:30am in the morning so I would not bet on its possibility or not :) Esteban > > Uko > >> >>> >>> Hilaire >>> >>> -- >>> Dr. Geo - http://drgeo.eu <http://drgeo.eu/> >>> iStoa - http://istoa.drgeo.eu <http://istoa.drgeo.eu/>

April 28, 2015

Re: [Pharo-dev] last time I had insomnia...

by Yuriy Tymchuk

> On 28 Apr 2015, at 15:20, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > >> On 28 Apr 2015, at 15:16, Hilaire <hilaire(a)drgeo.eu> wrote: >> >> Le 28/04/2015 15:05, Esteban Lorenzano a Ã©crit : >>> I have to say that I started this because I failed miserably to made >>> the eclipse icons work fine in Dark mode. Pharo does not understand >>> SVG out of the box, Roassal does it but in the conversion things where >>> not rightâ¦ so I found this solution. >>> >>> Btwâ¦ they look good also in standard theme: >>> >> >> Thanks Esteban, looks is simple, clean. >> Did you convert the svg to png or can you import the svg form? > > No, I failed to convert svg to png (probably just my ignorance) then I took this icons who where already in png but with good transparencies :) > > Esteban But on which stage are Athens? Because maybe we can use them for SVG? Uko > >> >> Hilaire >> >> -- >> Dr. Geo - http://drgeo.eu >> iStoa - http://istoa.drgeo.eu >> >> >> > >

April 28, 2015