November 2015 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] f65eb1: 50433

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: f65eb16c6e641a3a374f68fc779e65b336b1cfc0 https://github.com/pharo-project/pharo-core/commit/f65eb16c6e641a3a374f68fc… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-11-11 (Wed, 11 Nov 2015) Changed paths: M Kernel.package/Point.class/class/instance creation/r_degrees_.st M Kernel.package/Point.class/class/instance creation/x_y_.st M Kernel.package/Point.class/instance/accessing/x.st M Kernel.package/Point.class/instance/accessing/y.st M Kernel.package/Point.class/instance/arithmetic/min.st M Kernel.package/Point.class/instance/arithmetic/reciprocal.st M Kernel.package/Point.class/instance/comparing/%3C.st M Kernel.package/Point.class/instance/comparing/%3C=.st M Kernel.package/Point.class/instance/comparing/%3E.st M Kernel.package/Point.class/instance/comparing/%3E=.st M Kernel.package/Point.class/instance/comparing/=.st M Kernel.package/Point.class/instance/comparing/hash.st M Kernel.package/Point.class/instance/comparing/max_.st M Kernel.package/Point.class/instance/comparing/min_.st M Kernel.package/Point.class/instance/converting/adaptToCollection_andSend_.st M Kernel.package/Point.class/instance/converting/asMargin.st M Kernel.package/Point.class/instance/converting/asNonFractionalPoint.st M Kernel.package/Point.class/instance/converting/asPoint.st R Kernel.package/Point.class/instance/converting/corner_.st R Kernel.package/Point.class/instance/converting/extent_.st R Kernel.package/Point.class/instance/converting/isPoint.st R Kernel.package/Point.class/instance/converting/rectangle_.st M Kernel.package/Point.class/instance/copying/deepCopy.st M Kernel.package/Point.class/instance/copying/veryDeepCopyWith_.st M Kernel.package/Point.class/instance/extent functions/guarded.st M Kernel.package/Point.class/instance/extent functions/scaleTo_.st M Kernel.package/Point.class/instance/geometry/angle.st M Kernel.package/Point.class/instance/geometry/isInsideCircle_with_with_.st M Kernel.package/Point.class/instance/geometry/sideOf_.st M Kernel.package/Point.class/instance/geometry/to_intersects_to_.st M Kernel.package/Point.class/instance/geometry/triangleArea_with_.st M Kernel.package/Point.class/instance/interpolating/interpolateTo_at_.st M Kernel.package/Point.class/instance/point functions/angleWith_.st M Kernel.package/Point.class/instance/point functions/bearingToPoint_.st M Kernel.package/Point.class/instance/point functions/crossProduct_.st M Kernel.package/Point.class/instance/point functions/directionToLineFrom_to_.st A Kernel.package/Point.class/instance/point functions/distanceTo_.st M Kernel.package/Point.class/instance/point functions/dotProduct_.st M Kernel.package/Point.class/instance/point functions/flipBy_centerAt_.st M Kernel.package/Point.class/instance/point functions/insideTriangle_with_with_.st M Kernel.package/Point.class/instance/point functions/leftRotated.st M Kernel.package/Point.class/instance/point functions/nearestPointAlongLineFrom_to_.st M Kernel.package/Point.class/instance/point functions/normal.st M Kernel.package/Point.class/instance/point functions/normalized.st M Kernel.package/Point.class/instance/point functions/octantOf_.st M Kernel.package/Point.class/instance/point functions/quadrantOf_.st M Kernel.package/Point.class/instance/point functions/reflectedAbout_.st M Kernel.package/Point.class/instance/point functions/rightRotated.st M Kernel.package/Point.class/instance/point functions/sortsBefore_.st M Kernel.package/Point.class/instance/point functions/transposed.st M Kernel.package/Point.class/instance/polar coordinates/degrees.st M Kernel.package/Point.class/instance/polar coordinates/r.st M Kernel.package/Point.class/instance/polar coordinates/theta.st A Kernel.package/Point.class/instance/rectangle creation/corner_.st A Kernel.package/Point.class/instance/rectangle creation/extent_.st A Kernel.package/Point.class/instance/rectangle creation/rectangle_.st A Kernel.package/Point.class/instance/testing/isPoint.st M Kernel.package/Point.class/instance/testing/isZero.st M Kernel.package/Point.class/instance/transforming/translateBy_.st M Kernel.package/Point.class/instance/truncation and round off/ceiling.st M Kernel.package/Point.class/instance/truncation and round off/floor.st M Kernel.package/Point.class/instance/truncation and round off/roundDownTo_.st M Kernel.package/Point.class/instance/truncation and round off/roundTo_.st M Kernel.package/Point.class/instance/truncation and round off/roundUpTo_.st M Kernel.package/Point.class/instance/truncation and round off/rounded.st M Kernel.package/Point.class/instance/truncation and round off/truncateTo_.st M Kernel.package/Point.class/instance/truncation and round off/truncated.st A Morphic-Base.package/MenuTitleMorph.class/instance/rounding/roundedCorners.st A Morphic-Base.package/MenuTitleMorph.class/instance/rounding/wantsRoundedCorners.st R Nautilus.package/AbstractPackageWidget.class/instance/item creation/buildPackagesList.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/buildContents.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/deselectAll.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/enabled_.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/hasFocus.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/removeShortcuts_.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/resetGroupsSelection.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/resetPackagesSelection.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/selectGroup_.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/selectPackage_.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/selectedGroup.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/selectedGroups.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/selectedPackage.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/selectedPackageGroup.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/selectedPackages.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/setShortcuts_.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/takeKeyboardFocus.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/updateList.st R Nautilus.package/AbstractPackageWidget.class/instance/protocol/updatePackageView.st A Nautilus.package/CategoryWidget.class/class/menus/categoriesMenu_.st A Nautilus.package/CategoryWidget.class/class/shortcuts/buildProtocolShortcutsOn_.st M Nautilus.package/CategoryWidget.class/instance/protocol/categoriesMenu_shifted_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50432.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50433.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50432.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50433.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50433 16984 fixed menu on category in nautilus https://pharo.fogbugz.com/f/cases/16984 16981 Round the top corners of MenuTitleMorph if the menu itself uses rounded corners https://pharo.fogbugz.com/f/cases/16981 16973 clean all methods of point https://pharo.fogbugz.com/f/cases/16973 http://files.pharo.org/image/50/50433.zip

Nov. 11, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50433 Home: https://github.com/pharo-project/pharo-core

Nov. 11, 2015

Re: [Pharo-dev] Woe unto thee who assigns to class-side #name!

by stepharo

Hi gabriel Le 9/11/15 20:22, Gabriel Cotelli a Ã©crit : > > Yes please!! . I hate Object>>#name. Let me know if you need help. > Me too :) Guille sharpened his axe :) Stef > On Nov 9, 2015 15:22, "stepharo" <stepharo(a)free.fr > <mailto:stepharo@free.fr>> wrote: > > I would start to remove for real name from Object :) > > Stef > > > > Le 9/11/15 13:05, Sean P. DeNigris a Ã©crit : > > Ben Coman wrote > > But Class has an instance variable 'name', > and Class subclasses --> {ProtoObject class} > > He he, of course. Thanks for the clarification! > > > Ben Coman wrote > > should that instance variable and accessors be renamed to > 'classname'? > > YES to a rename! Let's remove all mysterious gotchas for > newbies (and me ha > ha). This is an obscure and scary bug, because it prevents all > operations on > the package, so one can not even commit or file out the package. > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/Woe-unto-thee-who-assigns-to-class-side-name-tp485973… > Sent from the Pharo Smalltalk Developers mailing list archive > at Nabble.com. > > > >

Nov. 11, 2015

I get error when I push down method

by stepharo

I get various error when doing pushdown. Pushing methods from MethodWidget to its subclass is a good test case. on ======================================================== showInstance ^ self model showInstance and methodsIconsCache ^ MethodsIconsCache okToChange ^ self model okToChange. I get parseTree = nil computePoolsToMove | poolVariables searcher | poolVariables := self poolVariableNamesFor: fromClass. pools := Set new. searcher := RBParseTreeSearcher new. searcher matches: '`var' do: [:aNode :answer | | varName pool | varName := aNode name. (aNode whoDefines: varName) isNil ifTrue: [(poolVariables includes: varName) ifTrue: [pool := self whichPoolDefines: varName. pool notNil ifTrue: [pools add: pool]]]]. searcher executeTree: parseTree ======================================================== I also got a problem that I cannot reproduce but having to do that may be the change was not recorded and the Undo was wrapping soemthing wrong. This would be great if one of you try to remove the AbstractMethodWidget using refactorings to spot the problem Stef

Nov. 11, 2015

Re: [Pharo-dev] It looks like I broke the category menu...

by stepharo

Yes I'm doing it right now. Le 11/11/15 15:31, Ferlicot D. Cyril a Ã©crit : > Le 11/11/2015 15:16, stepharo a Ã©crit : >> Hi >> >> It looks like I broke the category menu... when I folded the >> CategoryWidget into its superclass. >> I will try to find why? >> >> Stef >> > Do you plan to do the same with Class, Methods, Package widgets? >

Nov. 11, 2015

Re: [Pharo-dev] It looks like I broke the category menu...

by Ferlicot D. Cyril

Le 11/11/2015 15:16, stepharo a Ã©crit : > Hi > > It looks like I broke the category menu... when I folded the > CategoryWidget into its superclass. > I will try to find why? > > Stef > Do you plan to do the same with Class, Methods, Package widgets? -- Cyril Ferlicot http://www.synectique.eu 165 Avenue Bretagne Lille 59000 France

Nov. 11, 2015

Re: [Pharo-dev] It looks like I broke the category menu...

by stepharo

Yes I already published a fix Thanks for the feedback Le 11/11/15 15:19, Nicolai Hess a Ã©crit : > > > 2015-11-11 15:16 GMT+01:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > Hi > > It looks like I broke the category menu... when I folded the > CategoryWidget into its superclass. > I will try to find why? > > > class side method with menu/shortcut pragma! > > > Stef > >

Nov. 11, 2015

Re: [Pharo-dev] It looks like I broke the category menu...

by Nicolai Hess

2015-11-11 15:16 GMT+01:00 stepharo <stepharo(a)free.fr>: > Hi > > It looks like I broke the category menu... when I folded the > CategoryWidget into its superclass. > I will try to find why? > class side method with menu/shortcut pragma! > > Stef > >

Nov. 11, 2015

It looks like I broke the category menu...

by stepharo

Hi It looks like I broke the category menu... when I folded the CategoryWidget into its superclass. I will try to find why? Stef

Nov. 11, 2015

Re: [Pharo-dev] [Pharo-users] Changing playground and monticello shortcuts

by Tudor Girba

Hi, It was chosen a while ago that the Global shortcuts are checked first, before the local ones. The local ones propagate from bottom to top. The idea here was to guarantee global behavior, such as Shift+Enter for popping out things like Spotter. I was not happy about that, but that was the choice. Now, I think that the global keymap mechanism should be used sparingly, and I think that using it for Cmd+o is a bit too much. Cheers, Doru > On Nov 11, 2015, at 12:22 PM, Henrik Johansen <henrik.s.johansen(a)veloxit.no> wrote: > > Ehm, or maybe fix event dispatch so it works properly? > It should always end up testing for event handling By the leaf morph at the given event position and work its way up if unhandled, not check top-down like the change to dispatchEvent:with: has ended up doing... > > Cheers, > Henry > >> On 11 Nov 2015, at 11:46 , Tudor Girba <tudor(a)tudorgirba.com> wrote: >> >> I actually think we should disable those shortcuts. >> >> The reason is that they âpollute" the global shortcut space: for example, you can now not use Cmd+o for any custom action in your own window, and that is less than ideal. >> >> The alternative is to use Spotter to spawn windows. The interesting thing there is that you do not need shortcuts for every specific windows because you can use regular search. For example, opening Playground is: Shift+Enter, p, Enter >> >> Cheers, >> Doru >> >> >>> On Nov 11, 2015, at 10:49 AM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: >>> >>> >>> >>> 2015-11-11 10:45 GMT+01:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com>: >>> Hi, >>> >>> currently to open a Playground via shortcut one has to type <cmd>+o+w, that's because it used to open Workspace. >>> However since it now opens Playground the shortcut is no longer appropriate. >>> >>> So can we change it to <cmd>+o+p? >>> (This shortcut is currently occupied by Monticello Browser, but that can be movd to <cmd>+o+m which is free.) >>> >>> cmd+o+m would be >>> ctrl+o ctrl+m on windows, but ctrl+m does not work yet on windows. >>> >>> >>> You could argue that people are used to this shortcut, however that will not be true for newcommers, who will just see it as random naming (which it currently is). >>> >>> Peter >>> >> >> -- >> www.tudorgirba.com >> >> "We cannot reach the flow of things unless we let go." >> >> >> >> > -- www.tudorgirba.com "To lead is not to demand things, it is to make them happen."

Nov. 11, 2015