Pharo-dev

By thread

pharo-dev@lists.pharo.org

January 2015

1046 messages

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40457 Home: https://github.com/pharo-project/pharo-core

Jan. 22, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40456 Home: https://github.com/pharo-project/pharo-core

Jan. 22, 2015

[pharo-project/pharo-core] fff573: 40456

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: fff5733a681faefe375ff0a65f4ee1e1f540ac9d https://github.com/pharo-project/pharo-core/commit/fff5733a681faefe375ff0a6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-01-22 (Thu, 22 Jan 2015) Changed paths: A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script456.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40456.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40456 14770 Clean up the AST-Interpreter package further https://pharo.fogbugz.com/f/cases/14770 14769 final MCClassDefinition>>#load simplification https://pharo.fogbugz.com/f/cases/14769 http://files.pharo.org/image/40/40456.zip

Jan. 22, 2015

Re: [Pharo-dev] More people needed to review issues

by Ben Coman

For Work Needed cases, there should be a description of the problem sufficient for you the reproduce it. If not, ask for one. Try to locate which build version introduced the bug. I use PharoLauncher to help download and manage a large number of Image versions while manually bisecting versions like git bisect. Once determined, check the build announcements on pharo-dev for which slices were loaded to go from good image version to bad image version. For Resolved cases, there should be a description of the problem sufficient for you the reproduce it, then apply the fix and repeat the actions to confirm its fixed. If not, ask for one. I find I learn a lot by reviewing the fixes of others. I tend to do <Changes> first, then leave that open while I do a <Merge>. This makes it easier to go the the changed methods and scatter a few 'self halt's so that I can trace the running code. Sometimes in a separate Image I put the same 'self halt's in the original methods and step through both new and old simultaneously. cheers -ben On Thu, Jan 22, 2015 at 11:13 PM, Paul DeBruicker <pdebruic(a)gmail.com> wrote: > Go here > > https://pharo.fogbugz.com/ > > > and follow the instructions to make an account. > > > Then start with the issues that are tagged 'Work Needed' or 'Resolved (Fix > Review Needed)' > > > > > > > nacho wrote > > I would like to contribute. > > How can I help. How one contributes to fogbuzz? > > thanks > > Nacho > > > > > > -- > View this message in context: > http://forum.world.st/More-people-needed-to-review-issues-tp4800916p4801006… > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

Jan. 22, 2015

Re: [Pharo-dev] Commit custom Slot

by Marcus Denker

> On 22 Jan 2015, at 18:06, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > > And I also think that InstanceVariableSlot >>definitionString in subclasses should return self printString and not only its name > The thing is that we have two cases: 1) Full definition {#slot => PropertySlot} 2) shortened definition { #ivar } the later one is for ânormalâ instance variables (and globals), for all the cases where slots just model what we have now. the #isSpecial check returns false for those and true for all other slots. I think we should implement definitionString in InstanceVariableSlot to check isSpecial and call the super class method for the case when it is. This way it will work even for subclasses as expected. (the irregularity of the #simple notation adds a bit complexity, but I think it is worth it) Marcus

Jan. 22, 2015

Re: [Pharo-dev] Commit custom Slot

by Aliaksei Syrel

And I also think that InstanceVariableSlot >>definitionString in subclasses should return self printString and not only its name Cheers, Alex On Thu, Jan 22, 2015 at 6:02 PM, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > I will implement the method that checks if a slot should be print the full >> definition (I guess will rename it, too) to be this: >> isSpecial >> "I am just a backward compatible ivar slot. Note: my subclasses are >> special" >> ^(self class = InstanceVariableSlot) not >> this way the subclass of InstanceVariableSlot will print the full >> definition. > > > Yes, it would be great! Thanks > > Cheers, > Alex > > On Thu, Jan 22, 2015 at 5:58 PM, Marcus Denker <marcus.denker(a)inria.fr> > wrote: > >> >> On 22 Jan 2015, at 17:44, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: >> >> Hi Marcus, >> >> I think I just found a workaround: >> if you make Slot>>isVirtual to return *true* by default and override it >> in InstanceVariableSlot to return *false* the problem will be gone >> >> I don't want to subclass InstanceVariableSlot because it becomes >> impossible to see definition of class with slots in Browser and as soon as >> I add new instvars all old ones become default InstanceVariableSlot and not >> my custom. >> >> >> I will implement the method that checks if a slot should be print the >> full definition (I guess will rename it, too) to be this: >> >> isSpecial >> "I am just a backward compatible ivar slot. Note: my subclasses are >> special" >> ^(self class = InstanceVariableSlot) not >> >> this way the subclass of InstanceVariableSlot will print the full >> definition. >> >> Marcus >> > >

Jan. 22, 2015

Re: [Pharo-dev] Commit custom Slot

by Aliaksei Syrel

> > I will implement the method that checks if a slot should be print the full > definition (I guess will rename it, too) to be this: > isSpecial > "I am just a backward compatible ivar slot. Note: my subclasses are > special" > ^(self class = InstanceVariableSlot) not > this way the subclass of InstanceVariableSlot will print the full > definition. Yes, it would be great! Thanks Cheers, Alex On Thu, Jan 22, 2015 at 5:58 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 22 Jan 2015, at 17:44, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > > Hi Marcus, > > I think I just found a workaround: > if you make Slot>>isVirtual to return *true* by default and override it > in InstanceVariableSlot to return *false* the problem will be gone > > I don't want to subclass InstanceVariableSlot because it becomes > impossible to see definition of class with slots in Browser and as soon as > I add new instvars all old ones become default InstanceVariableSlot and not > my custom. > > > I will implement the method that checks if a slot should be print the full > definition (I guess will rename it, too) to be this: > > isSpecial > "I am just a backward compatible ivar slot. Note: my subclasses are > special" > ^(self class = InstanceVariableSlot) not > > this way the subclass of InstanceVariableSlot will print the full > definition. > > Marcus >

Jan. 22, 2015

Re: [Pharo-dev] Commit custom Slot

by Marcus Denker

> On 22 Jan 2015, at 17:44, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > > Hi Marcus, > > I think I just found a workaround: > if you make Slot>>isVirtual to return true by default and override it in InstanceVariableSlot to return false the problem will be gone > > I don't want to subclass InstanceVariableSlot because it becomes impossible to see definition of class with slots in Browser and as soon as I add new instvars all old ones become default InstanceVariableSlot and not my custom. > I will implement the method that checks if a slot should be print the full definition (I guess will rename it, too) to be this: isSpecial "I am just a backward compatible ivar slot. Note: my subclasses are special" ^(self class = InstanceVariableSlot) not this way the subclass of InstanceVariableSlot will print the full definition. Marcus

Jan. 22, 2015

Re: [Pharo-dev] Commit custom Slot

by Marcus Denker

> On 22 Jan 2015, at 17:44, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > > Hi Marcus, > > I think I just found a workaround: > if you make Slot>>isVirtual to return true by default and override it in InstanceVariableSlot to return false the problem will be gone > Yes, that should be done. > I don't want to subclass InstanceVariableSlot because it becomes impossible to see definition of class with slots in Browser and as soon as I add new instvars all old ones become default InstanceVariableSlot and not my custom. > Yes, I will fix that one, too. Because it can be nice to just subclass that oneâ¦ but people need to then know about byte code and change the emit* methods, too. Therefore the first step: https://pharo.fogbugz.com/f/cases/14772/add-AbstractInstanceVariableSlot Marcus

Jan. 22, 2015

Re: [Pharo-dev] Commit custom Slot

by Aliaksei Syrel

Hi Marcus, I think I just found a workaround: if you make Slot>>isVirtual to return *true* by default and override it in InstanceVariableSlot to return *false* the problem will be gone I don't want to subclass InstanceVariableSlot because it becomes impossible to see definition of class with slots in Browser and as soon as I add new instvars all old ones become default InstanceVariableSlot and not my custom. Cheers, Alex On Thu, Jan 22, 2015 at 5:32 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 22 Jan 2015, at 17:20, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: > > Hi, > > We faced a problem with committing and loading packages with Slots. It > seams like when loading a package, compiler first compiles a class that > uses custom Slot and only then Slot itself. It leads to an error like > MessageNotUnderstood: CustomSlot>>index:, but index: is implemented for > sure! I'm using the latest image and vm. > > > I think the reason why this fails is that it loads the first all classes > and then the methods. But this just makes another issue prominent: > > I want to add a class in-between Slot and InstanceVariableSlot for people > to subclass in this cas > (AbstractInstanceVariableSlot). > Because InstanceVariableSlot already needs the byte code level stuff, > while Slot is the superclass of all Slots, even those that have > no index. > > I will do that as the next step. > > > How to reproduce: > > 1) Create CustomSlot: > > Slot subclass: #CustomSlot > instanceVariableNames: '' > classVariableNames: '' > category: 'CustomSlot-Test' > > Implement the following methods: > > index > ^ index > > index: anIndex > index := anIndex > > read: anObject > ^ anObject instVarAt: index > > write: aValue to: anObject > ^ anObject instVarAt: index put: aValue. > > 2) Add our custom class: > > Object subclass: #CutomClass > slots: { #var => CustomSlot } > classVariables: { } > category: 'CustomSlot-Test' > > 3) Commit > 4) Try to load in fresh image > 5) Face error > > Any suggestions? > > Thanks, > Alex > > >

Jan. 22, 2015

Jump to page: