January 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Commit custom Slot

by Marcus Denker

> On 22 Jan 2015, at 18:15, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > >> On 22 Jan 2015, at 18:06, Aliaksei Syrel <alex.syrel(a)gmail.com> wrote: >> >> And I also think that InstanceVariableSlot >>definitionString in subclasses should return self printString and not only its name >> > > The thing is that we have two cases: > > 1) Full definition {#slot => PropertySlot} > 2) shortened definition { #ivar } > > the later one is for ânormalâ instance variables (and globals), for all the cases where slots just model what we have now. > > the #isSpecial check returns false for those and true for all other slots. > > I think we should implement definitionString in InstanceVariableSlot to check isSpecial and call the super > class method for the case when it is. This way it will work even for subclasses as expected. > This is fixed with https://pharo.fogbugz.com/f/cases/14779/fix-definitionString-for-subclasses… <https://pharo.fogbugz.com/f/cases/14779/fix-definitionString-for-subclasses…> Marcus

Jan. 23, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40458 Home: https://github.com/pharo-project/pharo-core

Jan. 23, 2015

[pharo-project/pharo-core] c7ddbd: 40458

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: c7ddbd0e8d0f858d0dfc9ee0c9689f6f9b4bfd51 https://github.com/pharo-project/pharo-core/commit/c7ddbd0e8d0f858d0dfc9ee0… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-01-23 (Fri, 23 Jan 2015) Changed paths: M AST-Interpreter-Core.package/AIBlockContext.class/definition.st M AST-Interpreter-Core.package/AIContext.class/definition.st M AST-Interpreter-Core.package/AIMethodContext.class/definition.st M AST-Interpreter-Core.package/AIRootContext.class/definition.st M AST-Interpreter-Core.package/ASTBlockClosure.class/definition.st M AST-Interpreter-Core.package/ASTInterpreter.class/definition.st M AST-Interpreter-Core.package/ExceptionHandler.class/definition.st M AST-Interpreter-Core.package/FakeCompiledMethod.class/definition.st M AST-Interpreter-Core.package/InterpretationError.class/definition.st M AST-Interpreter-Core.package/VariableNotDefined.class/definition.st M AST-Interpreter-Test.package/ASTCacheTest.class/definition.st M AST-Interpreter-Test.package/ASTInterpreterTest.class/definition.st M AST-Interpreter-Test.package/ASTStackMappingTest.class/definition.st M AST-Interpreter-Test.package/ASTStackMappingTest.class/instance/accessing/methodContext.st R AST-Interpreter-Test.package/ASTStackMappingTest.class/instance/as yet unclassified/setUp.st A AST-Interpreter-Test.package/ASTStackMappingTest.class/instance/running/setUp.st M AST-Interpreter-Test.package/DoesNotUnderstandCatcher.class/definition.st M AST-Interpreter-Test.package/InterpreterTest.class/definition.st M AST-Interpreter-Test.package/PharoVMInterpreterTest.class/definition.st M Jobs.package/Job.class/class/announcing/jobAnnouncer.st R Jobs.package/Job.class/class/example/example.st R Jobs.package/Job.class/class/example/example2.st R Jobs.package/Job.class/class/example/exampleDebug.st A Jobs.package/Job.class/class/examples/example.st A Jobs.package/Job.class/class/examples/example2.st A Jobs.package/Job.class/class/examples/exampleDebug.st M Jobs.package/Job.class/class/instance creation/block_.st M Jobs.package/Job.class/definition.st M Jobs.package/Job.class/instance/notification-handling/handleJobStart_.st M Jobs.package/Job.class/instance/progress/announcer.st M Jobs.package/JobChange.class/definition.st M Jobs.package/JobDetector.class/definition.st M Jobs.package/JobEnd.class/definition.st M Jobs.package/JobNotification.class/definition.st M Jobs.package/JobProgress.class/definition.st M Jobs.package/JobStart.class/definition.st M Jobs.package/JobStartNotification.class/definition.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script458.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40458.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40458 14775 Cleanup "Jobs" package further https://pharo.fogbugz.com/f/cases/14775 14770 Clean up the AST-Interpreter package further https://pharo.fogbugz.com/f/cases/14770 http://files.pharo.org/image/40/40458.zip

Jan. 23, 2015

Re: [Pharo-dev] Stuck jobs are not aborted CI

by stepharo

Thanks I removed it. Le 21/1/15 12:43, Stephan Eggermont a Ã©crit : > AFAIK, jobs that take too long should be aborted. > That doesn't seem to happen. > > https://ci.inria.fr/pharo-contribution/job/PharoProjectCatalog2/ > > Stephan > > >

Jan. 23, 2015

Re: [Pharo-dev] Package cleaning

by Ben Coman

What I found is that if the package you are loading does not exist, then prior to the merge Monticello creates the "new" package - presumably so it has something to compare against. (As an aside, if you do not proceed with the merge, then that "new" package remains, which is poor behaviour.) That works with a package without tags. With tags, I think it is noticing that the "new" package has no tags. So one solution might be to also add the tags when the "new" package it created pre-merge, but that seems a bit backward. Ideally the "new" package would never be registered in the system until the merge is actually executed. I logged the following to deal with that issue as a dependency for the others. https://pharo.fogbugz.com/default.asp?14616 On Fri, Jan 23, 2015 at 8:00 PM, Torsten Bergmann <astares(a)gmx.de> wrote: > Hi Marcus, Ben and others, > > how can we proceed on META issue https://pharo.fogbugz.com/f/cases/14447? > > Anyone with deeper knowdlege of Monticello and the integration process > able to help here? It's a merging issue although nothing to merge. > > Thx > T. > >

Jan. 23, 2015

Re: [Pharo-dev] HELP WANTED: improve Dark Theme

by Aliaksei Syrel

> > 3) Fix spotter theming (currently ignores dark theme) I added DarkTheme to spotter. Update to check and you can also take a look how theming mechanism works in GT. There is UITheme>>spotterWidgetThemer that returns themer object for Spotter and to add custom theme she needs to override it in her own theme like it is done in Pharo3DarkTheme>>spotterWidgetThemer. It allows to customize widgets deeply and reduces mess in themes :) Cheers, Alex On Fri, Jan 23, 2015 at 1:19 PM, kilon alios <kilon.alios(a)gmail.com> wrote: > I think roassal can do that > > On Fri, Jan 23, 2015 at 2:05 PM, Esteban Lorenzano <estebanlm(a)gmail.com> > wrote: > >> >> On 23 Jan 2015, at 12:53, Torsten Bergmann <astares(a)gmx.de> wrote: >> >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=385003 >> https://code.google.com/p/eclipse-svg-icons/ >> >> >> cool! >> now I have to figure out how to display svg icons in pharoâ¦ but this is >> what I was looking for :) >> >> Esteban >> >> >> >> Gesendet: Freitag, 23. Januar 2015 um 12:24 Uhr >> Von: "Sven Van Caekenberghe" <sven(a)stfx.eu> >> An: "Pharo Development List" <pharo-dev(a)lists.pharo.org> >> Betreff: Re: [Pharo-dev] HELP WANTED: improve Dark Theme >> >> >> On 23 Jan 2015, at 12:03, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >> >> Hi, >> >> The Dark Theme is a standard theme upcoming in Pharo4, but as you might >> noticed, is still far from perfect. >> I would like to take some actions on it but I do not have a lot of time >> this days, so I thought on asking for help :) >> >> What I think is needed? >> >> 1) There are some bugs (for example in the search window, cmd+f in text >> panes) >> 2) Icon-set is not prepared for dark backgrounds. Now, this is a problem >> in eclipse itself who didnât had a dark-theme either until recently. Now, I >> know they added a dark-theme and a corresponding set of icons (a set that >> can be displayed correctly both in white and black backgrounds), but I >> cannot find the icons. So if someone knows where they are, Iâll gladly >> replace them. >> >> >> 3) Fix spotter theming (currently ignores dark theme) >> >> I know in an ideal world we will have our own set of icons, but that >> requires a lot of effort and design talentâ¦ so in the mean time, I think >> eclipse icons are doing a good job :) >> >> cheers, >> Esteban >> >> >> >> >> >> >> >

Jan. 23, 2015

Re: [Pharo-dev] CI cleanup

by Damien Cassou

Max Leske writes: > As requested by the CI administration Iâve reduced the number or kept builds on the following jobs: > - LibGit > - Fuel-Serialize-All > - Fuel-Development > - Fuel-Stable > - PetitMarkdown thank you Max. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill

Jan. 23, 2015

Re: [Pharo-dev] HELP WANTED: improve Dark Theme

by kilon alios

I think roassal can do that On Fri, Jan 23, 2015 at 2:05 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > On 23 Jan 2015, at 12:53, Torsten Bergmann <astares(a)gmx.de> wrote: > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=385003 > https://code.google.com/p/eclipse-svg-icons/ > > > cool! > now I have to figure out how to display svg icons in pharoâ¦ but this is > what I was looking for :) > > Esteban > > > > Gesendet: Freitag, 23. Januar 2015 um 12:24 Uhr > Von: "Sven Van Caekenberghe" <sven(a)stfx.eu> > An: "Pharo Development List" <pharo-dev(a)lists.pharo.org> > Betreff: Re: [Pharo-dev] HELP WANTED: improve Dark Theme > > > On 23 Jan 2015, at 12:03, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > Hi, > > The Dark Theme is a standard theme upcoming in Pharo4, but as you might > noticed, is still far from perfect. > I would like to take some actions on it but I do not have a lot of time > this days, so I thought on asking for help :) > > What I think is needed? > > 1) There are some bugs (for example in the search window, cmd+f in text > panes) > 2) Icon-set is not prepared for dark backgrounds. Now, this is a problem > in eclipse itself who didnât had a dark-theme either until recently. Now, I > know they added a dark-theme and a corresponding set of icons (a set that > can be displayed correctly both in white and black backgrounds), but I > cannot find the icons. So if someone knows where they are, Iâll gladly > replace them. > > > 3) Fix spotter theming (currently ignores dark theme) > > I know in an ideal world we will have our own set of icons, but that > requires a lot of effort and design talentâ¦ so in the mean time, I think > eclipse icons are doing a good job :) > > cheers, > Esteban > > > > > > >

Jan. 23, 2015

Re: [Pharo-dev] HELP WANTED: improve Dark Theme

by Esteban Lorenzano

> On 23 Jan 2015, at 12:53, Torsten Bergmann <astares(a)gmx.de> wrote: > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=385003 > https://code.google.com/p/eclipse-svg-icons/ <https://code.google.com/p/eclipse-svg-icons/> cool! now I have to figure out how to display svg icons in pharoâ¦ but this is what I was looking for :) Esteban > > >> Gesendet: Freitag, 23. Januar 2015 um 12:24 Uhr >> Von: "Sven Van Caekenberghe" <sven(a)stfx.eu> >> An: "Pharo Development List" <pharo-dev(a)lists.pharo.org> >> Betreff: Re: [Pharo-dev] HELP WANTED: improve Dark Theme >> >> >>> On 23 Jan 2015, at 12:03, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >>> >>> Hi, >>> >>> The Dark Theme is a standard theme upcoming in Pharo4, but as you might noticed, is still far from perfect. >>> I would like to take some actions on it but I do not have a lot of time this days, so I thought on asking for help :) >>> >>> What I think is needed? >>> >>> 1) There are some bugs (for example in the search window, cmd+f in text panes) >>> 2) Icon-set is not prepared for dark backgrounds. Now, this is a problem in eclipse itself who didnât had a dark-theme either until recently. Now, I know they added a dark-theme and a corresponding set of icons (a set that can be displayed correctly both in white and black backgrounds), but I cannot find the icons. So if someone knows where they are, Iâll gladly replace them. >> >> 3) Fix spotter theming (currently ignores dark theme) >> >>> I know in an ideal world we will have our own set of icons, but that requires a lot of effort and design talentâ¦ so in the mean time, I think eclipse icons are doing a good job :) >>> >>> cheers, >>> Esteban >> >> >> >

Jan. 23, 2015

Re: [Pharo-dev] HELP WANTED: improve Dark Theme

by Esteban Lorenzano

> On 23 Jan 2015, at 12:24, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > >> On 23 Jan 2015, at 12:03, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >> >> Hi, >> >> The Dark Theme is a standard theme upcoming in Pharo4, but as you might noticed, is still far from perfect. >> I would like to take some actions on it but I do not have a lot of time this days, so I thought on asking for help :) >> >> What I think is needed? >> >> 1) There are some bugs (for example in the search window, cmd+f in text panes) >> 2) Icon-set is not prepared for dark backgrounds. Now, this is a problem in eclipse itself who didnât had a dark-theme either until recently. Now, I know they added a dark-theme and a corresponding set of icons (a set that can be displayed correctly both in white and black backgrounds), but I cannot find the icons. So if someone knows where they are, Iâll gladly replace them. > > 3) Fix spotter theming (currently ignores dark theme) Yes! but thatâs a problem of spotter, not Dark Theme ;) > >> I know in an ideal world we will have our own set of icons, but that requires a lot of effort and design talentâ¦ so in the mean time, I think eclipse icons are doing a good job :) >> >> cheers, >> Esteban > >

Jan. 23, 2015