September 2014 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] IMPORTANT: new preLoad and postLoad process when making a fix

by Nicolai Hess

2014-09-23 13:29 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > Hi, > > This is a message for people doing fixes in Pharo core, and because of > that doing SLICEs. > Since last week Iâm changing the integration process (something > transparent for most of you), to make it more automatedâ¦ so I added two new > fields to the issue tracker: > > - preload > - postload > > Soâ¦ from now, if your SLICE requires one or/and the other, you need to > fill those fieldsâ¦ it will not be part of the comment fields anymore. > > thanks, > Esteban > Great! What if I want to do a "postload" only, for example if we have an issue "need to reinitialize Class Xxx"?

Sept. 23, 2014

Re: [Pharo-dev] IMPORTANT: new preLoad and postLoad process when making a fix

by Ben Coman

Esteban Lorenzano wrote: > Hi, > > This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. > Since last week Iâm changing the integration process (something transparent for most of you), to make it more automatedâ¦ so I added two new fields to the issue tracker: > > - preload > - postload > > Soâ¦ from now, if your SLICE requires one or/and the other, you need to fill those fieldsâ¦ it will not be part of the comment fields anymore. > > thanks, > Esteban > > I've never used a preload or postload before in any way. Can you give an example? cheers -ben

Sept. 23, 2014

IMPORTANT: new preLoad and postLoad process when making a fix

by Esteban Lorenzano

Hi, This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automatedâ¦ so I added two new fields to the issue tracker: - preload - postload Soâ¦ from now, if your SLICE requires one or/and the other, you need to fill those fieldsâ¦ it will not be part of the comment fields anymore. thanks, Esteban

Sept. 23, 2014

Re: [Pharo-dev] Penelope Re: Call for CleanUp of the issue tracker

by Marcus Denker

On 22 Sep 2014, at 18:23, Damien Cassou <damien.cassou(a)gmail.com> wrote: > On Sat, Sep 20, 2014 at 12:28 PM, Ben Coman <btc(a)openinworld.com> wrote: >> >> I have two tickets open on Penelope... >> https://pharo.fogbugz.com/default.asp?11550 >> https://pharo.fogbugz.com/default.asp?11551 >> >> I'd be happy to give them a go myself if I had access to the code and be >> able to test it. >> cheers -ben > > > can anyone help Ben? > I would be interesting to have information about thisâ¦ I do not know it, either. Marcus

Sept. 23, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40241 Home: https://github.com/pharo-project/pharo-core

Sept. 23, 2014

[pharo-project/pharo-core] a37c37: 40241

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: a37c373b50e29bd8911a30c66183cae90777dd5b https://github.com/pharo-project/pharo-core/commit/a37c373b50e29bd8911a30c6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-09-23 (Tue, 23 Sep 2014) Changed paths: M Refactoring-Critics.package/RBBadMessageRule.class/instance/running/checkMethod_.st M Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/running/checkMethod_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script241.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40241.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Slot.package/LayoutAbstractScope.class/instance/testing/ifNotEmpty_.st A Slot.package/LayoutClassScope.class/instance/testing/ifNotEmpty_.st A Slot.package/LayoutEmptyScope.class/instance/testing/ifNotEmpty_.st M Slot.package/PharoClassInstaller.class/instance/notifications/sharedVariableOrSharedPoolChangedFrom_to_by_.st Log Message: ----------- 40241 14055 Fix some failing tests related to Code Critics (due to accidental #halt) https://pharo.fogbugz.com/f/cases/14055 13606 testSlotScopeParallelism is failing https://pharo.fogbugz.com/f/cases/13606 http://files.pharo.org/image/40/40241.zip

Sept. 23, 2014

[pharo-project/pharo-core] 9b7127: 40240

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 9b71277c26c4e8d40fa1aa7430812b48583d82cb https://github.com/pharo-project/pharo-core/commit/9b71277c26c4e8d40fa1aa74… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-09-23 (Tue, 23 Sep 2014) Changed paths: M Collections-Strings.package/String.class/instance/converting/subStrings_.st A Collections-Strings.package/String.class/instance/converting/substrings_.st A Manifest-Core.package/extension/RBDeprecateWithFirstCharacterDownshifted/instance/category.st A Manifest-Core.package/extension/RBDeprecateWithFirstCharacterDownshifted/instance/longDescription.st A Manifest-Core.package/extension/RBFutureDeprecationWarningRule/class/uniqueIdentifierName.st A Manifest-Core.package/extension/RBFutureDeprecationWarningRule/instance/category.st A Manifest-Core.package/extension/RBFutureDeprecationWarningRule/instance/longDescription.st M Refactoring-Critics.package/RBBadMessageRule.class/instance/running/checkMethod_.st A Refactoring-Critics.package/RBDeprecateWithFirstCharacterDownshifted.class/README.md A Refactoring-Critics.package/RBDeprecateWithFirstCharacterDownshifted.class/definition.st A Refactoring-Critics.package/RBDeprecateWithFirstCharacterDownshifted.class/instance/accessing/group.st A Refactoring-Critics.package/RBDeprecateWithFirstCharacterDownshifted.class/instance/accessing/name.st A Refactoring-Critics.package/RBDeprecateWithFirstCharacterDownshifted.class/instance/accessing/rational.st A Refactoring-Critics.package/RBDeprecateWithFirstCharacterDownshifted.class/instance/initialization/initialize.st A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/README.md A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/definition.st A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/accessing/group.st A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/accessing/name.st A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/accessing/rationale.st A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/private/oldSelectors.st A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/private/plannedSelectorRenames.st A Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/running/checkMethod_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script240.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40240.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Spec-MorphicAdapters.package/WorldModel.class/class/specs/defaultSpec.st M System-Announcements.package/AnnouncementLogger.class/definition.st M System-Announcements.package/CategoryAdded.class/definition.st M System-Announcements.package/CategoryRemoved.class/definition.st M System-Announcements.package/CategoryRenamed.class/definition.st M System-Announcements.package/ClassAdded.class/definition.st M System-Announcements.package/ClassAnnouncement.class/definition.st M System-Announcements.package/ClassCommented.class/definition.st M System-Announcements.package/ClassModifiedClassDefinition.class/definition.st M System-Announcements.package/ClassRecategorized.class/definition.st M System-Announcements.package/ClassRemoved.class/definition.st M System-Announcements.package/ClassRenamed.class/definition.st M System-Announcements.package/ClassReorganized.class/definition.st M System-Announcements.package/ExpressionEvaluated.class/definition.st M System-Announcements.package/MethodAdded.class/definition.st M System-Announcements.package/MethodAnnouncement.class/definition.st M System-Announcements.package/MethodModified.class/definition.st M System-Announcements.package/MethodRecategorized.class/definition.st M System-Announcements.package/MethodRemoved.class/definition.st M System-Announcements.package/ProtocolAdded.class/definition.st M System-Announcements.package/ProtocolAnnouncement.class/definition.st M System-Announcements.package/ProtocolRemoved.class/definition.st M System-Announcements.package/SnapshotDone.class/definition.st M System-Announcements.package/SystemAnnouncement.class/definition.st M System-Announcements.package/SystemAnnouncer.class/definition.st Log Message: ----------- 40240 14019 add critics rule for #withFirstCharacterDownshifted-> #uncapitalized https://pharo.fogbugz.com/f/cases/14019 14049 add String>>substrings: and lint rule for #subStrings: https://pharo.fogbugz.com/f/cases/14049 14035 openWorldWithSpec not taking over the world https://pharo.fogbugz.com/f/cases/14035 14045 Categorize classes in System-Announcements https://pharo.fogbugz.com/f/cases/14045 http://files.pharo.org/image/40/40240.zip

Sept. 23, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40240 Home: https://github.com/pharo-project/pharo-core

Sept. 23, 2014

Re: [Pharo-dev] Interesting Date/Time Thread on Squeak Dev

by Max Leske

On 19.09.2014, at 19:14, Mark Bestley <st(a)bestley.co.uk> wrote: > On 19/09/2014 13:48, Max Leske wrote: >> Ok, so I read Chrisâ e-mail and Iâm intrigued. >> >> Sven, youâre still right about financial months being 30 days for instance but the thing is that the current implementation seems broken (or inconsisten at least) and doesnât honor that case either. *Not* making the change will not help us eitherâ¦ >> >> So Iâd say: letâs do it. If somebody objects (or proposes a change) then we can handle that but at least we can claim that we try to give the users what we preach, like writing natural language like code (e.g. âx + 1 monthâ which is currently not possible). >> >> Thatâs my view at least. Also: weâre changing so much stuff in Pharo anyway all the time, I donât think this would hurt. >> > > That comment re 30 day months in financial is not totally correct. > > A common reason for calculating days in a financial calculation is for interest calculation and then you don't just need a number for the day difference but also for the number of days in a year. When I did this I think I had to support many ways of calculating the fraction of a year that was the difference between two dates depending on the interest basis (ie the contract terms) , Wikipedia gives 11 <http://en.wikipedia.org/wiki/Day_count_convention> > > > So I think that adding a financial number of days into a basic date object does not make sense as it will not be correct in many cases. The best way I have seen is to pass a daycount basis strategy class into the calculation and that strategy object does the calculation. I like the idea of using strategies. Although some might argue that such a change would unnecessarily bloat the code, strategies would give us the ability to define our âstandardâ calculation in a central place while enabling everyone to use their custom calculations. > > > > -- > Mark > >

Sept. 23, 2014

Re: [Pharo-dev] [Review: 13229] Year arithmetic broken

by Max Leske

On 22.09.2014, at 16:00, Henrik Johansen <henrik.s.johansen(a)veloxit.no> wrote: > I am sceptical to the use of Floats. > Even using doubles, you've lost nanosecond accuracy when you get up to a number of seconds corresponding to a year: > > 31536000.000000001 = 31536000.0 true > I don't see how the summing done in basicSeconds can possibly add up to correct valuesâ¦ Hm, good point. The intent (as I understand) was to get nano second precision. So either we go back to seconds or we use nano seconds (as integers) instead of floats (under the assumption that this change actually will be integratedâ¦) > > Cheers, > Henry > > On 18 Sep 2014, at 9:56 , Max Leske <maxleske(a)gmail.com> wrote: > >> Another issue for cleanup review. >> >> https://pharo.fogbugz.com/f/cases/13229/Year-arithmetic-broken >> >> >> Ported from Pharo 30. >> >> Made a few additional changes to #hash and #printOn: methods that no longer worked, added class comment to AnnualDuration. >> >> NOTE: I haven't done a full review on this and the change of seconds from integer to floats can have quite serious implications. Please look at this carefully. >> >> >> >> Name: SLICE-Issue-13229-Year-arithmetic-broken-MaxLeske.1 >> Author: MaxLeske >> Time: 18 September 2014, 9:50:41.500402 pm >> UUID: 44e5effc-4344-4aec-8cf5-3cb5d92ad73e >> Ancestors: >> Dependencies: Kernel-MaxLeske.1827, KernelTests-MaxLeske.678 >> >> Port from Pharo 30. >> >> - Added class comment to AnnualDuration. >> - adapted #hash and #printOn: methods that no longer worked because of seconds being floats >

Sept. 23, 2014