July 2014 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Refactor Nautilus

by Esteban Lorenzano

please, go ahead :) On 24 Jul 2014, at 10:23, Nicolai Hess <nicolaihess(a)web.de> wrote: > If no one raises objections, I would like to start on refactor / cleanup > nautilus code. > > This includes: > > renaming / recategorizing > solve code critics shown in Critics Browser > split classes (AbstractNautilusUI has 427 methods 24 instvars ) > stronger separation between the browser model, browser state > and browser UI. > > review event handling and UI updating > (sometimes there is a difference between what the UI shows > as selected and the selection the model(s) holds > > maybe: > create one package pane widget for package and groups > (therefore move all that package vs groups handling from > nautilus ui to that widget) > merge Nautilus and PackageTreeNautilus > > (I don't consider all of Nautilus bad code, it has well > designed parts, it just has grown meanwhile...) > > How to update the code? > > Working with slices makes it easier to find changes > that introduces new bugs. > Otherwise it takes time to do it in such small steps and I don't > know if those changes are reviewed at all. > > So, I would try to group the changes. > 1. code critics > 2. renameing/ simple refactoring > 3. .... > > > nicolai > > >

July 24, 2014

[Pharo4] Weekend Project 1: Cleanup Low-Level animation code

by Marcus Denker

Hi, Now with holidays comingâ¦ maybe someone wants to do a small Pharo related Project with impact on the future? Here is suggestion 1. Context: cleanup graphics. (so e.g. one could replace the canvas later). Details ====== Morphic has some very arcane code for animating moving morphs around that bypasses layers. DisplayObject has these methods: follow:while: follow:while:bitsBehind:startingLoc: slideFrom:to:nSteps:delay: slideWithFirstFrom:to:nSteps:delay: displayOnPort:at:rule: They are used by morphic for some not really important animation that for sure can be directly done by moving the morphs as morphs around. Bypassing and directly using low level (not even Canvas level) functionality is for sure not needed. On the Morph level the users are: slideBackToFormerSituation: vanishAfterSlidingTo:event: animationForMoveSuccess: What to do? -> rewrite the morphic level code to just move the morphs around. -> delete all the code from DisplayObject -> review âGrafPortâ usage, as this might have been the last client. Marcus

July 24, 2014

Re: [Pharo-dev] Refactor Nautilus

by Baptiste Quide

Good luck for that. I will have a look because the tool which allows to watch package dependencies embeds the Nautilus Browser, and i'm one of the maintainer at this time. Baptiste ----- Mail original ----- > De: "Nicolai Hess" <nicolaihess(a)web.de> > Ã: "Pharo Development List" <pharo-dev(a)lists.pharo.org> > EnvoyÃ©: Jeudi 24 Juillet 2014 10:23:15 > Objet: [Pharo-dev] Refactor Nautilus > If no one raises objections, I would like to start on refactor / cleanup > nautilus code. > This includes: > renaming / recategorizing > solve code critics shown in Critics Browser > split classes (AbstractNautilusUI has 427 methods 24 instvars ) > stronger separation between the browser model, browser state > and browser UI. > review event handling and UI updating > (sometimes there is a difference between what the UI shows > as selected and the selection the model(s) holds > maybe: > create one package pane widget for package and groups > (therefore move all that package vs groups handling from > nautilus ui to that widget) > merge Nautilus and PackageTreeNautilus > (I don't consider all of Nautilus bad code, it has well > designed parts, it just has grown meanwhile...) > How to update the code? > Working with slices makes it easier to find changes > that introduces new bugs. > Otherwise it takes time to do it in such small steps and I don't > know if those changes are reviewed at all. > So, I would try to group the changes. > 1. code critics > 2. renameing/ simple refactoring > 3. .... > nicolai

July 24, 2014

Re: [Pharo-dev] Package Dependencies Analysis : new features

by stepharo

I used it all yesterday evening :) I could not commit my changes because I could not rollbakc some of them but the tools is really great!!!! On 23/7/14 16:59, stepharo wrote: > I tried with Morphic-widgets and this is really cool because it is > really helping me to spot problems!!! > > Stef > > On 23/7/14 14:49, Baptiste Quide wrote: >> Hello Pharos Users, >> >> Since the first release of Package Dependencies Analysis, here is a >> summary of improvements : >> >> - tool is available in World Menu (Tools > Package Dependencies >> Browser) : choose your packages and browse dependencies. >> - add/remove packages into the analysis. >> - you can refresh the current analysis manually (for instance if you >> change a piece of code to remove/add dependency) >> - filter the packages displaying by name >> - button "find cycles" allows to find all cycles in the system where >> the selected packages in the tree are (it could take a while the >> first time you click) >> - contextual menu (right click) to browse scoped dependencies or find >> cycles among the selected packages in the tree >> >> Then, in the window displaying cycles among packages : >> >> - only dependencies among packages in the cycle are displaying (no >> outgoing dependencies) >> - packages appear by order (if you see aCycle : A, B, C, the cycle is >> A -> B -> C -> A) >> >> See more details : http://www.baptistequide.fr/packagedependencies.php >> >> Regards, >> >> Baptiste >

July 24, 2014

Refactor Nautilus

by Nicolai Hess

If no one raises objections, I would like to start on refactor / cleanup nautilus code. This includes: renaming / recategorizing solve code critics shown in Critics Browser split classes (AbstractNautilusUI has 427 methods 24 instvars ) stronger separation between the browser model, browser state and browser UI. review event handling and UI updating (sometimes there is a difference between what the UI shows as selected and the selection the model(s) holds maybe: create one package pane widget for package and groups (therefore move all that package vs groups handling from nautilus ui to that widget) merge Nautilus and PackageTreeNautilus (I don't consider all of Nautilus bad code, it has well designed parts, it just has grown meanwhile...) How to update the code? Working with slices makes it easier to find changes that introduces new bugs. Otherwise it takes time to do it in such small steps and I don't know if those changes are reviewed at all. So, I would try to group the changes. 1. code critics 2. renameing/ simple refactoring 3. .... nicolai

July 24, 2014

[pharo-project/pharo-core] 6135a2: 40121

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 6135a23fdd15d6fadf659a78e6d39da3a904bf98 https://github.com/pharo-project/pharo-core/commit/6135a23fdd15d6fadf659a78… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-07-24 (Thu, 24 Jul 2014) Changed paths: M Kernel.package/Context.class/instance/controlling/quickSend_to_with_super_.st M Kernel.package/Context.class/instance/controlling/send_to_with_super_.st M Kernel.package/Context.class/instance/instruction decoding/send_super_numArgs_.st M Kernel.package/Context.class/instance/private/doPrimitive_method_receiver_args_.st M Kernel.package/Context.class/instance/private/simulatePrimitive_in_receiver_arguments_.st M Kernel.package/Context.class/instance/private/tryPrimitiveFor_receiver_args_.st M Kernel.package/Context.class/instance/query/findSimilarSender.st M Polymorph-Tools-Diff.package/DiffMorph.class/instance/initialization/initialize.st R Polymorph-Widgets.package/extension/ThreadSafeTranscript/class/open.st R Polymorph-Widgets.package/extension/ThreadSafeTranscript/class/patchworkUIThemeColor.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script121.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40121.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st R Settings-Tools.package/CodeHolderSystemSettings.class/class/settings/codeBrowsingSettingsOn_.st M System-FilePackage.package/TextDiffBuilder.class/class/instance creation/buildDisplayPatchFrom_to_inClass_.st M System-FilePackage.package/TextDiffBuilder.class/class/settings/differatorSettingsOn_.st A System-FilePackage.package/TextDiffBuilder.class/class/settings/diffsWithPrettyPrint.st A System-FilePackage.package/TextDiffBuilder.class/class/settings/diffsWithPrettyPrint_.st M System-FilePackage.package/TextDiffBuilder.class/definition.st A Tool-Browser-Old.package/CodeHolder.class/class/defaults/browseWithPrettyPrint.st A Tool-Browser-Old.package/CodeHolder.class/class/defaults/decorateBrowserButtons.st A Tool-Browser-Old.package/CodeHolder.class/class/defaults/showAnnotationPane.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/browseWithPrettyPrint.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/browseWithPrettyPrint_.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/decorateBrowserButtons.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/decorateBrowserButtons_.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/diffsInChangeList.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/diffsInChangeList_.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/diffsWithPrettyPrint.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/diffsWithPrettyPrint_.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/showAnnotationPane.st R Tool-Browser-Old.package/CodeHolder.class/class/settings/showAnnotationPane_.st M Tool-Browser-Old.package/CodeHolder.class/instance/diffs/defaultDiffsSymbol.st A Tool-Changes.package/ChangeList.class/class/settings/ChangeListSettingsOn_.st A Tool-Changes.package/ChangeList.class/class/settings/diffsInChangeList.st A Tool-Changes.package/ChangeList.class/class/settings/diffsInChangeList_.st M Tool-Changes.package/ChangeList.class/instance/initialization/initialize.st A Tool-Transcript.package/extension/ThreadSafeTranscript/class/open.st A Tool-Transcript.package/extension/ThreadSafeTranscript/class/patchworkUIThemeColor.st Log Message: ----------- 40121 13664 Remove all references to CodeHolder https://pharo.fogbugz.com/f/cases/13664 13629 Polymorph-Widgets still extends ThreadSafeTranscript https://pharo.fogbugz.com/f/cases/13629 13661 Shadow variables in kernel Context https://pharo.fogbugz.com/f/cases/13661 http://files.pharo.org/image/40/40121.zip

July 24, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40121 Home: https://github.com/pharo-project/pharo-core

July 24, 2014

Re: [Pharo-dev] File Outs: Can We Have Unix Line Endings?

by HernÃ¡n Morales Durand

Why you cannot detect OS and then format accordingly? HernÃ¡n 2014-07-24 2:17 GMT-03:00 Sean P. DeNigris <sean(a)clipperadams.com>: > Any reason not to? Tedious to continually do "%s/\r/\r/g"s on Mac to fix: > TextStream subclass:^M#UCTextStream^MinstanceVariableNames: > ''^MclassVariableNames: ''^MpoolDictionaries: ''^Mcategory: 'UFFA-Core'!^M! > > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/File-Outs-Can-We-Have-Unix-Line-Endings-tp4769721.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

July 24, 2014

Re: [Pharo-dev] TextMorph: No Emphasis?

by Esteban Lorenzano

On 24 Jul 2014, at 03:47, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > EstebanLM wrote >> not all fonts have underline feature available. > > Ah, yes, changing the font shows the underline. This seems wierd. Maybe a > silly question, but why can e.g. Mac Pages show Arial underlined, but not in > Pharo? Is underlining something we implement separately for each font? probably a FT2 issue? it can be some kind of a bug, after allâ¦ Esteban > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/TextMorph-No-Emphasis-tp4769458p4769710.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

July 24, 2014

Re: [Pharo-dev] File Outs: Can We Have Unix Line Endings?

by Marcus Denker

On 24 Jul 2014, at 07:17, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > Any reason not to? Tedious to continually do "%s/\r/\r/g"s on Mac to fix: > TextStream subclass:^M#UCTextStream^MinstanceVariableNames: > ''^MclassVariableNames: ''^MpoolDictionaries: ''^Mcategory: 'UFFA-Core'!^M! > Yes, the default line endings should be unix for everything, this would simplify life a lot. Marcus

July 24, 2014